querysub 0.311.0 → 0.313.0

package/src/4-querysub/QuerysubController.ts

@@ -35,7 +35,6 @@ import { LoggingClient } from "../0-path-value-core/LoggingClient";
 import * as prediction from "./querysubPrediction";
 import { getCallResultPath } from "./querysubPrediction";
 import { nodePathAuthority, pathValueAuthority2 } from "../0-path-value-core/NodePathAuthorities";
-import { diskLog } from "../diagnostics/logs/diskLogger";
 import { assertIsManagementUser } from "../diagnostics/managementPages";
 import { getBrowserUrlNode } from "../-f-node-discovery/NodeDiscovery";
 setFlag(require, "preact", "allowclient", true);
@@ -44,6 +43,7 @@ import yargs from "yargs";
 import { mergeFilterables, parseFilterable, serializeFilterable } from "../misc/filterable";
 import { isManagementUser, onAllPredictionsFinished } from "../-0-hooks/hooks";
 import { getDomain, isBootstrapOnly, isLocal } from "../config";
+import { logDisk } from "../diagnostics/logs/diskLogger";
 
 let yargObj = isNodeTrue() && yargs(process.argv)
     .option("fncfilter", { type: "string", default: "", desc: `Sets the filterable state for function calls, causing them to target specific FunctionRunners. If no FunctionRunner matches, all functions will fail to run. For example: "devtestserver" will match a FunctionRunner that uses the "devtestserver" filter. Merges with the existing filterable state if a client sets it explicitly.` })
@@ -452,7 +452,7 @@ export class QuerysubControllerBase {
                 //      make the UI look cleaner (instead of showing stale values, it shows nothing)?
                 let undefinedValues: PathValue[] = newPathsNotAllowed.map(path => ({ path, value: undefined, canGCValue: true, isTransparent: true, time: epochTime, locks: [], lockCount: 0, valid: true, event: false }));
 
-                diskLog(`Disallowing PathValue watches due to disallowed permissions`, { count: newPathsNotAllowed.length, callerId });
+                logDisk("log", "Disallowing PathValue watches due to disallowed permissions", { count: newPathsNotAllowed.length, callerId });
 
                 ignoreErrors(pathValueSerializer.serialize(undefinedValues, { compress: Querysub.COMPRESS_NETWORK }).then(buffers =>
                     PathValueController.nodes[callerId].forwardWrites(

package/src/5-diagnostics/GenericFormat.tsx

@@ -168,6 +168,7 @@ export function formatValue(value: unknown, formatter: JSXFormatter = "guess", c
 }
 
 export function toSpaceCase(text: string) {
+    if (text.startsWith("_")) return text;
     return text
         // "camelCase" => "camel Case"
         //  "URL" => "URL"

package/src/5-diagnostics/Table.tsx

@@ -33,6 +33,8 @@ export class Table<RowT extends RowType> extends qreact.Component<TableType<RowT
     lineLimit?: number;
     characterLimit?: number;
     dark?: boolean;
+
+    getRowAttributes?: (row: RowT, index: number) => preact.JSX.HTMLAttributes<HTMLTableRowElement>;
 }> {
     state = {
         limit: this.props.initialLimit || 100,
@@ -67,6 +69,7 @@ export class Table<RowT extends RowType> extends qreact.Component<TableType<RowT
                             //      be able to above our siblings, which breaks palettes).
                             + css.relative
                         }
+                        {...this.props.getRowAttributes?.(row, index)}
                     >
                         <td class={css.center}>{index + 1}</td>
                         {Object.entries(columns).filter(x => x[1] !== null).map(([columnName, column]) => {

package/src/5-diagnostics/diskValueAudit.ts

@@ -11,6 +11,7 @@ import { isDevDebugbreak } from "../config";
 import { DebugLog, auditLog, getLogHistoryEquals } from "../0-path-value-core/auditLogs";
 import { getOwnNodeId } from "../-f-node-discovery/NodeDiscovery";
 import { sort } from "socket-function/src/misc";
+import { logDisk } from "../diagnostics/logs/diskLogger";
 
 const AUDIT_INTERVAL = ARCHIVE_FLUSH_LIMIT;
 const AUDIT_THRESHOLD = ARCHIVE_FLUSH_LIMIT;
@@ -187,7 +188,7 @@ async function checkAuthority(authority: AuthorityPath, threshold: number) {
         console.error(`Value mismatch between disk and memory for ${formatNumber(changedValues.size)} values. Ex: ${firstValue.path}`);
     }
     if (removedValues.size > 0) {
-        console.info(green(`Removing ${formatNumber(removedValues.size)} paths from memory which have been GCed on the disk.`));
+        logDisk("log", green(`Removing ${formatNumber(removedValues.size)} paths from memory which have been GCed on the disk.`));
     }
     if (changedValues.size > 0 || removedValues.size > 0) {
         let allValues = new Set([...changedValues, ...removedValues]);

package/src/5-diagnostics/nodeMetadata.ts

@@ -10,7 +10,6 @@ import { sort, throttleFunction, timeInMinute } from "socket-function/src/misc";
 import { formatNumber, formatPercent, formatTime } from "socket-function/src/formatting/format";
 import os from "os";
 import { isNode } from "typesafecss";
-import { diskLog } from "../diagnostics/logs/diskLogger";
 import { devDebugbreak } from "../config";
 import { addStatPeriodic, addStatSumPeriodic, addTimeProfileDistribution, onTimeProfile, logNodeStats, logNodeStateStats, registerNodeMetadata } from "../-0-hooks/hooks";
 import { magenta } from "socket-function/src/formatting/logColors";

package/src/deployManager/components/MachineDetailPage.tsx

@@ -5,8 +5,10 @@ import { css } from "typesafecss";
 import { currentViewParam, selectedMachineIdParam, selectedServiceIdParam } from "../urlParams";
 import { formatNumber, formatVeryNiceDateTime } from "socket-function/src/formatting/format";
 import { sort } from "socket-function/src/misc";
-import { Anchor } from "../../library-components/ATag";
+import { ATag, Anchor } from "../../library-components/ATag";
 import { ShowMore } from "../../library-components/ShowMore";
+import { filterParam } from "../../diagnostics/logs/FastArchiveViewer";
+import { managementPageURL } from "../../diagnostics/managementPages";
 
 export class MachineDetailPage extends qreact.Component {
     render() {
@@ -62,6 +64,12 @@ export class MachineDetailPage extends qreact.Component {
                     <div>
                         Apply Node ID: {machine.applyNodeId}
                     </div>
+                    <ATag values={[
+                        managementPageURL.getOverride("LogViewer2"),
+                        filterParam.getOverride(`__machineId = ${machineInfo.machineId}`),
+                    ]}>
+                        Machine Logs
+                    </ATag>
                 </div>
 
                 <div>

package/src/deployManager/components/ServiceDetailPage.tsx

@@ -13,13 +13,15 @@ import { Button } from "../../library-components/Button";
 import { isDefined } from "../../misc";
 import { watchScreenOutput, stopWatchingScreenOutput } from "../machineController";
 import { getPathStr2 } from "../../path";
-import { Anchor } from "../../library-components/ATag";
+import { ATag, Anchor } from "../../library-components/ATag";
 import { ScrollOnMount } from "../../library-components/ScrollOnMount";
 import { StickyBottomScroll } from "../../library-components/StickyBottomScroll";
 import { PrimitiveDisplay } from "../../diagnostics/logs/ObjectDisplay";
 import { parseAnsiColors, rgbToHsl } from "../../diagnostics/logs/ansiFormat";
 import { RenderGitRefInfo, UpdateServiceButtons, bigEmoji, buttonStyle } from "./deployButtons";
 import { TypedConfigEditor } from "../../library-components/TypedConfigEditor";
+import { filterParam } from "../../diagnostics/logs/FastArchiveViewer";
+import { managementPageURL } from "../../diagnostics/managementPages";
 
 
 
@@ -333,6 +335,13 @@ export class ServiceDetailPage extends qreact.Component {
                                 >
                                     {isWatching ? "Stop Watching Output" : "Watch Screen Output"}
                                 </div>
+
+                                <ATag values={[
+                                    managementPageURL.getOverride("LogViewer2"),
+                                    filterParam.getOverride(`__nodeId = ${machineId}`),
+                                ]}>
+                                    Machine Logs
+                                </ATag>
                             </div>
                             {hasError && (
                                 <div

package/src/diagnostics/NodeViewer.tsx

@@ -35,9 +35,9 @@ import { ButtonSelector } from "../library-components/ButtonSelector";
 import { assertIsManagementUser, managementPageURL } from "./managementPages";
 import { SocketRegistered } from "socket-function/SocketFunctionTypes";
 import { ATag } from "../library-components/ATag";
-import { filterURL, selectedNodeId } from "./logs/DiskLoggerPage";
 import { getSyncedController } from "../library-components/SyncedController";
 import child_process from "child_process";
+import { filterParam } from "./logs/FastArchiveViewer";
 
 
 type NodeData = {
@@ -296,9 +296,8 @@ export class NodeViewer extends qreact.Component {
 
                                         return (
                                             <ATag values={[
-                                                managementPageURL.getOverride("DiskLoggerPage"),
-                                                selectedNodeId.getOverride(str),
-                                                filterURL.getOverride(`"__nodeId":"${str}"`),
+                                                managementPageURL.getOverride("LogViewer2"),
+                                                filterParam.getOverride(`__nodeId = ${str}`),
                                             ]}>
                                                 Logs
                                             </ATag>