querysub 0.308.0 → 0.309.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "querysub",
-  "version": "0.308.0",
+  "version": "0.309.0",
   "main": "index.js",
   "license": "MIT",
   "note1": "note on node-forge fork, see https://github.com/digitalbazaar/forge/issues/744 for details",

package/src/0-path-value-core/pathValueCore.ts

@@ -1303,7 +1303,7 @@ class PathWatcher {
                     }
                     if (history.length === 0) {
                         // We always have to send something, or the client won't know when they are ready to show the data!
-                        initialValues.add({ path, value: undefined, canGCValue: true, valid: true, time: epochTime, locks: [], lockCount: 0, event: false });
+                        initialValues.add({ path, value: undefined, canGCValue: true, isTransparent: true, valid: true, time: epochTime, locks: [], lockCount: 0, event: false });
                     }
                 }
                 this.triggerLatestWatcher(

package/src/2-proxy/PathValueProxyWatcher.ts

@@ -1467,20 +1467,9 @@ export class PathValueProxyWatcher {
                                 continue;
                             }
                             if (!prefixes.some(x => value.path.startsWith(x))) continue;
-                            let oldReadCheck = !!(
-                                value.canGCValue
-                                || pathValueSerializer.getPathValue(value) === specialObjectWriteValue
-                            );
                             let newReadCheck = !!value.isTransparent;
-                            if (oldReadCheck !== newReadCheck) {
-                                console.error(`Old read check ${oldReadCheck} !== newReadCheck ${newReadCheck} for ${value.path}, canGCValue: ${value.canGCValue}, isTransparent: ${value.isTransparent}`);
-                                // IMPORTANT! IF WE HIT THIS ASSERT, DEBUG IT RIGHT NOW!
-                                //  - I updated the read check to use isTransparent. BUT... I'm not sure
-                                //      this is correct. This WILL break if we add any new isTransparent values,
-                                //      so this update is requried, but... this code is so old, that I'm not
-                                //      sure updating it like this is safe.
-                                //  - Double check the the value at `pathValueSerializer.getPathValue(value)`
-                                //      and value, and see if it should act as a tranparent value or not.
+                            if (value.canGCValue && !value.isTransparent) {
+                                console.error(`Value is GCable, but not transparent. We likely forgot to set isTransparent when setting canGCValue. Path ${value.path}, value: ${String(pathValueSerializer.getPathValue(value))}`);
                                 debugbreak(2);
                                 debugger;
                             }

package/src/4-querysub/QuerysubController.ts

@@ -450,7 +450,7 @@ export class QuerysubControllerBase {
                 // Send them undefined values at epochTime
                 //  NOTE: We COULD send at time Date.now(), which would allow clobbering any existing values. This might
                 //      make the UI look cleaner (instead of showing stale values, it shows nothing)?
-                let undefinedValues: PathValue[] = newPathsNotAllowed.map(path => ({ path, value: undefined, canGCValue: true, time: epochTime, locks: [], lockCount: 0, valid: true, event: false }));
+                let undefinedValues: PathValue[] = newPathsNotAllowed.map(path => ({ path, value: undefined, canGCValue: true, isTransparent: true, time: epochTime, locks: [], lockCount: 0, valid: true, event: false }));
 
                 diskLog(`Disallowing PathValue watches due to disallowed permissions`, { count: newPathsNotAllowed.length, callerId });