querysub 0.307.0 → 0.309.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "querysub",
-  "version": "0.307.0",
+  "version": "0.309.0",
   "main": "index.js",
   "license": "MIT",
   "note1": "note on node-forge fork, see https://github.com/digitalbazaar/forge/issues/744 for details",

package/src/0-path-value-core/pathValueCore.ts

@@ -1303,7 +1303,7 @@ class PathWatcher {
                     }
                     if (history.length === 0) {
                         // We always have to send something, or the client won't know when they are ready to show the data!
-                        initialValues.add({ path, value: undefined, canGCValue: true, valid: true, time: epochTime, locks: [], lockCount: 0, event: false });
+                        initialValues.add({ path, value: undefined, canGCValue: true, isTransparent: true, valid: true, time: epochTime, locks: [], lockCount: 0, event: false });
                     }
                 }
                 this.triggerLatestWatcher(

package/src/2-proxy/PathValueProxyWatcher.ts

@@ -1467,20 +1467,9 @@ export class PathValueProxyWatcher {
                                 continue;
                             }
                             if (!prefixes.some(x => value.path.startsWith(x))) continue;
-                            let oldReadCheck = !!(
-                                value.canGCValue
-                                || pathValueSerializer.getPathValue(value) === specialObjectWriteValue
-                            );
                             let newReadCheck = !!value.isTransparent;
-                            if (oldReadCheck !== newReadCheck) {
-                                console.error(`Old read check ${oldReadCheck} !== newReadCheck ${newReadCheck} for ${value.path}, canGCValue: ${value.canGCValue}, isTransparent: ${value.isTransparent}`);
-                                // IMPORTANT! IF WE HIT THIS ASSERT, DEBUG IT RIGHT NOW!
-                                //  - I updated the read check to use isTransparent. BUT... I'm not sure
-                                //      this is correct. This WILL break if we add any new isTransparent values,
-                                //      so this update is requried, but... this code is so old, that I'm not
-                                //      sure updating it like this is safe.
-                                //  - Double check the the value at `pathValueSerializer.getPathValue(value)`
-                                //      and value, and see if it should act as a tranparent value or not.
+                            if (value.canGCValue && !value.isTransparent) {
+                                console.error(`Value is GCable, but not transparent. We likely forgot to set isTransparent when setting canGCValue. Path ${value.path}, value: ${String(pathValueSerializer.getPathValue(value))}`);
                                 debugbreak(2);
                                 debugger;
                             }

package/src/4-querysub/QuerysubController.ts

@@ -450,7 +450,7 @@ export class QuerysubControllerBase {
                 // Send them undefined values at epochTime
                 //  NOTE: We COULD send at time Date.now(), which would allow clobbering any existing values. This might
                 //      make the UI look cleaner (instead of showing stale values, it shows nothing)?
-                let undefinedValues: PathValue[] = newPathsNotAllowed.map(path => ({ path, value: undefined, canGCValue: true, time: epochTime, locks: [], lockCount: 0, valid: true, event: false }));
+                let undefinedValues: PathValue[] = newPathsNotAllowed.map(path => ({ path, value: undefined, canGCValue: true, isTransparent: true, time: epochTime, locks: [], lockCount: 0, valid: true, event: false }));
 
                 diskLog(`Disallowing PathValue watches due to disallowed permissions`, { count: newPathsNotAllowed.length, callerId });
 

package/src/deployManager/components/MachineDetailPage.tsx

@@ -3,9 +3,10 @@ import { qreact } from "../../4-dom/qreact";
 import { MACHINE_RESYNC_INTERVAL, MachineServiceController, ServiceConfig } from "../machineSchema";
 import { css } from "typesafecss";
 import { currentViewParam, selectedMachineIdParam, selectedServiceIdParam } from "../urlParams";
-import { formatVeryNiceDateTime } from "socket-function/src/formatting/format";
+import { formatNumber, formatVeryNiceDateTime } from "socket-function/src/formatting/format";
 import { sort } from "socket-function/src/misc";
 import { Anchor } from "../../library-components/ATag";
+import { ShowMore } from "../../library-components/ShowMore";
 
 export class MachineDetailPage extends qreact.Component {
     render() {
@@ -65,10 +66,27 @@ export class MachineDetailPage extends qreact.Component {
 
                 <div>
                     <h3>System Information</h3>
-                    <div className={css.vbox(4)}>
+                    <div className={css.vbox(10)}>
                         {Object.entries(machine.info).map(([key, value]) => (
-                            <div key={key}>
-                                <span>{key}:</span> {JSON.stringify(value)}
+                            <div key={key} className={css.hbox(10).hsla(0, 0, 0, 0.1).pad2(10, 2)}>
+                                <b>{key}:</b>
+                                <ShowMore className={css.whiteSpace("pre-wrap")} maxHeight={40}>
+                                    {(() => {
+                                        if (typeof value === "object") {
+                                            return <div className={css.pad2(6, 2).hsla(0, 0, 0, 0.1).relative}>
+                                                <div className={
+                                                    css.absolute.pos(0, 0)
+                                                        .size(`${value.value / value.max * 100}%`, "100%")
+                                                        .hsl(0, 0, 70)
+                                                } />
+                                                <div className={css.relative}>
+                                                    {value.type} ({formatNumber(value.value)} / {formatNumber(value.max)})
+                                                </div>
+                                            </div>;
+                                        }
+                                        return value;
+                                    })()}
+                                </ShowMore>
                             </div>
                         ))}
                     </div>

package/src/deployManager/components/MachinesListPage.tsx

@@ -5,7 +5,7 @@ import { css } from "typesafecss";
 import { t } from "../../2-proxy/schema2";
 import { Querysub } from "../../4-querysub/QuerysubController";
 import { currentViewParam, selectedMachineIdParam } from "../urlParams";
-import { formatVeryNiceDateTime } from "socket-function/src/formatting/format";
+import { formatNumber, formatVeryNiceDateTime } from "socket-function/src/formatting/format";
 import { sort } from "socket-function/src/misc";
 import { formatDateJSX } from "../../misc/formatJSX";
 import { DeployMachineButtons, RenderGitRefInfo } from "./deployButtons";
@@ -173,6 +173,20 @@ export class MachinesListPage extends qreact.Component {
                                         Last heartbeat {formatDateJSX(machineInfo.heartbeat)}
                                     </div>
                                     <RenderGitRefInfo gitRef={machineInfo.gitRef} />
+                                    {Object.values(machineInfo.info).map(value => {
+                                        if (typeof value === "string") return undefined;
+                                        return <div className={css.pad2(6, 2).hsla(0, 0, 0, 0.1).relative}>
+                                            <div className={
+                                                css.absolute.pos(0, 0)
+                                                    .size(`${value.value / value.max * 100}%`, "100%")
+                                                    .hsl(0, 0, 70)
+                                            } />
+                                            <div className={css.relative}>
+                                                {value.type} ({formatNumber(value.value)} / {formatNumber(value.max)})
+                                            </div>
+                                        </div>;
+
+                                    })}
                                 </div>
                                 <div className={css.vbox(4).flexGrow(1)}>
                                     <div>

package/src/deployManager/machineApplyMainCode.ts

@@ -51,48 +51,6 @@ const getMemoryInfo = measureWrap(async function getMemoryInfo(): Promise<{ valu
     return undefined;
 });
 
-const getCpuInfo = measureWrap(async function getCpuInfo(): Promise<{ value: number; max: number; coreCount: number } | undefined> {
-    if (os.platform() === "win32") {
-        throw new Error("Windows is not supported for machine resource monitoring");
-    }
-
-    let coreCount = os.cpus().length;
-
-    try {
-        // Linux: Get CPU usage from /proc/stat - need two readings to calculate current usage
-        let result1 = await runPromise("grep 'cpu ' /proc/stat", { quiet: true });
-        let parts1 = result1.trim().split(/\s+/);
-
-        if (parts1.length >= 8) {
-            // Wait 1 second for accurate measurement
-            await new Promise(resolve => setTimeout(resolve, 1000));
-
-            let result2 = await runPromise("grep 'cpu ' /proc/stat", { quiet: true });
-            let parts2 = result2.trim().split(/\s+/);
-
-            if (parts2.length >= 8) {
-                // Calculate differences between the two readings
-                let idle1 = parseInt(parts1[4]) + parseInt(parts1[5]); // idle + iowait
-                let total1 = parts1.slice(1, 8).reduce((sum, val) => sum + parseInt(val), 0);
-
-                let idle2 = parseInt(parts2[4]) + parseInt(parts2[5]); // idle + iowait
-                let total2 = parts2.slice(1, 8).reduce((sum, val) => sum + parseInt(val), 0);
-
-                let totalDiff = total2 - total1;
-                let idleDiff = idle2 - idle1;
-
-                if (totalDiff > 0) {
-                    let usagePercent = (totalDiff - idleDiff) / totalDiff;
-                    let coresUsed = usagePercent * coreCount;
-                    return { value: coresUsed, max: coreCount, coreCount };
-                }
-            }
-        }
-    } catch (e: any) {
-        console.warn(`Error getting CPU info: ${e.message}`);
-    }
-    return undefined;
-});
 
 const getDiskInfo = measureWrap(async function getDiskInfo(): Promise<{ value: number; max: number } | undefined> {
     if (os.platform() === "win32") {
@@ -130,18 +88,9 @@ const getLiveMachineInfo = measureWrap(async function getLiveMachineInfo() {
         gitRef: "",
     };
 
-    machineInfo.info.hostnamectl = await errorToUndefinedSilent(runPromise("hostnamectl")) || "";
-    machineInfo.info.getExternalIP = await errorToUndefinedSilent(getExternalIP()) || "";
-    machineInfo.info.lscpu = await errorToUndefinedSilent(runPromise("lscpu")) || "";
-    machineInfo.info.id = await errorToUndefinedSilent(runPromise("id")) || await errorToUndefinedSilent(runPromise("whoami")) || "";
-
-    machineInfo.repoUrl = await getGitURLLive(".");
-    machineInfo.gitRef = await getGitRefLive(".");
-
     // Get system resource information
-    let [memoryInfo, cpuInfo, diskInfo] = await Promise.all([
+    let [memoryInfo, diskInfo] = await Promise.all([
         getMemoryInfo(),
-        getCpuInfo(),
         getDiskInfo()
     ]);
 
@@ -153,15 +102,6 @@ const getLiveMachineInfo = measureWrap(async function getLiveMachineInfo() {
         };
     }
 
-    if (cpuInfo) {
-        machineInfo.info.cpu = {
-            type: "CPU",
-            value: cpuInfo.value,
-            max: cpuInfo.max,
-            coreCount: cpuInfo.coreCount,
-        };
-    }
-
     if (diskInfo) {
         machineInfo.info.disk = {
             type: "DISK",
@@ -170,6 +110,14 @@ const getLiveMachineInfo = measureWrap(async function getLiveMachineInfo() {
         };
     }
 
+    machineInfo.info.hostnamectl = await errorToUndefinedSilent(runPromise("hostnamectl")) || "";
+    machineInfo.info.getExternalIP = await errorToUndefinedSilent(getExternalIP()) || "";
+    machineInfo.info.lscpu = await errorToUndefinedSilent(runPromise("lscpu")) || "";
+    machineInfo.info.id = await errorToUndefinedSilent(runPromise("id")) || await errorToUndefinedSilent(runPromise("whoami")) || "";
+
+    machineInfo.repoUrl = await getGitURLLive(".");
+    machineInfo.gitRef = await getGitRefLive(".");
+
     return machineInfo;
 });
 

package/src/deployManager/machineSchema.ts

@@ -47,7 +47,6 @@ export type MachineInfo = {
         type: string;
         value: number;
         max: number;
-        coreCount?: number;  // Optional for CPU info
     }>;
 
     repoUrl: string;

package/src/deployManager/spec.txt

@@ -1,16 +0,0 @@
-
-9) In machine info, support an object which can show current, and max, so we can show it as a bar and the max amount for:
-    RAM
-    CPU
-    DISK
-
-10) Add RAM total, ram % used, cpu count, CPU %, disk size, disk % used to machine info
-    - Show this all in the list page, with nice bars?
-        - Filled, but the total size will also depend on the maximum (to a degree), so it's very nice.
-        - A bar, with a label, or something. The AI can give us a few options
-    (Yes, it overlaps with node metrics, but that's okay, sometimes we want to look at machines, other times services, and the types of errors that show up in either changes).
-
-
-11) A spinning animation on the FPS display, so we can visually see when the browser locks up (because the animation will stop?)
-
-1) Update everything to latest