querysub 0.302.0 → 0.303.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "querysub",
-  "version": "0.302.0",
+  "version": "0.303.0",
   "main": "index.js",
   "license": "MIT",
   "note1": "note on node-forge fork, see https://github.com/digitalbazaar/forge/issues/744 for details",

package/src/2-proxy/PathValueProxyWatcher.ts

@@ -1469,6 +1469,7 @@ export class PathValueProxyWatcher {
                             );
                             let newReadCheck = !!value.isTransparent;
                             if (oldReadCheck !== newReadCheck) {
+                                console.error(`Old read check ${oldReadCheck} !== newReadCheck ${newReadCheck} for ${value.path}, canGCValue: ${value.canGCValue}, isTransparent: ${value.isTransparent}`);
                                 // IMPORTANT! IF WE HIT THIS ASSERT, DEBUG IT RIGHT NOW!
                                 //  - I updated the read check to use isTransparent. BUT... I'm not sure
                                 //      this is correct. This WILL break if we add any new isTransparent values,

package/src/deployManager/machineApplyMainCode.ts

@@ -367,6 +367,14 @@ const runScreenCommand = measureWrap(async function runScreenCommand(config: {
             } else {
                 console.log(red(`No nodeId file found for ${screenName}, not triggering rolling update notification`));
             }
+            // Stop the pipe-pane, and delete the pipe file
+            try {
+                await runPromise(`${prefix}tmux pipe-pane -O -t ${screenName}`);
+                await fs.promises.unlink(os.homedir() + "/" + SERVICE_FOLDER + screenName + "/pipe.txt");
+            } catch (e: any) {
+                console.warn(`Error stopping pipe-pane for ${screenName}: ${e.stack}`);
+            }
+
             let rollingScreenName = screenName + "-rolling" + SCREEN_SUFFIX;
             console.log(green(`Renaming screen ${screenName} to ${rollingScreenName} for rolling interval ${config.rollingWindow} at ${new Date().toLocaleString()}`));
             await runPromise(`${prefix}tmux rename-session -t ${screenName} ${rollingScreenName}`);

package/src/deployManager/spec.txt

@@ -1,5 +1,11 @@
+TODO: It seems like every other time it fails to reload?
+
+Uh... we get a failure in commitWrites, and then we never receive the path values we need?
+    - Although we only don't receive the values we need once, so... maybe the failed check is okay?
+
 1) Verify clientside notifications work when we rolling update cyoa
 2) Verify edge nodes are removed when we rolling update cyoa
+    - Eh... it removes most of the time?
 3) Update cyoa rolling time back to 4 hours
 
 1) Auto restart if the connect to the cyoa server is down, after 30 seconds, instead of just infinitely erroring out.