querysub 0.301.0 → 0.303.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "querysub",
-  "version": "0.301.0",
+  "version": "0.303.0",
   "main": "index.js",
   "license": "MIT",
   "note1": "note on node-forge fork, see https://github.com/digitalbazaar/forge/issues/744 for details",

package/src/2-proxy/PathValueProxyWatcher.ts

@@ -1469,6 +1469,7 @@ export class PathValueProxyWatcher {
                             );
                             let newReadCheck = !!value.isTransparent;
                             if (oldReadCheck !== newReadCheck) {
+                                console.error(`Old read check ${oldReadCheck} !== newReadCheck ${newReadCheck} for ${value.path}, canGCValue: ${value.canGCValue}, isTransparent: ${value.isTransparent}`);
                                 // IMPORTANT! IF WE HIT THIS ASSERT, DEBUG IT RIGHT NOW!
                                 //  - I updated the read check to use isTransparent. BUT... I'm not sure
                                 //      this is correct. This WILL break if we add any new isTransparent values,

package/src/4-deploy/edgeBootstrap.ts

@@ -229,7 +229,10 @@ async function edgeNodeFunction(config: {
     // JUST use it on the first loop, so if we can't find any matches, we ignore it.
     if (liveHashOverrideObj) {
         try {
-            let liveHashOverrideObject = JSON.parse(liveHashOverrideObj);
+            let liveHashOverrideObject = JSON.parse(liveHashOverrideObj) as {
+                liveHash: string;
+                time: number;
+            };
             liveHashOverrideExpiryTime = liveHashOverrideObject.time + 1000 * 30;
             liveHashOverride = liveHashOverrideObject.liveHash;
         } catch (e: any) {

package/src/4-deploy/edgeClientWatcher.tsx

@@ -87,9 +87,11 @@ function onLiveHashChange(liveHash: string, refreshThresholdTime: number) {
             if (i < notifyIntervals.length - 2 && waitDuration <= 30 * 1000) continue;
 
             // Update the URL override for manual refreshes
-            Querysub.localCommit(() => {
-                liveHashOverrideURL.value = { liveHash, time: Date.now() };
-            });
+            if (!liveHash.startsWith("forced")) {
+                Querysub.localCommit(() => {
+                    liveHashOverrideURL.value = { liveHash, time: Date.now() };
+                });
+            }
             if (!skipFirst) {
                 if (currentNotification) {
                     currentNotification.close();

package/src/deployManager/machineApplyMainCode.ts

@@ -367,6 +367,14 @@ const runScreenCommand = measureWrap(async function runScreenCommand(config: {
             } else {
                 console.log(red(`No nodeId file found for ${screenName}, not triggering rolling update notification`));
             }
+            // Stop the pipe-pane, and delete the pipe file
+            try {
+                await runPromise(`${prefix}tmux pipe-pane -O -t ${screenName}`);
+                await fs.promises.unlink(os.homedir() + "/" + SERVICE_FOLDER + screenName + "/pipe.txt");
+            } catch (e: any) {
+                console.warn(`Error stopping pipe-pane for ${screenName}: ${e.stack}`);
+            }
+
             let rollingScreenName = screenName + "-rolling" + SCREEN_SUFFIX;
             console.log(green(`Renaming screen ${screenName} to ${rollingScreenName} for rolling interval ${config.rollingWindow} at ${new Date().toLocaleString()}`));
             await runPromise(`${prefix}tmux rename-session -t ${screenName} ${rollingScreenName}`);

package/src/deployManager/spec.txt

@@ -1,7 +1,23 @@
+TODO: It seems like every other time it fails to reload?
+
+Uh... we get a failure in commitWrites, and then we never receive the path values we need?
+    - Although we only don't receive the values we need once, so... maybe the failed check is okay?
+
 1) Verify clientside notifications work when we rolling update cyoa
 2) Verify edge nodes are removed when we rolling update cyoa
+    - Eh... it removes most of the time?
 3) Update cyoa rolling time back to 4 hours
 
+1) Auto restart if the connect to the cyoa server is down, after 30 seconds, instead of just infinitely erroring out.
+    - Give a notification after 15 seconds warning them, with the ability to not restart if they click "do not restart"
+    - In edgeClientWatcher
+
+
+9) In machine info, support an object which can show current, and max, so we can show it as a bar and the max amount for:
+    RAM
+    CPU
+    DISK
+
 10) Add RAM total, ram % used, cpu count, CPU %, disk size, disk % used to machine info
     - Show this all in the list page, with nice bars?
         - Filled, but the total size will also depend on the maximum (to a degree), so it's very nice.
@@ -9,4 +25,5 @@
     (Yes, it overlaps with node metrics, but that's okay, sometimes we want to look at machines, other times services, and the types of errors that show up in either changes).
 
 
-11) Restart the server and verify everything starts up nicely on reboot!
+11) Restart the server and verify everything starts up nicely on reboot!
+    - Or... screw it, and move onto audio apis...