quasar 2.3.1 → 2.4.0

package/src/plugins/Notify.json

@@ -164,6 +164,7 @@
       "params": {
         "opts": {
           "type": [ "Object", "String" ],
+          "required": true,
           "desc": "Notification options",
           "definition": {
             "type": {
@@ -214,7 +215,7 @@
             "spinner": {
               "type": [ "Boolean", "Component" ],
               "desc": "Useful for notifications that are updated; Displays a Quasar spinner instead of an avatar or icon; If value is Boolean 'true' then the default QSpinner is shown",
-              "__exemption": [ "examples" ]
+              "examples": [ true, "QSpinnerBars" ]
             },
 
             "position": {
@@ -225,8 +226,7 @@
                 "top-left", "top-right",
                 "bottom-left", "bottom-right",
                 "top", "bottom", "left", "right", "center"
-              ],
-              "examples": [ "top-right" ]
+              ]
             },
 
             "group": {
@@ -251,8 +251,7 @@
               "values": [
                 "top-left", "top-right",
                 "bottom-left", "bottom-right"
-              ],
-              "examples": [ "bottom-right" ]
+              ]
             },
             "badgeStyle": {
               "type": [ "Array", "String", "Object" ],
@@ -339,9 +338,7 @@
               "type": "Boolean",
               "desc": "Ignore the default configuration (set by setDefaults()) for this instance only"
             }
-          },
-          "required": true,
-          "__exemption": [ "examples" ]
+          }
         }
       },
       "returns": {
@@ -350,6 +347,7 @@
         "params": {
           "props": {
             "type": "Object",
+            "required": false,
             "desc": "Notification properties that will be shallow merged to previous ones in order to update the non-grouped notification",
             "definition": {
               "type": {
@@ -483,6 +481,7 @@
       "params": {
         "opts": {
           "type": "Object",
+          "required": true,
           "desc": "Notification options",
           "definition": {
             "type": {
@@ -607,8 +606,7 @@
             "attrs": {
               "type": "Object",
               "desc": "Key-value for attributes to be set on the notification",
-              "examples": [ "{ role: 'alertdialog' }" ],
-              "__exemption": [ "definition" ]
+              "examples": [ "{ role: 'alertdialog' }" ]
             },
 
             "timeout": {
@@ -646,9 +644,7 @@
               "type": "Boolean",
               "desc": "Put notification into multi-line mode; If this prop isn't used and more than one 'action' is specified then notification goes into multi-line mode by default"
             }
-          },
-          "required": true,
-          "__exemption": [ "examples" ]
+          }
         }
       }
     },
@@ -658,13 +654,14 @@
       "params": {
         "typeName": {
           "type": "String",
-          "desc": "Name of the type (to be used as 'type' prop later on)",
           "required": true,
+          "desc": "Name of the type (to be used as 'type' prop later on)",
           "examples": [ "my-type" ]
         },
 
         "typeOpts": {
           "type": "Object",
+          "required": true,
           "desc": "Notification options",
           "definition": {
             "type": {
@@ -789,8 +786,7 @@
             "attrs": {
               "type": "Object",
               "desc": "Key-value for attributes to be set on the notification",
-              "examples": [ "{ role: 'alertdialog' }" ],
-              "__exemption": [ "definition" ]
+              "examples": [ "{ role: 'alertdialog' }" ]
             },
 
             "timeout": {
@@ -828,9 +824,7 @@
               "type": "Boolean",
               "desc": "Put notification into multi-line mode; If this prop isn't used and more than one 'action' is specified then notification goes into multi-line mode by default"
             }
-          },
-          "required": true,
-          "__exemption": [ "examples" ]
+          }
         }
       }
     }

package/src/plugins/Platform.js

@@ -3,6 +3,7 @@
 /* eslint-disable no-mixed-operators */
 
 import { ref, reactive } from 'vue'
+import { injectProp } from '../utils/private/inject-obj-prop'
 
 /**
  * __ QUASAR_SSR __            -> runs on SSR on client or server
@@ -330,23 +331,22 @@ else {
   // devland actually using it as this will get
   // reported under "Cookies" in Google Chrome
   let hasWebStorage
-  Object.defineProperty(client.has, 'webStorage', {
-    get: () => {
-      if (hasWebStorage !== void 0) {
-        return hasWebStorage
-      }
 
-      try {
-        if (window.localStorage) {
-          hasWebStorage = true
-          return true
-        }
-      }
-      catch (e) {}
+  injectProp(client.has, 'webStorage', () => {
+    if (hasWebStorage !== void 0) {
+      return hasWebStorage
+    }
 
-      hasWebStorage = false
-      return false
+    try {
+      if (window.localStorage) {
+        hasWebStorage = true
+        return true
+      }
     }
+    catch (e) {}
+
+    hasWebStorage = false
+    return false
   })
 
   iosEmulated = client.is.ios === true

package/src/utils/date.js

@@ -206,12 +206,12 @@ function getChange (date, mod, sign) {
       ? applyYearMonthDayChange(d, mod, sign)
       : d
 
-  Object.keys(mod).forEach(key => {
+  for (const key in mod) {
     if (key !== 'years' && key !== 'months' && key !== 'days') {
       const op = capitalize(key)
       t[ `set${ op }` ](t[ `get${ op }` ]() + sign * mod[ key ])
     }
-  })
+  }
 
   return t
 }
@@ -241,12 +241,12 @@ export function adjustDate (date, mod, utc) {
       ? applyYearMonthDay(d, mod, middle)
       : d
 
-  Object.keys(mod).forEach(key => {
+  for (const key in mod) {
     if (key !== 'year' && key !== 'month' && key !== 'date') {
       const op = key.charAt(0).toUpperCase() + key.slice(1)
       t[ `set${ middle }${ op }` ](mod[ key ])
     }
-  })
+  }
 
   return t
 }

package/src/utils/dom.js

@@ -27,9 +27,9 @@ export function width (el) {
 export function css (element, css) {
   const style = element.style
 
-  Object.keys(css).forEach(prop => {
+  for (const prop in css) {
     style[ prop ] = css[ prop ]
-  })
+  }
 }
 
 export function cssBatch (elements, style) {

package/src/utils/open-url.js

@@ -5,11 +5,11 @@ import { noop } from '../utils/event.js'
 function parseFeatures (winFeatures) {
   const cfg = Object.assign({ noopener: true }, winFeatures)
   const feat = []
-  Object.keys(cfg).forEach(key => {
+  for (const key in cfg) {
     if (cfg[ key ] === true) {
       feat.push(key)
     }
-  })
+  }
   return feat.join(',')
 }
 

package/src/utils/patterns.js

@@ -7,6 +7,7 @@ const
   rgb = /^rgb\(((0|[1-9][\d]?|1[\d]{0,2}|2[\d]?|2[0-4][\d]|25[0-5]),){2}(0|[1-9][\d]?|1[\d]{0,2}|2[\d]?|2[0-4][\d]|25[0-5])\)$/,
   rgba = /^rgba\(((0|[1-9][\d]?|1[\d]{0,2}|2[\d]?|2[0-4][\d]|25[0-5]),){2}(0|[1-9][\d]?|1[\d]{0,2}|2[\d]?|2[0-4][\d]|25[0-5]),(0|0\.[0-9]+[1-9]|0\.[1-9]+|1)\)$/
 
+// Keep in sync with ui/types/api/validation.d.ts
 export const testPattern = {
   date: v => /^-?[\d]+\/[0-1]\d\/[0-3]\d$/.test(v),
   time: v => /^([0-1]?\d|2[0-3]):[0-5]\d$/.test(v),

package/src/utils/private/define-reactive-plugin.js

@@ -1,4 +1,6 @@
+
 import { reactive } from 'vue'
+import { injectProp } from './inject-obj-prop'
 
 export default __QUASAR_SSR_SERVER__
   ? (state, plugin) => {
@@ -6,16 +8,16 @@ export default __QUASAR_SSR_SERVER__
       return plugin
     }
   : (state, plugin) => {
-      const props = {}
       const reactiveState = reactive(state)
 
-      Object.keys(state).forEach(name => {
-        props[ name ] = {
-          get: () => reactiveState[ name ],
-          set: val => { reactiveState[ name ] = val }
-        }
-      })
+      for (const name in state) {
+        injectProp(
+          plugin,
+          name,
+          () => reactiveState[ name ],
+          val => { reactiveState[ name ] = val }
+        )
+      }
 
-      Object.defineProperties(plugin, props)
       return plugin
     }

package/src/utils/private/global-dialog.js

@@ -133,14 +133,12 @@ export default function (DefaultComponent, supportsCustomComponent, parentApp) {
 
     let app = createChildApp({
       name: 'QGlobalDialog',
-      setup () {
-        return () => h(DialogComponent, {
-          ref: dialogRef,
-          ...props,
-          onOk,
-          onHide
-        })
-      }
+      setup: () => () => h(DialogComponent, {
+        ...props,
+        ref: dialogRef,
+        onOk,
+        onHide
+      })
     }, parentApp)
 
     vm = app.mount(el)

package/src/utils/private/global-dialog.json

@@ -29,6 +29,7 @@
         "definition": {
           "onOk": {
             "type": "Function",
+            "required": true,
             "desc": "Receives a Function param to tell what to do when OK is pressed / option is selected",
             "params": {
               "callbackFn": {
@@ -57,6 +58,7 @@
 
           "onCancel": {
             "type": "Function",
+            "required": true,
             "desc": "Receives a Function as param to tell what to do when Cancel is pressed / dialog is dismissed",
             "params": {
               "callbackFn": {
@@ -77,6 +79,7 @@
 
           "onDismiss": {
             "type": "Function",
+            "required": true,
             "desc": "Receives a Function param to tell what to do when the dialog is closed",
             "params": {
               "callbackFn": {
@@ -97,6 +100,7 @@
 
           "hide": {
             "type": "Function",
+            "required": true,
             "desc": "Hides the dialog when called",
             "params": null,
             "returns": {
@@ -109,10 +113,12 @@
 
           "update": {
             "type": "Function",
+            "required": true,
             "desc": "Updates the initial properties (given as create() param) except for 'component'",
             "params": {
               "opts": {
                 "type": "Object",
+                "required": true,
                 "desc": "Props (except 'component') which will overwrite the initial create() params; If create() was invoked with a custom dialog component then this param should contain the new componentProps",
                 "__exemption": [ "examples" ]
               }

package/src/utils/private/inject-obj-prop.js

@@ -0,0 +1,13 @@
+export function injectProp (target, propName, get, set) {
+  Object.defineProperty(target, propName, {
+    get,
+    set,
+    enumerable: true
+  })
+}
+
+export function injectMultipleProps (target, props) {
+  for (const key in props) {
+    injectProp(target, key, props[ key ])
+  }
+}

package/src/utils/private/is.js

@@ -99,10 +99,10 @@ export function isDeepEqual (a, b) {
       return a.toString() === b.toString()
     }
 
-    const keys = Object.keys(a)
+    const keys = Object.keys(a).filter(key => a[ key ] !== void 0)
     length = keys.length
 
-    if (length !== Object.keys(b).length) {
+    if (length !== Object.keys(b).filter(key => b[ key ] !== void 0).length) {
       return false
     }