quasar 2.11.10 → 2.12.0

package/src/components/select/QSelect.js

@@ -658,7 +658,7 @@ export default createComponent({
 
       resetInputValue()
 
-      if (typeof value === 'string' && value.length > 0) {
+      if (typeof value === 'string' && value.length !== 0) {
         const needle = value.toLocaleLowerCase()
         const findFn = extractFn => {
           const option = props.options.find(opt => extractFn.value(opt).toLocaleLowerCase() === needle)
@@ -705,7 +705,7 @@ export default createComponent({
         return
       }
 
-      const newValueModeValid = inputValue.value.length > 0
+      const newValueModeValid = inputValue.value.length !== 0
         && (props.newValueMode !== void 0 || props.onNewValue !== void 0)
 
       const tabShouldSelect = e.shiftKey !== true
@@ -800,7 +800,7 @@ export default createComponent({
         && e.altKey === false // not kbd shortcut
         && e.ctrlKey === false // not kbd shortcut
         && e.metaKey === false // not kbd shortcut, especially on macOS with Command key
-        && (e.keyCode !== 32 || searchBuffer.length > 0) // space in middle of search
+        && (e.keyCode !== 32 || searchBuffer.length !== 0) // space in middle of search
       ) {
         menu.value !== true && showPopup(e)
 
@@ -1087,7 +1087,7 @@ export default createComponent({
       if (
         val !== ''
         && props.multiple !== true
-        && innerValue.value.length > 0
+        && innerValue.value.length !== 0
         && userInputValue !== true
         && val === getOptionLabel.value(innerValue.value[ 0 ])
       ) {
@@ -1206,7 +1206,7 @@ export default createComponent({
           loading: innerLoadingIndicator.value,
           itemAligned: false,
           filled: true,
-          stackLabel: inputValue.value.length > 0,
+          stackLabel: inputValue.value.length !== 0,
           ...state.splitAttrs.listeners.value,
           onFocus: onDialogFieldFocus,
           onBlur: onDialogFieldBlur
@@ -1334,7 +1334,7 @@ export default createComponent({
 
     function resetInputValue () {
       props.useInput === true && updateInputValue(
-        props.multiple !== true && props.fillInput === true && innerValue.value.length > 0
+        props.multiple !== true && props.fillInput === true && innerValue.value.length !== 0
           ? getOptionLabel.value(innerValue.value[ 0 ]) || ''
           : '',
         true,
@@ -1346,7 +1346,7 @@ export default createComponent({
       let optionIndex = -1
 
       if (show === true) {
-        if (innerValue.value.length > 0) {
+        if (innerValue.value.length !== 0) {
           const val = getOptionValue.value(innerValue.value[ 0 ])
           optionIndex = props.options.findIndex(v => isDeepEqual(getOptionValue.value(v), val))
         }
@@ -1448,7 +1448,7 @@ export default createComponent({
       floatingLabel: computed(() =>
         (props.hideSelected !== true && hasValue.value === true)
         || typeof inputValue.value === 'number'
-        || inputValue.value.length > 0
+        || inputValue.value.length !== 0
         || fieldValueIsFilled(props.displayValue)
       ),
 
@@ -1517,7 +1517,7 @@ export default createComponent({
             })
           )
 
-          if (isTarget === true && typeof props.autocomplete === 'string' && props.autocomplete.length > 0) {
+          if (isTarget === true && typeof props.autocomplete === 'string' && props.autocomplete.length !== 0) {
             child.push(
               h('input', {
                 class: 'q-select__autocomplete-input',
@@ -1529,7 +1529,7 @@ export default createComponent({
           }
         }
 
-        if (nameProp.value !== void 0 && props.disable !== true && innerOptionsValue.value.length > 0) {
+        if (nameProp.value !== void 0 && props.disable !== true && innerOptionsValue.value.length !== 0) {
           const opts = innerOptionsValue.value.map(value => h('option', { value, selected: true }))
 
           child.push(

package/src/components/table/QTable.js

@@ -777,7 +777,7 @@ export default createComponent({
         }, getPaginationDiv(child))
       }
 
-      if (child.length > 0) {
+      if (child.length !== 0) {
         return h('div', { class: bottomClass }, child)
       }
     }

package/src/components/table/table-pagination.js

@@ -37,7 +37,7 @@ export function useTablePaginationState (vm, getCellValue) {
       sortBy: null,
       descending: false,
       page: 1,
-      rowsPerPage: props.rowsPerPageOptions.length > 0
+      rowsPerPage: props.rowsPerPageOptions.length !== 0
         ? props.rowsPerPageOptions[ 0 ]
         : 5
     }, props.pagination)

package/src/components/table/table-row-selection.js

@@ -36,7 +36,7 @@ export function useTableRowSelection (props, emit, computedRows, getRowKey) {
   })
 
   const allRowsSelected = computed(() =>
-    computedRows.value.length > 0 && computedRows.value.every(
+    computedRows.value.length !== 0 && computedRows.value.every(
       row => selectedKeys.value[ getRowKey.value(row) ] === true
     )
   )

package/src/components/time/QTime.js

@@ -470,9 +470,9 @@ export default createComponent({
           const am = computedFormat24h.value !== true
             ? isAM.value === true
             : (
-                validHours.value.am.values.length > 0 && validHours.value.pm.values.length > 0
+                validHours.value.am.values.length !== 0 && validHours.value.pm.values.length !== 0
                   ? distance >= clockRect.dist
-                  : validHours.value.am.values.length > 0
+                  : validHours.value.am.values.length !== 0
               )
 
           val = getNormalizedClockValue(

package/src/components/tree/QTree.js

@@ -140,7 +140,7 @@ export default createComponent({
         const tickStrategy = node.tickStrategy || (parent ? parent.tickStrategy : props.tickStrategy)
         const
           key = node[ props.nodeKey ],
-          isParent = node[ props.childrenKey ] && node[ props.childrenKey ].length > 0,
+          isParent = node[ props.childrenKey ] && node[ props.childrenKey ].length !== 0,
           selectable = node.disabled !== true && hasSelection.value === true && node.selectable !== false,
           expandable = node.disabled !== true && node.expandable !== false,
           hasTicking = tickStrategy !== 'none',
@@ -298,16 +298,15 @@ export default createComponent({
     }
 
     function expandAll () {
-      const
-        expanded = innerExpanded.value,
-        travel = node => {
-          if (node[ props.childrenKey ] && node[ props.childrenKey ].length > 0) {
-            if (node.expandable !== false && node.disabled !== true) {
-              expanded.push(node[ props.nodeKey ])
-              node[ props.childrenKey ].forEach(travel)
-            }
+      const expanded = []
+      const travel = node => {
+        if (node[ props.childrenKey ] && node[ props.childrenKey ].length !== 0) {
+          if (node.expandable !== false && node.disabled !== true) {
+            expanded.push(node[ props.nodeKey ])
+            node[ props.childrenKey ].forEach(travel)
           }
         }
+      }
 
       props.nodes.forEach(travel)
 
@@ -382,7 +381,7 @@ export default createComponent({
                 }
               })
             }
-            if (collapse.length > 0) {
+            if (collapse.length !== 0) {
               target = target.filter(k => collapse.includes(k) === false)
             }
           }
@@ -495,7 +494,7 @@ export default createComponent({
         ? getChildren(node[ props.childrenKey ])
         : []
 
-      const isParent = children.length > 0 || (m.lazy && m.lazy !== 'loaded')
+      const isParent = children.length !== 0 || (m.lazy && m.lazy !== 'loaded')
 
       let body = node.body
         ? slots[ `body-${ node.body }` ] || slots[ 'default-body' ]

package/src/components/uploader/__tests__/QUploader.cy.js

@@ -90,8 +90,8 @@ describe('Uploader API', () => {
         const headerSlot = `
 <template #header="scope">
   <div class="row no-wrap items-center q-pa-sm q-gutter-xs">
-    <q-btn v-if="scope.queuedFiles.length > 0" icon="clear_all" @click="scope.removeQueuedFiles" round dense flat />
-    <q-btn v-if="scope.uploadedFiles.length > 0" icon="done_all" @click="scope.removeUploadedFiles" round dense flat />
+    <q-btn v-if="scope.queuedFiles.length !== 0" icon="clear_all" @click="scope.removeQueuedFiles" round dense flat />
+    <q-btn v-if="scope.uploadedFiles.length !== 0" icon="done_all" @click="scope.removeUploadedFiles" round dense flat />
     <q-spinner v-if="scope.isUploading" class="q-uploader__spinner" />
     <div class="col">
       <div class="q-uploader__title">

package/src/components/uploader/uploader-core.js

@@ -135,7 +135,7 @@ export function getRenderer (getPlugin) {
     editable.value === true
     && state.isBusy.value !== true
     && state.isUploading.value !== true
-    && state.queuedFiles.value.length > 0
+    && state.queuedFiles.value.length !== 0
   )
 
   provide(uploaderKey, renderInput)
@@ -215,7 +215,7 @@ export function getRenderer (getPlugin) {
       return false
     })
 
-    if (removed.files.length > 0) {
+    if (removed.files.length !== 0) {
       state.files.value = localFiles
       cb(removed)
       emit('removed', removed.files)
@@ -343,8 +343,8 @@ export function getRenderer (getPlugin) {
         h('div', {
           class: 'flex flex-center no-wrap q-gutter-xs'
         }, [
-          getBtn(state.queuedFiles.value.length > 0, 'removeQueue', removeQueuedFiles),
-          getBtn(state.uploadedFiles.value.length > 0, 'removeUploaded', removeUploadedFiles),
+          getBtn(state.queuedFiles.value.length !== 0, 'removeQueue', removeQueuedFiles),
+          getBtn(state.uploadedFiles.value.length !== 0, 'removeUploaded', removeUploadedFiles),
 
           state.isUploading.value === true
             ? h(QSpinner, { class: 'q-uploader__spinner' })
@@ -426,7 +426,7 @@ export function getRenderer (getPlugin) {
 
   onBeforeUnmount(() => {
     state.isUploading.value === true && state.abort()
-    state.files.value.length > 0 && revokeImgURLs()
+    state.files.value.length !== 0 && revokeImgURLs()
   })
 
   const publicApi = {}

package/src/components/uploader/xhr-uploader-plugin.js

@@ -46,14 +46,14 @@ function injectPlugin ({ props, emit, helpers }) {
   }))
 
   const isUploading = computed(() => workingThreads.value > 0)
-  const isBusy = computed(() => promises.value.length > 0)
+  const isBusy = computed(() => promises.value.length !== 0)
 
   let abortPromises
 
   function abort () {
     xhrs.value.forEach(x => { x.abort() })
 
-    if (promises.value.length > 0) {
+    if (promises.value.length !== 0) {
       abortPromises = true
     }
   }

package/src/composables/private/use-field.js

@@ -21,7 +21,7 @@ function getTargetUid (val) {
 export function fieldValueIsFilled (val) {
   return val !== void 0
     && val !== null
-    && ('' + val).length > 0
+    && ('' + val).length !== 0
 }
 
 export const useFieldProps = {
@@ -217,7 +217,7 @@ export default function (state) {
       hasError.value === true
         ? ' text-negative'
         : (
-            typeof props.standout === 'string' && props.standout.length > 0 && state.focused.value === true
+            typeof props.standout === 'string' && props.standout.length !== 0 && state.focused.value === true
               ? ` ${ props.standout }`
               : (props.color !== void 0 ? ` text-${ props.color }` : '')
           )

package/src/composables/private/use-file.js

@@ -91,7 +91,7 @@ export default function ({
     const rejectedFiles = []
 
     const done = () => {
-      if (rejectedFiles.length > 0) {
+      if (rejectedFiles.length !== 0) {
         emit('rejected', rejectedFiles)
       }
     }
@@ -121,7 +121,7 @@ export default function ({
     // Cordova/iOS allows selecting multiple files even when the
     // multiple attribute is not specified. We also normalize drag'n'dropped
     // files here:
-    if (props.multiple !== true && files.length > 0) {
+    if (props.multiple !== true && files.length !== 0) {
       files = [ files[ 0 ] ]
     }
 
@@ -176,7 +176,7 @@ export default function ({
 
     done()
 
-    if (files.length > 0) {
+    if (files.length !== 0) {
       return files
     }
   }
@@ -202,7 +202,7 @@ export default function ({
     stopAndPreventDrag(e)
     const files = e.dataTransfer.files
 
-    if (files.length > 0) {
+    if (files.length !== 0) {
       addFilesToQueue(null, files)
     }
 

package/src/composables/private/use-panel.js

@@ -182,7 +182,7 @@ export default function () {
       index += direction
     }
 
-    if (props.infinite === true && panels.length > 0 && startIndex !== -1 && startIndex !== panels.length) {
+    if (props.infinite === true && panels.length !== 0 && startIndex !== -1 && startIndex !== panels.length) {
       goToPanelByOffset(direction, direction === -1 ? panels.length : -1)
     }
   }

package/src/composables/private/use-validate.js

@@ -39,7 +39,7 @@ export default function (focused, innerLoading) {
   const hasRules = computed(() =>
     props.rules !== void 0
     && props.rules !== null
-    && props.rules.length > 0
+    && props.rules.length !== 0
   )
 
   const hasActiveRules = computed(() =>
@@ -52,7 +52,7 @@ export default function (focused, innerLoading) {
   )
 
   const errorMessage = computed(() => (
-    typeof props.errorMessage === 'string' && props.errorMessage.length > 0
+    typeof props.errorMessage === 'string' && props.errorMessage.length !== 0
       ? props.errorMessage
       : innerErrorMessage.value
   ))

package/src/directives/Morph.js

@@ -75,7 +75,7 @@ function updateModifiers (mod, ctx) {
 }
 
 function insertArgs (arg, ctx) {
-  const opts = typeof arg === 'string' && arg.length > 0
+  const opts = typeof arg === 'string' && arg.length !== 0
     ? arg.split(':') : []
 
   ctx.name = opts[ 0 ]

package/src/directives/TouchHold.js

@@ -120,7 +120,7 @@ export default createDirective(__QUASAR_SSR_SERVER__
         // duration in ms, touch in pixels, mouse in pixels
         const data = [ 600, 5, 7 ]
 
-        if (typeof binding.arg === 'string' && binding.arg.length > 0) {
+        if (typeof binding.arg === 'string' && binding.arg.length !== 0) {
           binding.arg.split(':').forEach((val, index) => {
             const v = parseInt(val, 10)
             v && (data[ index ] = v)

package/src/directives/TouchRepeat.js

@@ -50,7 +50,7 @@ export default createDirective(__QUASAR_SSR_SERVER__
           return
         }
 
-        const durations = typeof arg === 'string' && arg.length > 0
+        const durations = typeof arg === 'string' && arg.length !== 0
           ? arg.split(':').map(val => parseInt(val, 10))
           : [ 0, 600, 300 ]
 

package/src/directives/TouchSwipe.js

@@ -107,6 +107,13 @@ export default createDirective(__QUASAR_SSR_SERVER__
                 return
               }
             }
+            // is user trying to select text?
+            // if so, then something should be reported here
+            // (previous selection, if any, was discarded when swipe started)
+            else if (window.getSelection().toString() !== '') {
+              ctx.end(evt)
+              return
+            }
             else if (absX < ctx.sensitivity[ 2 ] && absY < ctx.sensitivity[ 2 ]) {
               return
             }

package/src/lang.js

@@ -5,7 +5,7 @@ import defaultLang from '../lang/en-US'
 function getLocale () {
   if (__QUASAR_SSR_SERVER__) { return }
 
-  const val = Array.isArray(navigator.languages) === true && navigator.languages.length > 0
+  const val = Array.isArray(navigator.languages) === true && navigator.languages.length !== 0
     ? navigator.languages[ 0 ]
     : navigator.language
 

package/src/plugins/Meta.js

@@ -98,7 +98,7 @@ function apply ({ add, remove }) {
     document.title = add.title
   }
 
-  if (Object.keys(remove).length > 0) {
+  if (Object.keys(remove).length !== 0) {
     [ 'meta', 'link', 'script' ].forEach(type => {
       remove[ type ].forEach(name => {
         document.head.querySelector(`${ type }[data-qmeta="${ name }"]`).remove()
@@ -193,9 +193,9 @@ function injectServerMeta (ssrContext) {
 
   const htmlAttr = Object.keys(data.htmlAttr).filter(htmlFilter)
 
-  if (htmlAttr.length > 0) {
+  if (htmlAttr.length !== 0) {
     ctx.htmlAttrs += (
-      (ctx.htmlAttrs.length > 0 ? ' ' : '')
+      (ctx.htmlAttrs.length !== 0 ? ' ' : '')
       + htmlAttr.map(getAttr(data.htmlAttr)).join(' ')
     )
   }
@@ -204,9 +204,9 @@ function injectServerMeta (ssrContext) {
 
   const bodyAttr = Object.keys(data.bodyAttr).filter(bodyFilter)
 
-  if (bodyAttr.length > 0) {
+  if (bodyAttr.length !== 0) {
     ctx.bodyAttrs += (
-      (ctx.bodyAttrs.length > 0 ? ' ' : '')
+      (ctx.bodyAttrs.length !== 0 ? ' ' : '')
       + bodyAttr.map(getAttr(data.bodyAttr)).join(' ')
     )
   }

package/src/plugins/Screen.js

@@ -160,7 +160,7 @@ export default defineReactivePlugin({
 
       this.setDebounce(updateDebounce)
 
-      if (Object.keys(updateSizes).length > 0) {
+      if (Object.keys(updateSizes).length !== 0) {
         this.setSizes(updateSizes)
         updateSizes = void 0 // free up memory
       }

package/src/utils/EventBus.js

@@ -42,21 +42,25 @@ export default class EventBus {
 
   off (name, callback) {
     const list = this.__stack[ name ]
-    const liveEvents = []
 
-    if (list !== void 0 && callback) {
-      list.forEach(entry => {
-        if (entry.fn !== callback && entry.fn.__callback !== callback) {
-          liveEvents.push(entry)
-        }
-      })
+    if (list === void 0) {
+      return this // chainable
+    }
 
-      if (liveEvents.length !== 0) {
-        this.__stack[ name ] = liveEvents
-      }
-      else {
-        delete this.__stack[ name ]
-      }
+    if (callback === void 0) {
+      delete this.__stack[ name ]
+      return this // chainable
+    }
+
+    const liveEvents = list.filter(
+      entry => entry.fn !== callback && entry.fn.__callback !== callback
+    )
+
+    if (liveEvents.length !== 0) {
+      this.__stack[ name ] = liveEvents
+    }
+    else {
+      delete this.__stack[ name ]
     }
 
     return this // chainable

package/src/utils/morph.js

@@ -149,9 +149,9 @@ function normalizeOptions (options) {
     waitFor: options.waitFor === void 0 ? 0 : options.waitFor,
 
     duration: isNaN(options.duration) === true ? 300 : parseInt(options.duration, 10),
-    easing: typeof options.easing === 'string' && options.easing.length > 0 ? options.easing : 'ease-in-out',
+    easing: typeof options.easing === 'string' && options.easing.length !== 0 ? options.easing : 'ease-in-out',
     delay: isNaN(options.delay) === true ? 0 : parseInt(options.delay, 10),
-    fill: typeof options.fill === 'string' && options.fill.length > 0 ? options.fill : 'none',
+    fill: typeof options.fill === 'string' && options.fill.length !== 0 ? options.fill : 'none',
 
     resize: options.resize === true,
 

package/src/utils/private/focus-manager.js

@@ -13,7 +13,7 @@ export function addFocusWaitFlag (flag) {
 export function removeFocusWaitFlag (flag) {
   clearFlag(flag)
 
-  if (waitFlags.length === 0 && queue.length > 0) {
+  if (waitFlags.length === 0 && queue.length !== 0) {
     // only call last focus handler (can't focus multiple things at once)
     queue[ queue.length - 1 ]()
     queue = []

package/src/utils/private/touch.js

@@ -1,3 +1,4 @@
+
 const modifiersAll = {
   left: true,
   right: true,
@@ -45,11 +46,18 @@ export function getModifierDirections (mod) {
   return dir
 }
 
+// This is especially important (not the main reason, but important)
+// for TouchSwipe directive running on Firefox
+// because text selection on such elements cannot be determined
+// without additional work (on top of getSelection() API)
+// https://bugzilla.mozilla.org/show_bug.cgi?id=85686
+const avoidNodeNamesList = [ 'INPUT', 'TEXTAREA' ]
+
 export function shouldStart (evt, ctx) {
   return ctx.event === void 0
     && evt.target !== void 0
     && evt.target.draggable !== true
     && typeof ctx.handler === 'function'
-    && evt.target.nodeName.toUpperCase() !== 'INPUT'
+    && avoidNodeNamesList.includes(evt.target.nodeName.toUpperCase()) === false
     && (evt.qClonedBy === void 0 || evt.qClonedBy.indexOf(ctx.uid) === -1)
 }