qualia-framework 6.8.1 → 6.9.2

package/tests/state.test.sh

@@ -1011,6 +1011,89 @@ else
   fail_case "close-milestone + init" "got=$RESULT expected=2,4,1,1,1,0"
 fi
 
+# 46b. close-milestone resolves the REAL milestone name from JOURNEY.md
+# instead of emitting a "Milestone N" placeholder when tracking.json has
+# no (or a placeholder) milestone_name.
+TMP=$(make_project)
+cat > "$TMP/.planning/JOURNEY.md" <<'JOURNEY'
+# Journey
+
+## Milestone 1 · Foundation Arc
+
+Some prose.
+
+## Milestone 2 · Core Features
+JOURNEY
+$NODE -e "
+  const fs = require('fs');
+  const t = JSON.parse(fs.readFileSync('$TMP/.planning/tracking.json','utf8'));
+  t.milestone_name = 'Milestone 1'; // placeholder — must lose to JOURNEY.md
+  fs.writeFileSync('$TMP/.planning/tracking.json', JSON.stringify(t, null, 2));
+"
+(cd "$TMP" && $NODE "$STATE_JS" close-milestone --force >/dev/null 2>&1)
+RESULT=$($NODE -e "
+  const t = JSON.parse(require('fs').readFileSync('$TMP/.planning/tracking.json','utf8'));
+  console.log(t.milestones[0].name + '|' + t.milestone_name);
+")
+if [ "$RESULT" = "Foundation Arc|Core Features" ]; then
+  pass "close-milestone resolves real name from JOURNEY.md (no placeholder)"
+else
+  fail_case "close-milestone JOURNEY name resolution" "got=$RESULT expected='Foundation Arc|Core Features'"
+fi
+
+# 46c. close-milestone dedupes: same real name already logged under a
+# different (legacy string) num updates that entry instead of pushing a
+# duplicate.
+TMP=$(make_project)
+cat > "$TMP/.planning/JOURNEY.md" <<'JOURNEY'
+## Milestone 1 · Foundation Arc
+JOURNEY
+$NODE -e "
+  const fs = require('fs');
+  const t = JSON.parse(fs.readFileSync('$TMP/.planning/tracking.json','utf8'));
+  t.milestone_name = '';
+  t.milestones = [{ num: '9', name: 'Foundation Arc', total_phases: 2, phases_completed: 2, tasks_completed: 0, shipped_url: '', closed_at: '' }];
+  fs.writeFileSync('$TMP/.planning/tracking.json', JSON.stringify(t, null, 2));
+"
+(cd "$TMP" && $NODE "$STATE_JS" close-milestone --force >/dev/null 2>&1)
+RESULT=$($NODE -e "
+  const t = JSON.parse(require('fs').readFileSync('$TMP/.planning/tracking.json','utf8'));
+  console.log(t.milestones.length + '|' + t.milestones[0].num + '|' + t.milestones[0].name);
+")
+if [ "$RESULT" = "1|1|Foundation Arc" ]; then
+  pass "close-milestone dedupes same-name entry under different num"
+else
+  fail_case "close-milestone name dedupe" "got=$RESULT expected='1|1|Foundation Arc'"
+fi
+
+# 46d. backfill-milestones repairs a placeholder-named real-close entry in
+# place (fixes the name, keeps the richer close data like tasks_completed).
+TMP=$(make_project)
+cat > "$TMP/.planning/JOURNEY.md" <<'JOURNEY'
+# Journey
+
+| # | Milestone | Status | Phases | Closed |
+|---|-----------|--------|--------|--------|
+| 1 | Foundation Arc | CLOSED | 1–2 | 2026-01-01 |
+| 2 | Core Features | OPEN | rolling | — |
+JOURNEY
+$NODE -e "
+  const fs = require('fs');
+  const t = JSON.parse(fs.readFileSync('$TMP/.planning/tracking.json','utf8'));
+  t.milestones = [{ num: '1', name: 'Milestone 1', total_phases: 2, phases_completed: 2, tasks_completed: 7, shipped_url: 'https://x.test', closed_at: '2026-01-01T00:00:00.000Z' }];
+  fs.writeFileSync('$TMP/.planning/tracking.json', JSON.stringify(t, null, 2));
+"
+(cd "$TMP" && $NODE "$STATE_JS" backfill-milestones >/dev/null 2>&1)
+RESULT=$($NODE -e "
+  const t = JSON.parse(require('fs').readFileSync('$TMP/.planning/tracking.json','utf8'));
+  console.log(t.milestones.length + '|' + t.milestones[0].name + '|' + t.milestones[0].tasks_completed + '|' + t.milestone_name);
+")
+if [ "$RESULT" = "1|Foundation Arc|7|Core Features" ]; then
+  pass "backfill-milestones repairs placeholder name, keeps real close data"
+else
+  fail_case "backfill-milestones placeholder repair" "got=$RESULT expected='1|Foundation Arc|7|Core Features'"
+fi
+
 # ─── Backward compatibility ──────────────────────────────
 echo ""
 echo "backward compatibility:"