qa-control 0.6.7 → 0.6.8

package/bin/definition/definition.js

@@ -679,6 +679,35 @@ module.exports = function(qaControl){
                     }
                 }]
             },
+            qa_control_dev_dependency:{
+                checks:[{
+                    warnings:function(info) {
+                        var warns = [];
+                        // Only check if project has qa-control section AND has gha configured (but not "skip")
+                        var qaSection = info.packageJson && info.packageJson['qa-control'];
+                        if(!qaSection || !qaSection.gha || qaSection.gha === 'skip') { return warns; }
+                        var devDependencies = info.packageJson.devDependencies || {};
+                        if(!('qa-control' in devDependencies)) {
+                            warns.push({warning:'lack_of_qa_control_in_dev_dependencies', scoring:{dependencies:1}});
+                            return warns;
+                        }
+                        var actualVersion = devDependencies['qa-control'];
+                        var toolPkgPath = Path.join(__dirname, '../../package.json');
+                        var toolVersion;
+                        try {
+                            toolVersion = fs.readJsonSync(toolPkgPath).version;
+                        } catch(e) {
+                            try { toolVersion = require('../../package.json').version; } catch(e2) { toolVersion = null; }
+                        }
+                        if(!toolVersion) { return warns; }
+                        var expectedCaret = '^' + toolVersion;
+                        if(actualVersion !== expectedCaret && actualVersion !== toolVersion && actualVersion !== '~' + toolVersion) {
+                            warns.push({warning:'qa_control_version_mismatch_in_dev_dependencies_1_expected_2', params:[actualVersion, expectedCaret], scoring:{dependencies:1}});
+                        }
+                        return warns;
+                    }
+                }]
+            },
             workflows:{
                 checks:[{
                     warnings:function(info) {

package/bin/qa-control.js

@@ -27,6 +27,8 @@ qaControl.msgs={
     en:{
         lack_of_mandatory_section_1: 'lack of mandatory section "$1" in qa-control section of package.json',
         repository_name_not_found: 'packageJson.repository must be in format /{[-a-zA-Z0-9_.]+}\/[-a-zA-Z0-9_.]+/',
+        lack_of_qa_control_in_dev_dependencies: 'qa-control must be in devDependencies with the same version as qa-control.package-version',
+        qa_control_version_mismatch_in_dev_dependencies_1_expected_2: 'qa-control version in devDependencies is "$1" but expected "$2"',
         bailing_could_be_more: '--bail(ing)! There could be more issues'
     },
     es:{
@@ -63,6 +65,8 @@ qaControl.msgs={
         non_recomended_dependency_1_in_package_json: 'Dependencia no recomendada "$1" en package.json',
         lack_of_workflow_file_1: 'falta el archivo de workflow "$1"',
         workflow_file_1_differs: 'el archivo de workflow "$1" difiere del template de qa-control',
+        lack_of_qa_control_in_dev_dependencies: 'qa-control debe estar en devDependencies con la misma versión que qa-control.package-version',
+        qa_control_version_mismatch_in_dev_dependencies_1_expected_2: 'La versión de qa-control en devDependencies es "$1" pero se esperaba "$2"',
         bailing_could_be_more: '¡Qué --bail(e)! Podrían haber más problemas, correr de nuevo después de corregir estos'
     }
 };

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "qa-control",
   "description": "QA control of things that nobody controls",
-  "version": "0.6.7",
+  "version": "0.6.8",
   "author": "Codenautas <codenautas@googlegroups.com>",
   "license": "MIT",
   "repository": "codenautas/qa-control",
@@ -67,6 +67,7 @@
     "run-in": "server",
     "stability": "extending",
     "type": "cmd-tool",
-    "ecmaVersion": 6
+    "ecmaVersion": 6,
+    "gha": "all"
   }
 }