qa-control 0.6.5 → 0.6.8

package/bin/definition/definition.js

@@ -13,7 +13,7 @@ function eslintrcToFlatConfig(rc) {
     return flat;
 }
 var multilang = require('multilang');
-var fs = require('fs-promise');
+var fs = require('fs-extra');
 var Path = require('path');
 var yaml = require('js-yaml');
 
@@ -678,6 +678,68 @@ module.exports = function(qaControl){
                         return warns;
                     }
                 }]
+            },
+            qa_control_dev_dependency:{
+                checks:[{
+                    warnings:function(info) {
+                        var warns = [];
+                        // Only check if project has qa-control section AND has gha configured (but not "skip")
+                        var qaSection = info.packageJson && info.packageJson['qa-control'];
+                        if(!qaSection || !qaSection.gha || qaSection.gha === 'skip') { return warns; }
+                        var devDependencies = info.packageJson.devDependencies || {};
+                        if(!('qa-control' in devDependencies)) {
+                            warns.push({warning:'lack_of_qa_control_in_dev_dependencies', scoring:{dependencies:1}});
+                            return warns;
+                        }
+                        var actualVersion = devDependencies['qa-control'];
+                        var toolPkgPath = Path.join(__dirname, '../../package.json');
+                        var toolVersion;
+                        try {
+                            toolVersion = fs.readJsonSync(toolPkgPath).version;
+                        } catch(e) {
+                            try { toolVersion = require('../../package.json').version; } catch(e2) { toolVersion = null; }
+                        }
+                        if(!toolVersion) { return warns; }
+                        var expectedCaret = '^' + toolVersion;
+                        if(actualVersion !== expectedCaret && actualVersion !== toolVersion && actualVersion !== '~' + toolVersion) {
+                            warns.push({warning:'qa_control_version_mismatch_in_dev_dependencies_1_expected_2', params:[actualVersion, expectedCaret], scoring:{dependencies:1}});
+                        }
+                        return warns;
+                    }
+                }]
+            },
+            workflows:{
+                checks:[{
+                    warnings:function(info) {
+                        var qaSection = info.packageJson?.['qa-control'] || {};
+                        var gha = qaSection.gha;
+                        if(gha === 'skip' || (qaSection.profile === 'minimum' && !gha)) { return []; }
+                        var qaWorkflowsDir = Path.join(__dirname, '../../.github/workflows');
+                        var projWorkflowsDir = Path.join(info.projectDir, '.github/workflows');
+                        return fs.readdir(qaWorkflowsDir).then(function(qaFiles) {
+                            return Promise.all(qaFiles.map(function(fileName) {
+                                return fs.readFile(Path.join(qaWorkflowsDir, fileName), 'utf8').then(function(qaContent) {
+                                    return fs.readFile(Path.join(projWorkflowsDir, fileName), 'utf8').then(function(projContent) {
+                                        if(qaContent !== projContent) {
+                                            return [{warning:'workflow_file_1_differs', params:[fileName], scoring:{workflows:1}}];
+                                        }
+                                        return [];
+                                    }).catch(function(err) {
+                                        if(err.code === 'ENOENT') {
+                                            return [{warning:'lack_of_workflow_file_1', params:[fileName], scoring:{workflows:1}}];
+                                        }
+                                        throw err;
+                                    });
+                                });
+                            }));
+                        }).then(function(results) {
+                            return results.reduce(function(acc, arr) { return acc.concat(arr); }, []);
+                        }).catch(function(err) {
+                            if(err.code === 'ENOENT') { return []; }
+                            throw err;
+                        });
+                    }
+                }]
             }
         }
     };

package/bin/qa-control-run.js

@@ -5,8 +5,6 @@
 var { program } = require('commander');
 var qaControl = require('./qa-control');
 var qacInit = require('./qac-init');
-var fs = require('fs-promise');
-var path = require('path');
 
 program
     .version(require('../package.json').version)

package/bin/qa-control.js

@@ -3,7 +3,7 @@
 // CMD-TOOL
 var qaControl = {};
 
-var fs = require('fs-promise');
+var fs = require('fs-extra');
 var Path = require('path');
 var stripBom = require('strip-bom-string');
 var yaml = require('js-yaml');
@@ -27,6 +27,8 @@ qaControl.msgs={
     en:{
         lack_of_mandatory_section_1: 'lack of mandatory section "$1" in qa-control section of package.json',
         repository_name_not_found: 'packageJson.repository must be in format /{[-a-zA-Z0-9_.]+}\/[-a-zA-Z0-9_.]+/',
+        lack_of_qa_control_in_dev_dependencies: 'qa-control must be in devDependencies with the same version as qa-control.package-version',
+        qa_control_version_mismatch_in_dev_dependencies_1_expected_2: 'qa-control version in devDependencies is "$1" but expected "$2"',
         bailing_could_be_more: '--bail(ing)! There could be more issues'
     },
     es:{
@@ -61,6 +63,10 @@ qaControl.msgs={
         invalid_files_section_in_package_json: 'La sección "files" en package.json es inválida',
         incorrect_ecmascript_versions_in_package_json: 'Las versiones de ECMAScript utilizadas en package.json son incorrectas',
         non_recomended_dependency_1_in_package_json: 'Dependencia no recomendada "$1" en package.json',
+        lack_of_workflow_file_1: 'falta el archivo de workflow "$1"',
+        workflow_file_1_differs: 'el archivo de workflow "$1" difiere del template de qa-control',
+        lack_of_qa_control_in_dev_dependencies: 'qa-control debe estar en devDependencies con la misma versión que qa-control.package-version',
+        qa_control_version_mismatch_in_dev_dependencies_1_expected_2: 'La versión de qa-control en devDependencies es "$1" pero se esperaba "$2"',
         bailing_could_be_more: '¡Qué --bail(e)! Podrían haber más problemas, correr de nuevo después de corregir estos'
     }
 };

package/bin/qac-init.js

@@ -6,7 +6,7 @@
 
 var qacInit = {};
 
-var fs = require('fs-promise');
+var fs = require('fs-extra');
 var Path = require('path');
 var qaControl = require('./qa-control.js');
 var multilang = require('multilang');

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "qa-control",
   "description": "QA control of things that nobody controls",
-  "version": "0.6.5",
+  "version": "0.6.8",
   "author": "Codenautas <codenautas@googlegroups.com>",
   "license": "MIT",
   "repository": "codenautas/qa-control",
@@ -25,11 +25,10 @@
     "uuid": ">=14.0.0"
   },
   "dependencies": {
-    "best-globals": "^2.1.4",
+    "best-globals": "^2.1.5",
     "commander": "^14.0.3",
-    "eslint": "^10.3.0",
+    "eslint": "^10.4.0",
     "fs-extra": "^11.3.5",
-    "fs-promise": "^2.0.3",
     "js-yaml": "^4.1.1",
     "multilang": "^1.2.1",
     "semver": "^7.8.0",
@@ -37,7 +36,7 @@
   },
   "devDependencies": {
     "@types/mocha": "^10.0.10",
-    "@types/node": "^25.7.0",
+    "@types/node": "^25.9.0",
     "expect-called": "^0.4.0",
     "expect.js": "^0.3.1",
     "mocha": "^11.7.5",
@@ -68,6 +67,7 @@
     "run-in": "server",
     "stability": "extending",
     "type": "cmd-tool",
-    "ecmaVersion": 6
+    "ecmaVersion": 6,
+    "gha": "all"
   }
 }