pxt-core 7.4.26 → 7.4.29

package/built/pxtblocks.d.ts

@@ -511,6 +511,52 @@ declare namespace pxtblockly {
         dropdownCreate(): any;
     }
 }
+declare namespace pxtblockly {
+    interface FieldTextDropdownOptions extends Blockly.FieldCustomOptions {
+        values: any;
+    }
+    class FieldTextDropdown extends Blockly.FieldTextDropdown implements Blockly.FieldCustom {
+        isFieldCustom_: boolean;
+        constructor(text: string, options: FieldTextDropdownOptions, opt_validator?: Function);
+    }
+}
+declare namespace Blockly {
+    interface FieldTextDropdown {
+        showDropdown_(): void;
+        isTextValid_: boolean;
+    }
+}
+declare namespace pxtblockly {
+    interface FieldAutoCompleteOptions extends Blockly.FieldCustomOptions {
+        key: string;
+    }
+    class FieldAutoComplete extends Blockly.FieldTextDropdown implements Blockly.FieldCustom {
+        isFieldCustom_: boolean;
+        protected key: string;
+        protected parsedValue: string;
+        protected quoteSize_: number;
+        protected quoteWidth_: number;
+        protected quoteLeftX_: number;
+        protected quoteRightX_: number;
+        protected quoteY_: number;
+        protected quoteLeft_: SVGTextElement;
+        protected quoteRight_: SVGTextElement;
+        constructor(text: string, options: FieldAutoCompleteOptions, opt_validator?: Function);
+        isOptionListDynamic(): boolean;
+        getDisplayText_(): string;
+        doValueUpdate_(newValue: string): void;
+        getValue(): string;
+        getOptions(): [string, string][];
+        showDropdown_(): void;
+        getKey(): string;
+        initView(): void;
+        updateSize_(): void;
+        positionRight(x: number): number;
+        positionLeft(x: number): number;
+        createSVGArrow_(): void;
+        showPromptEditor_(): void;
+    }
+}
 declare namespace pxtblockly {
     class FieldBreakpoint extends Blockly.FieldNumber implements Blockly.FieldCustom {
         isFieldCustom_: boolean;
@@ -1193,15 +1239,6 @@ declare namespace pxtblockly {
         constructor(value: string, options?: StyleOptions, opt_validator?: Function);
     }
 }
-declare namespace pxtblockly {
-    interface FieldTextDropdownOptions extends Blockly.FieldCustomOptions {
-        values: any;
-    }
-    class FieldTextDropdown extends Blockly.FieldTextDropdown implements Blockly.FieldCustom {
-        isFieldCustom_: boolean;
-        constructor(text: string, options: FieldTextDropdownOptions, opt_validator?: Function);
-    }
-}
 declare namespace pxtblockly {
     class FieldTextInput extends Blockly.FieldTextInput implements Blockly.FieldCustom {
         isFieldCustom_: boolean;
@@ -1431,6 +1468,7 @@ declare namespace pxtblockly {
     function getAllBlocksWithTilesets(ws: Blockly.Workspace): FieldEditorReference<FieldTileset>[];
     function needsTilemapUpgrade(ws: Blockly.Workspace): boolean;
     function upgradeTilemapsInWorkspace(ws: Blockly.Workspace, proj: pxt.TilemapProject): void;
+    function getAllFields<U extends Blockly.Field>(ws: Blockly.Workspace, predicate: (field: Blockly.Field) => boolean): FieldEditorReference<U>[];
     function getAllReferencedTiles(workspace: Blockly.Workspace, excludeBlockID?: string): pxt.Tile[];
     function getTemporaryAssets(workspace: Blockly.Workspace, type: pxt.AssetType): pxt.Asset[];
 }

package/built/pxtblocks.js

@@ -2329,6 +2329,7 @@ var pxt;
             registerFieldEditor('protractor', pxtblockly.FieldProtractor);
             registerFieldEditor('position', pxtblockly.FieldPosition);
             registerFieldEditor('melody', pxtblockly.FieldCustomMelody);
+            registerFieldEditor('autocomplete', pxtblockly.FieldAutoComplete);
         }
         blocks.initFieldEditors = initFieldEditors;
         function registerFieldEditor(selector, field, validator) {
@@ -3908,11 +3909,10 @@ var pxt;
                 block.appendChild(createShadowValue(info, t, t.shadowBlockId || "variables_get", t.defaultValue || t.definitionName));
             }
             if (fn.parameters) {
-                comp.parameters.filter(pr => !pr.isOptional &&
-                    (primitiveTypeRegex.test(pr.type)
-                        || primitiveTypeRegex.test(isArrayType(pr.type))
-                        || pr.shadowBlockId
-                        || pr.defaultValue))
+                comp.parameters.filter(pr => primitiveTypeRegex.test(pr.type)
+                    || primitiveTypeRegex.test(isArrayType(pr.type))
+                    || pr.shadowBlockId
+                    || pr.defaultValue)
                     .forEach(pr => {
                     block.appendChild(createShadowValue(info, pr));
                 });
@@ -7246,18 +7246,27 @@ var pxt;
             // by BlocklyLoader. The number makes it an invalid JS identifier
             const buttonAddName = "0_add_button";
             const buttonRemName = "0_rem_button";
+            const buttonAddRemName = "0_add_rem_button";
             const numVisibleAttr = "_expanded";
             const inputInitAttr = "_input_init";
             const optionNames = def.parameters.map(p => p.name);
             const totalOptions = def.parameters.length;
             const buttonDelta = toggle ? totalOptions : 1;
+            const variableInlineInputs = info.blocksById[b.type].attributes.inlineInputMode === "variable";
+            const inlineInputModeLimit = info.blocksById[b.type].attributes.inlineInputModeLimit || 4;
+            const breakString = info.blocksById[b.type].attributes.expandableArgumentBreaks;
+            let breaks;
+            if (breakString) {
+                breaks = breakString.split(/[;,]/).map(s => parseInt(s));
+            }
             const state = new MutationState(b);
             state.setEventsEnabled(false);
             state.setValue(numVisibleAttr, 0);
             state.setValue(inputInitAttr, false);
             state.setEventsEnabled(true);
             Blockly.Extensions.apply('inline-svgs', b, false);
-            addPlusButton();
+            let updatingInputs = false;
+            let firstRender = true;
             appendMutation(b, {
                 mutationToDom: (el) => {
                     // The reason we store the inputsInitialized variable separately from visibleOptions
@@ -7272,8 +7281,8 @@ var pxt;
                     state.setEventsEnabled(false);
                     if (saved.hasAttribute(inputInitAttr) && saved.getAttribute(inputInitAttr) == "true" && !state.getBoolean(inputInitAttr)) {
                         state.setValue(inputInitAttr, true);
-                        initOptionalInputs();
                     }
+                    initOptionalInputs();
                     if (saved.hasAttribute(numVisibleAttr)) {
                         const val = parseInt(saved.getAttribute(numVisibleAttr));
                         if (!isNaN(val)) {
@@ -7284,6 +7293,7 @@ var pxt;
                                 }
                                 else {
                                     state.setValue(numVisibleAttr, addDelta(delta));
+                                    updateButtons();
                                 }
                             }
                             else {
@@ -7294,14 +7304,18 @@ var pxt;
                     state.setEventsEnabled(true);
                 }
             });
-            // Blockly only lets you hide an input once it is rendered, so we can't
-            // hide the inputs in init() or domToMutation(). This will get executed after
-            // the block is rendered
-            setTimeout(() => {
-                if (b.rendered && !b.workspace.isDragging()) {
+            initOptionalInputs();
+            b.render = (opt_bubble) => {
+                if (updatingInputs)
+                    return;
+                if (firstRender) {
+                    firstRender = false;
+                    updatingInputs = true;
                     updateShape(0, undefined, true);
+                    updatingInputs = false;
                 }
-            }, 1);
+                Blockly.BlockSvg.prototype.render.call(b, opt_bubble);
+            };
             // Set skipRender to true if the block is still initializing. Otherwise
             // the inputs will render before their shadow blocks are created and
             // leave behind annoying artifacts
@@ -7331,25 +7345,14 @@ var pxt;
                         setInputVisible(input, visible);
                         if (visible && input.connection && !input.connection.isConnected() && !b.isInsertionMarker()) {
                             const param = comp.definitionNameToParam[def.parameters[optIndex].name];
-                            let shadow = blocks.createShadowValue(info, param);
-                            if (shadow.tagName.toLowerCase() === "value") {
-                                // Unwrap the block
-                                shadow = shadow.firstElementChild;
-                            }
-                            Blockly.Events.disable();
-                            try {
-                                const nb = Blockly.Xml.domToBlock(shadow, b.workspace);
-                                if (nb) {
-                                    input.connection.connect(nb.outputConnection);
-                                }
-                            }
-                            catch (e) { }
-                            Blockly.Events.enable();
+                            attachShadowBlock(input, param);
                         }
                         ++optIndex;
                     }
                 }
                 updateButtons();
+                if (variableInlineInputs)
+                    b.setInputsInline(visibleOptions < inlineInputModeLimit);
                 if (!skipRender)
                     b.render();
             }
@@ -7358,31 +7361,32 @@ var pxt;
                     .appendField(new Blockly.FieldImage(uri, 24, 24, alt, () => updateShape(delta), false));
             }
             function updateButtons() {
+                if (updatingInputs)
+                    return;
                 const visibleOptions = state.getNumber(numVisibleAttr);
                 const showPlus = visibleOptions !== totalOptions;
                 const showMinus = visibleOptions !== 0;
-                const hasMinus = !!b.getInput(buttonRemName);
-                const hasPlus = !!b.getInput(buttonAddName);
-                if (!showPlus) {
+                if (b.inputList.some(i => i.name === buttonAddName))
                     b.removeInput(buttonAddName, true);
-                }
-                if (!showMinus) {
+                if (b.inputList.some(i => i.name === buttonRemName))
                     b.removeInput(buttonRemName, true);
+                if (b.inputList.some(i => i.name === buttonAddRemName))
+                    b.removeInput(buttonAddRemName, true);
+                if (showPlus && showMinus) {
+                    addPlusAndMinusButtons();
                 }
-                if (showMinus && !hasMinus) {
-                    addMinusButton();
+                else if (showPlus) {
+                    addPlusButton();
                 }
-                if (showPlus) {
-                    // make sure plus button is last in line.
-                    if (hasPlus && b.inputList.findIndex(el => el.name === buttonAddName) !== b.inputList.length - 1) {
-                        b.removeInput(buttonAddName, true);
-                        addPlusButton();
-                    }
-                    else if (!hasPlus) {
-                        addPlusButton();
-                    }
+                else if (showMinus) {
+                    addMinusButton();
                 }
             }
+            function addPlusAndMinusButtons() {
+                b.appendDummyInput(buttonAddRemName)
+                    .appendField(new Blockly.FieldImage(b.REMOVE_IMAGE_DATAURI, 24, 24, lf("Hide optional arguments"), () => updateShape(-1 * buttonDelta), false))
+                    .appendField(new Blockly.FieldImage(b.ADD_IMAGE_DATAURI, 24, 24, lf("Reveal optional arguments"), () => updateShape(buttonDelta), false));
+            }
             function addPlusButton() {
                 addButton(buttonAddName, b.ADD_IMAGE_DATAURI, lf("Reveal optional arguments"), buttonDelta);
             }
@@ -7395,16 +7399,48 @@ var pxt;
                 updateButtons();
             }
             function addDelta(delta) {
-                return Math.min(Math.max(state.getNumber(numVisibleAttr) + delta, 0), totalOptions);
+                const newValue = Math.min(Math.max(state.getNumber(numVisibleAttr) + delta, 0), totalOptions);
+                if (breaks) {
+                    if (delta >= 0) {
+                        if (newValue === 0)
+                            return 0;
+                        for (const breakpoint of breaks) {
+                            if (breakpoint >= newValue) {
+                                return breakpoint;
+                            }
+                        }
+                        return totalOptions;
+                    }
+                    else {
+                        for (let i = 0; i < breaks.length; i++) {
+                            if (breaks[i] >= newValue) {
+                                return i > 0 ? breaks[i - 1] : 0;
+                            }
+                        }
+                        return breaks[breaks.length - 1];
+                    }
+                }
+                return newValue;
             }
             function setInputVisible(input, visible) {
                 // If the block isn't rendered, Blockly will crash
-                if (b.rendered) {
-                    let renderList = input.setVisible(visible);
-                    renderList.forEach((block) => {
-                        block.render();
-                    });
+                input.setVisible(visible);
+            }
+            function attachShadowBlock(input, param) {
+                let shadow = blocks.createShadowValue(info, param);
+                if (shadow.tagName.toLowerCase() === "value") {
+                    // Unwrap the block
+                    shadow = shadow.firstElementChild;
+                }
+                Blockly.Events.disable();
+                try {
+                    const nb = Blockly.Xml.domToBlock(shadow, b.workspace);
+                    if (nb) {
+                        input.connection.connect(nb.outputConnection);
+                    }
                 }
+                catch (e) { }
+                Blockly.Events.enable();
             }
         }
         blocks.initExpandableBlock = initExpandableBlock;
@@ -8328,6 +8364,162 @@ var pxtblockly;
     }
     pxtblockly.FieldArgumentVariable = FieldArgumentVariable;
 })(pxtblockly || (pxtblockly = {}));
+/// <reference path="../../localtypings/pxtblockly.d.ts" />
+var pxtblockly;
+(function (pxtblockly) {
+    class FieldTextDropdown extends Blockly.FieldTextDropdown {
+        constructor(text, options, opt_validator) {
+            super(text, options.values, opt_validator);
+            this.isFieldCustom_ = true;
+        }
+    }
+    pxtblockly.FieldTextDropdown = FieldTextDropdown;
+})(pxtblockly || (pxtblockly = {}));
+/// <reference path="../../localtypings/pxtblockly.d.ts" />
+/// <reference path="./field_textdropdown.ts" />
+var pxtblockly;
+(function (pxtblockly) {
+    class FieldAutoComplete extends Blockly.FieldTextDropdown {
+        constructor(text, options, opt_validator) {
+            super(text, () => [], opt_validator);
+            this.isFieldCustom_ = true;
+            this.key = options.key;
+            this.isTextValid_ = true;
+        }
+        isOptionListDynamic() {
+            return true;
+        }
+        getDisplayText_() {
+            return this.parsedValue || "";
+        }
+        doValueUpdate_(newValue) {
+            if (newValue === null)
+                return;
+            if (/['"`].*['"`]/.test(newValue)) {
+                this.parsedValue = JSON.parse(newValue);
+            }
+            else {
+                this.parsedValue = newValue;
+            }
+            this.value_ = this.parsedValue;
+        }
+        getValue() {
+            if (this.parsedValue) {
+                return JSON.stringify(this.parsedValue);
+            }
+            else
+                return '""';
+        }
+        getOptions() {
+            var _a;
+            const workspace = (_a = this.sourceBlock_) === null || _a === void 0 ? void 0 : _a.workspace;
+            if (!workspace)
+                return [];
+            const res = [];
+            const fields = pxtblockly.getAllFields(workspace, field => field instanceof FieldAutoComplete && field.getKey() === this.key);
+            const options = fields.map(field => field.ref.getDisplayText_());
+            for (const option of options) {
+                if (!option.trim() || res.some(tuple => tuple[0] === option))
+                    continue;
+                res.push([option, option]);
+            }
+            res.sort((a, b) => a[0].localeCompare(b[0]));
+            return res;
+        }
+        showDropdown_() {
+            const options = this.getOptions();
+            if (options.length)
+                super.showDropdown_();
+        }
+        getKey() {
+            if (this.key)
+                return this.key;
+            if (this.sourceBlock_)
+                return this.sourceBlock_.type;
+            return undefined;
+        }
+        // Copied from field_string in pxt-blockly
+        initView() {
+            // Add quotes around the string
+            // Positioned on updatSize, after text size is calculated.
+            this.quoteSize_ = 16;
+            this.quoteWidth_ = 8;
+            this.quoteLeftX_ = 0;
+            this.quoteRightX_ = 0;
+            this.quoteY_ = 10;
+            if (this.quoteLeft_)
+                this.quoteLeft_.parentNode.removeChild(this.quoteLeft_);
+            this.quoteLeft_ = Blockly.utils.dom.createSvgElement('text', {
+                'font-size': this.quoteSize_ + 'px',
+                'class': 'field-text-quote'
+            }, this.fieldGroup_);
+            super.initView();
+            if (this.quoteRight_)
+                this.quoteRight_.parentNode.removeChild(this.quoteRight_);
+            this.quoteRight_ = Blockly.utils.dom.createSvgElement('text', {
+                'font-size': this.quoteSize_ + 'px',
+                'class': 'field-text-quote'
+            }, this.fieldGroup_);
+            this.quoteLeft_.appendChild(document.createTextNode('"'));
+            this.quoteRight_.appendChild(document.createTextNode('"'));
+        }
+        // Copied from field_string in pxt-blockly
+        updateSize_() {
+            super.updateSize_();
+            const sWidth = Math.max(this.size_.width, 1);
+            const xPadding = 3;
+            let addedWidth = this.positionLeft(sWidth + xPadding);
+            this.textElement_.setAttribute('x', addedWidth.toString());
+            addedWidth += this.positionRight(addedWidth + sWidth + xPadding);
+            this.size_.width = sWidth + addedWidth;
+        }
+        // Copied from field_string in pxt-blockly
+        positionRight(x) {
+            if (!this.quoteRight_) {
+                return 0;
+            }
+            let addedWidth = 0;
+            if (this.sourceBlock_.RTL) {
+                this.quoteRightX_ = Blockly.FieldString.quotePadding;
+                addedWidth = this.quoteWidth_ + Blockly.FieldString.quotePadding;
+            }
+            else {
+                this.quoteRightX_ = x + Blockly.FieldString.quotePadding;
+                addedWidth = this.quoteWidth_ + Blockly.FieldString.quotePadding;
+            }
+            this.quoteRight_.setAttribute('transform', 'translate(' + this.quoteRightX_ + ',' + this.quoteY_ + ')');
+            return addedWidth;
+        }
+        // Copied from field_string in pxt-blockly
+        positionLeft(x) {
+            if (!this.quoteLeft_) {
+                return 0;
+            }
+            let addedWidth = 0;
+            if (this.sourceBlock_.RTL) {
+                this.quoteLeftX_ = x + this.quoteWidth_ + Blockly.FieldString.quotePadding * 2;
+                addedWidth = this.quoteWidth_ + Blockly.FieldString.quotePadding;
+            }
+            else {
+                this.quoteLeftX_ = 0;
+                addedWidth = this.quoteWidth_ + Blockly.FieldString.quotePadding;
+            }
+            this.quoteLeft_.setAttribute('transform', 'translate(' + this.quoteLeftX_ + ',' + this.quoteY_ + ')');
+            return addedWidth;
+        }
+        createSVGArrow_() {
+            // This creates the little arrow for dropdown fields. Intentionally
+            // do nothing
+        }
+        showPromptEditor_() {
+            Blockly.prompt(Blockly.Msg['CHANGE_VALUE_TITLE'], this.parsedValue, (newValue) => {
+                this.setValue(this.getValueFromEditorText_(newValue));
+                this.forceRerender();
+            });
+        }
+    }
+    pxtblockly.FieldAutoComplete = FieldAutoComplete;
+})(pxtblockly || (pxtblockly = {}));
 /// <reference path="../../localtypings/blockly.d.ts" />
 /// <reference path="../../built/pxtsim.d.ts" />
 var pxtblockly;
@@ -11670,17 +11862,6 @@ var pxtblockly;
 })(pxtblockly || (pxtblockly = {}));
 /// <reference path="../../localtypings/pxtblockly.d.ts" />
 var pxtblockly;
-(function (pxtblockly) {
-    class FieldTextDropdown extends Blockly.FieldTextDropdown {
-        constructor(text, options, opt_validator) {
-            super(text, options.values, opt_validator);
-            this.isFieldCustom_ = true;
-        }
-    }
-    pxtblockly.FieldTextDropdown = FieldTextDropdown;
-})(pxtblockly || (pxtblockly = {}));
-/// <reference path="../../localtypings/pxtblockly.d.ts" />
-var pxtblockly;
 (function (pxtblockly) {
     class FieldTextInput extends Blockly.FieldTextInput {
         constructor(value, options, opt_validator) {
@@ -12792,11 +12973,11 @@ var pxtblockly;
         }
     }
     function getAllBlocksWithTilemaps(ws) {
-        return getAllFieldsCore(ws, f => f instanceof pxtblockly.FieldTilemap && !f.isGreyBlock);
+        return getAllFields(ws, f => f instanceof pxtblockly.FieldTilemap && !f.isGreyBlock);
     }
     pxtblockly.getAllBlocksWithTilemaps = getAllBlocksWithTilemaps;
     function getAllBlocksWithTilesets(ws) {
-        return getAllFieldsCore(ws, f => f instanceof pxtblockly.FieldTileset);
+        return getAllFields(ws, f => f instanceof pxtblockly.FieldTileset);
     }
     pxtblockly.getAllBlocksWithTilesets = getAllBlocksWithTilesets;
     function needsTilemapUpgrade(ws) {
@@ -12852,7 +13033,7 @@ var pxtblockly;
         }
     }
     pxtblockly.upgradeTilemapsInWorkspace = upgradeTilemapsInWorkspace;
-    function getAllFieldsCore(ws, predicate) {
+    function getAllFields(ws, predicate) {
         const result = [];
         const top = ws.getTopBlocks(false);
         top.forEach(block => getAllFieldsRecursive(block));
@@ -12873,6 +13054,7 @@ var pxtblockly;
             }
         }
     }
+    pxtblockly.getAllFields = getAllFields;
     function getAllReferencedTiles(workspace, excludeBlockID) {
         var _a;
         let all = {};
@@ -12911,10 +13093,10 @@ var pxtblockly;
     function getTemporaryAssets(workspace, type) {
         switch (type) {
             case "image" /* Image */:
-                return getAllFieldsCore(workspace, field => field instanceof pxtblockly.FieldSpriteEditor && field.isTemporaryAsset())
+                return getAllFields(workspace, field => field instanceof pxtblockly.FieldSpriteEditor && field.isTemporaryAsset())
                     .map(f => f.ref.getAsset());
             case "animation" /* Animation */:
-                return getAllFieldsCore(workspace, field => field instanceof pxtblockly.FieldAnimationEditor && field.isTemporaryAsset())
+                return getAllFields(workspace, field => field instanceof pxtblockly.FieldAnimationEditor && field.isTemporaryAsset())
                     .map(f => f.ref.getAsset());
             default: return [];
         }

package/built/pxtcompiler.js

@@ -18375,6 +18375,7 @@ var ts;
                 let snippet;
                 if (preDefinedSnippet) {
                     snippet = [preDefinedSnippet];
+                    snippetPrefix = undefined;
                 }
                 else {
                     snippet = [fnName];

package/built/pxteditor.js

@@ -1048,8 +1048,8 @@ var pxt;
                 let proj;
                 let id;
                 if (name) {
-                    let id = ts.pxtc.escapeIdentifier(name);
-                    proj = project.getTilemap(id);
+                    id = ts.pxtc.escapeIdentifier(name);
+                    proj = project.getTilemap(id) || project.lookupAssetByName("tilemap" /* Tilemap */, name);
                 }
                 if (!proj) {
                     let tileWidth = 16;

package/built/pxtlib.js

@@ -15791,7 +15791,7 @@ var ts;
             return r;
         }
         pxtc.emptyExtInfo = emptyExtInfo;
-        const numberAttributes = ["weight", "imageLiteral", "topblockWeight"];
+        const numberAttributes = ["weight", "imageLiteral", "topblockWeight", "inlineInputModeLimit"];
         const booleanAttributes = [
             "advanced",
             "handlerStatement",
@@ -17842,7 +17842,7 @@ var pxt;
                 id,
                 type: "tilemap" /* Tilemap */,
                 meta: {
-                    displayName: id
+                    displayName: name || id
                 },
                 data: data
             });