pxt-core 7.4.1 → 7.4.7

package/built/pxt.js

@@ -97876,14 +97876,15 @@ var pxt;
         let _client;
         function client() { return _client; }
         auth.client = client;
-        const PREFERENCES_DEBOUNCE_MS = 5 * 1000;
-        const PREFERENCES_DEBOUNCE_MAX_MS = 30 * 1000;
+        const PREFERENCES_DEBOUNCE_MS = 1 * 1000;
+        const PREFERENCES_DEBOUNCE_MAX_MS = 10 * 1000;
         let debouncePreferencesChangedTimeout = 0;
         let debouncePreferencesChangedStarted = 0;
         class AuthClient {
             constructor() {
                 this.initialUserPreferences_ = undefined;
                 this.initialAuthCheck_ = undefined;
+                this.prefPatchOps = [];
                 pxt.Util.assert(!_client);
                 // Set global instance.
                 _client = this;
@@ -98073,8 +98074,9 @@ var pxt;
                 }
                 return result.success;
             }
-            async patchUserPreferencesAsync(ops) {
+            async patchUserPreferencesAsync(ops, immediate = false) {
                 ops = Array.isArray(ops) ? ops : [ops];
+                ops = ops.filter(op => !!op);
                 if (!ops.length) {
                     return;
                 }
@@ -98086,10 +98088,27 @@ var pxt;
                     return;
                 }
                 // If the user is logged in, save to cloud, but debounce the api call as this can be called frequently from skillmaps
+                // Replace matching patches in the queue
+                ops.forEach((incoming, iIncoming) => {
+                    this.prefPatchOps.some((existing, iExisting) => {
+                        if (!ts.pxtc.jsonPatch.opsAreEqual(existing, incoming))
+                            return false;
+                        // Patches are equivalent, replace in queue
+                        this.prefPatchOps[iExisting] = incoming;
+                        // Clear from incoming so we don't add it below
+                        ops[iIncoming] = null;
+                        return true;
+                    });
+                });
+                // Add remaining ops to the queue
+                ops.filter(op => !!op).forEach(op => this.prefPatchOps.push(op));
                 clearTimeout(debouncePreferencesChangedTimeout);
                 const savePrefs = async () => {
                     debouncePreferencesChangedStarted = 0;
-                    const result = await this.apiAsync('/api/user/preferences', ops, 'PATCH');
+                    // Clear queued patch ops before send.
+                    const prefPatchOps = this.prefPatchOps;
+                    this.prefPatchOps = [];
+                    const result = await this.apiAsync('/api/user/preferences', prefPatchOps, 'PATCH');
                     if (result.success) {
                         pxt.debug("Updating local user preferences w/ cloud data after result of POST");
                         // Set user profile from returned value so we stay in-sync
@@ -98099,14 +98118,19 @@ var pxt;
                         pxt.reportError("identity", "update preferences failed", result);
                     }
                 };
-                if (!debouncePreferencesChangedStarted) {
-                    debouncePreferencesChangedStarted = pxt.U.now();
-                }
-                if (PREFERENCES_DEBOUNCE_MAX_MS < pxt.U.now() - debouncePreferencesChangedStarted) {
+                if (immediate) {
                     await savePrefs();
                 }
                 else {
-                    debouncePreferencesChangedTimeout = setTimeout(savePrefs, PREFERENCES_DEBOUNCE_MS);
+                    if (!debouncePreferencesChangedStarted) {
+                        debouncePreferencesChangedStarted = pxt.U.now();
+                    }
+                    if (PREFERENCES_DEBOUNCE_MAX_MS < pxt.U.now() - debouncePreferencesChangedStarted) {
+                        await savePrefs();
+                    }
+                    else {
+                        debouncePreferencesChangedTimeout = setTimeout(savePrefs, PREFERENCES_DEBOUNCE_MS);
+                    }
                 }
             }
             /*protected*/ hasUserId() {
@@ -98900,6 +98924,18 @@ var ts;
                 return arr;
             }
             Util.reversed = reversed;
+            function arrayEquals(a, b, compare = (c, d) => c === d) {
+                if (a == b)
+                    return true;
+                if (!a && b || !b && a || a.length !== b.length)
+                    return false;
+                for (let i = 0; i < a.length; i++) {
+                    if (!compare(a[i], b[i]))
+                        return false;
+                }
+                return true;
+            }
+            Util.arrayEquals = arrayEquals;
             function iterMap(m, f) {
                 Object.keys(m).forEach(k => f(k, m[k]));
             }
@@ -100723,6 +100759,10 @@ var ts;
                 }
             }
             jsonPatch.patchInPlace = patchInPlace;
+            function opsAreEqual(a, b) {
+                return (a.op === b.op && pxtc.U.arrayEquals(a.path, b.path));
+            }
+            jsonPatch.opsAreEqual = opsAreEqual;
         })(jsonPatch = pxtc.jsonPatch || (pxtc.jsonPatch = {}));
     })(pxtc = ts.pxtc || (ts.pxtc = {}));
 })(ts || (ts = {}));
@@ -116191,8 +116231,8 @@ var pxt;
         if (a == b)
             return true;
         if (a.id !== b.id || a.type !== b.type ||
-            !arrayEquals(a.meta.tags, b.meta.tags) ||
-            !arrayEquals(a.meta.blockIDs, b.meta.blockIDs) ||
+            !pxt.U.arrayEquals(a.meta.tags, b.meta.tags) ||
+            !pxt.U.arrayEquals(a.meta.blockIDs, b.meta.blockIDs) ||
             a.meta.displayName !== b.meta.displayName)
             return false;
         switch (a.type) {
@@ -116201,7 +116241,7 @@ var pxt;
                 return pxt.sprite.bitmapEquals(a.bitmap, b.bitmap);
             case "animation" /* Animation */:
                 const bAnimation = b;
-                return a.interval === bAnimation.interval && arrayEquals(a.frames, bAnimation.frames, pxt.sprite.bitmapEquals);
+                return a.interval === bAnimation.interval && pxt.U.arrayEquals(a.frames, bAnimation.frames, pxt.sprite.bitmapEquals);
             case "tilemap" /* Tilemap */:
                 return a.data.equals(b.data);
         }
@@ -116323,17 +116363,6 @@ var pxt;
         }
         return id;
     }
-    function arrayEquals(a, b, compare = (c, d) => c === d) {
-        if (a == b)
-            return true;
-        if (!a && b || !b && a || a.length !== b.length)
-            return false;
-        for (let i = 0; i < a.length; i++) {
-            if (!compare(a[i], b[i]))
-                return false;
-        }
-        return true;
-    }
     function serializeTilemap(tilemap, id, name) {
         const tm = tilemap.tilemap.data();
         const data = new Uint8ClampedArray(5 + tm.data.length + tilemap.layers.data.length);
@@ -139059,6 +139088,7 @@ var ts;
             }
             service.snippetAddsDefinitions = snippetAddsDefinitions;
             function getSnippet(context, fn, decl, python, recursionDepth = 0) {
+                var _a;
                 // TODO: a lot of this is duplicate logic with blocklyloader.ts:buildBlockFromDef; we should
                 //  unify these approaches
                 let { apis, takenNames, blocksInfo, screenSize, checker } = context;
@@ -139091,10 +139121,15 @@ var ts;
                 if (attrs.shim === "TD_ID" && recursionDepth && decl.parameters.length) {
                     return getParameterDefault(decl.parameters[0]);
                 }
+                const element = fn;
+                const params = pxt.blocks.compileInfo(element);
                 const blocksById = blocksInfo.blocksById;
                 // TODO: move out of getSnippet for general reuse
+                const blockParameters = ((_a = attrs._def) === null || _a === void 0 ? void 0 : _a.parameters.filter(param => !!params.definitionNameToParam[param.name]).map(param => params.definitionNameToParam[param.name].actualName)) || [];
                 const includedParameters = decl.parameters ? decl.parameters
-                    .filter(param => !param.initializer && !param.questionToken) : [];
+                    // Only keep required parameters and parameters included in the blockdef
+                    .filter(param => (!param.initializer && !param.questionToken)
+                    || (blockParameters.indexOf(param.name.getText()) >= 0)) : [];
                 const args = includedParameters
                     .map(getParameterDefault)
                     .map(p => 
@@ -139104,7 +139139,6 @@ var ts;
                     default: p,
                     isLiteral: true
                 }));
-                const element = fn;
                 if (element.attributes.block) {
                     if (element.attributes.defaultInstance) {
                         snippetPrefix = element.attributes.defaultInstance;
@@ -139152,7 +139186,6 @@ var ts;
                             isInstance = true;
                         }
                         else if (element.kind == 1 /* Method */ || element.kind == 2 /* Property */) {
-                            const params = pxt.blocks.compileInfo(element);
                             if (params.thisParameter) {
                                 let varName = undefined;
                                 if (params.thisParameter.definitionName) {

package/built/pxtcompiler.js

@@ -18255,6 +18255,7 @@ var ts;
             }
             service.snippetAddsDefinitions = snippetAddsDefinitions;
             function getSnippet(context, fn, decl, python, recursionDepth = 0) {
+                var _a;
                 // TODO: a lot of this is duplicate logic with blocklyloader.ts:buildBlockFromDef; we should
                 //  unify these approaches
                 let { apis, takenNames, blocksInfo, screenSize, checker } = context;
@@ -18287,10 +18288,15 @@ var ts;
                 if (attrs.shim === "TD_ID" && recursionDepth && decl.parameters.length) {
                     return getParameterDefault(decl.parameters[0]);
                 }
+                const element = fn;
+                const params = pxt.blocks.compileInfo(element);
                 const blocksById = blocksInfo.blocksById;
                 // TODO: move out of getSnippet for general reuse
+                const blockParameters = ((_a = attrs._def) === null || _a === void 0 ? void 0 : _a.parameters.filter(param => !!params.definitionNameToParam[param.name]).map(param => params.definitionNameToParam[param.name].actualName)) || [];
                 const includedParameters = decl.parameters ? decl.parameters
-                    .filter(param => !param.initializer && !param.questionToken) : [];
+                    // Only keep required parameters and parameters included in the blockdef
+                    .filter(param => (!param.initializer && !param.questionToken)
+                    || (blockParameters.indexOf(param.name.getText()) >= 0)) : [];
                 const args = includedParameters
                     .map(getParameterDefault)
                     .map(p => 
@@ -18300,7 +18306,6 @@ var ts;
                     default: p,
                     isLiteral: true
                 }));
-                const element = fn;
                 if (element.attributes.block) {
                     if (element.attributes.defaultInstance) {
                         snippetPrefix = element.attributes.defaultInstance;
@@ -18348,7 +18353,6 @@ var ts;
                             isInstance = true;
                         }
                         else if (element.kind == 1 /* Method */ || element.kind == 2 /* Property */) {
-                            const params = pxt.blocks.compileInfo(element);
                             if (params.thisParameter) {
                                 let varName = undefined;
                                 if (params.thisParameter.definitionName) {

package/built/pxteditor.d.ts

@@ -543,7 +543,7 @@ declare namespace pxt.editor {
         message?: string;
         data?: Map<string | number>;
     }
-    type EditorMessageTutorialEventRequest = EditorMessageTutorialProgressEventRequest | EditorMessageTutorialCompletedEventRequest | EditorMessageTutorialLoadedEventRequest;
+    type EditorMessageTutorialEventRequest = EditorMessageTutorialProgressEventRequest | EditorMessageTutorialCompletedEventRequest | EditorMessageTutorialLoadedEventRequest | EditorMessageTutorialExitEventRequest;
     interface EditorMessageTutorialProgressEventRequest extends EditorMessageRequest {
         action: "tutorialevent";
         tutorialEvent: "progress";

package/built/pxtlib.d.ts

@@ -124,7 +124,8 @@ declare namespace pxt.auth {
             username?: string;
             avatarUrl?: string;
         }): Promise<boolean>;
-        patchUserPreferencesAsync(ops: ts.pxtc.jsonPatch.PatchOperation | ts.pxtc.jsonPatch.PatchOperation[]): Promise<void>;
+        private prefPatchOps;
+        patchUserPreferencesAsync(ops: ts.pxtc.jsonPatch.PatchOperation | ts.pxtc.jsonPatch.PatchOperation[], immediate?: boolean): Promise<void>;
         hasUserId(): boolean;
         private fetchUserAsync;
         private setUserProfileAsync;
@@ -269,6 +270,7 @@ declare namespace ts.pxtc.Util {
     export function listsEqual<T>(a: T[], b: T[]): boolean;
     export function oops(msg?: string): Error;
     export function reversed<T>(arr: T[]): T[];
+    export function arrayEquals<U>(a: U[], b: U[], compare?: (c: U, d: U) => boolean): boolean;
     export function iterMap<T>(m: pxt.Map<T>, f: (k: string, v: T) => void): void;
     export function mapMap<T, S>(m: pxt.Map<T>, f: (k: string, v: T) => S): pxt.Map<S>;
     export function values<T>(m: pxt.Map<T>): T[];
@@ -464,6 +466,7 @@ declare namespace ts.pxtc.jsonPatch {
      * Applies a set of JSON Patch operations to the object.
      */
     function patchInPlace(obj: any, ops: PatchOperation[]): void;
+    function opsAreEqual(a: PatchOperation, b: PatchOperation): boolean;
 }
 declare namespace ts.pxtc.jsonPatch.tests {
     function diffTests(): void;

package/built/pxtlib.js

@@ -190,14 +190,15 @@ var pxt;
         let _client;
         function client() { return _client; }
         auth.client = client;
-        const PREFERENCES_DEBOUNCE_MS = 5 * 1000;
-        const PREFERENCES_DEBOUNCE_MAX_MS = 30 * 1000;
+        const PREFERENCES_DEBOUNCE_MS = 1 * 1000;
+        const PREFERENCES_DEBOUNCE_MAX_MS = 10 * 1000;
         let debouncePreferencesChangedTimeout = 0;
         let debouncePreferencesChangedStarted = 0;
         class AuthClient {
             constructor() {
                 this.initialUserPreferences_ = undefined;
                 this.initialAuthCheck_ = undefined;
+                this.prefPatchOps = [];
                 pxt.Util.assert(!_client);
                 // Set global instance.
                 _client = this;
@@ -387,8 +388,9 @@ var pxt;
                 }
                 return result.success;
             }
-            async patchUserPreferencesAsync(ops) {
+            async patchUserPreferencesAsync(ops, immediate = false) {
                 ops = Array.isArray(ops) ? ops : [ops];
+                ops = ops.filter(op => !!op);
                 if (!ops.length) {
                     return;
                 }
@@ -400,10 +402,27 @@ var pxt;
                     return;
                 }
                 // If the user is logged in, save to cloud, but debounce the api call as this can be called frequently from skillmaps
+                // Replace matching patches in the queue
+                ops.forEach((incoming, iIncoming) => {
+                    this.prefPatchOps.some((existing, iExisting) => {
+                        if (!ts.pxtc.jsonPatch.opsAreEqual(existing, incoming))
+                            return false;
+                        // Patches are equivalent, replace in queue
+                        this.prefPatchOps[iExisting] = incoming;
+                        // Clear from incoming so we don't add it below
+                        ops[iIncoming] = null;
+                        return true;
+                    });
+                });
+                // Add remaining ops to the queue
+                ops.filter(op => !!op).forEach(op => this.prefPatchOps.push(op));
                 clearTimeout(debouncePreferencesChangedTimeout);
                 const savePrefs = async () => {
                     debouncePreferencesChangedStarted = 0;
-                    const result = await this.apiAsync('/api/user/preferences', ops, 'PATCH');
+                    // Clear queued patch ops before send.
+                    const prefPatchOps = this.prefPatchOps;
+                    this.prefPatchOps = [];
+                    const result = await this.apiAsync('/api/user/preferences', prefPatchOps, 'PATCH');
                     if (result.success) {
                         pxt.debug("Updating local user preferences w/ cloud data after result of POST");
                         // Set user profile from returned value so we stay in-sync
@@ -413,14 +432,19 @@ var pxt;
                         pxt.reportError("identity", "update preferences failed", result);
                     }
                 };
-                if (!debouncePreferencesChangedStarted) {
-                    debouncePreferencesChangedStarted = pxt.U.now();
-                }
-                if (PREFERENCES_DEBOUNCE_MAX_MS < pxt.U.now() - debouncePreferencesChangedStarted) {
+                if (immediate) {
                     await savePrefs();
                 }
                 else {
-                    debouncePreferencesChangedTimeout = setTimeout(savePrefs, PREFERENCES_DEBOUNCE_MS);
+                    if (!debouncePreferencesChangedStarted) {
+                        debouncePreferencesChangedStarted = pxt.U.now();
+                    }
+                    if (PREFERENCES_DEBOUNCE_MAX_MS < pxt.U.now() - debouncePreferencesChangedStarted) {
+                        await savePrefs();
+                    }
+                    else {
+                        debouncePreferencesChangedTimeout = setTimeout(savePrefs, PREFERENCES_DEBOUNCE_MS);
+                    }
                 }
             }
             /*protected*/ hasUserId() {
@@ -1214,6 +1238,18 @@ var ts;
                 return arr;
             }
             Util.reversed = reversed;
+            function arrayEquals(a, b, compare = (c, d) => c === d) {
+                if (a == b)
+                    return true;
+                if (!a && b || !b && a || a.length !== b.length)
+                    return false;
+                for (let i = 0; i < a.length; i++) {
+                    if (!compare(a[i], b[i]))
+                        return false;
+                }
+                return true;
+            }
+            Util.arrayEquals = arrayEquals;
             function iterMap(m, f) {
                 Object.keys(m).forEach(k => f(k, m[k]));
             }
@@ -3037,6 +3073,10 @@ var ts;
                 }
             }
             jsonPatch.patchInPlace = patchInPlace;
+            function opsAreEqual(a, b) {
+                return (a.op === b.op && pxtc.U.arrayEquals(a.path, b.path));
+            }
+            jsonPatch.opsAreEqual = opsAreEqual;
         })(jsonPatch = pxtc.jsonPatch || (pxtc.jsonPatch = {}));
     })(pxtc = ts.pxtc || (ts.pxtc = {}));
 })(ts || (ts = {}));
@@ -18505,8 +18545,8 @@ var pxt;
         if (a == b)
             return true;
         if (a.id !== b.id || a.type !== b.type ||
-            !arrayEquals(a.meta.tags, b.meta.tags) ||
-            !arrayEquals(a.meta.blockIDs, b.meta.blockIDs) ||
+            !pxt.U.arrayEquals(a.meta.tags, b.meta.tags) ||
+            !pxt.U.arrayEquals(a.meta.blockIDs, b.meta.blockIDs) ||
             a.meta.displayName !== b.meta.displayName)
             return false;
         switch (a.type) {
@@ -18515,7 +18555,7 @@ var pxt;
                 return pxt.sprite.bitmapEquals(a.bitmap, b.bitmap);
             case "animation" /* Animation */:
                 const bAnimation = b;
-                return a.interval === bAnimation.interval && arrayEquals(a.frames, bAnimation.frames, pxt.sprite.bitmapEquals);
+                return a.interval === bAnimation.interval && pxt.U.arrayEquals(a.frames, bAnimation.frames, pxt.sprite.bitmapEquals);
             case "tilemap" /* Tilemap */:
                 return a.data.equals(b.data);
         }
@@ -18637,17 +18677,6 @@ var pxt;
         }
         return id;
     }
-    function arrayEquals(a, b, compare = (c, d) => c === d) {
-        if (a == b)
-            return true;
-        if (!a && b || !b && a || a.length !== b.length)
-            return false;
-        for (let i = 0; i < a.length; i++) {
-            if (!compare(a[i], b[i]))
-                return false;
-        }
-        return true;
-    }
     function serializeTilemap(tilemap, id, name) {
         const tm = tilemap.tilemap.data();
         const data = new Uint8ClampedArray(5 + tm.data.length + tilemap.layers.data.length);