pxt-core 7.3.8 → 7.3.12

package/built/pxt.js

@@ -97876,14 +97876,15 @@ var pxt;
         let _client;
         function client() { return _client; }
         auth.client = client;
-        const PREFERENCES_DEBOUNCE_MS = 5 * 1000;
-        const PREFERENCES_DEBOUNCE_MAX_MS = 30 * 1000;
+        const PREFERENCES_DEBOUNCE_MS = 1 * 1000;
+        const PREFERENCES_DEBOUNCE_MAX_MS = 10 * 1000;
         let debouncePreferencesChangedTimeout = 0;
         let debouncePreferencesChangedStarted = 0;
         class AuthClient {
             constructor() {
                 this.initialUserPreferences_ = undefined;
                 this.initialAuthCheck_ = undefined;
+                this.prefPatchOps = [];
                 pxt.Util.assert(!_client);
                 // Set global instance.
                 _client = this;
@@ -98073,7 +98074,7 @@ var pxt;
                 }
                 return result.success;
             }
-            async patchUserPreferencesAsync(ops) {
+            async patchUserPreferencesAsync(ops, immediate = false) {
                 ops = Array.isArray(ops) ? ops : [ops];
                 if (!ops.length) {
                     return;
@@ -98086,10 +98087,15 @@ var pxt;
                     return;
                 }
                 // If the user is logged in, save to cloud, but debounce the api call as this can be called frequently from skillmaps
+                // Accumulate the ops and send to cloud in batch.
+                this.prefPatchOps.push(...ops);
                 clearTimeout(debouncePreferencesChangedTimeout);
                 const savePrefs = async () => {
                     debouncePreferencesChangedStarted = 0;
-                    const result = await this.apiAsync('/api/user/preferences', ops, 'PATCH');
+                    // Clear queued patch ops before send.
+                    const prefPatchOps = this.prefPatchOps;
+                    this.prefPatchOps = [];
+                    const result = await this.apiAsync('/api/user/preferences', prefPatchOps, 'PATCH');
                     if (result.success) {
                         pxt.debug("Updating local user preferences w/ cloud data after result of POST");
                         // Set user profile from returned value so we stay in-sync
@@ -98099,14 +98105,19 @@ var pxt;
                         pxt.reportError("identity", "update preferences failed", result);
                     }
                 };
-                if (!debouncePreferencesChangedStarted) {
-                    debouncePreferencesChangedStarted = pxt.U.now();
-                }
-                if (PREFERENCES_DEBOUNCE_MAX_MS < pxt.U.now() - debouncePreferencesChangedStarted) {
+                if (immediate) {
                     await savePrefs();
                 }
                 else {
-                    debouncePreferencesChangedTimeout = setTimeout(savePrefs, PREFERENCES_DEBOUNCE_MS);
+                    if (!debouncePreferencesChangedStarted) {
+                        debouncePreferencesChangedStarted = pxt.U.now();
+                    }
+                    if (PREFERENCES_DEBOUNCE_MAX_MS < pxt.U.now() - debouncePreferencesChangedStarted) {
+                        await savePrefs();
+                    }
+                    else {
+                        debouncePreferencesChangedTimeout = setTimeout(savePrefs, PREFERENCES_DEBOUNCE_MS);
+                    }
                 }
             }
             /*protected*/ hasUserId() {
@@ -139059,6 +139070,7 @@ var ts;
             }
             service.snippetAddsDefinitions = snippetAddsDefinitions;
             function getSnippet(context, fn, decl, python, recursionDepth = 0) {
+                var _a;
                 // TODO: a lot of this is duplicate logic with blocklyloader.ts:buildBlockFromDef; we should
                 //  unify these approaches
                 let { apis, takenNames, blocksInfo, screenSize, checker } = context;
@@ -139091,10 +139103,15 @@ var ts;
                 if (attrs.shim === "TD_ID" && recursionDepth && decl.parameters.length) {
                     return getParameterDefault(decl.parameters[0]);
                 }
+                const element = fn;
+                const params = pxt.blocks.compileInfo(element);
                 const blocksById = blocksInfo.blocksById;
                 // TODO: move out of getSnippet for general reuse
+                const blockParameters = ((_a = attrs._def) === null || _a === void 0 ? void 0 : _a.parameters.filter(param => !!params.definitionNameToParam[param.name]).map(param => params.definitionNameToParam[param.name].actualName)) || [];
                 const includedParameters = decl.parameters ? decl.parameters
-                    .filter(param => !param.initializer && !param.questionToken) : [];
+                    // Only keep required parameters and parameters included in the blockdef
+                    .filter(param => (!param.initializer && !param.questionToken)
+                    || (blockParameters.indexOf(param.name.getText()) >= 0)) : [];
                 const args = includedParameters
                     .map(getParameterDefault)
                     .map(p => 
@@ -139104,7 +139121,6 @@ var ts;
                     default: p,
                     isLiteral: true
                 }));
-                const element = fn;
                 if (element.attributes.block) {
                     if (element.attributes.defaultInstance) {
                         snippetPrefix = element.attributes.defaultInstance;
@@ -139152,7 +139168,6 @@ var ts;
                             isInstance = true;
                         }
                         else if (element.kind == 1 /* Method */ || element.kind == 2 /* Property */) {
-                            const params = pxt.blocks.compileInfo(element);
                             if (params.thisParameter) {
                                 let varName = undefined;
                                 if (params.thisParameter.definitionName) {

package/built/pxtcompiler.js

@@ -18255,6 +18255,7 @@ var ts;
             }
             service.snippetAddsDefinitions = snippetAddsDefinitions;
             function getSnippet(context, fn, decl, python, recursionDepth = 0) {
+                var _a;
                 // TODO: a lot of this is duplicate logic with blocklyloader.ts:buildBlockFromDef; we should
                 //  unify these approaches
                 let { apis, takenNames, blocksInfo, screenSize, checker } = context;
@@ -18287,10 +18288,15 @@ var ts;
                 if (attrs.shim === "TD_ID" && recursionDepth && decl.parameters.length) {
                     return getParameterDefault(decl.parameters[0]);
                 }
+                const element = fn;
+                const params = pxt.blocks.compileInfo(element);
                 const blocksById = blocksInfo.blocksById;
                 // TODO: move out of getSnippet for general reuse
+                const blockParameters = ((_a = attrs._def) === null || _a === void 0 ? void 0 : _a.parameters.filter(param => !!params.definitionNameToParam[param.name]).map(param => params.definitionNameToParam[param.name].actualName)) || [];
                 const includedParameters = decl.parameters ? decl.parameters
-                    .filter(param => !param.initializer && !param.questionToken) : [];
+                    // Only keep required parameters and parameters included in the blockdef
+                    .filter(param => (!param.initializer && !param.questionToken)
+                    || (blockParameters.indexOf(param.name.getText()) >= 0)) : [];
                 const args = includedParameters
                     .map(getParameterDefault)
                     .map(p => 
@@ -18300,7 +18306,6 @@ var ts;
                     default: p,
                     isLiteral: true
                 }));
-                const element = fn;
                 if (element.attributes.block) {
                     if (element.attributes.defaultInstance) {
                         snippetPrefix = element.attributes.defaultInstance;
@@ -18348,7 +18353,6 @@ var ts;
                             isInstance = true;
                         }
                         else if (element.kind == 1 /* Method */ || element.kind == 2 /* Property */) {
-                            const params = pxt.blocks.compileInfo(element);
                             if (params.thisParameter) {
                                 let varName = undefined;
                                 if (params.thisParameter.definitionName) {

package/built/pxteditor.d.ts

@@ -543,7 +543,7 @@ declare namespace pxt.editor {
         message?: string;
         data?: Map<string | number>;
     }
-    type EditorMessageTutorialEventRequest = EditorMessageTutorialProgressEventRequest | EditorMessageTutorialCompletedEventRequest | EditorMessageTutorialLoadedEventRequest;
+    type EditorMessageTutorialEventRequest = EditorMessageTutorialProgressEventRequest | EditorMessageTutorialCompletedEventRequest | EditorMessageTutorialLoadedEventRequest | EditorMessageTutorialExitEventRequest;
     interface EditorMessageTutorialProgressEventRequest extends EditorMessageRequest {
         action: "tutorialevent";
         tutorialEvent: "progress";

package/built/pxtlib.d.ts

@@ -124,7 +124,8 @@ declare namespace pxt.auth {
             username?: string;
             avatarUrl?: string;
         }): Promise<boolean>;
-        patchUserPreferencesAsync(ops: ts.pxtc.jsonPatch.PatchOperation | ts.pxtc.jsonPatch.PatchOperation[]): Promise<void>;
+        private prefPatchOps;
+        patchUserPreferencesAsync(ops: ts.pxtc.jsonPatch.PatchOperation | ts.pxtc.jsonPatch.PatchOperation[], immediate?: boolean): Promise<void>;
         hasUserId(): boolean;
         private fetchUserAsync;
         private setUserProfileAsync;

package/built/pxtlib.js

@@ -190,14 +190,15 @@ var pxt;
         let _client;
         function client() { return _client; }
         auth.client = client;
-        const PREFERENCES_DEBOUNCE_MS = 5 * 1000;
-        const PREFERENCES_DEBOUNCE_MAX_MS = 30 * 1000;
+        const PREFERENCES_DEBOUNCE_MS = 1 * 1000;
+        const PREFERENCES_DEBOUNCE_MAX_MS = 10 * 1000;
         let debouncePreferencesChangedTimeout = 0;
         let debouncePreferencesChangedStarted = 0;
         class AuthClient {
             constructor() {
                 this.initialUserPreferences_ = undefined;
                 this.initialAuthCheck_ = undefined;
+                this.prefPatchOps = [];
                 pxt.Util.assert(!_client);
                 // Set global instance.
                 _client = this;
@@ -387,7 +388,7 @@ var pxt;
                 }
                 return result.success;
             }
-            async patchUserPreferencesAsync(ops) {
+            async patchUserPreferencesAsync(ops, immediate = false) {
                 ops = Array.isArray(ops) ? ops : [ops];
                 if (!ops.length) {
                     return;
@@ -400,10 +401,15 @@ var pxt;
                     return;
                 }
                 // If the user is logged in, save to cloud, but debounce the api call as this can be called frequently from skillmaps
+                // Accumulate the ops and send to cloud in batch.
+                this.prefPatchOps.push(...ops);
                 clearTimeout(debouncePreferencesChangedTimeout);
                 const savePrefs = async () => {
                     debouncePreferencesChangedStarted = 0;
-                    const result = await this.apiAsync('/api/user/preferences', ops, 'PATCH');
+                    // Clear queued patch ops before send.
+                    const prefPatchOps = this.prefPatchOps;
+                    this.prefPatchOps = [];
+                    const result = await this.apiAsync('/api/user/preferences', prefPatchOps, 'PATCH');
                     if (result.success) {
                         pxt.debug("Updating local user preferences w/ cloud data after result of POST");
                         // Set user profile from returned value so we stay in-sync
@@ -413,14 +419,19 @@ var pxt;
                         pxt.reportError("identity", "update preferences failed", result);
                     }
                 };
-                if (!debouncePreferencesChangedStarted) {
-                    debouncePreferencesChangedStarted = pxt.U.now();
-                }
-                if (PREFERENCES_DEBOUNCE_MAX_MS < pxt.U.now() - debouncePreferencesChangedStarted) {
+                if (immediate) {
                     await savePrefs();
                 }
                 else {
-                    debouncePreferencesChangedTimeout = setTimeout(savePrefs, PREFERENCES_DEBOUNCE_MS);
+                    if (!debouncePreferencesChangedStarted) {
+                        debouncePreferencesChangedStarted = pxt.U.now();
+                    }
+                    if (PREFERENCES_DEBOUNCE_MAX_MS < pxt.U.now() - debouncePreferencesChangedStarted) {
+                        await savePrefs();
+                    }
+                    else {
+                        debouncePreferencesChangedTimeout = setTimeout(savePrefs, PREFERENCES_DEBOUNCE_MS);
+                    }
                 }
             }
             /*protected*/ hasUserId() {