pumuki 6.3.360 → 6.3.361
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/core/facts/detectors/text/android.test.ts +28 -0
- package/core/facts/detectors/text/android.ts +45 -0
- package/core/facts/extractHeuristicFacts.ts +1 -0
- package/core/rules/presets/heuristics/android.test.ts +6 -1
- package/core/rules/presets/heuristics/android.ts +20 -0
- package/integrations/config/skillsDetectorRegistry.ts +8 -0
- package/package.json +1 -1
- package/skills.lock.json +1 -1
|
@@ -7,6 +7,7 @@ import {
|
|
|
7
7
|
findKotlinOpenClosedWhenMatch,
|
|
8
8
|
findKotlinPresentationSrpMatch,
|
|
9
9
|
hasAndroidAsyncTaskUsage,
|
|
10
|
+
hasAndroidCustomSingletonObjectUsage,
|
|
10
11
|
hasAndroidLegacyFingerprintApiUsage,
|
|
11
12
|
hasKotlinCoroutineTryCatchUsage,
|
|
12
13
|
hasKotlinDispatcherMainBoundaryLeakUsage,
|
|
@@ -1278,3 +1279,30 @@ val sample = "FingerprintManagerCompat"
|
|
|
1278
1279
|
assert.equal(hasAndroidLegacyFingerprintApiUsage(legacyCompat), true);
|
|
1279
1280
|
assert.equal(hasAndroidLegacyFingerprintApiUsage(modern), false);
|
|
1280
1281
|
});
|
|
1282
|
+
|
|
1283
|
+
test('hasAndroidCustomSingletonObjectUsage detecta singletons Kotlin propios y preserva objetos seguros', () => {
|
|
1284
|
+
const singletonSource = `
|
|
1285
|
+
object CheckoutRepository {
|
|
1286
|
+
fun loadCheckout() = Unit
|
|
1287
|
+
}
|
|
1288
|
+
|
|
1289
|
+
object SessionManager {
|
|
1290
|
+
fun clear() = Unit
|
|
1291
|
+
}
|
|
1292
|
+
`;
|
|
1293
|
+
const safeSource = `
|
|
1294
|
+
object CheckoutRoute {
|
|
1295
|
+
const val PATH = "checkout"
|
|
1296
|
+
}
|
|
1297
|
+
|
|
1298
|
+
@Module
|
|
1299
|
+
@InstallIn(SingletonComponent::class)
|
|
1300
|
+
object CheckoutModule {
|
|
1301
|
+
@Provides
|
|
1302
|
+
fun provideRepository(): CheckoutRepository = CheckoutRepository()
|
|
1303
|
+
}
|
|
1304
|
+
`;
|
|
1305
|
+
|
|
1306
|
+
assert.equal(hasAndroidCustomSingletonObjectUsage(singletonSource), true);
|
|
1307
|
+
assert.equal(hasAndroidCustomSingletonObjectUsage(safeSource), false);
|
|
1308
|
+
});
|
|
@@ -130,6 +130,51 @@ const sortedUniqueLines = (lines: ReadonlyArray<number>): readonly number[] => {
|
|
|
130
130
|
.sort((left, right) => left - right);
|
|
131
131
|
};
|
|
132
132
|
|
|
133
|
+
const androidCustomSingletonObjectNamePattern =
|
|
134
|
+
/(?:Repository|Service|Manager|Client|Store|DataSource|Gateway|Controller|Coordinator)$/;
|
|
135
|
+
|
|
136
|
+
const androidSafeObjectNamePattern =
|
|
137
|
+
/(?:Route|Routes|Screen|Screens|Destination|Destinations|Module|Modules|Constants|Config|Keys|Theme|Colors|Typography)$/;
|
|
138
|
+
|
|
139
|
+
const isAndroidHiltModuleObjectContext = (
|
|
140
|
+
lines: readonly string[],
|
|
141
|
+
index: number
|
|
142
|
+
): boolean => {
|
|
143
|
+
const context = lines
|
|
144
|
+
.slice(Math.max(0, index - 4), index)
|
|
145
|
+
.map((line) => stripKotlinLineForSemanticScan(line))
|
|
146
|
+
.join('\n');
|
|
147
|
+
return /@(?:Module|InstallIn|Provides|Binds)\b/.test(context);
|
|
148
|
+
};
|
|
149
|
+
|
|
150
|
+
export const collectAndroidCustomSingletonObjectLines = (source: string): readonly number[] => {
|
|
151
|
+
const lines = source.split(/\r?\n/);
|
|
152
|
+
const matches: number[] = [];
|
|
153
|
+
|
|
154
|
+
lines.forEach((line, index) => {
|
|
155
|
+
const sanitized = stripKotlinLineForSemanticScan(line);
|
|
156
|
+
if (sanitized.trimStart().startsWith('import ')) {
|
|
157
|
+
return;
|
|
158
|
+
}
|
|
159
|
+
const objectMatch = sanitized.match(/^\s*object\s+([A-Za-z_][A-Za-z0-9_]*)\b/);
|
|
160
|
+
const objectName = objectMatch?.[1];
|
|
161
|
+
if (!objectName) {
|
|
162
|
+
return;
|
|
163
|
+
}
|
|
164
|
+
if (androidSafeObjectNamePattern.test(objectName) || isAndroidHiltModuleObjectContext(lines, index)) {
|
|
165
|
+
return;
|
|
166
|
+
}
|
|
167
|
+
if (androidCustomSingletonObjectNamePattern.test(objectName)) {
|
|
168
|
+
matches.push(index + 1);
|
|
169
|
+
}
|
|
170
|
+
});
|
|
171
|
+
|
|
172
|
+
return sortedUniqueLines(matches);
|
|
173
|
+
};
|
|
174
|
+
|
|
175
|
+
export const hasAndroidCustomSingletonObjectUsage = (source: string): boolean =>
|
|
176
|
+
collectAndroidCustomSingletonObjectLines(source).length > 0;
|
|
177
|
+
|
|
133
178
|
const countTokenOccurrences = (line: string, token: string): number => {
|
|
134
179
|
return line.split(token).length - 1;
|
|
135
180
|
};
|
|
@@ -894,6 +894,7 @@ const textDetectorRegistry: ReadonlyArray<TextDetectorRegistryEntry> = [
|
|
|
894
894
|
{ platform: 'android', pathCheck: isAndroidKotlinPath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasKotlinRunBlockingUsage, ruleId: 'heuristics.android.run-blocking.ast', code: 'HEURISTICS_ANDROID_RUN_BLOCKING_AST', message: 'AST heuristic detected runBlocking usage in production Kotlin code.' },
|
|
895
895
|
{ platform: 'android', pathCheck: isAndroidSourcePath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasAndroidAsyncTaskUsage, ruleId: 'heuristics.android.concurrency.asynctask.ast', code: 'HEURISTICS_ANDROID_CONCURRENCY_ASYNCTASK_AST', message: 'AST heuristic detected deprecated AsyncTask usage in Android production code; use coroutines.' },
|
|
896
896
|
{ platform: 'android', pathCheck: isAndroidKotlinPath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasAndroidLegacyFingerprintApiUsage, locateLines: TextAndroid.collectAndroidLegacyFingerprintApiLines, ruleId: 'heuristics.android.security.legacy-fingerprint-api.ast', code: 'HEURISTICS_ANDROID_SECURITY_LEGACY_FINGERPRINT_API_AST', message: 'AST heuristic detected legacy FingerprintManager API usage; use androidx.biometric.BiometricPrompt.' },
|
|
897
|
+
{ platform: 'android', pathCheck: isAndroidKotlinPath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasAndroidCustomSingletonObjectUsage, locateLines: TextAndroid.collectAndroidCustomSingletonObjectLines, primaryNode: (lines) => ({ kind: 'class', name: 'Kotlin object singleton', lines }), relatedNodes: (lines) => [{ kind: 'member', name: 'replacement: Hilt/Dagger dependency injection boundary', lines }], why: 'Kotlin object singletons create global mutable architecture boundaries that bypass the Android DI graph.', impact: 'Global repositories, services or managers make feature slices harder to test, override and isolate in brownfield remediation.', expected_fix: 'Replace custom Kotlin object singletons with constructor-injected classes provided by Hilt/Dagger. Keep object declarations only for constants, routes, UI metadata or DI modules.', ruleId: 'heuristics.android.architecture.custom-singleton-object.ast', code: 'HEURISTICS_ANDROID_ARCHITECTURE_CUSTOM_SINGLETON_OBJECT_AST', message: 'AST heuristic detected a custom Kotlin object singleton in Android production code; use Hilt/Dagger dependency injection.' },
|
|
897
898
|
{ platform: 'android', pathCheck: isAndroidKotlinPath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasKotlinGodActivityUsage, ruleId: 'heuristics.android.architecture.god-activity.ast', code: 'HEURISTICS_ANDROID_ARCHITECTURE_GOD_ACTIVITY_AST', message: 'AST heuristic detected an Android Activity mixing UI entrypoint with product responsibilities; keep Activity thin and move features to composables/ViewModels/use cases.' },
|
|
898
899
|
{ platform: 'android', pathCheck: isAndroidKotlinPath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasKotlinApplicationOnCreateHeavyInitializationUsage, ruleId: 'heuristics.android.startup.application-oncreate-heavy-init.ast', code: 'HEURISTICS_ANDROID_STARTUP_APPLICATION_ONCREATE_HEAVY_INIT_AST', message: 'AST heuristic detected heavy library initialization in Application.onCreate; move lazy startup work to AndroidX Startup Initializer or defer it behind the feature boundary.' },
|
|
899
900
|
{ platform: 'android', pathCheck: isAndroidKotlinPath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasKotlinNonLazyScrollableCollectionUsage, ruleId: 'heuristics.android.compose.non-lazy-scrollable-collection.ast', code: 'HEURISTICS_ANDROID_COMPOSE_NON_LAZY_SCROLLABLE_COLLECTION_AST', message: 'AST heuristic detected a scrollable Column/Row rendering a collection; use LazyColumn/LazyRow for virtualized lists.' },
|
|
@@ -3,7 +3,7 @@ import test from 'node:test';
|
|
|
3
3
|
import { androidRules } from './android';
|
|
4
4
|
|
|
5
5
|
test('androidRules define reglas heurísticas locked para plataforma android', () => {
|
|
6
|
-
assert.equal(androidRules.length,
|
|
6
|
+
assert.equal(androidRules.length, 41);
|
|
7
7
|
|
|
8
8
|
const ids = androidRules.map((rule) => rule.id);
|
|
9
9
|
assert.deepEqual(ids, [
|
|
@@ -14,6 +14,7 @@ test('androidRules define reglas heurísticas locked para plataforma android', (
|
|
|
14
14
|
'heuristics.android.flow.viewmodel-flow-without-statein.ast',
|
|
15
15
|
'heuristics.android.flow.sharedflow-used-as-state.ast',
|
|
16
16
|
'heuristics.android.security.legacy-fingerprint-api.ast',
|
|
17
|
+
'heuristics.android.architecture.custom-singleton-object.ast',
|
|
17
18
|
'heuristics.android.concurrency.asynctask.ast',
|
|
18
19
|
'heuristics.android.architecture.god-activity.ast',
|
|
19
20
|
'heuristics.android.startup.application-oncreate-heavy-init.ast',
|
|
@@ -88,6 +89,10 @@ test('androidRules define reglas heurísticas locked para plataforma android', (
|
|
|
88
89
|
byId.get('heuristics.android.security.legacy-fingerprint-api.ast')?.then.code,
|
|
89
90
|
'HEURISTICS_ANDROID_SECURITY_LEGACY_FINGERPRINT_API_AST'
|
|
90
91
|
);
|
|
92
|
+
assert.equal(
|
|
93
|
+
byId.get('heuristics.android.architecture.custom-singleton-object.ast')?.then.code,
|
|
94
|
+
'HEURISTICS_ANDROID_ARCHITECTURE_CUSTOM_SINGLETON_OBJECT_AST'
|
|
95
|
+
);
|
|
91
96
|
assert.equal(
|
|
92
97
|
byId.get('heuristics.android.concurrency.asynctask.ast')?.then.code,
|
|
93
98
|
'HEURISTICS_ANDROID_CONCURRENCY_ASYNCTASK_AST'
|
|
@@ -135,6 +135,26 @@ export const androidRules: RuleSet = [
|
|
|
135
135
|
code: 'HEURISTICS_ANDROID_SECURITY_LEGACY_FINGERPRINT_API_AST',
|
|
136
136
|
},
|
|
137
137
|
},
|
|
138
|
+
{
|
|
139
|
+
id: 'heuristics.android.architecture.custom-singleton-object.ast',
|
|
140
|
+
description:
|
|
141
|
+
'Detects custom Kotlin object singletons in Android production code where Hilt/Dagger dependency injection is expected.',
|
|
142
|
+
severity: 'WARN',
|
|
143
|
+
platform: 'android',
|
|
144
|
+
locked: true,
|
|
145
|
+
when: {
|
|
146
|
+
kind: 'Heuristic',
|
|
147
|
+
where: {
|
|
148
|
+
ruleId: 'heuristics.android.architecture.custom-singleton-object.ast',
|
|
149
|
+
},
|
|
150
|
+
},
|
|
151
|
+
then: {
|
|
152
|
+
kind: 'Finding',
|
|
153
|
+
message:
|
|
154
|
+
'AST heuristic detected a custom Kotlin object singleton in Android production code; use Hilt/Dagger dependency injection.',
|
|
155
|
+
code: 'HEURISTICS_ANDROID_ARCHITECTURE_CUSTOM_SINGLETON_OBJECT_AST',
|
|
156
|
+
},
|
|
157
|
+
},
|
|
138
158
|
{
|
|
139
159
|
id: 'heuristics.android.concurrency.asynctask.ast',
|
|
140
160
|
description:
|
|
@@ -1435,6 +1435,14 @@ const registryByRuleId: Record<string, SkillsDetectorBinding> = {
|
|
|
1435
1435
|
'android.security.biometric-prompt',
|
|
1436
1436
|
['heuristics.android.security.legacy-fingerprint-api.ast']
|
|
1437
1437
|
),
|
|
1438
|
+
'skills.android.guideline.android.no-singleton-usar-inyeccio-n-de-dependencias-hilt-dagger':
|
|
1439
|
+
heuristicDetector('android.architecture.custom-singleton-object', [
|
|
1440
|
+
'heuristics.android.architecture.custom-singleton-object.ast',
|
|
1441
|
+
]),
|
|
1442
|
+
'skills.android.guideline.android.singletons-everywhere-usar-hilt-di': heuristicDetector(
|
|
1443
|
+
'android.architecture.custom-singleton-object',
|
|
1444
|
+
['heuristics.android.architecture.custom-singleton-object.ast']
|
|
1445
|
+
),
|
|
1438
1446
|
'skills.android.guideline.android.statein-convertir-cold-flow-a-hot-stateflow': heuristicDetector(
|
|
1439
1447
|
'android.flow.viewmodel-flow-without-statein',
|
|
1440
1448
|
['heuristics.android.flow.viewmodel-flow-without-statein.ast']
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "pumuki",
|
|
3
|
-
"version": "6.3.
|
|
3
|
+
"version": "6.3.361",
|
|
4
4
|
"description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
|
|
5
5
|
"main": "index.js",
|
|
6
6
|
"bin": {
|