pumuki 6.3.344 → 6.3.346

package/core/facts/detectors/text/android.test.ts

@@ -12,6 +12,7 @@ import {
   hasKotlinGlobalScopeUsage,
   hasKotlinGodActivityUsage,
   hasKotlinHardcodedBackgroundDispatcherUsage,
+  hasKotlinApplicationOnCreateHeavyInitializationUsage,
   hasKotlinIncompleteMaterialThemeUsage,
   hasKotlinJUnit4Usage,
   hasKotlinHardcodedUiStringUsage,
@@ -185,6 +186,39 @@ class MainActivity : ComponentActivity() {
   assert.equal(hasKotlinGodActivityUsage(source), false);
 });
 
+test('hasKotlinApplicationOnCreateHeavyInitializationUsage detecta inicializacion pesada en Application.onCreate', () => {
+  const source = `
+class RuralGoApplication : Application() {
+  override fun onCreate() {
+    super.onCreate()
+    FirebaseApp.initializeApp(this)
+    WorkManager.initialize(this, configuration)
+    Room.databaseBuilder(this, AppDatabase::class.java, "app.db").build()
+  }
+}
+`;
+  assert.equal(hasKotlinApplicationOnCreateHeavyInitializationUsage(source), true);
+});
+
+test('hasKotlinApplicationOnCreateHeavyInitializationUsage permite Application delgada e Initializer dedicado', () => {
+  const thinApplication = `
+class RuralGoApplication : Application() {
+  override fun onCreate() {
+    super.onCreate()
+  }
+}
+`;
+  const startupInitializer = `
+class AnalyticsInitializer : Initializer<FirebaseApp> {
+  override fun create(context: Context): FirebaseApp {
+    return FirebaseApp.initializeApp(context)!!
+  }
+}
+`;
+  assert.equal(hasKotlinApplicationOnCreateHeavyInitializationUsage(thinApplication), false);
+  assert.equal(hasKotlinApplicationOnCreateHeavyInitializationUsage(startupInitializer), false);
+});
+
 test('hasKotlinNonLazyScrollableCollectionUsage detecta Column scrollable con iteracion de coleccion', () => {
   const source = `
 @Composable

package/core/facts/detectors/text/android.ts

@@ -465,6 +465,39 @@ export const hasKotlinGodActivityUsage = (source: string): boolean => {
   });
 };
 
+export const hasKotlinApplicationOnCreateHeavyInitializationUsage = (source: string): boolean => {
+  const lines = source.split(/\r?\n/);
+  const declarations = parseKotlinTypeDeclarations(source);
+
+  return declarations.some((declaration) => {
+    const isApplication = declaration.conformances.some((conformance) =>
+      conformance === 'Application'
+    );
+    if (!isApplication) {
+      return false;
+    }
+
+    const body = lines
+      .slice(declaration.bodyStartLine - 1, declaration.bodyEndLine)
+      .map((line) => stripKotlinLineForSemanticScan(line))
+      .filter((line) => !line.trimStart().startsWith('import '))
+      .join('\n');
+
+    const onCreateMatch = /\boverride\s+fun\s+onCreate\s*\([^)]*\)\s*\{/g.exec(body);
+    if (!onCreateMatch) {
+      return false;
+    }
+
+    const openBraceIndex = body.indexOf('{', onCreateMatch.index);
+    const onCreateBody = extractBalancedBlockSegment(body, openBraceIndex);
+    if (!onCreateBody) {
+      return false;
+    }
+
+    return /\b(?:FirebaseApp|WorkManager|Room|Retrofit|OkHttpClient|Glide|Coil|Timber)\s*(?:\.|Builder\s*\(|\()/.test(onCreateBody);
+  });
+};
+
 export const hasKotlinNonLazyScrollableCollectionUsage = (source: string): boolean => {
   const sanitizedSource = source
     .split(/\r?\n/)

package/core/facts/detectors/text/ios.test.ts

@@ -1306,6 +1306,10 @@ struct CheckoutView: View {
   @State private var isLoading = false
 
   var body: some View {
+    Button(action: navigateBack) {
+      Image(systemName: "chevron.left")
+    }
+
     Button {
       if isLoading {
         return
@@ -1332,11 +1336,47 @@ struct CheckoutView: View {
 `;
 
   assert.equal(hasSwiftUiInlineActionLogicUsage(source), true);
-  assert.deepEqual(collectSwiftUiInlineActionLogicLines(source), [6]);
+  assert.deepEqual(collectSwiftUiInlineActionLogicLines(source), [10]);
   assert.equal(hasSwiftUiInlineActionLogicUsage(safe), false);
   assert.deepEqual(collectSwiftUiInlineActionLogicLines(safe), []);
 });
 
+test('hasSwiftUiInlineActionLogicUsage preserva varios Button(action: metodo) aunque exista otro Button inline', () => {
+  const source = `
+struct ProductDetailScreen: View {
+  var body: some View {
+    VStack {
+      Button(action: navigateBackFromProductDetail) {
+        Image(systemName: "chevron.left")
+      }
+      Button(action: toggleFavoriteProduct) {
+        Image(systemName: "heart")
+      }
+      Button(action: decrementQuantity) {
+        Text("-")
+      }
+      Button(action: incrementQuantity) {
+        Text("+")
+      }
+      Button(action: addProductToCartAndNavigate) {
+        Text("Add")
+      }
+      Button {
+        if isLoading {
+          return
+        }
+      } label: {
+        Text("Retry")
+      }
+    }
+  }
+}
+`;
+
+  assert.equal(hasSwiftUiInlineActionLogicUsage(source), true);
+  assert.deepEqual(collectSwiftUiInlineActionLogicLines(source), [20]);
+});
+
 test('hasSwiftAnimationWithoutReduceMotionUsage detecta animaciones sin preferencia reduce motion', () => {
   const source = `
 struct CheckoutView: View {

package/core/facts/detectors/text/ios.ts

@@ -854,14 +854,35 @@ export const hasSwiftLargeViewBuilderFunctionUsage = (source: string): boolean =
   return collectSwiftLargeViewBuilderFunctionLines(source).length > 0;
 };
 
-export const hasSwiftUiInlineActionLogicUsage = (source: string): boolean => {
+const swiftInlineActionLogicPattern = /\b(?:if|guard|switch|for|while|Task)\b/;
+
+const swiftSnippetContainsInlineActionLogic = (snippet: string): boolean => {
+  return swiftInlineActionLogicPattern.test(snippet);
+};
+
+export const collectSwiftUiInlineActionLogicLines = (source: string): readonly number[] => {
   const swiftSource = sanitizeSwiftSourceForMultilineRegex(source);
+  const matches: number[] = [];
   const inlineButtonActionPattern =
-    /\bButton\s*\{[\s\S]{0,900}\b(?:if|guard|switch|for|while|Task)\b[\s\S]{0,900}\}\s*label\s*:/;
+    /\bButton\s*\{(?<body>[\s\S]{0,900}?)\}\s*label\s*:/g;
   const inlineActionParameterPattern =
-    /\bButton\s*\([^)]*\baction\s*:\s*\{[\s\S]{0,900}\b(?:if|guard|switch|for|while|Task)\b[\s\S]{0,900}\}/;
+    /\bButton\s*\([^)]*\baction\s*:\s*\{(?<body>[\s\S]{0,900}?)\}/g;
+
+  for (const pattern of [inlineButtonActionPattern, inlineActionParameterPattern]) {
+    for (const match of swiftSource.matchAll(pattern)) {
+      const body = match.groups?.body ?? '';
+      if (!swiftSnippetContainsInlineActionLogic(body)) {
+        continue;
+      }
+      matches.push(getLineNumberAtIndex(swiftSource, match.index ?? 0));
+    }
+  }
 
-  return inlineButtonActionPattern.test(swiftSource) || inlineActionParameterPattern.test(swiftSource);
+  return sortedUniqueLines(matches);
+};
+
+export const hasSwiftUiInlineActionLogicUsage = (source: string): boolean => {
+  return collectSwiftUiInlineActionLogicLines(source).length > 0;
 };
 
 export const collectSwiftAnimationWithoutReduceMotionLines = (source: string): readonly number[] => {
@@ -880,13 +901,6 @@ export const hasSwiftAnimationWithoutReduceMotionUsage = (source: string): boole
   return collectSwiftAnimationWithoutReduceMotionLines(source).length > 0;
 };
 
-export const collectSwiftUiInlineActionLogicLines = (source: string): readonly number[] => {
-  if (!hasSwiftUiInlineActionLogicUsage(source)) {
-    return [];
-  }
-  return collectSwiftRegexLines(source, /\bButton\s*(?:\(|\{)/);
-};
-
 export const hasSwiftDispatchQueueUsage = (source: string): boolean => {
   return scanCodeLikeSource(source, ({ source: swiftSource, index, current }) => {
     if (current !== 'D' || !hasIdentifierAt(swiftSource, index, 'DispatchQueue')) {

package/core/facts/extractHeuristicFacts.ts

@@ -894,6 +894,7 @@ const textDetectorRegistry: ReadonlyArray<TextDetectorRegistryEntry> = [
   { platform: 'android', pathCheck: isAndroidKotlinPath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasKotlinRunBlockingUsage, ruleId: 'heuristics.android.run-blocking.ast', code: 'HEURISTICS_ANDROID_RUN_BLOCKING_AST', message: 'AST heuristic detected runBlocking usage in production Kotlin code.' },
   { platform: 'android', pathCheck: isAndroidSourcePath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasAndroidAsyncTaskUsage, ruleId: 'heuristics.android.concurrency.asynctask.ast', code: 'HEURISTICS_ANDROID_CONCURRENCY_ASYNCTASK_AST', message: 'AST heuristic detected deprecated AsyncTask usage in Android production code; use coroutines.' },
   { platform: 'android', pathCheck: isAndroidKotlinPath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasKotlinGodActivityUsage, ruleId: 'heuristics.android.architecture.god-activity.ast', code: 'HEURISTICS_ANDROID_ARCHITECTURE_GOD_ACTIVITY_AST', message: 'AST heuristic detected an Android Activity mixing UI entrypoint with product responsibilities; keep Activity thin and move features to composables/ViewModels/use cases.' },
+  { platform: 'android', pathCheck: isAndroidKotlinPath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasKotlinApplicationOnCreateHeavyInitializationUsage, ruleId: 'heuristics.android.startup.application-oncreate-heavy-init.ast', code: 'HEURISTICS_ANDROID_STARTUP_APPLICATION_ONCREATE_HEAVY_INIT_AST', message: 'AST heuristic detected heavy library initialization in Application.onCreate; move lazy startup work to AndroidX Startup Initializer or defer it behind the feature boundary.' },
   { platform: 'android', pathCheck: isAndroidKotlinPath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasKotlinNonLazyScrollableCollectionUsage, ruleId: 'heuristics.android.compose.non-lazy-scrollable-collection.ast', code: 'HEURISTICS_ANDROID_COMPOSE_NON_LAZY_SCROLLABLE_COLLECTION_AST', message: 'AST heuristic detected a scrollable Column/Row rendering a collection; use LazyColumn/LazyRow for virtualized lists.' },
   { platform: 'android', pathCheck: isAndroidKotlinPath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasKotlinUnstableLaunchedEffectKeyUsage, ruleId: 'heuristics.android.compose.unstable-launched-effect-key.ast', code: 'HEURISTICS_ANDROID_COMPOSE_UNSTABLE_LAUNCHED_EFFECT_KEY_AST', message: 'AST heuristic detected LaunchedEffect without a stable state key; use a meaningful key that controls when the effect restarts.' },
   { platform: 'android', pathCheck: isAndroidKotlinPath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasKotlinLaunchedEffectBusyLoopUsage, ruleId: 'heuristics.android.compose.launched-effect-busy-loop.ast', code: 'HEURISTICS_ANDROID_COMPOSE_LAUNCHED_EFFECT_BUSY_LOOP_AST', message: 'AST heuristic detected non-cooperative loop inside LaunchedEffect; add suspension/cancellation cooperation or move work to lifecycle-aware flow.' },

package/core/rules/presets/heuristics/android.test.ts

@@ -3,7 +3,7 @@ import test from 'node:test';
 import { androidRules } from './android';
 
 test('androidRules define reglas heurísticas locked para plataforma android', () => {
-  assert.equal(androidRules.length, 38);
+  assert.equal(androidRules.length, 39);
 
   const ids = androidRules.map((rule) => rule.id);
   assert.deepEqual(ids, [
@@ -15,6 +15,7 @@ test('androidRules define reglas heurísticas locked para plataforma android', (
     'heuristics.android.flow.sharedflow-used-as-state.ast',
     'heuristics.android.concurrency.asynctask.ast',
     'heuristics.android.architecture.god-activity.ast',
+    'heuristics.android.startup.application-oncreate-heavy-init.ast',
     'heuristics.android.compose.non-lazy-scrollable-collection.ast',
     'heuristics.android.compose.unstable-launched-effect-key.ast',
     'heuristics.android.compose.launched-effect-busy-loop.ast',
@@ -90,6 +91,10 @@ test('androidRules define reglas heurísticas locked para plataforma android', (
     byId.get('heuristics.android.architecture.god-activity.ast')?.then.code,
     'HEURISTICS_ANDROID_ARCHITECTURE_GOD_ACTIVITY_AST'
   );
+  assert.equal(
+    byId.get('heuristics.android.startup.application-oncreate-heavy-init.ast')?.then.code,
+    'HEURISTICS_ANDROID_STARTUP_APPLICATION_ONCREATE_HEAVY_INIT_AST'
+  );
   assert.equal(
     byId.get('heuristics.android.compose.non-lazy-scrollable-collection.ast')?.then.code,
     'HEURISTICS_ANDROID_COMPOSE_NON_LAZY_SCROLLABLE_COLLECTION_AST'

package/core/rules/presets/heuristics/android.ts

@@ -155,6 +155,26 @@ export const androidRules: RuleSet = [
       code: 'HEURISTICS_ANDROID_ARCHITECTURE_GOD_ACTIVITY_AST',
     },
   },
+  {
+    id: 'heuristics.android.startup.application-oncreate-heavy-init.ast',
+    description:
+      'Detects heavy library initialization inside Android Application.onCreate where AndroidX Startup Initializer or lazy feature initialization should be used.',
+    severity: 'WARN',
+    platform: 'android',
+    locked: true,
+    when: {
+      kind: 'Heuristic',
+      where: {
+        ruleId: 'heuristics.android.startup.application-oncreate-heavy-init.ast',
+      },
+    },
+    then: {
+      kind: 'Finding',
+      message:
+        'AST heuristic detected heavy initialization inside Application.onCreate.',
+      code: 'HEURISTICS_ANDROID_STARTUP_APPLICATION_ONCREATE_HEAVY_INIT_AST',
+    },
+  },
   {
     id: 'heuristics.android.compose.non-lazy-scrollable-collection.ast',
     description:

package/integrations/config/skillsDetectorRegistry.ts

@@ -1304,6 +1304,10 @@ const registryByRuleId: Record<string, SkillsDetectorBinding> = {
     'android.architecture.god-activity',
     ['heuristics.android.architecture.god-activity.ast']
   ),
+  'skills.android.guideline.android.app-startup-androidx-startup-para-lazy-init': heuristicDetector(
+    'android.startup.application-oncreate-heavy-init',
+    ['heuristics.android.startup.application-oncreate-heavy-init.ast']
+  ),
   'skills.android.guideline.android.lazycolumn-lazyrow-virtualizacio-n-de-listas': heuristicDetector(
     'android.compose.lazy-collection',
     ['heuristics.android.compose.non-lazy-scrollable-collection.ast']

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pumuki",
-  "version": "6.3.344",
+  "version": "6.3.346",
   "description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
   "main": "index.js",
   "bin": {