pumuki 6.3.340 → 6.3.342

package/core/facts/detectors/text/ios.test.ts

@@ -1129,6 +1129,53 @@ struct FeedView: View {
   assert.equal(hasSwiftUiForEachConditionalViewCountUsage(safe), false);
 });
 
+test('hasSwiftUiForEachConditionalViewCountUsage preserva filas ForEach extraidas con branching interno', () => {
+  const source = `
+struct OnboardingCarouselView: View {
+  let pages: [OnboardingPage]
+  let indicators: [OnboardingIndicator]
+
+  var body: some View {
+    LazyVStack {
+      ForEach(pages) { page in
+        OnboardingPageView(page: page)
+      }
+      LazyHStack {
+        ForEach(indicators) { indicator in
+          OnboardingPageIndicatorView(indicator: indicator)
+        }
+      }
+    }
+  }
+}
+
+private struct OnboardingPageView: View {
+  let page: OnboardingPage
+
+  var body: some View {
+    switch page.kind {
+    case .hero:
+      OnboardingHeroStepView(page: page)
+    case .feature:
+      OnboardingFeatureStepView(page: page)
+    }
+  }
+}
+
+private struct OnboardingPageIndicatorView: View {
+  let indicator: OnboardingIndicator
+
+  var body: some View {
+    Capsule()
+      .fill(indicator.isSelected ? Color.primary : Color.secondary)
+  }
+}
+`;
+
+  assert.equal(hasSwiftUiForEachConditionalViewCountUsage(source), false);
+  assert.deepEqual(collectSwiftUiForEachConditionalViewCountLines(source), []);
+});
+
 test('hasSwiftViewBodyObjectCreationUsage detecta formatter creado en body y preserva dependencia externa', () => {
   const source = `
 struct PriceView: View {
@@ -2781,7 +2828,7 @@ struct StoresView: View {
   assert.deepEqual(collectSwiftNonLazyScrollForEachLines(source), [4, 6, 11]);
   assert.deepEqual(collectSwiftForEachIndicesLines(source), [6]);
   assert.deepEqual(collectSwiftForEachSelfIdentityLines(source), [6]);
-  assert.deepEqual(collectSwiftUiForEachConditionalViewCountLines(source), [6, 7, 11, 14, 20]);
+  assert.deepEqual(collectSwiftUiForEachConditionalViewCountLines(source), [6, 7]);
   assert.deepEqual(collectSwiftInlineForEachTransformLines(source), [11]);
   assert.deepEqual(collectSwiftUiConditionalSameViewIdentityLines(source), [7, 14, 20]);
   assert.deepEqual(collectSwiftUiInlineActionLogicLines(source), [19]);

package/core/facts/detectors/text/ios.ts

@@ -660,24 +660,99 @@ export const collectSwiftNonLazyScrollForEachLines = (source: string): readonly
   ]);
 };
 
-export const hasSwiftUiForEachConditionalViewCountUsage = (source: string): boolean => {
-  const swiftSource = sanitizeSwiftSourceForMultilineRegex(source);
-  const conditionalForEachPattern =
-    /\bForEach\s*\([^)]*\)\s*\{[\s\S]{0,1600}\b(?:if|switch)\b[\s\S]{0,1600}\}/;
+const findMatchingSwiftParen = (source: string, openParenIndex: number): number => {
+  let depth = 0;
+  for (let index = openParenIndex; index < source.length; index += 1) {
+    const current = source[index];
+    if (current === '(') {
+      depth += 1;
+    } else if (current === ')') {
+      depth -= 1;
+      if (depth === 0) {
+        return index;
+      }
+    }
+  }
+  return -1;
+};
 
-  return conditionalForEachPattern.test(swiftSource);
+const getLineNumberAtIndex = (source: string, targetIndex: number): number => {
+  let lineNumber = 1;
+  for (let index = 0; index < targetIndex && index < source.length; index += 1) {
+    if (source[index] === '\n') {
+      lineNumber += 1;
+    }
+  }
+  return lineNumber;
+};
+
+const collectSwiftUiForEachDirectConditionalLines = (source: string): readonly number[] => {
+  const sanitized = sanitizeSwiftSourceForMultilineRegex(source);
+  const lines: number[] = [];
+  const forEachPattern = /\bForEach\s*\(/g;
+
+  for (const match of sanitized.matchAll(forEachPattern)) {
+    const matchIndex = match.index ?? 0;
+    const openParenIndex = sanitized.indexOf('(', matchIndex);
+    if (openParenIndex < 0) {
+      continue;
+    }
+
+    const closeParenIndex = findMatchingSwiftParen(sanitized, openParenIndex);
+    if (closeParenIndex < 0) {
+      continue;
+    }
+
+    const openBraceIndex = sanitized.indexOf('{', closeParenIndex);
+    if (openBraceIndex < 0) {
+      continue;
+    }
+
+    const closeBraceIndex = findMatchingSwiftBrace(sanitized, openBraceIndex);
+    if (closeBraceIndex < 0) {
+      continue;
+    }
+
+    const body = sanitized.slice(openBraceIndex + 1, closeBraceIndex);
+    let depth = 0;
+    let hasDirectConditional = false;
+    const conditionalPattern = /\b(?:if|switch)\b/g;
+
+    for (const conditionalMatch of body.matchAll(conditionalPattern)) {
+      const conditionalIndex = conditionalMatch.index ?? 0;
+      for (let index = 0; index < conditionalIndex; index += 1) {
+        const current = body[index];
+        if (current === '{') {
+          depth += 1;
+        } else if (current === '}') {
+          depth = Math.max(0, depth - 1);
+        }
+      }
+      if (depth === 0) {
+        lines.push(getLineNumberAtIndex(sanitized, matchIndex));
+        lines.push(getLineNumberAtIndex(sanitized, openBraceIndex + 1 + conditionalIndex));
+        hasDirectConditional = true;
+        break;
+      }
+      depth = 0;
+    }
+
+    if (!hasDirectConditional) {
+      continue;
+    }
+  }
+
+  return sortedUniqueLines(lines);
+};
+
+export const hasSwiftUiForEachConditionalViewCountUsage = (source: string): boolean => {
+  return collectSwiftUiForEachDirectConditionalLines(source).length > 0;
 };
 
 export const collectSwiftUiForEachConditionalViewCountLines = (
   source: string
 ): readonly number[] => {
-  if (!hasSwiftUiForEachConditionalViewCountUsage(source)) {
-    return [];
-  }
-  return sortedUniqueLines([
-    ...collectSwiftRegexLines(source, /\bForEach\s*\(/),
-    ...collectSwiftRegexLines(source, /\b(?:if|switch)\b/),
-  ]);
+  return collectSwiftUiForEachDirectConditionalLines(source);
 };
 
 export const hasSwiftViewBodyObjectCreationUsage = (source: string): boolean => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pumuki",
-  "version": "6.3.340",
+  "version": "6.3.342",
   "description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
   "main": "index.js",
   "bin": {

package/scripts/framework-menu-system-notifications-macos-dialog-payload.ts

@@ -73,6 +73,9 @@ const stripTechnicalFieldsFromMessage = (message: string): string => {
 const localizeDeveloperText = (value: string): string => {
   const normalized = normalizeNotificationText(value);
   const knownTexts: ReadonlyArray<[RegExp, string]> = [
+    [/Dynamic Type - Font scaling autom[aá]tico/iu, 'Dynamic Type: tamaño de fuente fijo sin escala dinámica.'],
+    [/Dynamic Type - fuentes escalables y layouts adaptativos/iu, 'Dynamic Type: fuente fija o layout no preparado para tamaños de texto del sistema.'],
+    [/Use semantic SwiftUI text styles such as \.headline\/\.body, Font\.TextStyle, or UIFontMetrics\/scaled metrics when a custom size is required\./iu, 'Usa estilos semánticos de SwiftUI como .headline o .body. Si necesitas un tamaño custom, escálalo con Font.TextStyle o UIFontMetrics.'],
     [/Disallow empty catch blocks in backend runtime code\./iu, 'Catch vacío en código backend runtime.'],
     [/Action handlers should reference methods, not contain inline logic/iu, 'El handler contiene lógica inline; debe llamar a un método o comando del view model.'],
     [/Ensure constant number of views per ForEach element/iu, 'Cada elemento de ForEach debe devolver una estructura de vistas estable.'],

package/scripts/framework-menu-system-notifications-payloads-blocked.ts

@@ -134,6 +134,7 @@ const humanizeRuleId = (ruleId: string): string => {
     'no-wait-for-expectations': 'waitForExpectations en XCTest',
     'ios-test-quality': 'calidad de tests iOS',
     'dynamic-type-font-scaling-automatico': 'Dynamic Type',
+    'dynamic-type-font-scaling-automa-tico': 'Dynamic Type',
     'dynamic-type-fuentes-escalables-y-layouts-adaptativos': 'fuentes escalables y layouts adaptativos',
     'use-relative-layout-over-hard-coded-constants': 'layout relativo en vez de constantes fijas',
     'magic-numbers-usar-constantes-con-nombres': 'números mágicos sin constantes con nombre',
@@ -146,10 +147,15 @@ const humanizeRuleId = (ruleId: string): string => {
     .replace(/_/gu, '-');
   const parts = normalized.split('.').filter(Boolean);
   const leaf = parts.at(-1) ?? normalized;
-  if (knownRules[leaf]) {
-    return knownRules[leaf];
+  const compactLeaf = leaf.replace(/-+/gu, '-');
+  const accentlessLeaf = compactLeaf.normalize('NFD').replace(/[\u0300-\u036f]/gu, '');
+  if (knownRules[compactLeaf]) {
+    return knownRules[compactLeaf];
   }
-  return leaf
+  if (knownRules[accentlessLeaf]) {
+    return knownRules[accentlessLeaf];
+  }
+  return compactLeaf
     .replace(/-/gu, ' ')
     .replace(/\bios\b/giu, 'iOS')
     .replace(/\bui\b/giu, 'UI')
@@ -160,6 +166,21 @@ const humanizeRuleId = (ruleId: string): string => {
     .trim();
 };
 
+const localizeDeveloperText = (value: string): string => {
+  const normalized = normalizeNotificationText(value);
+  const knownTexts: ReadonlyArray<[RegExp, string]> = [
+    [/Dynamic Type - Font scaling autom[aá]tico/iu, 'Dynamic Type: tamaño de fuente fijo sin escala dinámica.'],
+    [/Dynamic Type - fuentes escalables y layouts adaptativos/iu, 'Dynamic Type: fuente fija o layout no preparado para tamaños de texto del sistema.'],
+    [/Use semantic SwiftUI text styles such as \.headline\/\.body, Font\.TextStyle, or UIFontMetrics\/scaled metrics when a custom size is required\./iu, 'Usa estilos semánticos de SwiftUI como .headline o .body. Si necesitas un tamaño custom, escálalo con Font.TextStyle o UIFontMetrics.'],
+  ];
+  for (const [pattern, replacement] of knownTexts) {
+    if (pattern.test(normalized)) {
+      return replacement;
+    }
+  }
+  return normalized;
+};
+
 const formatVisibleRule = (cause: BlockedCause): string => {
   const ruleId = formatCauseRule(cause);
   const readable = humanizeRuleId(ruleId);
@@ -188,13 +209,13 @@ const stripTechnicalFieldsFromMessage = (message: string): string =>
 const formatCauseProblem = (cause: BlockedCause): string => {
   const messageField = extractMessageField(cause.message, 'message');
   if (messageField) {
-    return messageField;
+    return localizeDeveloperText(messageField);
   }
-  return stripTechnicalFieldsFromMessage(cause.message) || cause.code;
+  return localizeDeveloperText(stripTechnicalFieldsFromMessage(cause.message) || cause.code);
 };
 
 const formatCauseFix = (cause: BlockedCause): string =>
-  normalizeNotificationText(
+  localizeDeveloperText(
     cause.remediation ??
     'Corrige la violación indicada con regla, fichero y línea, y vuelve a intentar el commit.'
   );