pumuki 6.3.331 → 6.3.333
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/integrations/evidence/blockingCauses.ts +21 -2
- package/integrations/gate/evaluateAiGate.ts +24 -6
- package/integrations/git/runPlatformGate.ts +1 -1
- package/integrations/tdd/enforcement.ts +15 -4
- package/package.json +1 -1
- package/scripts/framework-menu-system-notifications-macos-dialog-payload.ts +5 -1
- package/scripts/framework-menu-system-notifications-payloads-blocked.ts +1 -0
|
@@ -14,6 +14,13 @@ export type EvidenceBlockingCause = {
|
|
|
14
14
|
const isBlockingSeverity = (severity: string): boolean =>
|
|
15
15
|
severity.toUpperCase() === 'CRITICAL' || severity.toUpperCase() === 'ERROR';
|
|
16
16
|
|
|
17
|
+
const isNonBlockingSwiftTestingMigrationWarning = (params: {
|
|
18
|
+
ruleId?: string;
|
|
19
|
+
severity: string;
|
|
20
|
+
}): boolean =>
|
|
21
|
+
params.ruleId === 'skills.ios.prefer-swift-testing'
|
|
22
|
+
&& params.severity.toUpperCase() === 'WARN';
|
|
23
|
+
|
|
17
24
|
const toFindingBlockingCause = (finding: SnapshotFinding): EvidenceBlockingCause => ({
|
|
18
25
|
ruleId: finding.ruleId,
|
|
19
26
|
code: finding.code,
|
|
@@ -56,7 +63,14 @@ export const extractEvidenceBlockingCauses = (
|
|
|
56
63
|
|
|
57
64
|
for (const finding of evidence.snapshot.findings) {
|
|
58
65
|
const explicitlyBlocking = finding.blocking === true;
|
|
59
|
-
if (
|
|
66
|
+
if (
|
|
67
|
+
finding.blocking === false
|
|
68
|
+
|| isNonBlockingSwiftTestingMigrationWarning({
|
|
69
|
+
ruleId: finding.ruleId,
|
|
70
|
+
severity: finding.severity,
|
|
71
|
+
})
|
|
72
|
+
|| (!explicitlyBlocking && !isBlockingSeverity(finding.severity))
|
|
73
|
+
) {
|
|
60
74
|
continue;
|
|
61
75
|
}
|
|
62
76
|
const cause = toFindingBlockingCause(finding);
|
|
@@ -69,9 +83,14 @@ export const extractEvidenceBlockingCauses = (
|
|
|
69
83
|
|
|
70
84
|
for (const violation of evidence.ai_gate.violations) {
|
|
71
85
|
const explicitlyBlocking = violation.blocking === true;
|
|
86
|
+
const severity = resolveViolationSeverity(violation);
|
|
72
87
|
if (
|
|
73
88
|
violation.blocking === false ||
|
|
74
|
-
(
|
|
89
|
+
isNonBlockingSwiftTestingMigrationWarning({
|
|
90
|
+
ruleId: violation.ruleId,
|
|
91
|
+
severity,
|
|
92
|
+
}) ||
|
|
93
|
+
(!explicitlyBlocking && !isBlockingSeverity(severity))
|
|
75
94
|
) {
|
|
76
95
|
continue;
|
|
77
96
|
}
|
|
@@ -486,6 +486,28 @@ const resolvePreWriteCriticalSkillsRules = (params: {
|
|
|
486
486
|
return ruleIds;
|
|
487
487
|
};
|
|
488
488
|
|
|
489
|
+
const hasRuleCoverage = (
|
|
490
|
+
coverage: NonNullable<Extract<EvidenceReadResult, { kind: 'valid' }>['evidence']['snapshot']['rules_coverage']>,
|
|
491
|
+
ruleId: string
|
|
492
|
+
): boolean =>
|
|
493
|
+
coverage.active_rule_ids.includes(ruleId) && coverage.evaluated_rule_ids.includes(ruleId);
|
|
494
|
+
|
|
495
|
+
const hasEquivalentCriticalRuleCoverage = (
|
|
496
|
+
coverage: NonNullable<Extract<EvidenceReadResult, { kind: 'valid' }>['evidence']['snapshot']['rules_coverage']>,
|
|
497
|
+
ruleId: string
|
|
498
|
+
): boolean => {
|
|
499
|
+
if (ruleId !== 'skills.ios.critical-test-quality') {
|
|
500
|
+
return false;
|
|
501
|
+
}
|
|
502
|
+
return hasRuleCoverage(coverage, 'skills.ios.prefer-swift-testing');
|
|
503
|
+
};
|
|
504
|
+
|
|
505
|
+
const hasRequiredCriticalRuleCoverage = (
|
|
506
|
+
coverage: NonNullable<Extract<EvidenceReadResult, { kind: 'valid' }>['evidence']['snapshot']['rules_coverage']>,
|
|
507
|
+
ruleId: string
|
|
508
|
+
): boolean =>
|
|
509
|
+
hasRuleCoverage(coverage, ruleId) || hasEquivalentCriticalRuleCoverage(coverage, ruleId);
|
|
510
|
+
|
|
489
511
|
const isPlatformPath = (platform: PreWriteSkillsPlatform, filePath: string): boolean => {
|
|
490
512
|
const normalized = normalizeChangedPath(filePath).toLowerCase();
|
|
491
513
|
if (platform === 'ios') {
|
|
@@ -757,9 +779,7 @@ const collectPreWritePlatformSkillsViolations = (params: {
|
|
|
757
779
|
continue;
|
|
758
780
|
}
|
|
759
781
|
const missingCriticalRuleIds = requiredCriticalRuleIds.filter((ruleId) => {
|
|
760
|
-
|
|
761
|
-
const hasEvaluated = params.coverage.evaluated_rule_ids.includes(ruleId);
|
|
762
|
-
return !hasActive || !hasEvaluated;
|
|
782
|
+
return !hasRequiredCriticalRuleCoverage(params.coverage, ruleId);
|
|
763
783
|
});
|
|
764
784
|
if (missingCriticalRuleIds.length === 0) {
|
|
765
785
|
continue;
|
|
@@ -1051,9 +1071,7 @@ const toSkillsContractAssessment = (params: {
|
|
|
1051
1071
|
);
|
|
1052
1072
|
const missingCriticalRuleIds = coverage
|
|
1053
1073
|
? requiredCriticalRuleIds.filter((ruleId) => {
|
|
1054
|
-
|
|
1055
|
-
const hasEvaluated = coverage.evaluated_rule_ids.includes(ruleId);
|
|
1056
|
-
return !hasActive || !hasEvaluated;
|
|
1074
|
+
return !hasRequiredCriticalRuleCoverage(coverage, ruleId);
|
|
1057
1075
|
})
|
|
1058
1076
|
: [...requiredCriticalRuleIds];
|
|
1059
1077
|
const transversalCriticalCovered =
|
|
@@ -641,7 +641,7 @@ const hasTrackForMemoryLeaksPattern = (content: string): boolean =>
|
|
|
641
641
|
const IOS_CRITICAL_TEST_QUALITY_RULE_ID = 'skills.ios.critical-test-quality';
|
|
642
642
|
|
|
643
643
|
const hasIosTestQualityScope = (facts: ReadonlyArray<Fact>): boolean =>
|
|
644
|
-
collectIosTestFileContents(facts).
|
|
644
|
+
collectIosTestFileContents(facts).length > 0;
|
|
645
645
|
|
|
646
646
|
const appendUniqueRuleId = (
|
|
647
647
|
ruleIds: ReadonlyArray<string>,
|
|
@@ -3,6 +3,7 @@ import { isAbsolute, resolve } from 'node:path';
|
|
|
3
3
|
import type { Fact } from '../../core/facts/Fact';
|
|
4
4
|
import type { Finding } from '../../core/gate/Finding';
|
|
5
5
|
import { readTddBddEvidence } from './contract';
|
|
6
|
+
import type { TddSlice } from './contract';
|
|
6
7
|
import { classifyTddBddScope } from './scope';
|
|
7
8
|
import type { TddBddSnapshot } from './types';
|
|
8
9
|
import { resolveActiveTddBddWaiver } from './waiver';
|
|
@@ -78,6 +79,14 @@ const isTimelineOrdered = (timestamps: ReadonlyArray<string | undefined>): boole
|
|
|
78
79
|
return true;
|
|
79
80
|
};
|
|
80
81
|
|
|
82
|
+
const selectEnforcedEvidenceSlices = (slices: ReadonlyArray<TddSlice>): ReadonlyArray<TddSlice> => {
|
|
83
|
+
if (slices.length <= 1) {
|
|
84
|
+
return slices;
|
|
85
|
+
}
|
|
86
|
+
const latestSlice = slices[slices.length - 1];
|
|
87
|
+
return latestSlice ? [latestSlice] : [];
|
|
88
|
+
};
|
|
89
|
+
|
|
81
90
|
export const enforceTddBddPolicy = (params: {
|
|
82
91
|
facts: ReadonlyArray<Fact>;
|
|
83
92
|
repoRoot: string;
|
|
@@ -222,7 +231,9 @@ export const enforceTddBddPolicy = (params: {
|
|
|
222
231
|
verify: 'missing',
|
|
223
232
|
};
|
|
224
233
|
|
|
225
|
-
|
|
234
|
+
const enforcedSlices = selectEnforcedEvidenceSlices(evidenceRead.evidence.slices);
|
|
235
|
+
|
|
236
|
+
if (enforcedSlices.length === 0) {
|
|
226
237
|
sliceFindings.push(
|
|
227
238
|
buildFinding({
|
|
228
239
|
ruleId: 'generic_tdd_vertical_required',
|
|
@@ -233,7 +244,7 @@ export const enforceTddBddPolicy = (params: {
|
|
|
233
244
|
);
|
|
234
245
|
}
|
|
235
246
|
|
|
236
|
-
for (const slice of
|
|
247
|
+
for (const slice of enforcedSlices) {
|
|
237
248
|
const sliceErrorsBefore = sliceFindings.length;
|
|
238
249
|
|
|
239
250
|
if (seenSliceIds.has(slice.id)) {
|
|
@@ -355,7 +366,7 @@ export const enforceTddBddPolicy = (params: {
|
|
|
355
366
|
}
|
|
356
367
|
}
|
|
357
368
|
|
|
358
|
-
const invalidSlices = Math.max(0,
|
|
369
|
+
const invalidSlices = Math.max(0, enforcedSlices.length - validSlices);
|
|
359
370
|
const hasBlockingFindings = sliceFindings.some(
|
|
360
371
|
(finding) => finding.severity === 'ERROR' || finding.severity === 'CRITICAL'
|
|
361
372
|
);
|
|
@@ -369,7 +380,7 @@ export const enforceTddBddPolicy = (params: {
|
|
|
369
380
|
...baseSnapshot.evidence,
|
|
370
381
|
state: 'valid',
|
|
371
382
|
version: evidenceRead.evidence.version,
|
|
372
|
-
slices_total:
|
|
383
|
+
slices_total: enforcedSlices.length,
|
|
373
384
|
slices_valid: validSlices,
|
|
374
385
|
slices_invalid: invalidSlices,
|
|
375
386
|
integrity_ok: evidenceRead.integrity.valid,
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "pumuki",
|
|
3
|
-
"version": "6.3.
|
|
3
|
+
"version": "6.3.333",
|
|
4
4
|
"description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
|
|
5
5
|
"main": "index.js",
|
|
6
6
|
"bin": {
|
|
@@ -248,6 +248,7 @@ const formatPlatformName = (platform: string | null): string =>
|
|
|
248
248
|
const extractSkillsContractPlatform = (message: string): string | null =>
|
|
249
249
|
message.match(/\bplatforms?=([a-z0-9_,.-]+)/i)?.[1]?.split(',')[0]?.trim()
|
|
250
250
|
?? message.match(/\b(ios|android|frontend|backend)\(missing_critical_rule_ids=/i)?.[1]?.trim()
|
|
251
|
+
?? message.match(/\bskills\.(ios|android|frontend|backend)\./i)?.[1]?.trim()
|
|
251
252
|
?? message.match(/\bfor\s+(ios|android|frontend|backend)\s*:/i)?.[1]?.trim()
|
|
252
253
|
?? null;
|
|
253
254
|
|
|
@@ -261,6 +262,9 @@ const extractSkillsContractRules = (message: string): string | null => {
|
|
|
261
262
|
const SKILLS_CONTRACT_REMEDIATION =
|
|
262
263
|
'Actualiza o reconcilia el contrato de skills de Pumuki y vuelve a intentar el commit. Si ya estás en la última versión, es un bug del motor de Pumuki y debe corregirse allí antes de cerrar el commit.';
|
|
263
264
|
|
|
265
|
+
const SKILLS_CONTRACT_DIALOG_REMEDIATION =
|
|
266
|
+
'Corrige el contrato de skills indicado arriba y vuelve a intentar el commit.';
|
|
267
|
+
|
|
264
268
|
const WORKTREE_HYGIENE_REMEDIATION =
|
|
265
269
|
'Reduce el worktree pendiente a un slice atómico: stagea solo la tarea activa o guarda el resto en stash nombrado, y reejecuta PRE_WRITE.';
|
|
266
270
|
|
|
@@ -409,7 +413,7 @@ export const buildBlockedDialogPayload = (params: {
|
|
|
409
413
|
: hasOnlyBddScenarioMissingCauses(params.event.blockingCauses)
|
|
410
414
|
? 'Crea el fichero .feature esperado para la slice activa o corrige la referencia de tarea. Después vuelve a intentar el commit.'
|
|
411
415
|
: hasOnlySkillsContractCauses(params.event.blockingCauses)
|
|
412
|
-
?
|
|
416
|
+
? SKILLS_CONTRACT_DIALOG_REMEDIATION
|
|
413
417
|
: params.event.blockingCauses && params.event.blockingCauses.length > 0
|
|
414
418
|
? 'Corrige las violaciones listadas y vuelve a intentar el commit.'
|
|
415
419
|
: resolveBlockedRemediation(params.event, causeCode);
|
|
@@ -67,6 +67,7 @@ const formatPlatformName = (platform: string | null): string =>
|
|
|
67
67
|
const extractSkillsContractPlatform = (message: string): string | null =>
|
|
68
68
|
message.match(/\bplatforms?=([a-z0-9_,.-]+)/i)?.[1]?.split(',')[0]?.trim()
|
|
69
69
|
?? message.match(/\b(ios|android|frontend|backend)\(missing_critical_rule_ids=/i)?.[1]?.trim()
|
|
70
|
+
?? message.match(/\bskills\.(ios|android|frontend|backend)\./i)?.[1]?.trim()
|
|
70
71
|
?? message.match(/\bfor\s+(ios|android|frontend|backend)\s*:/i)?.[1]?.trim()
|
|
71
72
|
?? null;
|
|
72
73
|
|