pumuki 6.3.313 → 6.3.315

package/integrations/notifications/emitAuditSummaryNotification.ts

@@ -1,5 +1,9 @@
 import type { AiEvidenceV2_1 } from '../evidence/schema';
 import { readEvidence } from '../evidence/readEvidence';
+import {
+  extractEvidenceBlockingCauses,
+  formatEvidenceBlockingCause,
+} from '../evidence/blockingCauses';
 import type { AiGateCheckResult } from '../gate/evaluateAiGate';
 import { appendTrackingActionableContext } from '../git/aiGateRepoPolicyFindings';
 import {
@@ -51,6 +55,13 @@ const withTrackingContext = (params: {
   });
 };
 
+const normalizeNotificationStage = (stage: string): PumukiNotificationStage => {
+  if (stage === 'PRE_WRITE' || stage === 'PRE_COMMIT' || stage === 'PRE_PUSH' || stage === 'CI') {
+    return stage;
+  }
+  return 'PRE_COMMIT';
+};
+
 export const shouldEmitAuditSummaryNotificationForStage = (
   stage: AuditSummaryNotificationStage,
   env: NodeJS.ProcessEnv = process.env
@@ -66,6 +77,25 @@ export const toAuditSummaryEventFromEvidence = (
 ): PumukiCriticalNotificationEvent => {
   const enterpriseSeverity = evidence.severity_metrics.by_enterprise_severity;
   const severity = evidence.severity_metrics.by_severity;
+  const blockingCauses = extractEvidenceBlockingCauses(evidence);
+  if (blockingCauses.length > 0) {
+    const primaryCause = blockingCauses[0]!;
+    return {
+      kind: 'gate.blocked',
+      stage: normalizeNotificationStage(evidence.snapshot.stage),
+      totalViolations: evidence.severity_metrics.total_violations,
+      causeCode: primaryCause.code,
+      causeMessage: formatEvidenceBlockingCause(primaryCause),
+      remediation: primaryCause.remediation ?? 'Corrige la violación indicada y vuelve a intentar el commit.',
+      blockingCauses: blockingCauses.map((cause) => ({
+        code: cause.code,
+        ruleId: cause.ruleId,
+        file: cause.file,
+        message: formatEvidenceBlockingCause(cause),
+        remediation: cause.remediation,
+      })),
+    };
+  }
   return {
     kind: 'audit.summary',
     totalViolations: evidence.severity_metrics.total_violations,
@@ -76,6 +106,7 @@ export const toAuditSummaryEventFromEvidence = (
 
 export const toAuditSummaryEventFromAiGate = (params: {
   aiGateResult: Pick<AiGateCheckResult, 'violations'>;
+  stage?: PumukiNotificationStage;
 }): PumukiCriticalNotificationEvent => {
   const criticalViolations = params.aiGateResult.violations.reduce(
     (total, violation) => (violation.severity === 'ERROR' ? total + 1 : total),
@@ -85,6 +116,23 @@ export const toAuditSummaryEventFromAiGate = (params: {
     (total, violation) => (violation.severity === 'WARN' ? total + 1 : total),
     0
   );
+  if (params.aiGateResult.violations.length > 0) {
+    const primaryViolation = params.aiGateResult.violations[0]!;
+    return {
+      kind: 'gate.blocked',
+      stage: params.stage ?? 'PRE_WRITE',
+      totalViolations: params.aiGateResult.violations.length,
+      causeCode: primaryViolation.code,
+      causeMessage: primaryViolation.message,
+      remediation: 'Corrige la violación indicada y vuelve a intentar el commit.',
+      blockingCauses: params.aiGateResult.violations.map((violation) => ({
+        code: violation.code,
+        ruleId: violation.code,
+        message: violation.message,
+        remediation: 'Corrige la violación indicada y vuelve a intentar el commit.',
+      })),
+    };
+  }
   return {
     kind: 'audit.summary',
     totalViolations: params.aiGateResult.violations.length,
@@ -144,6 +192,7 @@ export const emitAuditSummaryNotificationFromAiGate = (
   }
   const event = toAuditSummaryEventFromAiGate({
     aiGateResult: params.aiGateResult,
+    stage: params.stage,
   });
   return activeDependencies.emitSystemNotification({
     event,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pumuki",
-  "version": "6.3.313",
+  "version": "6.3.315",
   "description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
   "main": "index.js",
   "bin": {

package/scripts/framework-menu-system-notifications-macos-dialog-payload.ts

@@ -60,6 +60,32 @@ const stripTechnicalFieldsFromMessage = (message: string): string => {
     .trim();
 };
 
+const localizeDeveloperText = (value: string): string => {
+  const normalized = normalizeNotificationText(value);
+  const knownTexts: ReadonlyArray<[RegExp, string]> = [
+    [/Disallow empty catch blocks in backend runtime code\./iu, 'Catch vacío en código backend runtime.'],
+    [/Action handlers should reference methods, not contain inline logic/iu, 'El handler contiene lógica inline; debe llamar a un método o comando del view model.'],
+    [/Ensure constant number of views per ForEach element/iu, 'Cada elemento de ForEach debe devolver una estructura de vistas estable.'],
+    [/Ensure ForEach uses stable identity/iu, 'ForEach debe usar una identidad estable.'],
+    [/Prefer modifiers over conditional views for state changes/iu, 'Para cambios de estado, usa modificadores en vez de cambiar la identidad de la vista.'],
+    [/Prefer static member lookup \(\.blue vs Color\.blue\)/iu, 'Usa colores semánticos o static member lookup en SwiftUI.'],
+    [/LazyVStack\/LazyHStack - Para listas grandes/iu, 'Las listas grandes deben renderizarse con LazyVStack o LazyHStack.'],
+    [/navigationDestination \(for:\) - Destinos tipados/iu, 'La navegación debe usar navigationDestination(for:) con destinos tipados.'],
+    [/Extract the action body to a named method or view model command and reference that method from Button\./iu, 'Extrae la acción a un método con nombre o comando del view model y referencia ese método desde Button.'],
+    [/Move branching into a dedicated row view or prefer conditional modifiers\/values that keep a stable view structure per element\./iu, 'Mueve la ramificación a una fila dedicada o usa modificadores condicionales que mantengan estable la estructura de vistas por elemento.'],
+    [/Use Identifiable models or an explicit stable domain identifier such as id: \\.id\./iu, 'Usa modelos Identifiable o un identificador estable del dominio, por ejemplo id: \\.id.'],
+    [/Keep one view instance and move the condition into modifiers, parameters or extracted stable row state\./iu, 'Mantén una única instancia de vista y mueve la condición a modificadores, parámetros o estado estable extraído.'],
+    [/Replace Color\.blue\/Color\.primary\/etc\. with \.blue\/\.primary in SwiftUI style contexts, or use named asset colors such as Color\("BrandPrimary"\) when design tokens are required\./iu, 'Sustituye Color.blue/Color.primary por .blue/.primary en contextos SwiftUI, o usa colores semánticos del design system cuando aplique.'],
+    [/Replace VStack\/HStack under ScrollView with LazyVStack\/LazyHStack when rendering collection rows\./iu, 'Sustituye VStack/HStack dentro de ScrollView por LazyVStack/LazyHStack al renderizar colecciones.'],
+  ];
+  for (const [pattern, replacement] of knownTexts) {
+    if (pattern.test(normalized)) {
+      return replacement;
+    }
+  }
+  return normalized;
+};
+
 const extractFieldFromCauseMessage = (message: string, field: string): string | null => {
   const escapedField = field.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
   const match = message.match(new RegExp(`\\b${escapedField}=([^\\n]+?)(?=\\s(?:severity|code|rule|file|lines?|message|remediation|snippet|node|primary_node|missing)=|$)`, 'i'));
@@ -104,15 +130,22 @@ const formatLocation = (cause: NonNullable<Extract<PumukiCriticalNotificationEve
 
 const humanizeRuleId = (ruleId: string): string => {
   const knownRules: Record<string, string> = {
+    'no-empty-catch': 'catch vacío',
     'prefer-swift-testing': 'Swift Testing',
     'no-xctassert': 'XCTest assertions',
     'no-wait-for-expectations': 'waitForExpectations en XCTest',
     'ios-test-quality': 'calidad de tests iOS',
+    'action-handlers-should-reference-methods-not-contain-inline-logic': 'handlers SwiftUI sin lógica inline',
+    'ensure-constant-number-of-views-per-foreach-element': 'estructura estable en ForEach',
+    'ensure-foreach-uses-stable-identity-see-references-list-patterns-md': 'identidad estable en ForEach',
+    'prefer-modifiers-over-conditional-views-for-state-changes': 'modificadores para cambios de estado',
     'dynamic-type-font-scaling-automatico': 'Dynamic Type',
     'dynamic-type-fuentes-escalables-y-layouts-adaptativos': 'fuentes escalables y layouts adaptativos',
     'use-relative-layout-over-hard-coded-constants': 'layout relativo en vez de constantes fijas',
     'magic-numbers-usar-constantes-con-nombres': 'números mágicos sin constantes con nombre',
     'prefer-static-member-lookup-blue-vs-color-blue': 'colores semánticos en SwiftUI',
+    'use-lazyvstack-lazyhstack-for-large-lists': 'LazyVStack/LazyHStack para listas grandes',
+    'use-navigationdestination-for-type-safe-navigation': 'navigationDestination type-safe',
   };
   const normalized = ruleId
     .replace(/^skills\./u, '')
@@ -218,13 +251,13 @@ const formatBlockingCauseForDialog = (
 ): readonly string[] => {
   const rule = cause.ruleId ?? cause.code;
   const visibleRule = formatVisibleRule(cause);
-  const problem = stripTechnicalFieldsFromMessage(cause.message) || cause.code;
+  const problem = localizeDeveloperText(stripTechnicalFieldsFromMessage(cause.message) || cause.code);
   const remediation = isGoldenFlowCause(cause)
     ? GOLDEN_FLOW_REMEDIATION
     : isWorktreeHygieneCause(cause)
     ? WORKTREE_HYGIENE_REMEDIATION
     : cause.remediation
-    ? normalizeNotificationText(cause.remediation)
+    ? localizeDeveloperText(cause.remediation)
     : 'Corrige la violación indicada y vuelve a intentar el commit.';
   if (isWorktreeHygieneCause(cause)) {
     return [
@@ -246,7 +279,7 @@ const formatBlockingCauseForDialog = (
   return [
     `${index + 1}. ${causeLabel}: ${truncateNotificationText(visibleRule, 96)}`,
     `   Fichero: ${truncateNotificationText(formatLocation(cause), 120)}`,
-    `   Viola: ${truncateNotificationText(problem, 160)}`,
+    `   Falla: ${truncateNotificationText(problem, 160)}`,
     buildEvidenceLine(cause),
     `   Solución: ${truncateNotificationText(remediation, 180)}`,
   ].filter((line): line is string => typeof line === 'string');

package/scripts/framework-menu-system-notifications-macos-swift-source.ts

@@ -41,8 +41,30 @@ final class DialogAppDelegate: NSObject, NSApplicationDelegate {
 
     let alert = NSAlert()
     alert.messageText = config.title
-    alert.informativeText = "Causa: \(config.cause)\n\nSolución: \(config.remediation)"
+    alert.informativeText = "Revisa el detalle del bloqueo. Puedes seleccionar y copiar el texto."
     alert.alertStyle = .critical
+
+    let details = "Causa:\n\(config.cause)\n\nSolución:\n\(config.remediation)"
+    let scrollView = NSScrollView(frame: NSRect(x: 0, y: 0, width: 560, height: 420))
+    scrollView.hasVerticalScroller = true
+    scrollView.hasHorizontalScroller = false
+    scrollView.borderType = .bezelBorder
+
+    let textView = NSTextView(frame: scrollView.contentView.bounds)
+    textView.string = details
+    textView.isEditable = false
+    textView.isSelectable = true
+    textView.drawsBackground = false
+    textView.font = NSFont.monospacedSystemFont(ofSize: 12, weight: .regular)
+    textView.textContainerInset = NSSize(width: 8, height: 8)
+    textView.textContainer?.widthTracksTextView = true
+    textView.textContainer?.containerSize = NSSize(width: scrollView.contentSize.width, height: CGFloat.greatestFiniteMagnitude)
+    textView.isVerticallyResizable = true
+    textView.isHorizontallyResizable = false
+    textView.autoresizingMask = [.width]
+    scrollView.documentView = textView
+    alert.accessoryView = scrollView
+
     alert.addButton(withTitle: config.keepButton)
     alert.addButton(withTitle: config.muteButton)
     alert.addButton(withTitle: config.disableButton)

package/scripts/framework-menu-system-notifications-payloads-audit.ts

@@ -8,24 +8,24 @@ export const buildAuditSummaryPayload = (
 ): SystemNotificationPayload => {
   if (event.criticalViolations > 0) {
     return {
-      title: 'AST Audit Blocked',
-      message: `🔴 ${event.criticalViolations} CRITICAL, ${event.highViolations} HIGH violations`,
+      title: 'Pumuki audit: resumen',
+      message: `Hay ${event.criticalViolations} críticas y ${event.highViolations} high. Abre el bloqueo detallado para ver regla, fichero y solución.`,
     };
   }
   if (event.highViolations > 0) {
     return {
-      title: 'AST Audit Blocked',
-      message: `🟡 ${event.highViolations} HIGH violations found`,
+      title: 'Pumuki audit: resumen',
+      message: `Hay ${event.highViolations} high. Abre el bloqueo detallado para ver regla, fichero y solución.`,
     };
   }
   if (event.totalViolations > 0) {
     return {
-      title: 'AST Audit Blocked',
-      message: `🔴 ${event.totalViolations} violations block the gate`,
+      title: 'Pumuki audit: resumen',
+      message: `Hay ${event.totalViolations} violaciones. Abre el bloqueo detallado para ver regla, fichero y solución.`,
     };
   }
   return {
-    title: 'AST Audit Complete',
-    message: '✅ No violations found',
+    title: 'Pumuki audit: OK',
+    message: 'No se han detectado violaciones.',
   };
 };