pumuki 6.3.293 → 6.3.295

package/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## [6.3.295] - 2026-05-19
+
+- `PUMUKI-INC-156`: staged PRE_WRITE/PRE_COMMIT no longer blocks an atomic iOS slice with broad file-level SwiftUI skill findings that expose dozens of lines without a precise AST node introduced by the diff. Precise AST/skills findings still block in every severity when they intersect changed lines; broad brownfield file debt is retained as advisory with remediation demanding line/node-level evidence or a dedicated remediation slice.
+
 ## [6.3.283] - 2026-05-19
 
 - `PUMUKI-INC-150`: brownfield XCTest specs that satisfy `makeSUT()` and `trackForMemoryLeaks()` are also exempt from Swift Testing migration assertion findings (`skills.ios.no-xctassert` / `skills.ios.no-xctunwrap`). These rules remain active for modern Swift Testing suites and XCTest specs without an explicit brownfield quality contract.

package/VERSION

@@ -1 +1 @@
-6.3.291
+6.3.294

package/core/facts/detectors/text/ios.test.ts

@@ -31,6 +31,10 @@ import {
   hasSwiftAdHocLoggingUsage,
   hasSwiftAlamofireUsage,
   hasSwiftEmptyCatchUsage,
+  collectSwiftNSErrorThrowLines,
+  hasSwiftNSErrorThrowUsage,
+  collectSwiftPackageBranchDependencyLines,
+  hasSwiftPackageBranchDependencyUsage,
   hasSwiftForEachIndicesUsage,
   hasSwiftForEachSelfIdentityUsage,
   collectSwiftForceCastLines,
@@ -98,9 +102,11 @@ import {
   hasSwiftNonIBOutletImplicitlyUnwrappedOptionalUsage,
   hasSwiftObservableObjectUsage,
   hasSwiftOnChangeTaskUsage,
+  collectSwiftOnChangeTaskLines,
   collectSwiftOnChangeReadonlyVarLines,
   hasSwiftOnChangeReadonlyVarUsage,
   hasSwiftOnAppearTaskUsage,
+  collectSwiftOnAppearTaskLines,
   hasSwiftOnTapGestureUsage,
   hasSwiftOperationQueueUsage,
   hasSwiftContainsUserFilterUsage,
@@ -382,6 +388,61 @@ do {
   assert.equal(hasSwiftEmptyCatchUsage(safe), false);
 });
 
+test('hasSwiftNSErrorThrowUsage detecta NSError lanzado directamente y preserva errores tipados', () => {
+  const source = `
+func map(response: HTTPURLResponse) throws {
+  if response.statusCode >= 500 {
+    throw NSError(domain: "Network", code: response.statusCode)
+  }
+}
+`;
+  const safe = `
+enum NetworkError: Error {
+  case server(statusCode: Int)
+}
+
+func map(response: HTTPURLResponse) throws {
+  if response.statusCode >= 500 {
+    throw NetworkError.server(statusCode: response.statusCode)
+  }
+}
+
+let sample = "throw NSError(domain: code:)"
+// throw NSError(domain: "Sample", code: 1)
+`;
+
+  assert.equal(hasSwiftNSErrorThrowUsage(source), true);
+  assert.deepEqual(collectSwiftNSErrorThrowLines(source), [4]);
+  assert.equal(hasSwiftNSErrorThrowUsage(safe), false);
+  assert.deepEqual(collectSwiftNSErrorThrowLines(safe), []);
+});
+
+test('hasSwiftPackageBranchDependencyUsage detecta dependencias SwiftPM por branch y preserva versiones', () => {
+  const source = `
+let package = Package(
+  dependencies: [
+    .package(url: "https://example.com/ui-kit.git", branch: "main"),
+  ]
+)
+`;
+  const safe = `
+let package = Package(
+  dependencies: [
+    .package(url: "https://example.com/ui-kit.git", exact: "1.2.3"),
+    .package(url: "https://example.com/domain.git", from: "2.0.0"),
+  ]
+)
+
+let sample = ".package(url: branch:)"
+// .package(url: "https://example.com/debug.git", branch: "develop")
+`;
+
+  assert.equal(hasSwiftPackageBranchDependencyUsage(source), true);
+  assert.deepEqual(collectSwiftPackageBranchDependencyLines(source), [4]);
+  assert.equal(hasSwiftPackageBranchDependencyUsage(safe), false);
+  assert.deepEqual(collectSwiftPackageBranchDependencyLines(safe), []);
+});
+
 test('hasSwiftNonLazyScrollForEachUsage detecta ScrollView con stack no lazy y preserva LazyVStack', () => {
   const source = `
 struct FeedView: View {
@@ -766,7 +827,9 @@ struct FeedView: View {
 `;
 
   assert.equal(hasSwiftOnAppearTaskUsage(source), true);
+  assert.deepEqual(collectSwiftOnAppearTaskLines(source), [8]);
   assert.equal(hasSwiftOnAppearTaskUsage(safe), false);
+  assert.deepEqual(collectSwiftOnAppearTaskLines(safe), []);
 });
 
 test('hasSwiftOnChangeTaskUsage detecta Task dentro de onChange y preserva task id', () => {
@@ -803,7 +866,9 @@ struct SearchView: View {
 `;
 
   assert.equal(hasSwiftOnChangeTaskUsage(source), true);
+  assert.deepEqual(collectSwiftOnChangeTaskLines(source), [8]);
   assert.equal(hasSwiftOnChangeTaskUsage(safe), false);
+  assert.deepEqual(collectSwiftOnChangeTaskLines(safe), []);
 });
 
 test('hasSwiftOnChangeReadonlyVarUsage detecta var local dentro de onChange y preserva let', () => {

package/core/facts/detectors/text/ios.ts

@@ -698,18 +698,78 @@ export const hasSwiftEmptyCatchUsage = (source: string): boolean => {
   return /\bcatch(?:\s+(?:let|var)\s+[A-Za-z_][A-Za-z0-9_]*)?\s*\{\s*\}/.test(sanitized);
 };
 
+export const collectSwiftNSErrorThrowLines = (source: string): readonly number[] => {
+  return collectSwiftRegexLines(source, /\bthrow\s+NSError\s*\(/g);
+};
+
+export const hasSwiftNSErrorThrowUsage = (source: string): boolean => {
+  return collectSwiftNSErrorThrowLines(source).length > 0;
+};
+
+export const collectSwiftPackageBranchDependencyLines = (source: string): readonly number[] => {
+  const matches: number[] = [];
+  source.split(/\r?\n/).forEach((line, index) => {
+    const sanitized = line
+      .replace(/"(?:\\.|[^"\\])*"/g, '""')
+      .replace(/\/\/.*$/, '');
+    if (/\.\s*package\s*\([^)]*\bbranch\s*:/.test(sanitized)) {
+      matches.push(index + 1);
+    }
+  });
+  return matches;
+};
+
+export const hasSwiftPackageBranchDependencyUsage = (source: string): boolean => {
+  return collectSwiftPackageBranchDependencyLines(source).length > 0;
+};
+
 export const hasSwiftOnAppearTaskUsage = (source: string): boolean => {
-  const sanitized = sanitizeSwiftSourceForMultilineRegex(source);
-  return /\.onAppear\s*\{[\s\S]{0,500}?\bTask\s*(?:\([^)]*\))?\s*\{/.test(sanitized);
+  return collectSwiftOnAppearTaskLines(source).length > 0;
 };
 
 export const hasSwiftOnChangeTaskUsage = (source: string): boolean => {
-  const sanitized = sanitizeSwiftSourceForMultilineRegex(source);
-  return /\.onChange\s*\([^)]*\)\s*\{[\s\S]{0,500}?\bTask\s*(?:\([^)]*\))?\s*\{/.test(
-    sanitized
-  );
+  return collectSwiftOnChangeTaskLines(source).length > 0;
 };
 
+const collectSwiftLifecycleTaskLines = (
+  source: string,
+  lifecyclePattern: RegExp
+): readonly number[] => {
+  const lines: number[] = [];
+  let insideLifecycle = false;
+  let braceDepth = 0;
+
+  source.split(/\r?\n/).forEach((rawLine, index) => {
+    const line = stripSwiftLineForSemanticScan(rawLine);
+
+    if (!insideLifecycle && lifecyclePattern.test(line)) {
+      insideLifecycle = true;
+      braceDepth = 0;
+    }
+
+    if (insideLifecycle && /\bTask\s*(?:\([^)]*\))?\s*\{/.test(line)) {
+      lines.push(index + 1);
+    }
+
+    if (insideLifecycle) {
+      const opened = (line.match(/\{/g) ?? []).length;
+      const closed = (line.match(/\}/g) ?? []).length;
+      braceDepth += opened - closed;
+      if (braceDepth <= 0) {
+        insideLifecycle = false;
+      }
+    }
+  });
+
+  return sortedUniqueLines(lines);
+};
+
+export const collectSwiftOnAppearTaskLines = (source: string): readonly number[] =>
+  collectSwiftLifecycleTaskLines(source, /\.onAppear\s*\{/);
+
+export const collectSwiftOnChangeTaskLines = (source: string): readonly number[] =>
+  collectSwiftLifecycleTaskLines(source, /\.onChange\s*\([^)]*\)\s*\{/);
+
 export const collectSwiftOnChangeReadonlyVarLines = (source: string): readonly number[] => {
   const lines: number[] = [];
   let insideOnChange = false;