pumuki 6.3.284 → 6.3.286

package/VERSION

@@ -1 +1 @@
-v6.3.284
+6.3.286

package/core/facts/detectors/text/ios.test.ts

@@ -46,9 +46,24 @@ import {
   hasSwiftHardcodedSensitiveStringUsage,
   hasSwiftUnlocalizedDateFormatterUsage,
   hasSwiftIconOnlyControlWithoutAccessibilityLabelUsage,
+  collectSwiftIconOnlyControlWithoutAccessibilityLabelLines,
   collectSwiftInteractiveControlWithoutAccessibilityIdentifierLines,
   hasSwiftInteractiveControlWithoutAccessibilityIdentifierUsage,
   collectSwiftBindableMissingForObservableBindingUsageLines,
+  collectSwiftExplicitColorStaticMemberLines,
+  collectSwiftFixedFontSizeLines,
+  collectSwiftHardcodedSensitiveStringLines,
+  collectSwiftHardcodedUiStringLines,
+  collectSwiftNonLazyScrollForEachLines,
+  collectSwiftUiForEachConditionalViewCountLines,
+  collectSwiftUiInlineActionLogicLines,
+  collectSwiftForEachIndicesLines,
+  collectSwiftForEachSelfIdentityLines,
+  collectSwiftInlineForEachTransformLines,
+  collectSwiftUiConditionalSameViewIdentityLines,
+  collectSwiftForegroundColorLines,
+  collectSwiftCornerRadiusLines,
+  collectSwiftMagicNumberLayoutLines,
   hasSwiftBindableMissingForObservableBindingUsage,
   hasSwiftLooseAssetResourceUsage,
   hasSwiftLegacyOnChangeUsage,
@@ -107,6 +122,7 @@ import {
   hasSwiftExplicitColorStaticMemberUsage,
   hasSwiftClosureBasedViewBuilderContentUsage,
   collectSwiftForceUnwrapLines,
+  collectSwiftWarningSuppressionLines,
   hasSwiftLargeConfigContextViewPropertyUsage,
   hasSwiftUiConditionalSameViewIdentityUsage,
   hasSwiftUiParentOwnedSheetActionUsage,
@@ -120,6 +136,7 @@ import {
   hasSwiftTaskDetachedUsage,
   hasSwiftUnownedSelfCaptureUsage,
   hasSwiftWaitForExpectationsUsage,
+  hasSwiftWarningSuppressionUsage,
   hasSwiftUIScreenMainBoundsUsage,
   hasSwiftXCTestAssertionUsage,
   hasSwiftXCTUnwrapUsage,
@@ -160,6 +177,28 @@ if waitersByKey[key] != nil {
   assert.deepEqual(collectSwiftForceUnwrapLines(source), []);
 });
 
+test('collectSwiftWarningSuppressionLines localiza supresiones de warnings Swift accionables', () => {
+  const source = [
+    'struct CheckoutView {',
+    '  // swiftlint:disable force_unwrapping',
+    '  let title = "swiftlint:disable is just copy"',
+    '  #warning("Remove temporary checkout branch")',
+    '  // swiftformat:disable:next redundantSelf',
+    '}',
+  ].join('\n');
+  const safe = [
+    'struct CheckoutView {',
+    '  let title = "No warnings are suppressed"',
+    '  // regular design note without disabling tooling',
+    '}',
+  ].join('\n');
+
+  assert.equal(hasSwiftWarningSuppressionUsage(source), true);
+  assert.deepEqual(collectSwiftWarningSuppressionLines(source), [2, 4, 5]);
+  assert.equal(hasSwiftWarningSuppressionUsage(safe), false);
+  assert.deepEqual(collectSwiftWarningSuppressionLines(safe), []);
+});
+
 test('hasSwiftUnownedSelfCaptureUsage detecta captures unowned y preserva weak', () => {
   const source = `
 final class ProfileViewModel {
@@ -237,12 +276,15 @@ send()
   assert.equal(hasSwiftProductionCommentUsage(safe), false);
 });
 
-test('hasSwiftCombineSinkWithoutStoreUsage detecta sink sin store y preserva cancellables', () => {
+test('hasSwiftCombineSinkWithoutStoreUsage detecta sink/assign sin store y preserva cancellables', () => {
   const source = `
 publisher
   .sink { value in
     render(value)
   }
+
+publisher
+  .assign(to: \\Model.title, on: model)
 `;
   const safe = `
 publisher
@@ -250,7 +292,11 @@ publisher
     render(value)
   }
   .store(in: &cancellables)
+publisher
+  .assign(to: \\Model.title, on: model)
+  .store(in: &cancellables)
 let ignored = ".sink { value in }"
+let ignoredAssign = ".assign(to: \\\\Model.title, on: model)"
 // publisher.sink { value in }
 `;
 
@@ -496,7 +542,9 @@ struct CheckoutView: View {
 `;
 
   assert.equal(hasSwiftUiInlineActionLogicUsage(source), true);
+  assert.deepEqual(collectSwiftUiInlineActionLogicLines(source), [6]);
   assert.equal(hasSwiftUiInlineActionLogicUsage(safe), false);
+  assert.deepEqual(collectSwiftUiInlineActionLogicLines(safe), []);
 });
 
 test('hasSwiftForEachSelfIdentityUsage detecta id self y preserva ids estables', () => {
@@ -1011,7 +1059,9 @@ struct ProfileView: View {
 `;
 
   assert.equal(hasSwiftMagicNumberLayoutUsage(source), true);
+  assert.deepEqual(collectSwiftMagicNumberLayoutLines(source), [4, 6, 7]);
   assert.equal(hasSwiftMagicNumberLayoutUsage(constants), false);
+  assert.deepEqual(collectSwiftMagicNumberLayoutLines(constants), []);
 });
 
 test('detectores de logging iOS detectan logs ad-hoc y PII en produccion', () => {
@@ -1054,7 +1104,9 @@ final class Credentials {
 `;
 
   assert.equal(hasSwiftHardcodedSensitiveStringUsage(source), true);
+  assert.deepEqual(collectSwiftHardcodedSensitiveStringLines(source), [3, 4]);
   assert.equal(hasSwiftHardcodedSensitiveStringUsage(safe), false);
+  assert.deepEqual(collectSwiftHardcodedSensitiveStringLines(safe), []);
 });
 
 test('hasSwiftUnlocalizedDateFormatterUsage detecta dateFormat fijo sin locale explicito', () => {
@@ -1191,7 +1243,9 @@ struct OrdersView: View {
 `;
 
   assert.equal(hasSwiftHardcodedUiStringUsage(source), true);
+  assert.deepEqual(collectSwiftHardcodedUiStringLines(source), [5, 6, 7, 8, 9]);
   assert.equal(hasSwiftHardcodedUiStringUsage(ignored), false);
+  assert.deepEqual(collectSwiftHardcodedUiStringLines(ignored), []);
 });
 
 test('detector iOS de assets detecta recursos sueltos sin confundir asset catalogs', () => {
@@ -1225,7 +1279,9 @@ let text = "UIFont.systemFont(ofSize: 16)"
 `;
 
   assert.equal(hasSwiftFixedFontSizeUsage(source), true);
+  assert.deepEqual(collectSwiftFixedFontSizeLines(source), [2, 3, 4]);
   assert.equal(hasSwiftFixedFontSizeUsage(ignored), false);
+  assert.deepEqual(collectSwiftFixedFontSizeLines(ignored), []);
 });
 
 test('detector iOS de localización detecta alineación física sin confundir leading/trailing', () => {
@@ -1325,7 +1381,9 @@ struct ToolbarView: View {
 `;
 
   assert.equal(hasSwiftIconOnlyControlWithoutAccessibilityLabelUsage(source), true);
+  assert.deepEqual(collectSwiftIconOnlyControlWithoutAccessibilityLabelLines(source), [4]);
   assert.equal(hasSwiftIconOnlyControlWithoutAccessibilityLabelUsage(ignored), false);
+  assert.deepEqual(collectSwiftIconOnlyControlWithoutAccessibilityLabelLines(ignored), []);
 });
 
 test('detector iOS de accesibilidad detecta controles interactivos sin accessibilityIdentifier', () => {
@@ -1630,7 +1688,51 @@ let ignored = "Color.green"
 `;
 
   assert.equal(hasSwiftExplicitColorStaticMemberUsage(source), true);
+  assert.deepEqual(collectSwiftExplicitColorStaticMemberLines(source), [4, 5]);
   assert.equal(hasSwiftExplicitColorStaticMemberUsage(safe), false);
+  assert.deepEqual(collectSwiftExplicitColorStaticMemberLines(safe), []);
+});
+
+test('collectors iOS de INC-152 devuelven lineas accionables para reglas SwiftUI bloqueantes', () => {
+  const source = `
+struct StoresView: View {
+  var body: some View {
+    ScrollView {
+      VStack {
+        ForEach(items.indices, id: \\.self) { index in
+          if items[index].isVisible {
+            Text(items[index].title).foregroundColor(.blue)
+          }
+        }
+        ForEach(items.filter { $0.isVisible }) { item in
+          Text(item.title)
+        }
+        if isLoading {
+          Text("Loading")
+        } else {
+          Text("Ready")
+        }
+        Button {
+          if isLoading { return }
+        } label: {
+          Text("Retry")
+        }
+        Image("hero").cornerRadius(12)
+      }
+    }
+  }
+}
+`;
+
+  assert.deepEqual(collectSwiftNonLazyScrollForEachLines(source), [4, 6, 11]);
+  assert.deepEqual(collectSwiftForEachIndicesLines(source), [6]);
+  assert.deepEqual(collectSwiftForEachSelfIdentityLines(source), [6]);
+  assert.deepEqual(collectSwiftUiForEachConditionalViewCountLines(source), [6, 7, 11, 14, 20]);
+  assert.deepEqual(collectSwiftInlineForEachTransformLines(source), [11]);
+  assert.deepEqual(collectSwiftUiConditionalSameViewIdentityLines(source), [7, 14, 20]);
+  assert.deepEqual(collectSwiftUiInlineActionLogicLines(source), [19]);
+  assert.deepEqual(collectSwiftForegroundColorLines(source), [8]);
+  assert.deepEqual(collectSwiftCornerRadiusLines(source), [24]);
 });
 
 test('hasSwiftClosureBasedViewBuilderContentUsage detecta content closure y preserva @ViewBuilder let content', () => {

package/core/facts/detectors/text/ios.ts

@@ -109,12 +109,32 @@ export const hasSwiftProductionCommentUsage = (source: string): boolean => {
   });
 };
 
+export const collectSwiftWarningSuppressionLines = (source: string): readonly number[] => {
+  const lines: number[] = [];
+
+  source.split(/\r?\n/).forEach((rawLine, index) => {
+    const line = stripSwiftStringLiterals(rawLine);
+    if (
+      /^\s*#warning\s*\(/.test(line) ||
+      /\/\/\s*(?:swiftlint|swiftformat|periphery)\s*:\s*disable(?::|\b)/i.test(line)
+    ) {
+      lines.push(index + 1);
+    }
+  });
+
+  return sortedUniqueLines(lines);
+};
+
+export const hasSwiftWarningSuppressionUsage = (source: string): boolean => {
+  return collectSwiftWarningSuppressionLines(source).length > 0;
+};
+
 export const hasSwiftCombineSinkWithoutStoreUsage = (source: string): boolean => {
   const lines = source.split(/\r?\n/);
 
   for (let index = 0; index < lines.length; index += 1) {
     const line = stripSwiftLineForSemanticScan(lines[index] ?? '');
-    if (!/\.sink\s*(?:\(|\{)/.test(line)) {
+    if (!/\.(?:sink|assign)\s*(?:\(|\{)/.test(line)) {
       continue;
     }
 
@@ -502,6 +522,16 @@ export const hasSwiftNonLazyScrollForEachUsage = (source: string): boolean => {
   return nonLazyScrollableCollectionPattern.test(swiftSource);
 };
 
+export const collectSwiftNonLazyScrollForEachLines = (source: string): readonly number[] => {
+  if (!hasSwiftNonLazyScrollForEachUsage(source)) {
+    return [];
+  }
+  return sortedUniqueLines([
+    ...collectSwiftRegexLines(source, /\bScrollView\s*(?:\([^)]*\))?\s*\{/),
+    ...collectSwiftRegexLines(source, /\bForEach\s*\(/),
+  ]);
+};
+
 export const hasSwiftUiForEachConditionalViewCountUsage = (source: string): boolean => {
   const swiftSource = sanitizeSwiftSourceForMultilineRegex(source);
   const conditionalForEachPattern =
@@ -510,6 +540,18 @@ export const hasSwiftUiForEachConditionalViewCountUsage = (source: string): bool
   return conditionalForEachPattern.test(swiftSource);
 };
 
+export const collectSwiftUiForEachConditionalViewCountLines = (
+  source: string
+): readonly number[] => {
+  if (!hasSwiftUiForEachConditionalViewCountUsage(source)) {
+    return [];
+  }
+  return sortedUniqueLines([
+    ...collectSwiftRegexLines(source, /\bForEach\s*\(/),
+    ...collectSwiftRegexLines(source, /\b(?:if|switch)\b/),
+  ]);
+};
+
 export const hasSwiftViewBodyObjectCreationUsage = (source: string): boolean => {
   const swiftSource = sanitizeSwiftSourceForMultilineRegex(source);
   const viewBodyObjectCreationPattern =
@@ -533,6 +575,13 @@ export const hasSwiftUiInlineActionLogicUsage = (source: string): boolean => {
   return inlineButtonActionPattern.test(swiftSource) || inlineActionParameterPattern.test(swiftSource);
 };
 
+export const collectSwiftUiInlineActionLogicLines = (source: string): readonly number[] => {
+  if (!hasSwiftUiInlineActionLogicUsage(source)) {
+    return [];
+  }
+  return collectSwiftRegexLines(source, /\bButton\s*(?:\(|\{)/);
+};
+
 export const hasSwiftDispatchQueueUsage = (source: string): boolean => {
   return scanCodeLikeSource(source, ({ source: swiftSource, index, current }) => {
     if (current !== 'D' || !hasIdentifierAt(swiftSource, index, 'DispatchQueue')) {
@@ -831,6 +880,13 @@ export const hasSwiftMagicNumberLayoutUsage = (source: string): boolean => {
   return collectSwiftRegexLines(source, swiftUiLayoutNumberPattern).length > 0;
 };
 
+export const collectSwiftMagicNumberLayoutLines = (source: string): readonly number[] => {
+  const swiftUiLayoutNumberPattern =
+    /(?:\b(?:VStack|HStack|ZStack|LazyVStack|LazyHStack)\s*\([^)]*\bspacing\s*:\s*|\.(?:padding|frame|offset|position|shadow|blur)\s*\([^)]*(?:\b(?:width|height|spacing|radius|x|y)\s*:\s*)?)\b(?:[3-9]|[1-9][0-9]+)(?:\.[0-9]+)?\b/;
+
+  return collectSwiftRegexLines(source, swiftUiLayoutNumberPattern);
+};
+
 export const hasSwiftAdHocLoggingUsage = (source: string): boolean => {
   return collectSwiftRegexLines(
     source,
@@ -865,6 +921,13 @@ export const hasSwiftHardcodedSensitiveStringUsage = (source: string): boolean =
   ).length > 0;
 };
 
+export const collectSwiftHardcodedSensitiveStringLines = (source: string): readonly number[] => {
+  return collectSwiftRegexLines(
+    source,
+    /\b(?:(?:private|fileprivate|internal|public|open|static|class|final|lazy)\s+)*(?:let|var)\s+(?=[A-Za-z_])[A-Za-z0-9_]*(?:token|secret|password|apikey|clientsecret|privatekey|sessionid)[A-Za-z0-9_]*\s*(?::\s*String\s*)?=\s*""/i
+  );
+};
+
 export const hasSwiftUnlocalizedDateFormatterUsage = (source: string): boolean => {
   const sanitizedSource = sanitizeSwiftSourceForMultilineRegex(source);
   const formatterDeclarations = sanitizedSource.matchAll(
@@ -975,6 +1038,32 @@ export const hasSwiftHardcodedUiStringUsage = (source: string): boolean => {
   });
 };
 
+export const collectSwiftHardcodedUiStringLines = (source: string): readonly number[] => {
+  const withoutBlockComments = source.replace(/\/\*[\s\S]*?\*\//g, '\n');
+  const matches: number[] = [];
+  withoutBlockComments.split(/\r?\n/).forEach((line, index) => {
+    if (/^\s*\/\//.test(line)) {
+      return;
+    }
+    const withoutInlineComment = line.replace(/\/\/.*$/, '');
+    const hasHardcodedUiLiteral = swiftUiLiteralTextPatterns.some((pattern) => {
+      const match = withoutInlineComment.match(pattern);
+      if (!match) {
+        return false;
+      }
+      const literal = match[1]?.trim() ?? '';
+      if (literal.length === 0) {
+        return false;
+      }
+      return !looksLikeLocalizationKey(literal);
+    });
+    if (hasHardcodedUiLiteral) {
+      matches.push(index + 1);
+    }
+  });
+  return matches;
+};
+
 export const hasSwiftLooseAssetResourceUsage = (source: string): boolean => {
   const withoutBlockComments = source.replace(/\/\*[\s\S]*?\*\//g, '\n');
   return withoutBlockComments.split(/\r?\n/).some((line) => {
@@ -1009,6 +1098,27 @@ export const hasSwiftFixedFontSizeUsage = (source: string): boolean => {
   });
 };
 
+export const collectSwiftFixedFontSizeLines = (source: string): readonly number[] => {
+  const withoutBlockComments = source.replace(/\/\*[\s\S]*?\*\//g, '\n');
+  const matches: number[] = [];
+  withoutBlockComments.split(/\r?\n/).forEach((line, index) => {
+    if (/^\s*\/\//.test(line)) {
+      return;
+    }
+    const sanitized = stripSwiftLineForSemanticScan(line);
+    if (
+      /\.\s*font\s*\(\s*\.\s*system\s*\(\s*size\s*:/.test(sanitized) ||
+      /\bFont\s*\.\s*system\s*\(\s*size\s*:/.test(sanitized) ||
+      /\bUIFont\s*\.\s*(?:systemFont|boldSystemFont|italicSystemFont)\s*\(\s*ofSize\s*:/.test(
+        sanitized
+      )
+    ) {
+      matches.push(index + 1);
+    }
+  });
+  return matches;
+};
+
 export const hasSwiftPhysicalTextAlignmentUsage = (source: string): boolean => {
   const withoutBlockComments = source.replace(/\/\*[\s\S]*?\*\//g, '\n');
   return withoutBlockComments.split(/\r?\n/).some((line) => {
@@ -1054,6 +1164,15 @@ export const hasSwiftIconOnlyControlWithoutAccessibilityLabelUsage = (source: st
   return false;
 };
 
+export const collectSwiftIconOnlyControlWithoutAccessibilityLabelLines = (
+  source: string
+): readonly number[] => {
+  if (!hasSwiftIconOnlyControlWithoutAccessibilityLabelUsage(source)) {
+    return [];
+  }
+  return collectSwiftRegexLines(source, /\bButton\s*(?:\(|\{)/);
+};
+
 export const collectSwiftInteractiveControlWithoutAccessibilityIdentifierLines = (
   source: string
 ): readonly number[] => {
@@ -1213,10 +1332,21 @@ export const hasSwiftForEachIndicesUsage = (source: string): boolean => {
   );
 };
 
+export const collectSwiftForEachIndicesLines = (source: string): readonly number[] => {
+  return collectSwiftRegexLines(
+    source,
+    /\bForEach\s*\(\s*(?:Array\s*\(\s*)?[A-Za-z_][A-Za-z0-9_.]*\.indices\b/
+  );
+};
+
 export const hasSwiftForEachSelfIdentityUsage = (source: string): boolean => {
   return hasSwiftSanitizedRegexMatch(source, /\bForEach\s*\([^)]*\bid\s*:\s*\\\.self\b/g);
 };
 
+export const collectSwiftForEachSelfIdentityLines = (source: string): readonly number[] => {
+  return collectSwiftRegexLines(source, /\bForEach\s*\([^)]*\bid\s*:\s*\\\.self\b/);
+};
+
 export const hasSwiftSelfPrintChangesUsage = (source: string): boolean => {
   return hasSwiftSanitizedRegexMatch(source, /\bSelf\s*\.\s*_printChanges\s*\(/g);
 };
@@ -1228,6 +1358,13 @@ export const hasSwiftInlineForEachTransformUsage = (source: string): boolean =>
   );
 };
 
+export const collectSwiftInlineForEachTransformLines = (source: string): readonly number[] => {
+  return collectSwiftRegexLines(
+    source,
+    /\bForEach\s*\(\s*(?:Array\s*\(\s*)?[A-Za-z_][A-Za-z0-9_]*(?:\.[A-Za-z_][A-Za-z0-9_]*)*\s*\.\s*(?:filter|map|compactMap|sorted)\s*(?:\{|\()/
+  );
+};
+
 const isUserSearchIdentifier = (value: string): boolean => {
   return /^(?:query|search(?:Text|Term|Query|Value)?|filter(?:Text|Value)?|text|term|input)$/i.test(
     value
@@ -1281,6 +1418,13 @@ export const hasSwiftExplicitColorStaticMemberUsage = (source: string): boolean
   );
 };
 
+export const collectSwiftExplicitColorStaticMemberLines = (source: string): readonly number[] => {
+  return collectSwiftRegexLines(
+    source,
+    /\bColor\s*\.\s*(?:accentColor|black|blue|brown|clear|cyan|gray|green|indigo|mint|orange|pink|primary|purple|red|secondary|teal|white|yellow)\b/g
+  );
+};
+
 export const hasSwiftClosureBasedViewBuilderContentUsage = (source: string): boolean => {
   return hasSwiftSanitizedRegexMatch(
     source,
@@ -1345,6 +1489,15 @@ export const hasSwiftUiConditionalSameViewIdentityUsage = (source: string): bool
   return false;
 };
 
+export const collectSwiftUiConditionalSameViewIdentityLines = (
+  source: string
+): readonly number[] => {
+  if (!hasSwiftUiConditionalSameViewIdentityUsage(source)) {
+    return [];
+  }
+  return collectSwiftRegexLines(source, /\bif\s+[^{}]+\{/);
+};
+
 export const hasSwiftUiParentOwnedSheetActionUsage = (source: string): boolean => {
   const sanitized = sanitizeSwiftSourceForMultilineRegex(source);
   const swiftUIViewBodyPattern =
@@ -1501,10 +1654,18 @@ export const hasSwiftForegroundColorUsage = (source: string): boolean => {
   return hasSwiftUiModernizationSnapshotMatch(source, 'foreground-color');
 };
 
+export const collectSwiftForegroundColorLines = (source: string): readonly number[] => {
+  return collectSwiftRegexLines(source, /\.\s*foregroundColor\s*\(/);
+};
+
 export const hasSwiftCornerRadiusUsage = (source: string): boolean => {
   return hasSwiftUiModernizationSnapshotMatch(source, 'corner-radius');
 };
 
+export const collectSwiftCornerRadiusLines = (source: string): readonly number[] => {
+  return collectSwiftRegexLines(source, /\.\s*cornerRadius\s*\(/);
+};
+
 export const hasSwiftTabItemUsage = (source: string): boolean => {
   return hasSwiftUiModernizationSnapshotMatch(source, 'tab-item');
 };