pumuki 6.3.252 → 6.3.254

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## [6.3.254] - 2026-05-14
+
+- iOS Swift Testing parity: `skills.ios.no-legacy-expectation-description` now emits AST-style line and node evidence for legacy `expectation(description:)` scaffolding, with actionable replacement guidance toward `await confirmation(...)` or awaited fulfillment flows.
+
+## [6.3.253] - 2026-05-14
+
+### Added
+- **iOS AST node evidence for XCTest waits:** `skills.ios.no-wait-for-expectations` now emits actionable line and node metadata for `wait(for:)`, `self.wait(for:)`, `waitForExpectations(timeout:)` and `XCTWaiter.wait(for:)`, while ignoring strings and comments.
+
 All notable changes to `pumuki` are documented here.
 
 This project follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

package/core/facts/detectors/text/ios.test.ts

@@ -6,6 +6,8 @@ import {
   findSwiftOpenClosedSwitchMatch,
   findSwiftConcreteDependencyDipMatch,
   findSwiftPresentationSrpMatch,
+  collectSwiftLegacyExpectationDescriptionLines,
+  collectSwiftWaitForExpectationsLines,
   hasSwiftAnyViewUsage,
   hasSwiftAsyncWithoutAwaitUsage,
   hasSwiftCallbackStyleSignature,
@@ -1721,14 +1723,20 @@ test('hasSwiftWaitForExpectationsUsage detecta waits legacy y excluye await fulf
 let expectation = expectation(description: "Done")
 wait(for: [expectation], timeout: 1)
 waitForExpectations(timeout: 1)
+self.wait(for: [expectation], timeout: 1)
+XCTWaiter.wait(for: [expectation], timeout: 1)
 `;
   const modernWait = `
 let expectation = expectation(description: "Done")
 await fulfillment(of: [expectation], timeout: 1)
+let sample = "waitForExpectations(timeout: 1)"
+// wait(for: [expectation], timeout: 1)
 `;
 
   assert.equal(hasSwiftWaitForExpectationsUsage(legacyWait), true);
   assert.equal(hasSwiftWaitForExpectationsUsage(modernWait), false);
+  assert.deepEqual(collectSwiftWaitForExpectationsLines(legacyWait), [3, 4, 5, 6]);
+  assert.deepEqual(collectSwiftWaitForExpectationsLines(modernWait), []);
 });
 
 test('hasSwiftLegacyExpectationDescriptionUsage detecta expectation(description:) sin flujo moderno', () => {
@@ -1751,6 +1759,8 @@ await confirmation("Done") { confirm in
   assert.equal(hasSwiftLegacyExpectationDescriptionUsage(legacyExpectation), true);
   assert.equal(hasSwiftLegacyExpectationDescriptionUsage(modernExpectation), false);
   assert.equal(hasSwiftLegacyExpectationDescriptionUsage(confirmationOnly), false);
+  assert.deepEqual(collectSwiftLegacyExpectationDescriptionLines(legacyExpectation), [2]);
+  assert.deepEqual(collectSwiftLegacyExpectationDescriptionLines(confirmationOnly), []);
 });
 
 test('hasSwiftNSManagedObjectBoundaryUsage detecta boundaries con NSManagedObject y excluye IDs o subclases', () => {

package/core/facts/detectors/text/ios.ts

@@ -1362,20 +1362,27 @@ const hasSwiftConfirmationUsage = (source: string): boolean => {
   return hasSwiftSanitizedRegexMatch(source, /\bawait\s+confirmation\b/);
 };
 
+export const collectSwiftWaitForExpectationsLines = (source: string): readonly number[] => {
+  return sortedUniqueLines([
+    ...collectSwiftRegexLines(source, /\b(?:self\s*\.\s*)?wait\s*\(\s*for\s*:/),
+    ...collectSwiftRegexLines(source, /\bwaitForExpectations\s*\(/),
+    ...collectSwiftRegexLines(source, /\bXCTWaiter\s*\.\s*wait\s*\(\s*for\s*:/),
+  ]);
+};
+
 export const hasSwiftWaitForExpectationsUsage = (source: string): boolean => {
-  return hasSwiftSanitizedRegexMatch(
-    source,
-    /\bwait\s*\(\s*for\s*:|\bwaitForExpectations\s*\(/
-  );
+  return collectSwiftWaitForExpectationsLines(source).length > 0;
 };
 
-export const hasSwiftLegacyExpectationDescriptionUsage = (source: string): boolean => {
-  const hasLegacyExpectation = collectSwiftRegexLines(
+export const collectSwiftLegacyExpectationDescriptionLines = (source: string): readonly number[] => {
+  return sortedUniqueLines(collectSwiftRegexLines(
     source,
     /\bexpectation\s*\(\s*description\s*:/
-  ).length > 0;
+  ));
+};
 
-  if (!hasLegacyExpectation) {
+export const hasSwiftLegacyExpectationDescriptionUsage = (source: string): boolean => {
+  if (collectSwiftLegacyExpectationDescriptionLines(source).length === 0) {
     return false;
   }
 

package/core/facts/extractHeuristicFacts.ts

@@ -627,6 +627,12 @@ type TextDetectorRegistryEntry = {
   readonly pathCheck: (path: string) => boolean;
   readonly excludePaths: ReadonlyArray<(path: string) => boolean>;
   readonly detect: (content: string) => boolean;
+  readonly locateLines?: (content: string) => readonly number[];
+  readonly primaryNode?: (lines: readonly number[]) => HeuristicFact['primary_node'];
+  readonly relatedNodes?: (lines: readonly number[]) => HeuristicFact['related_nodes'];
+  readonly why?: string;
+  readonly impact?: string;
+  readonly expected_fix?: string;
   readonly ruleId: string;
   readonly code: string;
   readonly message: string;
@@ -714,8 +720,8 @@ const textDetectorRegistry: ReadonlyArray<TextDetectorRegistryEntry> = [
   { platform: 'ios', pathCheck: isIOSSwiftTestPath, excludePaths: [], detect: TextIOS.hasSwiftModernizableXCTestSuiteUsage, ruleId: 'heuristics.ios.testing.xctest-suite-modernizable.ast', code: 'HEURISTICS_IOS_TESTING_XCTEST_SUITE_MODERNIZABLE_AST', message: 'AST heuristic detected XCTestCase/test... suite that may be modernizable to Swift Testing with import Testing and @Test.' },
   { platform: 'ios', pathCheck: isIOSSwiftTestPath, excludePaths: [], detect: TextIOS.hasSwiftXCTestAssertionUsage, ruleId: 'heuristics.ios.testing.xctassert.ast', code: 'HEURISTICS_IOS_TESTING_XCTASSERT_AST', message: 'AST heuristic detected XCTest assertion usage where #expect may be preferred.' },
   { platform: 'ios', pathCheck: isIOSSwiftTestPath, excludePaths: [], detect: TextIOS.hasSwiftXCTUnwrapUsage, ruleId: 'heuristics.ios.testing.xctunwrap.ast', code: 'HEURISTICS_IOS_TESTING_XCTUNWRAP_AST', message: 'AST heuristic detected XCTUnwrap usage where #require may be preferred.' },
-  { platform: 'ios', pathCheck: isIOSSwiftTestPath, excludePaths: [], detect: TextIOS.hasSwiftWaitForExpectationsUsage, ruleId: 'heuristics.ios.testing.wait-for-expectations.ast', code: 'HEURISTICS_IOS_TESTING_WAIT_FOR_EXPECTATIONS_AST', message: 'AST heuristic detected wait(for:)/waitForExpectations usage where await fulfillment(of:) may be preferred.' },
-  { platform: 'ios', pathCheck: isIOSSwiftTestPath, excludePaths: [], detect: TextIOS.hasSwiftLegacyExpectationDescriptionUsage, ruleId: 'heuristics.ios.testing.legacy-expectation-description.ast', code: 'HEURISTICS_IOS_TESTING_LEGACY_EXPECTATION_DESCRIPTION_AST', message: 'AST heuristic detected expectation(description:) usage without modern fulfillment/confirmation flow.' },
+  { platform: 'ios', pathCheck: isIOSSwiftTestPath, excludePaths: [], detect: TextIOS.hasSwiftWaitForExpectationsUsage, locateLines: TextIOS.collectSwiftWaitForExpectationsLines, primaryNode: (lines) => ({ kind: 'call', name: 'legacy XCTest wait call', lines }), relatedNodes: (lines) => [{ kind: 'call', name: 'replacement: await fulfillment(of:timeout:)', lines }], why: 'Legacy XCTest wait APIs block the current test thread and hide async intent that Swift concurrency can express directly.', impact: 'Async tests become less deterministic, harder to cancel and easier to keep tied to XCTest-only migration paths.', expected_fix: 'Replace wait(for:timeout:), self.wait(for:timeout:) or waitForExpectations(timeout:) with await fulfillment(of:timeout:) when the test target supports async XCTest migration.', ruleId: 'heuristics.ios.testing.wait-for-expectations.ast', code: 'HEURISTICS_IOS_TESTING_WAIT_FOR_EXPECTATIONS_AST', message: 'AST heuristic detected wait(for:)/waitForExpectations usage where await fulfillment(of:) may be preferred.' },
+  { platform: 'ios', pathCheck: isIOSSwiftTestPath, excludePaths: [], detect: TextIOS.hasSwiftLegacyExpectationDescriptionUsage, locateLines: TextIOS.collectSwiftLegacyExpectationDescriptionLines, primaryNode: (lines) => ({ kind: 'call', name: 'legacy XCTest expectation(description:) call', lines }), relatedNodes: (lines) => [{ kind: 'call', name: 'replacement: await confirmation or awaited fulfillment flow', lines }], why: 'Legacy expectation(description:) scaffolding keeps async tests coupled to XCTest-style callbacks instead of expressing confirmation intent directly.', impact: 'Tests can remain harder to read and migrate because the assertion flow is split between expectation creation, callback fulfillment and a later wait.', expected_fix: 'Prefer await confirmation(...) for callback confirmation, or pair legacy expectations with await fulfillment(of:timeout:) when the target still requires XCTest compatibility.', ruleId: 'heuristics.ios.testing.legacy-expectation-description.ast', code: 'HEURISTICS_IOS_TESTING_LEGACY_EXPECTATION_DESCRIPTION_AST', message: 'AST heuristic detected expectation(description:) usage without modern fulfillment/confirmation flow.' },
   { platform: 'ios', pathCheck: isIOSSwiftTestPath, excludePaths: [], detect: TextIOS.hasSwiftMixedTestingFrameworksUsage, ruleId: 'heuristics.ios.testing.mixed-frameworks.ast', code: 'HEURISTICS_IOS_TESTING_MIXED_FRAMEWORKS_AST', message: 'AST heuristic detected XCTestCase and Swift Testing markers mixed in the same test file without explicit compatibility reason.' },
   { platform: 'ios', pathCheck: isIOSSwiftTestPath, excludePaths: [], detect: TextIOS.hasSwiftQuickNimbleUsage, ruleId: 'heuristics.ios.testing.quick-nimble.ast', code: 'HEURISTICS_IOS_TESTING_QUICK_NIMBLE_AST', message: 'AST heuristic detected Quick/Nimble usage where native Swift Testing remains the preferred baseline.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftNSManagedObjectBoundaryUsage, ruleId: 'heuristics.ios.core-data.nsmanagedobject-boundary.ast', code: 'HEURISTICS_IOS_CORE_DATA_NSMANAGEDOBJECT_BOUNDARY_AST', message: 'AST heuristic detected NSManagedObject in a shared boundary.' },
@@ -812,12 +818,19 @@ export const extractHeuristicFacts = (
         (entry.excludePaths ?? []).every((exclude) => !exclude(fileFact.path)) &&
         entry.detect(fileFact.content)
       ) {
+        const lines = entry.locateLines?.(fileFact.content);
         heuristicFacts.push(
           createHeuristicFact({
             ruleId: entry.ruleId,
             code: entry.code,
             message: entry.message,
             filePath: fileFact.path,
+            lines,
+            primary_node: lines && lines.length > 0 ? entry.primaryNode?.(lines) : undefined,
+            related_nodes: lines && lines.length > 0 ? entry.relatedNodes?.(lines) : undefined,
+            why: entry.why,
+            impact: entry.impact,
+            expected_fix: entry.expected_fix,
           })
         );
       }

package/docs/operations/RELEASE_NOTES.md

@@ -6,6 +6,15 @@ This file keeps only the operational highlights and rollout notes that matter wh
 
 ## 2026-04 (CLI stability and macOS notifications)
 
+### 2026-05-14 (v6.3.254)
+- **Paridad AST iOS testing:** `skills.ios.no-legacy-expectation-description` ancla `expectation(description:)` a líneas y nodos accionables, con reemplazo recomendado hacia `await confirmation(...)` o `await fulfillment(of:timeout:)`.
+- **Rollout recomendado:** publicar `pumuki@6.3.254` y repinear consumers que dependan de paridad iOS/Swift Testing.
+
+### 2026-05-14 (v6.3.253)
+
+- **Paridad AST iOS testing:** `skills.ios.no-wait-for-expectations` queda respaldada por evidencia accionable de llamada Swift, con líneas, nodo primario y remediación hacia `await fulfillment(of:timeout:)`.
+- **Rollout recomendado:** publicar `pumuki@6.3.253` y continuar con `skills.ios.no-legacy-expectation-description` si no entra bug externo nuevo.
+
 ### 2026-05-14 (v6.3.252)
 
 - **Parser de tracking estricto:** el refresh SDD ya no interpreta bullets operativos (`Siguiente`, `next`, `delegable`) como IDs de task activa.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pumuki",
-  "version": "6.3.252",
+  "version": "6.3.254",
   "description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
   "main": "index.js",
   "bin": {