pumuki 6.3.245 → 6.3.247

package/CHANGELOG.md

@@ -6,6 +6,18 @@ This project follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
 
+## [6.3.247] - 2026-05-14
+
+### Added
+
+- **SwiftUI sheet action parity:** `skills.ios.guideline.ios-swiftui-expert.sheets-should-own-their-actions-and-call-dismiss-internally` now maps to a scoped AUTO heuristic that detects sheet content receiving parent-owned save/cancel/dismiss callbacks, preserving sheets that own their actions internally.
+
+## [6.3.246] - 2026-05-14
+
+### Added
+
+- **SwiftUI view-identity parity:** `skills.ios.guideline.ios-swiftui-expert.prefer-modifiers-over-conditional-views-for-state-changes-maintains-vi` now maps to a conservative AUTO heuristic for `if/else` branches that rebuild the same SwiftUI View type for state-only visual changes, preserving legitimate conditional composition.
+
 ## [6.3.245] - 2026-05-14
 
 ### Added

package/core/facts/detectors/text/ios.test.ts

@@ -74,6 +74,8 @@ import {
   hasSwiftExplicitColorStaticMemberUsage,
   hasSwiftClosureBasedViewBuilderContentUsage,
   hasSwiftLargeConfigContextViewPropertyUsage,
+  hasSwiftUiConditionalSameViewIdentityUsage,
+  hasSwiftUiParentOwnedSheetActionUsage,
   hasSwiftRedundantReactiveStateAssignmentUsage,
   hasSwiftInlineForEachTransformUsage,
   hasSwiftStringFormatUsage,
@@ -2071,3 +2073,103 @@ final class PumukiLspIosCanaryPremiumDiscount: PumukiLspIosCanaryDiscountApplyin
   assert.match(match.impact, /sustitución|precondiciones|regresiones/i);
   assert.match(match.expected_fix, /contrato base|adaptador|estrategia/i);
 });
+
+test('hasSwiftUiConditionalSameViewIdentityUsage detecta ramas que reconstruyen la misma View por estado visual', () => {
+  const source = `
+struct StatusBadge: View {
+  let isSelected: Bool
+
+  var body: some View {
+    if isSelected {
+      Text("Active")
+        .foregroundStyle(.green)
+    } else {
+      Text("Active")
+        .foregroundStyle(.secondary)
+    }
+  }
+}
+`;
+  const safe = `
+struct StatusBadge: View {
+  let isSelected: Bool
+
+  var body: some View {
+    Text("Active")
+      .foregroundStyle(isSelected ? .green : .secondary)
+
+    if isSelected {
+      SuccessBadge()
+    } else {
+      EmptyView()
+    }
+
+    let sample = "if isSelected { Text(\"Active\") } else { Text(\"Active\") }"
+    // if isSelected { Text("Active") } else { Text("Active") }
+  }
+}
+`;
+
+  assert.equal(hasSwiftUiConditionalSameViewIdentityUsage(source), true);
+  assert.equal(hasSwiftUiConditionalSameViewIdentityUsage(safe), false);
+});
+
+test('hasSwiftUiParentOwnedSheetActionUsage detecta sheets que reciben callbacks de accion del padre', () => {
+  const source = `
+struct ParentView: View {
+  @State private var selectedItem: Item?
+
+  var body: some View {
+    List(items) { item in
+      Button(item.name) {
+        selectedItem = item
+      }
+    }
+    .sheet(item: $selectedItem) { item in
+      EditItemSheet(
+        item: item,
+        onSave: { newName in
+          save(item, newName)
+        },
+        onCancel: {
+          selectedItem = nil
+        }
+      )
+    }
+  }
+}
+`;
+  const safe = `
+struct ParentView: View {
+  @State private var selectedItem: Item?
+
+  var body: some View {
+    List(items) { item in
+      Button(item.name) {
+        selectedItem = item
+      }
+    }
+    .sheet(item: $selectedItem) { item in
+      EditItemSheet(item: item)
+    }
+
+    let sample = ".sheet(item: $selectedItem) { EditItemSheet(onCancel: {}) }"
+    // .sheet(item: $selectedItem) { EditItemSheet(onSave: {}) }
+  }
+}
+
+struct EditItemSheet: View {
+  @Environment(\\.dismiss) private var dismiss
+  let item: Item
+
+  var body: some View {
+    Button("Cancel") {
+      dismiss()
+    }
+  }
+}
+`;
+
+  assert.equal(hasSwiftUiParentOwnedSheetActionUsage(source), true);
+  assert.equal(hasSwiftUiParentOwnedSheetActionUsage(safe), false);
+});

package/core/facts/detectors/text/ios.ts

@@ -981,6 +981,59 @@ export const hasSwiftLargeConfigContextViewPropertyUsage = (source: string): boo
   return false;
 };
 
+const swiftIdentitySensitiveViewConstructors = [
+  'Text',
+  'Image',
+  'Button',
+  'Label',
+  'HStack',
+  'VStack',
+  'ZStack',
+  'Group',
+  'RoundedRectangle',
+  'Circle',
+  'Capsule',
+  'Rectangle',
+] as const;
+
+export const hasSwiftUiConditionalSameViewIdentityUsage = (source: string): boolean => {
+  const sanitized = sanitizeSwiftSourceForMultilineRegex(source);
+  const swiftUIViewBodyPattern =
+    /\bstruct\s+[A-Za-z_][A-Za-z0-9_]*\s*:\s*View\s*\{[\s\S]{0,2200}?\bvar\s+body\s*:\s*some\s+View\s*\{/m;
+
+  if (!swiftUIViewBodyPattern.test(sanitized)) {
+    return false;
+  }
+
+  for (const constructor of swiftIdentitySensitiveViewConstructors) {
+    const escapedConstructor = escapeRegex(constructor);
+    const sameViewBranchPattern = new RegExp(
+      `\\bif\\s+[^{}]+\\{\\s*${escapedConstructor}\\s*(?:\\(|\\{|\\.)[\\s\\S]{0,600}?\\}\\s*else\\s*\\{\\s*${escapedConstructor}\\s*(?:\\(|\\{|\\.)`,
+      'm'
+    );
+    if (sameViewBranchPattern.test(sanitized)) {
+      return true;
+    }
+  }
+
+  return false;
+};
+
+export const hasSwiftUiParentOwnedSheetActionUsage = (source: string): boolean => {
+  const sanitized = sanitizeSwiftSourceForMultilineRegex(source);
+  const swiftUIViewBodyPattern =
+    /\bstruct\s+[A-Za-z_][A-Za-z0-9_]*\s*:\s*View\s*\{[\s\S]{0,2200}?\bvar\s+body\s*:\s*some\s+View\s*\{/m;
+
+  if (!swiftUIViewBodyPattern.test(sanitized)) {
+    return false;
+  }
+
+  const sheetWithCallbackPattern =
+    /\.(?:sheet|fullScreenCover)\s*\([^)]*\)\s*\{[\s\S]{0,1200}?\b[A-Za-z_][A-Za-z0-9_]*\s*\([\s\S]{0,900}?\b(?:onSave|onCancel|onDismiss|onClose|onDone|onDelete|onConfirm)\s*:\s*\{/g;
+
+  return sheetWithCallbackPattern.test(sanitized);
+};
+
 export const hasSwiftRedundantReactiveStateAssignmentUsage = (source: string): boolean => {
   const sanitized = sanitizeSwiftSourceForMultilineRegex(source);
   const reactiveAssignmentPattern =

package/core/facts/extractHeuristicFacts.ts

@@ -690,6 +690,8 @@ const textDetectorRegistry: ReadonlyArray<TextDetectorRegistryEntry> = [
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftExplicitColorStaticMemberUsage, ruleId: 'heuristics.ios.swiftui.explicit-color-static-member.ast', code: 'HEURISTICS_IOS_SWIFTUI_EXPLICIT_COLOR_STATIC_MEMBER_AST', message: 'AST heuristic detected Color.* static member usage where SwiftUI static member lookup may be preferred.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftClosureBasedViewBuilderContentUsage, ruleId: 'heuristics.ios.swiftui.closure-based-viewbuilder-content.ast', code: 'HEURISTICS_IOS_SWIFTUI_CLOSURE_BASED_VIEWBUILDER_CONTENT_AST', message: 'AST heuristic detected closure-based content storage; @ViewBuilder let content: Content remains the preferred SwiftUI container baseline.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftLargeConfigContextViewPropertyUsage, ruleId: 'heuristics.ios.swiftui.large-config-context-prop.ast', code: 'HEURISTICS_IOS_SWIFTUI_LARGE_CONFIG_CONTEXT_PROP_AST', message: 'AST heuristic detected a SwiftUI View storing a broad config/context object; pass only needed values to reduce update fan-out.' },
+  { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftUiConditionalSameViewIdentityUsage, ruleId: 'heuristics.ios.swiftui.conditional-same-view-identity.ast', code: 'HEURISTICS_IOS_SWIFTUI_CONDITIONAL_SAME_VIEW_IDENTITY_AST', message: 'AST heuristic detected conditional branches rebuilding the same SwiftUI View type; prefer conditional modifiers or values to preserve view identity.' },
+  { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftUiParentOwnedSheetActionUsage, ruleId: 'heuristics.ios.swiftui.parent-owned-sheet-action.ast', code: 'HEURISTICS_IOS_SWIFTUI_PARENT_OWNED_SHEET_ACTION_AST', message: 'AST heuristic detected a SwiftUI sheet receiving parent-owned action callbacks; sheets should own save/cancel actions and call dismiss() internally.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftRedundantReactiveStateAssignmentUsage, ruleId: 'heuristics.ios.swiftui.redundant-reactive-state-assignment.ast', code: 'HEURISTICS_IOS_SWIFTUI_REDUNDANT_REACTIVE_STATE_ASSIGNMENT_AST', message: 'AST heuristic detected reactive state assignment without a value-change guard; check for value changes before assigning state in hot paths.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftNonLazyScrollForEachUsage, ruleId: 'heuristics.ios.swiftui.non-lazy-scroll-foreach.ast', code: 'HEURISTICS_IOS_SWIFTUI_NON_LAZY_SCROLL_FOREACH_AST', message: 'AST heuristic detected ScrollView with a non-lazy stack feeding ForEach; LazyVStack/LazyHStack remain the preferred baseline for large scrollable collections.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftViewBodyObjectCreationUsage, ruleId: 'heuristics.ios.swiftui.body-object-creation.ast', code: 'HEURISTICS_IOS_SWIFTUI_BODY_OBJECT_CREATION_AST', message: 'AST heuristic detected formatter object creation inside SwiftUI body; keep body simple and move expensive objects out of render paths.' },

package/core/rules/presets/heuristics/ios.test.ts

@@ -3,7 +3,7 @@ import test from 'node:test';
 import { iosRules } from './ios';
 
 test('iosRules define reglas heurísticas locked para plataforma ios', () => {
-  assert.equal(iosRules.length, 84);
+  assert.equal(iosRules.length, 86);
 
   const ids = iosRules.map((rule) => rule.id);
   assert.deepEqual(ids, [
@@ -62,6 +62,8 @@ test('iosRules define reglas heurísticas locked para plataforma ios', () => {
     'heuristics.ios.swiftui.explicit-color-static-member.ast',
     'heuristics.ios.swiftui.closure-based-viewbuilder-content.ast',
     'heuristics.ios.swiftui.large-config-context-prop.ast',
+    'heuristics.ios.swiftui.conditional-same-view-identity.ast',
+    'heuristics.ios.swiftui.parent-owned-sheet-action.ast',
     'heuristics.ios.swiftui.redundant-reactive-state-assignment.ast',
     'heuristics.ios.swiftui.non-lazy-scroll-foreach.ast',
     'heuristics.ios.swiftui.body-object-creation.ast',
@@ -210,6 +212,14 @@ test('iosRules define reglas heurísticas locked para plataforma ios', () => {
     byId.get('heuristics.ios.swiftui.large-config-context-prop.ast')?.then.code,
     'HEURISTICS_IOS_SWIFTUI_LARGE_CONFIG_CONTEXT_PROP_AST'
   );
+  assert.equal(
+    byId.get('heuristics.ios.swiftui.conditional-same-view-identity.ast')?.then.code,
+    'HEURISTICS_IOS_SWIFTUI_CONDITIONAL_SAME_VIEW_IDENTITY_AST'
+  );
+  assert.equal(
+    byId.get('heuristics.ios.swiftui.parent-owned-sheet-action.ast')?.then.code,
+    'HEURISTICS_IOS_SWIFTUI_PARENT_OWNED_SHEET_ACTION_AST'
+  );
   assert.equal(
     byId.get('heuristics.ios.uiscreen-main-bounds.ast')?.then.code,
     'HEURISTICS_IOS_UISCREEN_MAIN_BOUNDS_AST'

package/core/rules/presets/heuristics/ios.ts

@@ -1008,6 +1008,46 @@ export const iosRules: RuleSet = [
       code: 'HEURISTICS_IOS_SWIFTUI_LARGE_CONFIG_CONTEXT_PROP_AST',
     },
   },
+  {
+    id: 'heuristics.ios.swiftui.conditional-same-view-identity.ast',
+    description:
+      'Detects SwiftUI if/else branches that rebuild the same View type for state-only visual changes.',
+    severity: 'WARN',
+    platform: 'ios',
+    locked: true,
+    when: {
+      kind: 'Heuristic',
+      where: {
+        ruleId: 'heuristics.ios.swiftui.conditional-same-view-identity.ast',
+      },
+    },
+    then: {
+      kind: 'Finding',
+      message:
+        'AST heuristic detected conditional branches rebuilding the same SwiftUI View type; prefer conditional modifiers or values to preserve view identity.',
+      code: 'HEURISTICS_IOS_SWIFTUI_CONDITIONAL_SAME_VIEW_IDENTITY_AST',
+    },
+  },
+  {
+    id: 'heuristics.ios.swiftui.parent-owned-sheet-action.ast',
+    description:
+      'Detects SwiftUI sheets that receive save/cancel/dismiss callbacks from the parent view.',
+    severity: 'WARN',
+    platform: 'ios',
+    locked: true,
+    when: {
+      kind: 'Heuristic',
+      where: {
+        ruleId: 'heuristics.ios.swiftui.parent-owned-sheet-action.ast',
+      },
+    },
+    then: {
+      kind: 'Finding',
+      message:
+        'AST heuristic detected a SwiftUI sheet receiving parent-owned action callbacks; sheets should own save/cancel actions and call dismiss() internally.',
+      code: 'HEURISTICS_IOS_SWIFTUI_PARENT_OWNED_SHEET_ACTION_AST',
+    },
+  },
   {
     id: 'heuristics.ios.swiftui.redundant-reactive-state-assignment.ast',
     description: 'Detects onChange/onReceive state assignments without a value-change guard.',

package/integrations/config/skillsDetectorRegistry.ts

@@ -284,6 +284,14 @@ const registryByRuleId: Record<string, SkillsDetectorBinding> = {
     heuristicDetector('ios.swiftui.large-config-context-prop', [
       'heuristics.ios.swiftui.large-config-context-prop.ast',
     ]),
+  'skills.ios.guideline.ios-swiftui-expert.prefer-modifiers-over-conditional-views-for-state-changes-maintains-vi':
+    heuristicDetector('ios.swiftui.conditional-same-view-identity', [
+      'heuristics.ios.swiftui.conditional-same-view-identity.ast',
+    ]),
+  'skills.ios.guideline.ios-swiftui-expert.sheets-should-own-their-actions-and-call-dismiss-internally':
+    heuristicDetector('ios.swiftui.parent-owned-sheet-action', [
+      'heuristics.ios.swiftui.parent-owned-sheet-action.ast',
+    ]),
   'skills.ios.guideline.ios-swiftui-expert.avoid-redundant-state-updates-in-onreceive-onchange-scroll-handlers':
     heuristicDetector('ios.swiftui.redundant-reactive-state-assignment', [
       'heuristics.ios.swiftui.redundant-reactive-state-assignment.ast',

package/integrations/config/skillsMarkdownRules.ts

@@ -324,6 +324,19 @@ const normalizeKnownRuleTarget = (
     ) {
       return 'skills.ios.guideline.ios-swiftui-expert.use-relative-layout-over-hard-coded-constants';
     }
+    if (
+      (includes('prefer modifiers') || includes('modifiers over conditional views')) &&
+      (includes('conditional views') || includes('view identity') || includes('maintains view identity'))
+    ) {
+      return 'skills.ios.guideline.ios-swiftui-expert.prefer-modifiers-over-conditional-views-for-state-changes-maintains-vi';
+    }
+    if (
+      includes('sheets should own their actions') ||
+      (includes('call dismiss internally') && includes('sheet')) ||
+      (includes('avoid passing dismiss') && includes('callbacks to sheets'))
+    ) {
+      return 'skills.ios.guideline.ios-swiftui-expert.sheets-should-own-their-actions-and-call-dismiss-internally';
+    }
     if (
       (includes('foreach') && includes('indices')) ||
       includes('stable identity for foreach') ||

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pumuki",
-  "version": "6.3.245",
+  "version": "6.3.247",
   "description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
   "main": "index.js",
   "bin": {

package/skills.lock.json

@@ -1,7 +1,7 @@
 {
   "version": "1.0",
   "compilerVersion": "1.0.0",
-  "generatedAt": "2026-05-14T07:45:13.168Z",
+  "generatedAt": "2026-05-14T08:03:51.620Z",
   "bundles": [
     {
       "name": "android-guidelines",
@@ -8620,7 +8620,7 @@
       "name": "ios-swiftui-expert-guidelines",
       "version": "1.0.0",
       "source": "file:vendor/skills/swiftui-expert-skill/SKILL.md",
-      "hash": "0c30a1be4bf60d113d15b12da5fdea1f49c5dc64cda8bbb8c3b9885dcfe5abcb",
+      "hash": "5a759b80ddf1308e23cd04aef7e1628abf13dcd0e9d7649039da10a40f1de860",
       "rules": [
         {
           "id": "skills.ios.guideline.ios-swiftui-expert.action-handlers-should-reference-methods-not-contain-inline-logic",
@@ -8727,7 +8727,7 @@
           "sourcePath": "vendor/skills/swiftui-expert-skill/SKILL.md",
           "confidence": "MEDIUM",
           "locked": true,
-          "evaluationMode": "DECLARATIVE",
+          "evaluationMode": "AUTO",
           "origin": "core"
         },
         {
@@ -8775,7 +8775,7 @@
           "sourcePath": "vendor/skills/swiftui-expert-skill/SKILL.md",
           "confidence": "MEDIUM",
           "locked": true,
-          "evaluationMode": "DECLARATIVE",
+          "evaluationMode": "AUTO",
           "origin": "core"
         },
         {