pumuki 6.3.228 → 6.3.230

package/core/facts/detectors/text/ios.test.ts

@@ -15,6 +15,7 @@ import {
   hasSwiftAdHocLoggingUsage,
   hasSwiftAlamofireUsage,
   hasSwiftForEachIndicesUsage,
+  hasSwiftForEachSelfIdentityUsage,
   hasSwiftForceCastUsage,
   hasSwiftFontWeightBoldUsage,
   hasSwiftFixedFontSizeUsage,
@@ -48,6 +49,7 @@ import {
   hasSwiftNSManagedObjectBoundaryUsage,
   hasSwiftNSManagedObjectStateLeakUsage,
   hasSwiftNavigationViewUsage,
+  hasSwiftUntypedNavigationLinkDestinationUsage,
   hasSwiftNonPrivateStateOwnershipUsage,
   hasSwiftNonIBOutletImplicitlyUnwrappedOptionalUsage,
   hasSwiftObservableObjectUsage,
@@ -291,6 +293,89 @@ struct CheckoutView: View {
   assert.equal(hasSwiftUiInlineActionLogicUsage(safe), false);
 });
 
+test('hasSwiftForEachSelfIdentityUsage detecta id self y preserva ids estables', () => {
+  const source = `
+struct FeedView: View {
+  let items: [Item]
+
+  var body: some View {
+    ForEach(items, id: \\.self) { item in
+      FeedRow(item: item)
+    }
+  }
+}
+`;
+  const safe = `
+struct FeedView: View {
+  let items: [Item]
+
+  var body: some View {
+    ForEach(items, id: \\.id) { item in
+      FeedRow(item: item)
+    }
+    let sample = "ForEach(items, id: \\.self) { item in FeedRow(item: item) }"
+    // ForEach(items, id: \.self) { item in FeedRow(item: item) }
+  }
+}
+`;
+
+  assert.equal(hasSwiftForEachSelfIdentityUsage(source), true);
+  assert.equal(hasSwiftForEachSelfIdentityUsage(safe), false);
+});
+
+test('hasSwiftUntypedNavigationLinkDestinationUsage detecta NavigationLink no tipado y preserva value navigation', () => {
+  const source = `
+struct FeedView: View {
+  let items: [Item]
+
+  var body: some View {
+    NavigationStack {
+      List(items) { item in
+        NavigationLink(destination: DetailView(item: item)) {
+          Text(item.title)
+        }
+      }
+    }
+  }
+}
+`;
+  const trailing = `
+struct FeedView: View {
+  var body: some View {
+    NavigationLink {
+      DetailView()
+    } label: {
+      Text("Open")
+    }
+  }
+}
+`;
+  const safe = `
+struct FeedView: View {
+  let items: [Item]
+
+  var body: some View {
+    NavigationStack {
+      List(items) { item in
+        NavigationLink(value: item) {
+          Text(item.title)
+        }
+      }
+      .navigationDestination(for: Item.self) { item in
+        DetailView(item: item)
+      }
+    }
+    let sample = "NavigationLink(destination: DetailView())"
+    // NavigationLink { DetailView() } label: { Text("Open") }
+  }
+}
+`;
+
+  assert.equal(hasSwiftUntypedNavigationLinkDestinationUsage(source), true);
+  assert.equal(hasSwiftUntypedNavigationLinkDestinationUsage(trailing), true);
+  assert.equal(hasSwiftUntypedNavigationLinkDestinationUsage(safe), false);
+});
+
 test('hasSwiftForceTryUsage detecta try! y descarta try?', () => {
   const positive = `
 func load() {

package/core/facts/detectors/text/ios.ts

@@ -849,6 +849,10 @@ export const hasSwiftForEachIndicesUsage = (source: string): boolean => {
   );
 };
 
+export const hasSwiftForEachSelfIdentityUsage = (source: string): boolean => {
+  return hasSwiftSanitizedRegexMatch(source, /\bForEach\s*\([^)]*\bid\s*:\s*\\\.self\b/g);
+};
+
 export const hasSwiftInlineForEachTransformUsage = (source: string): boolean => {
   const sanitized = sanitizeSwiftSourceForMultilineRegex(source);
   return /\bForEach\s*\(\s*(?:Array\s*\(\s*)?[A-Za-z_][A-Za-z0-9_]*(?:\.[A-Za-z_][A-Za-z0-9_]*)*\s*\.\s*(?:filter|map|compactMap|sorted)\s*(?:\{|\()/g.test(
@@ -1017,6 +1021,15 @@ export const hasSwiftNavigationViewUsage = (source: string): boolean => {
   });
 };
 
+export const hasSwiftUntypedNavigationLinkDestinationUsage = (source: string): boolean => {
+  const swiftSource = sanitizeSwiftSourceForMultilineRegex(source);
+  const destinationParameterPattern = /\bNavigationLink\s*\([^)]*\bdestination\s*:/;
+  const trailingDestinationPattern =
+    /\bNavigationLink\s*\{[\s\S]{0,900}\b[A-Z][A-Za-z0-9_]*View\s*\([^}]*\)[\s\S]{0,900}\}\s*label\s*:/;
+
+  return destinationParameterPattern.test(swiftSource) || trailingDestinationPattern.test(swiftSource);
+};
+
 export const hasSwiftForegroundColorUsage = (source: string): boolean => {
   return hasSwiftUiModernizationSnapshotMatch(source, 'foreground-color');
 };

package/core/facts/extractHeuristicFacts.ts

@@ -678,6 +678,7 @@ const textDetectorRegistry: ReadonlyArray<TextDetectorRegistryEntry> = [
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftNonPrivateStateOwnershipUsage, ruleId: 'heuristics.ios.swiftui.non-private-state-ownership.ast', code: 'HEURISTICS_IOS_SWIFTUI_NON_PRIVATE_STATE_OWNERSHIP_AST', message: 'AST heuristic detected @State/@StateObject without private visibility; SwiftUI owned state should be private.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftPassedValueStateWrapperUsage, ruleId: 'heuristics.ios.passed-value-state-wrapper.ast', code: 'HEURISTICS_IOS_PASSED_VALUE_STATE_WRAPPER_AST', message: 'AST heuristic detected a passed value stored as @State/@StateObject via init wrapper ownership.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftForEachIndicesUsage, ruleId: 'heuristics.ios.foreach-indices.ast', code: 'HEURISTICS_IOS_FOREACH_INDICES_AST', message: 'AST heuristic detected ForEach(...indices...) usage where stable element identity may be preferred.' },
+  { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftForEachSelfIdentityUsage, ruleId: 'heuristics.ios.swiftui.foreach-self-identity.ast', code: 'HEURISTICS_IOS_SWIFTUI_FOREACH_SELF_IDENTITY_AST', message: 'AST heuristic detected ForEach(..., id: \.self) usage; prefer a stable domain identity such as id: \.id or Identifiable models.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftInlineForEachTransformUsage, ruleId: 'heuristics.ios.swiftui.inline-foreach-transform.ast', code: 'HEURISTICS_IOS_SWIFTUI_INLINE_FOREACH_TRANSFORM_AST', message: 'AST heuristic detected inline filter/map/sort work inside ForEach; prefiltered or cached collections remain the preferred baseline.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftUiForEachConditionalViewCountUsage, ruleId: 'heuristics.ios.swiftui.foreach-conditional-view-count.ast', code: 'HEURISTICS_IOS_SWIFTUI_FOREACH_CONDITIONAL_VIEW_COUNT_AST', message: 'AST heuristic detected conditional view count inside ForEach; keep a constant number of views per element by moving branching into row views or modifiers.' },
   { platform: 'ios', pathCheck: isIOSApplicationOrPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftContainsUserFilterUsage, ruleId: 'heuristics.ios.contains-user-filter.ast', code: 'HEURISTICS_IOS_CONTAINS_USER_FILTER_AST', message: 'AST heuristic detected contains() in a user-facing filter where localizedStandardContains() may be preferred.' },
@@ -691,6 +692,7 @@ const textDetectorRegistry: ReadonlyArray<TextDetectorRegistryEntry> = [
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftUiImageDataDecodingUsage, ruleId: 'heuristics.ios.swiftui.image-data-decoding.ast', code: 'HEURISTICS_IOS_SWIFTUI_IMAGE_DATA_DECODING_AST', message: 'AST heuristic detected UIImage(data:) in SwiftUI presentation; downsample image data before rendering large images.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftUiInlineActionLogicUsage, ruleId: 'heuristics.ios.swiftui.inline-action-logic.ast', code: 'HEURISTICS_IOS_SWIFTUI_INLINE_ACTION_LOGIC_AST', message: 'AST heuristic detected inline logic inside a SwiftUI action handler; action handlers should reference methods and keep view declarations focused.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftNavigationViewUsage, ruleId: 'heuristics.ios.navigation-view.ast', code: 'HEURISTICS_IOS_NAVIGATION_VIEW_AST', message: 'AST heuristic detected NavigationView usage.' },
+  { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftUntypedNavigationLinkDestinationUsage, ruleId: 'heuristics.ios.swiftui.untyped-navigation-link-destination.ast', code: 'HEURISTICS_IOS_SWIFTUI_UNTYPED_NAVIGATION_LINK_DESTINATION_AST', message: 'AST heuristic detected untyped NavigationLink destination usage; prefer NavigationLink(value:) with navigationDestination(for:) for type-safe navigation.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftForegroundColorUsage, ruleId: 'heuristics.ios.foreground-color.ast', code: 'HEURISTICS_IOS_FOREGROUND_COLOR_AST', message: 'AST heuristic detected foregroundColor usage.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftCornerRadiusUsage, ruleId: 'heuristics.ios.corner-radius.ast', code: 'HEURISTICS_IOS_CORNER_RADIUS_AST', message: 'AST heuristic detected cornerRadius usage.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftTabItemUsage, ruleId: 'heuristics.ios.tab-item.ast', code: 'HEURISTICS_IOS_TAB_ITEM_AST', message: 'AST heuristic detected tabItem usage.' },

package/core/rules/presets/heuristics/ios.ts

@@ -785,6 +785,25 @@ export const iosRules: RuleSet = [
       code: 'HEURISTICS_IOS_FOREACH_INDICES_AST',
     },
   },
+  {
+    id: 'heuristics.ios.swiftui.foreach-self-identity.ast',
+    description: 'Detects SwiftUI ForEach usage with id: \.self instead of stable domain identity.',
+    severity: 'WARN',
+    platform: 'ios',
+    locked: true,
+    when: {
+      kind: 'Heuristic',
+      where: {
+        ruleId: 'heuristics.ios.swiftui.foreach-self-identity.ast',
+      },
+    },
+    then: {
+      kind: 'Finding',
+      message:
+        'AST heuristic detected ForEach(..., id: \.self) usage; prefer a stable domain identity such as id: \.id or Identifiable models.',
+      code: 'HEURISTICS_IOS_SWIFTUI_FOREACH_SELF_IDENTITY_AST',
+    },
+  },
   {
     id: 'heuristics.ios.swiftui.inline-foreach-transform.ast',
     description: 'Detects inline filter/map/sort transformations inside SwiftUI ForEach calls.',
@@ -1024,6 +1043,25 @@ export const iosRules: RuleSet = [
       code: 'HEURISTICS_IOS_NAVIGATION_VIEW_AST',
     },
   },
+  {
+    id: 'heuristics.ios.swiftui.untyped-navigation-link-destination.ast',
+    description: 'Detects untyped SwiftUI NavigationLink destination usage.',
+    severity: 'WARN',
+    platform: 'ios',
+    locked: true,
+    when: {
+      kind: 'Heuristic',
+      where: {
+        ruleId: 'heuristics.ios.swiftui.untyped-navigation-link-destination.ast',
+      },
+    },
+    then: {
+      kind: 'Finding',
+      message:
+        'AST heuristic detected untyped NavigationLink destination usage; prefer NavigationLink(value:) with navigationDestination(for:) for type-safe navigation.',
+      code: 'HEURISTICS_IOS_SWIFTUI_UNTYPED_NAVIGATION_LINK_DESTINATION_AST',
+    },
+  },
   {
     id: 'heuristics.ios.foreground-color.ast',
     description: 'Detects foregroundColor usage in modern SwiftUI code paths.',

package/integrations/config/skillsDetectorRegistry.ts

@@ -211,6 +211,10 @@ const registryByRuleId: Record<string, SkillsDetectorBinding> = {
   'skills.ios.no-navigation-view': heuristicDetector('ios.navigation-view', [
     'heuristics.ios.navigation-view.ast',
   ]),
+  'skills.ios.guideline.ios-swiftui-expert.use-navigationdestination-for-for-type-safe-navigation':
+    heuristicDetector('ios.swiftui.untyped-navigation-link-destination', [
+      'heuristics.ios.swiftui.untyped-navigation-link-destination.ast',
+    ]),
   'skills.ios.no-foreground-color': heuristicDetector('ios.foreground-color', [
     'heuristics.ios.foreground-color.ast',
   ]),
@@ -229,6 +233,14 @@ const registryByRuleId: Record<string, SkillsDetectorBinding> = {
   'skills.ios.no-foreach-indices': heuristicDetector('ios.foreach-indices', [
     'heuristics.ios.foreach-indices.ast',
   ]),
+  'skills.ios.guideline.ios-swiftui-expert.ensure-foreach-uses-stable-identity-see-references-list-patterns-md':
+    heuristicDetector('ios.swiftui.foreach-self-identity', [
+      'heuristics.ios.swiftui.foreach-self-identity.ast',
+    ]),
+  'skills.ios.guideline.ios-swiftui-expert.verify-list-patterns-use-stable-identity-see-references-list-patterns-':
+    heuristicDetector('ios.swiftui.foreach-self-identity', [
+      'heuristics.ios.swiftui.foreach-self-identity.ast',
+    ]),
   'skills.ios.guideline.ios-swiftui-expert.avoid-inline-filtering-in-foreach-prefilter-and-cache':
     heuristicDetector('ios.swiftui.inline-foreach-transform', [
       'heuristics.ios.swiftui.inline-foreach-transform.ast',

package/integrations/config/skillsMarkdownRules.ts

@@ -277,6 +277,13 @@ const normalizeKnownRuleTarget = (
     if (includes('navigationview') || includes('navigation view')) {
       return 'skills.ios.no-navigation-view';
     }
+    if (
+      includes('navigationdestination for') ||
+      (includes('navigationdestination') && includes('type safe navigation')) ||
+      (includes('navigationlink') && includes('value') && includes('navigationdestination'))
+    ) {
+      return 'skills.ios.guideline.ios-swiftui-expert.use-navigationdestination-for-for-type-safe-navigation';
+    }
     if (
       includes('foregroundstyle instead of foregroundcolor') ||
       includes('foregroundstyle over foregroundcolor') ||
@@ -309,6 +316,15 @@ const normalizeKnownRuleTarget = (
     ) {
       return 'skills.ios.no-foreach-indices';
     }
+    if (
+      (includes('foreach') && includes('stable identity')) ||
+      (includes('list patterns') && includes('stable identity'))
+    ) {
+      if (includes('verify list patterns')) {
+        return 'skills.ios.guideline.ios-swiftui-expert.verify-list-patterns-use-stable-identity-see-references-list-patterns-';
+      }
+      return 'skills.ios.guideline.ios-swiftui-expert.ensure-foreach-uses-stable-identity-see-references-list-patterns-md';
+    }
     if (
       (includes('inline filtering') && includes('foreach')) ||
       (includes('no inline filtering') && includes('foreach')) ||

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pumuki",
-  "version": "6.3.228",
+  "version": "6.3.230",
   "description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
   "main": "index.js",
   "bin": {

package/skills.lock.json

@@ -1,7 +1,7 @@
 {
   "version": "1.0",
   "compilerVersion": "1.0.0",
-  "generatedAt": "2026-05-13T16:36:55.011Z",
+  "generatedAt": "2026-05-13T16:49:25.074Z",
   "bundles": [
     {
       "name": "android-guidelines",
@@ -5764,8 +5764,20 @@
       "name": "ios-guidelines",
       "version": "1.0.0",
       "source": "file:vendor/skills/ios-enterprise-rules/SKILL.md",
-      "hash": "2d56094eff6a0b688d9f20ef6970de5945dfa74aaf3a3973dfee2091b9e98542",
+      "hash": "a70065766533e822f2139da42d7933b6f240634c93939ee60969e3fd009409ce",
       "rules": [
+        {
+          "id": "skills.ios.guideline.ios-swiftui-expert.use-navigationdestination-for-for-type-safe-navigation",
+          "description": "navigationDestination(for:) - Destinos tipados",
+          "severity": "WARN",
+          "platform": "ios",
+          "sourceSkill": "ios-guidelines",
+          "sourcePath": "vendor/skills/ios-enterprise-rules/SKILL.md",
+          "confidence": "MEDIUM",
+          "locked": true,
+          "evaluationMode": "AUTO",
+          "origin": "core"
+        },
         {
           "id": "skills.ios.guideline.ios-swiftui-expert.use-task-modifier-for-automatic-cancellation-of-async-work",
           "description": ".task/.task(id:) - Trabajos async con cancelación automática",
@@ -7051,30 +7063,6 @@
           "evaluationMode": "DECLARATIVE",
           "origin": "core"
         },
-        {
-          "id": "skills.ios.guideline.ios.navigationdestination-for-destinos-tipados",
-          "description": "navigationDestination(for:) - Destinos tipados",
-          "severity": "WARN",
-          "platform": "ios",
-          "sourceSkill": "ios-guidelines",
-          "sourcePath": "vendor/skills/ios-enterprise-rules/SKILL.md",
-          "confidence": "MEDIUM",
-          "locked": true,
-          "evaluationMode": "DECLARATIVE",
-          "origin": "core"
-        },
-        {
-          "id": "skills.ios.guideline.ios.navigationdestination-for-para-destinos",
-          "description": "NavigationDestination(for:) para destinos",
-          "severity": "WARN",
-          "platform": "ios",
-          "sourceSkill": "ios-guidelines",
-          "sourcePath": "vendor/skills/ios-enterprise-rules/SKILL.md",
-          "confidence": "MEDIUM",
-          "locked": true,
-          "evaluationMode": "DECLARATIVE",
-          "origin": "core"
-        },
         {
           "id": "skills.ios.guideline.ios.navigationstack-navigationpath-con-rutas-tipadas",
           "description": "NavigationStack + NavigationPath con rutas tipadas",
@@ -8632,7 +8620,7 @@
       "name": "ios-swiftui-expert-guidelines",
       "version": "1.0.0",
       "source": "file:vendor/skills/swiftui-expert-skill/SKILL.md",
-      "hash": "87916172b71811a09b147336b1625bce94571b1f9c66885bd136cfac27079b0d",
+      "hash": "71169779d2e497e74027e271cc9ada00eb269509218964df2a2ff798b9a63f93",
       "rules": [
         {
           "id": "skills.ios.guideline.ios-swiftui-expert.action-handlers-should-reference-methods-not-contain-inline-logic",
@@ -8703,7 +8691,7 @@
           "sourcePath": "vendor/skills/swiftui-expert-skill/SKILL.md",
           "confidence": "MEDIUM",
           "locked": true,
-          "evaluationMode": "DECLARATIVE",
+          "evaluationMode": "AUTO",
           "origin": "core"
         },
         {
@@ -8895,7 +8883,7 @@
           "sourcePath": "vendor/skills/swiftui-expert-skill/SKILL.md",
           "confidence": "MEDIUM",
           "locked": true,
-          "evaluationMode": "DECLARATIVE",
+          "evaluationMode": "AUTO",
           "origin": "core"
         },
         {
@@ -8991,7 +8979,7 @@
           "sourcePath": "vendor/skills/swiftui-expert-skill/SKILL.md",
           "confidence": "MEDIUM",
           "locked": true,
-          "evaluationMode": "DECLARATIVE",
+          "evaluationMode": "AUTO",
           "origin": "core"
         },
         {