pumuki 6.3.226 → 6.3.228

package/core/facts/detectors/text/ios.test.ts

@@ -36,8 +36,10 @@ import {
   hasSwiftLegacyXCTestImportUsage,
   hasSwiftModernizableXCTestSuiteUsage,
   hasSwiftNonLazyScrollForEachUsage,
+  hasSwiftUiForEachConditionalViewCountUsage,
   hasSwiftViewBodyObjectCreationUsage,
   hasSwiftUiImageDataDecodingUsage,
+  hasSwiftUiInlineActionLogicUsage,
   hasSwiftAssumeIsolatedUsage,
   hasSwiftCoreDataLayerLeakUsage,
   hasSwiftSwiftDataLayerLeakUsage,
@@ -164,6 +166,40 @@ struct FeedView: View {
   assert.equal(hasSwiftNonLazyScrollForEachUsage(safe), false);
 });
 
+test('hasSwiftUiForEachConditionalViewCountUsage detecta branching condicional dentro de ForEach', () => {
+  const source = `
+struct FeedView: View {
+  let items: [Item]
+
+  var body: some View {
+    ForEach(items) { item in
+      if item.isPromoted {
+        PromotedRow(item: item)
+      } else {
+        RegularRow(item: item)
+      }
+    }
+  }
+}
+`;
+  const safe = `
+struct FeedView: View {
+  let items: [Item]
+
+  var body: some View {
+    ForEach(items) { item in
+      FeedRow(item: item)
+    }
+    let sample = "ForEach(items) { item in if item.isPromoted { PromotedRow(item: item) } }"
+    // ForEach(items) { item in if item.isPromoted { PromotedRow(item: item) } }
+  }
+}
+`;
+
+  assert.equal(hasSwiftUiForEachConditionalViewCountUsage(source), true);
+  assert.equal(hasSwiftUiForEachConditionalViewCountUsage(safe), false);
+});
+
 test('hasSwiftViewBodyObjectCreationUsage detecta formatter creado en body y preserva dependencia externa', () => {
   const source = `
 struct PriceView: View {
@@ -220,6 +256,41 @@ struct AvatarView: View {
   assert.equal(hasSwiftUiImageDataDecodingUsage(safe), false);
 });
 
+test('hasSwiftUiInlineActionLogicUsage detecta lógica inline en Button y preserva método referenciado', () => {
+  const source = `
+struct CheckoutView: View {
+  @State private var isLoading = false
+
+  var body: some View {
+    Button {
+      if isLoading {
+        return
+      }
+      Task {
+        await submit()
+      }
+    } label: {
+      Text("Pay")
+    }
+  }
+}
+`;
+  const safe = `
+struct CheckoutView: View {
+  var body: some View {
+    Button(action: submit) {
+      Text("Pay")
+    }
+    let sample = "Button { if loading { return } } label:"
+    // Button { if loading { return } } label:
+  }
+}
+`;
+
+  assert.equal(hasSwiftUiInlineActionLogicUsage(source), true);
+  assert.equal(hasSwiftUiInlineActionLogicUsage(safe), false);
+});
+
 test('hasSwiftForceTryUsage detecta try! y descarta try?', () => {
   const positive = `
 func load() {

package/core/facts/detectors/text/ios.ts

@@ -388,6 +388,14 @@ export const hasSwiftNonLazyScrollForEachUsage = (source: string): boolean => {
   return nonLazyScrollableCollectionPattern.test(swiftSource);
 };
 
+export const hasSwiftUiForEachConditionalViewCountUsage = (source: string): boolean => {
+  const swiftSource = sanitizeSwiftSourceForMultilineRegex(source);
+  const conditionalForEachPattern =
+    /\bForEach\s*\([^)]*\)\s*\{[\s\S]{0,1600}\b(?:if|switch)\b[\s\S]{0,1600}\}/;
+
+  return conditionalForEachPattern.test(swiftSource);
+};
+
 export const hasSwiftViewBodyObjectCreationUsage = (source: string): boolean => {
   const swiftSource = sanitizeSwiftSourceForMultilineRegex(source);
   const viewBodyObjectCreationPattern =
@@ -401,6 +409,16 @@ export const hasSwiftUiImageDataDecodingUsage = (source: string): boolean => {
   return /\bUIImage\s*\(\s*data\s*:/.test(swiftSource);
 };
 
+export const hasSwiftUiInlineActionLogicUsage = (source: string): boolean => {
+  const swiftSource = sanitizeSwiftSourceForMultilineRegex(source);
+  const inlineButtonActionPattern =
+    /\bButton\s*\{[\s\S]{0,900}\b(?:if|guard|switch|for|while|Task)\b[\s\S]{0,900}\}\s*label\s*:/;
+  const inlineActionParameterPattern =
+    /\bButton\s*\([^)]*\baction\s*:\s*\{[\s\S]{0,900}\b(?:if|guard|switch|for|while|Task)\b[\s\S]{0,900}\}/;
+
+  return inlineButtonActionPattern.test(swiftSource) || inlineActionParameterPattern.test(swiftSource);
+};
+
 export const hasSwiftDispatchQueueUsage = (source: string): boolean => {
   return scanCodeLikeSource(source, ({ source: swiftSource, index, current }) => {
     if (current !== 'D' || !hasIdentifierAt(swiftSource, index, 'DispatchQueue')) {

package/core/facts/extractHeuristicFacts.ts

@@ -679,6 +679,7 @@ const textDetectorRegistry: ReadonlyArray<TextDetectorRegistryEntry> = [
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftPassedValueStateWrapperUsage, ruleId: 'heuristics.ios.passed-value-state-wrapper.ast', code: 'HEURISTICS_IOS_PASSED_VALUE_STATE_WRAPPER_AST', message: 'AST heuristic detected a passed value stored as @State/@StateObject via init wrapper ownership.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftForEachIndicesUsage, ruleId: 'heuristics.ios.foreach-indices.ast', code: 'HEURISTICS_IOS_FOREACH_INDICES_AST', message: 'AST heuristic detected ForEach(...indices...) usage where stable element identity may be preferred.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftInlineForEachTransformUsage, ruleId: 'heuristics.ios.swiftui.inline-foreach-transform.ast', code: 'HEURISTICS_IOS_SWIFTUI_INLINE_FOREACH_TRANSFORM_AST', message: 'AST heuristic detected inline filter/map/sort work inside ForEach; prefiltered or cached collections remain the preferred baseline.' },
+  { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftUiForEachConditionalViewCountUsage, ruleId: 'heuristics.ios.swiftui.foreach-conditional-view-count.ast', code: 'HEURISTICS_IOS_SWIFTUI_FOREACH_CONDITIONAL_VIEW_COUNT_AST', message: 'AST heuristic detected conditional view count inside ForEach; keep a constant number of views per element by moving branching into row views or modifiers.' },
   { platform: 'ios', pathCheck: isIOSApplicationOrPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftContainsUserFilterUsage, ruleId: 'heuristics.ios.contains-user-filter.ast', code: 'HEURISTICS_IOS_CONTAINS_USER_FILTER_AST', message: 'AST heuristic detected contains() in a user-facing filter where localizedStandardContains() may be preferred.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftGeometryReaderUsage, ruleId: 'heuristics.ios.geometryreader.ast', code: 'HEURISTICS_IOS_GEOMETRYREADER_AST', message: 'AST heuristic detected GeometryReader usage that may be replaceable with modern layout APIs.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftFontWeightBoldUsage, ruleId: 'heuristics.ios.font-weight-bold.ast', code: 'HEURISTICS_IOS_FONT_WEIGHT_BOLD_AST', message: 'AST heuristic detected fontWeight(.bold) usage where bold() may be preferred.' },
@@ -688,6 +689,7 @@ const textDetectorRegistry: ReadonlyArray<TextDetectorRegistryEntry> = [
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftNonLazyScrollForEachUsage, ruleId: 'heuristics.ios.swiftui.non-lazy-scroll-foreach.ast', code: 'HEURISTICS_IOS_SWIFTUI_NON_LAZY_SCROLL_FOREACH_AST', message: 'AST heuristic detected ScrollView with a non-lazy stack feeding ForEach; LazyVStack/LazyHStack remain the preferred baseline for large scrollable collections.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftViewBodyObjectCreationUsage, ruleId: 'heuristics.ios.swiftui.body-object-creation.ast', code: 'HEURISTICS_IOS_SWIFTUI_BODY_OBJECT_CREATION_AST', message: 'AST heuristic detected formatter object creation inside SwiftUI body; keep body simple and move expensive objects out of render paths.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftUiImageDataDecodingUsage, ruleId: 'heuristics.ios.swiftui.image-data-decoding.ast', code: 'HEURISTICS_IOS_SWIFTUI_IMAGE_DATA_DECODING_AST', message: 'AST heuristic detected UIImage(data:) in SwiftUI presentation; downsample image data before rendering large images.' },
+  { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftUiInlineActionLogicUsage, ruleId: 'heuristics.ios.swiftui.inline-action-logic.ast', code: 'HEURISTICS_IOS_SWIFTUI_INLINE_ACTION_LOGIC_AST', message: 'AST heuristic detected inline logic inside a SwiftUI action handler; action handlers should reference methods and keep view declarations focused.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftNavigationViewUsage, ruleId: 'heuristics.ios.navigation-view.ast', code: 'HEURISTICS_IOS_NAVIGATION_VIEW_AST', message: 'AST heuristic detected NavigationView usage.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftForegroundColorUsage, ruleId: 'heuristics.ios.foreground-color.ast', code: 'HEURISTICS_IOS_FOREGROUND_COLOR_AST', message: 'AST heuristic detected foregroundColor usage.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftCornerRadiusUsage, ruleId: 'heuristics.ios.corner-radius.ast', code: 'HEURISTICS_IOS_CORNER_RADIUS_AST', message: 'AST heuristic detected cornerRadius usage.' },

package/core/rules/presets/heuristics/ios.ts

@@ -803,6 +803,25 @@ export const iosRules: RuleSet = [
       code: 'HEURISTICS_IOS_SWIFTUI_INLINE_FOREACH_TRANSFORM_AST',
     },
   },
+  {
+    id: 'heuristics.ios.swiftui.foreach-conditional-view-count.ast',
+    description: 'Detects conditional view counts inside SwiftUI ForEach rows.',
+    severity: 'WARN',
+    platform: 'ios',
+    locked: true,
+    when: {
+      kind: 'Heuristic',
+      where: {
+        ruleId: 'heuristics.ios.swiftui.foreach-conditional-view-count.ast',
+      },
+    },
+    then: {
+      kind: 'Finding',
+      message:
+        'AST heuristic detected conditional view count inside ForEach; keep a constant number of views per element by moving branching into row views or modifiers.',
+      code: 'HEURISTICS_IOS_SWIFTUI_FOREACH_CONDITIONAL_VIEW_COUNT_AST',
+    },
+  },
   {
     id: 'heuristics.ios.contains-user-filter.ast',
     description: 'Detects contains() usage in user-facing filter flows where localizedStandardContains() may be preferred.',
@@ -968,6 +987,25 @@ export const iosRules: RuleSet = [
       code: 'HEURISTICS_IOS_SWIFTUI_IMAGE_DATA_DECODING_AST',
     },
   },
+  {
+    id: 'heuristics.ios.swiftui.inline-action-logic.ast',
+    description: 'Detects inline control-flow logic inside SwiftUI action handlers.',
+    severity: 'WARN',
+    platform: 'ios',
+    locked: true,
+    when: {
+      kind: 'Heuristic',
+      where: {
+        ruleId: 'heuristics.ios.swiftui.inline-action-logic.ast',
+      },
+    },
+    then: {
+      kind: 'Finding',
+      message:
+        'AST heuristic detected inline logic inside a SwiftUI action handler; action handlers should reference methods and keep view declarations focused.',
+      code: 'HEURISTICS_IOS_SWIFTUI_INLINE_ACTION_LOGIC_AST',
+    },
+  },
   {
     id: 'heuristics.ios.navigation-view.ast',
     description: 'Detects NavigationView usage in iOS production code.',

package/integrations/config/skillsDetectorRegistry.ts

@@ -233,6 +233,10 @@ const registryByRuleId: Record<string, SkillsDetectorBinding> = {
     heuristicDetector('ios.swiftui.inline-foreach-transform', [
       'heuristics.ios.swiftui.inline-foreach-transform.ast',
     ]),
+  'skills.ios.guideline.ios-swiftui-expert.ensure-constant-number-of-views-per-foreach-element':
+    heuristicDetector('ios.swiftui.foreach-conditional-view-count', [
+      'heuristics.ios.swiftui.foreach-conditional-view-count.ast',
+    ]),
   'skills.ios.no-contains-user-filter': heuristicDetector('ios.contains-user-filter', [
     'heuristics.ios.contains-user-filter.ast',
   ]),
@@ -266,6 +270,10 @@ const registryByRuleId: Record<string, SkillsDetectorBinding> = {
     heuristicDetector('ios.swiftui.image-data-decoding', [
       'heuristics.ios.swiftui.image-data-decoding.ast',
     ]),
+  'skills.ios.guideline.ios-swiftui-expert.action-handlers-should-reference-methods-not-contain-inline-logic':
+    heuristicDetector('ios.swiftui.inline-action-logic', [
+      'heuristics.ios.swiftui.inline-action-logic.ast',
+    ]),
   'skills.ios.no-scrollview-shows-indicators': heuristicDetector(
     'ios.scrollview-shows-indicators',
     ['heuristics.ios.scrollview-shows-indicators.ast']

package/integrations/config/skillsMarkdownRules.ts

@@ -16,7 +16,7 @@ const MARKDOWN_BOLD_PATTERN = /[*_]{1,3}/g;
 const MULTISPACE_PATTERN = /\s+/g;
 const AST_NODE_ID_PATTERN = /\bheuristics\.[a-z0-9._-]+\.ast\b/gi;
 const RULE_KEYWORDS =
-  /\b(always|siempre|prefer|use|usar|avoid|evitar|never|nunca|must|obligatorio|required|disallow|do not|no|suggest)\b/i;
+  /\b(always|siempre|prefer|use|usar|avoid|evitar|ensure|never|nunca|must|obligatorio|required|disallow|do not|no|suggest|should)\b/i;
 
 const normalizeForLookup = (value: string): string => {
   return value
@@ -316,6 +316,12 @@ const normalizeKnownRuleTarget = (
     ) {
       return 'skills.ios.guideline.ios-swiftui-expert.avoid-inline-filtering-in-foreach-prefilter-and-cache';
     }
+    if (
+      includes('constant number of views per foreach element') ||
+      (includes('foreach') && includes('constant number of views'))
+    ) {
+      return 'skills.ios.guideline.ios-swiftui-expert.ensure-constant-number-of-views-per-foreach-element';
+    }
     if (
       includes('localizedstandardcontains') ||
       includes('localized standard contains') ||
@@ -381,6 +387,13 @@ const normalizeKnownRuleTarget = (
     ) {
       return 'skills.ios.guideline.ios-swiftui-expert.suggest-image-downsampling-when-uiimage-data-is-encountered';
     }
+    if (
+      (includes('action handlers') && includes('reference methods')) ||
+      (includes('action handlers') && includes('inline logic')) ||
+      (includes('handlers should reference methods') && includes('inline logic'))
+    ) {
+      return 'skills.ios.guideline.ios-swiftui-expert.action-handlers-should-reference-methods-not-contain-inline-logic';
+    }
     if (
       includes('scrollindicators hidden') ||
       includes('scroll indicators hidden') ||

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pumuki",
-  "version": "6.3.226",
+  "version": "6.3.228",
   "description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
   "main": "index.js",
   "bin": {

package/skills.lock.json

@@ -1,7 +1,7 @@
 {
   "version": "1.0",
   "compilerVersion": "1.0.0",
-  "generatedAt": "2026-05-13T16:23:26.589Z",
+  "generatedAt": "2026-05-13T16:36:55.011Z",
   "bundles": [
     {
       "name": "android-guidelines",
@@ -8632,8 +8632,20 @@
       "name": "ios-swiftui-expert-guidelines",
       "version": "1.0.0",
       "source": "file:vendor/skills/swiftui-expert-skill/SKILL.md",
-      "hash": "10b8966d8204f1abb91af3254cfb809bf0a3822b8d09347c28639d23e6dfc1c7",
+      "hash": "87916172b71811a09b147336b1625bce94571b1f9c66885bd136cfac27079b0d",
       "rules": [
+        {
+          "id": "skills.ios.guideline.ios-swiftui-expert.action-handlers-should-reference-methods-not-contain-inline-logic",
+          "description": "Action handlers should reference methods, not contain inline logic",
+          "severity": "WARN",
+          "platform": "ios",
+          "sourceSkill": "ios-swiftui-expert-guidelines",
+          "sourcePath": "vendor/skills/swiftui-expert-skill/SKILL.md",
+          "confidence": "MEDIUM",
+          "locked": true,
+          "evaluationMode": "AUTO",
+          "origin": "core"
+        },
         {
           "id": "skills.ios.guideline.ios-swiftui-expert.always-mark-state-and-stateobject-as-private-makes-dependencies-clear",
           "description": "Always mark @State and @StateObject as private (makes dependencies clear)",
@@ -8670,6 +8682,30 @@
           "evaluationMode": "AUTO",
           "origin": "core"
         },
+        {
+          "id": "skills.ios.guideline.ios-swiftui-expert.ensure-constant-number-of-views-per-foreach-element",
+          "description": "Ensure constant number of views per ForEach element",
+          "severity": "WARN",
+          "platform": "ios",
+          "sourceSkill": "ios-swiftui-expert-guidelines",
+          "sourcePath": "vendor/skills/swiftui-expert-skill/SKILL.md",
+          "confidence": "MEDIUM",
+          "locked": true,
+          "evaluationMode": "AUTO",
+          "origin": "core"
+        },
+        {
+          "id": "skills.ios.guideline.ios-swiftui-expert.ensure-foreach-uses-stable-identity-see-references-list-patterns-md",
+          "description": "Ensure ForEach uses stable identity (see references/list-patterns.md)",
+          "severity": "WARN",
+          "platform": "ios",
+          "sourceSkill": "ios-swiftui-expert-guidelines",
+          "sourcePath": "vendor/skills/swiftui-expert-skill/SKILL.md",
+          "confidence": "MEDIUM",
+          "locked": true,
+          "evaluationMode": "DECLARATIVE",
+          "origin": "core"
+        },
         {
           "id": "skills.ios.guideline.ios-swiftui-expert.keep-view-body-simple-and-pure-no-side-effects-or-complex-logic",
           "description": "Keep view body simple and pure (no side effects or complex logic)",
@@ -8742,6 +8778,18 @@
           "evaluationMode": "DECLARATIVE",
           "origin": "core"
         },
+        {
+          "id": "skills.ios.guideline.ios-swiftui-expert.sheets-should-own-their-actions-and-call-dismiss-internally",
+          "description": "Sheets should own their actions and call dismiss() internally",
+          "severity": "WARN",
+          "platform": "ios",
+          "sourceSkill": "ios-swiftui-expert-guidelines",
+          "sourcePath": "vendor/skills/swiftui-expert-skill/SKILL.md",
+          "confidence": "MEDIUM",
+          "locked": true,
+          "evaluationMode": "DECLARATIVE",
+          "origin": "core"
+        },
         {
           "id": "skills.ios.guideline.ios-swiftui-expert.suggest-image-downsampling-when-uiimage-data-is-encountered",
           "description": "Suggest image downsampling when UIImage(data:) is used (as optional optimization, see references/image-optimization.md)",
@@ -8946,6 +8994,18 @@
           "evaluationMode": "DECLARATIVE",
           "origin": "core"
         },
+        {
+          "id": "skills.ios.guideline.ios-swiftui-expert.views-should-work-in-any-context-don-t-assume-screen-size-or-presentat",
+          "description": "Views should work in any context (don't assume screen size or presentation style)",
+          "severity": "WARN",
+          "platform": "ios",
+          "sourceSkill": "ios-swiftui-expert-guidelines",
+          "sourcePath": "vendor/skills/swiftui-expert-skill/SKILL.md",
+          "confidence": "MEDIUM",
+          "locked": true,
+          "evaluationMode": "DECLARATIVE",
+          "origin": "core"
+        },
         {
           "id": "skills.ios.no-anyview",
           "description": "Avoid AnyView in list rows",