pumuki 6.3.222 → 6.3.224

package/core/facts/detectors/text/ios.test.ts

@@ -35,6 +35,7 @@ import {
   hasSwiftMixedTestingFrameworksUsage,
   hasSwiftLegacyXCTestImportUsage,
   hasSwiftModernizableXCTestSuiteUsage,
+  hasSwiftNonLazyScrollForEachUsage,
   hasSwiftAssumeIsolatedUsage,
   hasSwiftCoreDataLayerLeakUsage,
   hasSwiftSwiftDataLayerLeakUsage,
@@ -63,6 +64,7 @@ import {
   hasSwiftJSONSerializationUsage,
   hasSwiftExplicitColorStaticMemberUsage,
   hasSwiftClosureBasedViewBuilderContentUsage,
+  hasSwiftRedundantReactiveStateAssignmentUsage,
   hasSwiftInlineForEachTransformUsage,
   hasSwiftStringFormatUsage,
   hasSwiftStrongDelegateReferenceUsage,
@@ -122,6 +124,44 @@ test('hasSwiftAnyViewUsage ignora comentarios, strings y coincidencias parciales
   assert.equal(hasSwiftAnyViewUsage(source), false);
 });
 
+test('hasSwiftNonLazyScrollForEachUsage detecta ScrollView con stack no lazy y preserva LazyVStack', () => {
+  const source = `
+struct FeedView: View {
+  let items: [Item]
+
+  var body: some View {
+    ScrollView {
+      VStack(spacing: 12) {
+        ForEach(items) { item in
+          FeedRow(item: item)
+        }
+      }
+    }
+  }
+}
+`;
+  const safe = `
+struct FeedView: View {
+  let items: [Item]
+
+  var body: some View {
+    ScrollView {
+      LazyVStack(spacing: 12) {
+        ForEach(items) { item in
+          FeedRow(item: item)
+        }
+      }
+    }
+    let sample = "ScrollView { VStack { ForEach(items) } }"
+    // ScrollView { VStack { ForEach(items) } }
+  }
+}
+`;
+
+  assert.equal(hasSwiftNonLazyScrollForEachUsage(source), true);
+  assert.equal(hasSwiftNonLazyScrollForEachUsage(safe), false);
+});
+
 test('hasSwiftForceTryUsage detecta try! y descarta try?', () => {
   const positive = `
 func load() {
@@ -737,6 +777,9 @@ GeometryReader { proxy in
 Text("Headline").fontWeight(.bold)
 Text("State").foregroundStyle(Color.green)
 let content: () -> Content
+.onChange(of: query) { newValue in
+  query = newValue
+}
 let filtered = items.filter { $0.title.contains(searchText) }
 ForEach(items.indices, id: \\.self) { index in
   Text(items[index].title)
@@ -785,6 +828,7 @@ MainActor.assumeIsolated { reload() }
   assert.equal(hasSwiftFontWeightBoldUsage(source), true);
   assert.equal(hasSwiftExplicitColorStaticMemberUsage(source), true);
   assert.equal(hasSwiftClosureBasedViewBuilderContentUsage(source), true);
+  assert.equal(hasSwiftRedundantReactiveStateAssignmentUsage(source), true);
   assert.equal(hasSwiftObservableObjectUsage(source), true);
   assert.equal(hasSwiftLegacySwiftUiObservableWrapperUsage(source), true);
   assert.equal(hasSwiftNavigationViewUsage(source), true);
@@ -826,6 +870,7 @@ let t = "MainActor.assumeIsolated { reload() }"
 let u = "ForEach(items.filter { $0.isVisible }) { item in }"
 let v = "Color.green"
 let w = "let content: () -> Content"
+let x = ".onChange(of: query) { newValue in query = newValue }"
 `;
   assert.equal(hasSwiftPreconcurrencyUsage(source), false);
   assert.equal(hasSwiftNonisolatedUnsafeUsage(source), false);
@@ -837,6 +882,7 @@ let w = "let content: () -> Content"
   assert.equal(hasSwiftFontWeightBoldUsage(source), false);
   assert.equal(hasSwiftExplicitColorStaticMemberUsage(source), false);
   assert.equal(hasSwiftClosureBasedViewBuilderContentUsage(source), false);
+  assert.equal(hasSwiftRedundantReactiveStateAssignmentUsage(source), false);
   assert.equal(hasSwiftTaskDetachedUsage(source), false);
   assert.equal(hasSwiftNavigationViewUsage(source), false);
   assert.equal(hasSwiftForegroundColorUsage(source), false);
@@ -891,6 +937,7 @@ ScrollView {
   assert.equal(hasSwiftFontWeightBoldUsage(source), false);
   assert.equal(hasSwiftExplicitColorStaticMemberUsage(source), false);
   assert.equal(hasSwiftClosureBasedViewBuilderContentUsage(source), false);
+  assert.equal(hasSwiftRedundantReactiveStateAssignmentUsage(source), false);
   assert.equal(hasSwiftForegroundColorUsage(source), false);
   assert.equal(hasSwiftCornerRadiusUsage(source), false);
   assert.equal(hasSwiftTabItemUsage(source), false);
@@ -946,6 +993,47 @@ let ignored = "let content: () -> Content"
   assert.equal(hasSwiftClosureBasedViewBuilderContentUsage(safe), false);
 });
 
+test('hasSwiftRedundantReactiveStateAssignmentUsage detecta asignaciones reactivas redundantes y preserva guard de cambio', () => {
+  const source = `
+struct SearchView: View {
+  @State private var query = ""
+
+  var body: some View {
+    TextField("Search", text: $query)
+      .onChange(of: query) { newValue in
+        query = newValue
+      }
+      .onReceive(model.$value) { value in
+        self.query = value
+      }
+  }
+}
+`;
+  const safe = `
+struct SearchView: View {
+  @State private var query = ""
+
+  var body: some View {
+    TextField("Search", text: $query)
+      .onChange(of: query) { newValue in
+        if query != newValue {
+          query = newValue
+        }
+      }
+      .onReceive(model.$value) { value in
+        guard self.query != value else { return }
+        self.query = value
+      }
+  }
+}
+let ignored = ".onChange(of: query) { newValue in query = newValue }"
+// .onReceive(model.$value) { value in query = value }
+`;
+
+  assert.equal(hasSwiftRedundantReactiveStateAssignmentUsage(source), true);
+  assert.equal(hasSwiftRedundantReactiveStateAssignmentUsage(safe), false);
+});
+
 test('hasSwiftLegacyXCTestImportUsage detecta XCTest unitario y excluye UI/performance', () => {
   const unitTest = `
 import XCTest

package/core/facts/detectors/text/ios.ts

@@ -380,6 +380,14 @@ export const hasSwiftAnyViewUsage = (source: string): boolean => {
   });
 };
 
+export const hasSwiftNonLazyScrollForEachUsage = (source: string): boolean => {
+  const swiftSource = sanitizeSwiftSourceForMultilineRegex(source);
+  const nonLazyScrollableCollectionPattern =
+    /\bScrollView\s*(?:\([^)]*\))?\s*\{[\s\S]{0,2000}\b(?:VStack|HStack)\s*(?:\([^)]*\))?\s*\{[\s\S]{0,1200}\bForEach\s*\(/;
+
+  return nonLazyScrollableCollectionPattern.test(swiftSource);
+};
+
 export const hasSwiftDispatchQueueUsage = (source: string): boolean => {
   return scanCodeLikeSource(source, ({ source: swiftSource, index, current }) => {
     if (current !== 'D' || !hasIdentifierAt(swiftSource, index, 'DispatchQueue')) {
@@ -877,6 +885,28 @@ export const hasSwiftClosureBasedViewBuilderContentUsage = (source: string): boo
   );
 };
 
+export const hasSwiftRedundantReactiveStateAssignmentUsage = (source: string): boolean => {
+  const sanitized = sanitizeSwiftSourceForMultilineRegex(source);
+  const reactiveAssignmentPattern =
+    /\.(?:onChange|onReceive)\s*\([^)]*\)\s*\{[\s\S]{0,500}?\b(?:self\s*\.\s*)?([A-Za-z_][A-Za-z0-9_]*)\s*=\s*(?:newValue|value|output|receivedValue)\b/g;
+
+  for (const match of sanitized.matchAll(reactiveAssignmentPattern)) {
+    const target = match[1];
+    const segment = match[0] ?? '';
+    if (!target) {
+      continue;
+    }
+    const guardedAssignmentPattern = new RegExp(
+      `\\b(?:if|guard)\\s+(?:self\\s*\\.\\s*)?${target}\\s*!=\\s*(?:newValue|value|output|receivedValue)\\b`
+    );
+    if (!guardedAssignmentPattern.test(segment)) {
+      return true;
+    }
+  }
+
+  return false;
+};
+
 export const hasSwiftLegacySwiftUiObservableWrapperUsage = (source: string): boolean => {
   return hasSwiftSanitizedRegexMatch(source, /@\s*(?:StateObject|ObservedObject)\b/);
 };

package/core/facts/extractHeuristicFacts.ts

@@ -684,6 +684,8 @@ const textDetectorRegistry: ReadonlyArray<TextDetectorRegistryEntry> = [
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftFontWeightBoldUsage, ruleId: 'heuristics.ios.font-weight-bold.ast', code: 'HEURISTICS_IOS_FONT_WEIGHT_BOLD_AST', message: 'AST heuristic detected fontWeight(.bold) usage where bold() may be preferred.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftExplicitColorStaticMemberUsage, ruleId: 'heuristics.ios.swiftui.explicit-color-static-member.ast', code: 'HEURISTICS_IOS_SWIFTUI_EXPLICIT_COLOR_STATIC_MEMBER_AST', message: 'AST heuristic detected Color.* static member usage where SwiftUI static member lookup may be preferred.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftClosureBasedViewBuilderContentUsage, ruleId: 'heuristics.ios.swiftui.closure-based-viewbuilder-content.ast', code: 'HEURISTICS_IOS_SWIFTUI_CLOSURE_BASED_VIEWBUILDER_CONTENT_AST', message: 'AST heuristic detected closure-based content storage; @ViewBuilder let content: Content remains the preferred SwiftUI container baseline.' },
+  { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftRedundantReactiveStateAssignmentUsage, ruleId: 'heuristics.ios.swiftui.redundant-reactive-state-assignment.ast', code: 'HEURISTICS_IOS_SWIFTUI_REDUNDANT_REACTIVE_STATE_ASSIGNMENT_AST', message: 'AST heuristic detected reactive state assignment without a value-change guard; check for value changes before assigning state in hot paths.' },
+  { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftNonLazyScrollForEachUsage, ruleId: 'heuristics.ios.swiftui.non-lazy-scroll-foreach.ast', code: 'HEURISTICS_IOS_SWIFTUI_NON_LAZY_SCROLL_FOREACH_AST', message: 'AST heuristic detected ScrollView with a non-lazy stack feeding ForEach; LazyVStack/LazyHStack remain the preferred baseline for large scrollable collections.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftNavigationViewUsage, ruleId: 'heuristics.ios.navigation-view.ast', code: 'HEURISTICS_IOS_NAVIGATION_VIEW_AST', message: 'AST heuristic detected NavigationView usage.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftForegroundColorUsage, ruleId: 'heuristics.ios.foreground-color.ast', code: 'HEURISTICS_IOS_FOREGROUND_COLOR_AST', message: 'AST heuristic detected foregroundColor usage.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftCornerRadiusUsage, ruleId: 'heuristics.ios.corner-radius.ast', code: 'HEURISTICS_IOS_CORNER_RADIUS_AST', message: 'AST heuristic detected cornerRadius usage.' },

package/core/rules/presets/heuristics/ios.ts

@@ -893,6 +893,43 @@ export const iosRules: RuleSet = [
       code: 'HEURISTICS_IOS_SWIFTUI_CLOSURE_BASED_VIEWBUILDER_CONTENT_AST',
     },
   },
+  {
+    id: 'heuristics.ios.swiftui.redundant-reactive-state-assignment.ast',
+    description: 'Detects onChange/onReceive state assignments without a value-change guard.',
+    severity: 'WARN',
+    platform: 'ios',
+    locked: true,
+    when: {
+      kind: 'Heuristic',
+      where: {
+        ruleId: 'heuristics.ios.swiftui.redundant-reactive-state-assignment.ast',
+      },
+    },
+    then: {
+      kind: 'Finding',
+      message: 'AST heuristic detected reactive state assignment without a value-change guard; check for value changes before assigning state in hot paths.',
+      code: 'HEURISTICS_IOS_SWIFTUI_REDUNDANT_REACTIVE_STATE_ASSIGNMENT_AST',
+    },
+  },
+  {
+    id: 'heuristics.ios.swiftui.non-lazy-scroll-foreach.ast',
+    description: 'Detects ScrollView content backed by non-lazy stacks and ForEach.',
+    severity: 'WARN',
+    platform: 'ios',
+    locked: true,
+    when: {
+      kind: 'Heuristic',
+      where: {
+        ruleId: 'heuristics.ios.swiftui.non-lazy-scroll-foreach.ast',
+      },
+    },
+    then: {
+      kind: 'Finding',
+      message:
+        'AST heuristic detected ScrollView with a non-lazy stack feeding ForEach; LazyVStack/LazyHStack remain the preferred baseline for large scrollable collections.',
+      code: 'HEURISTICS_IOS_SWIFTUI_NON_LAZY_SCROLL_FOREACH_AST',
+    },
+  },
   {
     id: 'heuristics.ios.navigation-view.ast',
     description: 'Detects NavigationView usage in iOS production code.',

package/integrations/config/skillsDetectorRegistry.ts

@@ -250,6 +250,14 @@ const registryByRuleId: Record<string, SkillsDetectorBinding> = {
     heuristicDetector('ios.swiftui.closure-based-viewbuilder-content', [
       'heuristics.ios.swiftui.closure-based-viewbuilder-content.ast',
     ]),
+  'skills.ios.guideline.ios-swiftui-expert.avoid-redundant-state-updates-in-onreceive-onchange-scroll-handlers':
+    heuristicDetector('ios.swiftui.redundant-reactive-state-assignment', [
+      'heuristics.ios.swiftui.redundant-reactive-state-assignment.ast',
+    ]),
+  'skills.ios.guideline.ios-swiftui-expert.use-lazyvstack-lazyhstack-for-large-lists':
+    heuristicDetector('ios.swiftui.non-lazy-scroll-foreach', [
+      'heuristics.ios.swiftui.non-lazy-scroll-foreach.ast',
+    ]),
   'skills.ios.no-scrollview-shows-indicators': heuristicDetector(
     'ios.scrollview-shows-indicators',
     ['heuristics.ios.scrollview-shows-indicators.ast']

package/integrations/config/skillsMarkdownRules.ts

@@ -353,6 +353,20 @@ const normalizeKnownRuleTarget = (
     ) {
       return 'skills.ios.guideline.ios-swiftui-expert.prefer-viewbuilder-let-content-content-over-closure-based-content-prop';
     }
+    if (
+      includes('redundant state updates') ||
+      (includes('onreceive') && includes('onchange') && includes('state updates')) ||
+      (includes('check for value changes') && includes('assigning state'))
+    ) {
+      return 'skills.ios.guideline.ios-swiftui-expert.avoid-redundant-state-updates-in-onreceive-onchange-scroll-handlers';
+    }
+    if (
+      (includes('lazyvstack') && includes('lazyhstack') && includes('large lists')) ||
+      (includes('lazyvstack') && includes('foreach') && includes('scrollview')) ||
+      (includes('lazyhstack') && includes('foreach') && includes('scrollview'))
+    ) {
+      return 'skills.ios.guideline.ios-swiftui-expert.use-lazyvstack-lazyhstack-for-large-lists';
+    }
     if (
       includes('scrollindicators hidden') ||
       includes('scroll indicators hidden') ||

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pumuki",
-  "version": "6.3.222",
+  "version": "6.3.224",
   "description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
   "main": "index.js",
   "bin": {

package/skills.lock.json

@@ -1,7 +1,7 @@
 {
   "version": "1.0",
   "compilerVersion": "1.0.0",
-  "generatedAt": "2026-05-13T16:04:37.359Z",
+  "generatedAt": "2026-05-13T16:15:52.668Z",
   "bundles": [
     {
       "name": "android-guidelines",
@@ -8632,7 +8632,7 @@
       "name": "ios-swiftui-expert-guidelines",
       "version": "1.0.0",
       "source": "file:vendor/skills/swiftui-expert-skill/SKILL.md",
-      "hash": "938525eec7fea70ecba6c27711800036b964e4b668f80b177cc918cb268e08c5",
+      "hash": "2acbd66e86e9e809f0c4bdb5d215618096f5773e359085e3a4dc707b83c1ebb1",
       "rules": [
         {
           "id": "skills.ios.guideline.ios-swiftui-expert.always-mark-state-and-stateobject-as-private-makes-dependencies-clear",
@@ -8667,7 +8667,7 @@
           "sourcePath": "vendor/skills/swiftui-expert-skill/SKILL.md",
           "confidence": "MEDIUM",
           "locked": true,
-          "evaluationMode": "DECLARATIVE",
+          "evaluationMode": "AUTO",
           "origin": "core"
         },
         {
@@ -8787,7 +8787,7 @@
           "sourcePath": "vendor/skills/swiftui-expert-skill/SKILL.md",
           "confidence": "MEDIUM",
           "locked": true,
-          "evaluationMode": "DECLARATIVE",
+          "evaluationMode": "AUTO",
           "origin": "core"
         },
         {