pumuki 6.3.218 → 6.3.220

package/core/facts/detectors/text/ios.test.ts

@@ -43,6 +43,7 @@ import {
   hasSwiftNSManagedObjectBoundaryUsage,
   hasSwiftNSManagedObjectStateLeakUsage,
   hasSwiftNavigationViewUsage,
+  hasSwiftNonPrivateStateOwnershipUsage,
   hasSwiftNonIBOutletImplicitlyUnwrappedOptionalUsage,
   hasSwiftObservableObjectUsage,
   hasSwiftOnAppearTaskUsage,
@@ -60,6 +61,7 @@ import {
   hasSwiftSensitiveUserDefaultsStorageUsage,
   hasSwiftInsecureTransportUsage,
   hasSwiftJSONSerializationUsage,
+  hasSwiftInlineForEachTransformUsage,
   hasSwiftStringFormatUsage,
   hasSwiftStrongDelegateReferenceUsage,
   hasSwiftStrongSelfEscapingClosureUsage,
@@ -735,6 +737,9 @@ let filtered = items.filter { $0.title.contains(searchText) }
 ForEach(items.indices, id: \\.self) { index in
   Text(items[index].title)
 }
+ForEach(items.filter { $0.isVisible }) { item in
+  Text(item.title)
+}
 Text("Primary").foregroundColor(.blue)
 Image("hero").cornerRadius(12)
 TabView {
@@ -770,6 +775,7 @@ MainActor.assumeIsolated { reload() }
   assert.equal(hasSwiftNonisolatedUnsafeUsage(source), true);
   assert.equal(hasSwiftAssumeIsolatedUsage(source), true);
   assert.equal(hasSwiftForEachIndicesUsage(source), true);
+  assert.equal(hasSwiftInlineForEachTransformUsage(source), true);
   assert.equal(hasSwiftContainsUserFilterUsage(source), true);
   assert.equal(hasSwiftGeometryReaderUsage(source), true);
   assert.equal(hasSwiftFontWeightBoldUsage(source), true);
@@ -811,11 +817,13 @@ let q = ".fontWeight(.bold)"
 let r = "@preconcurrency import LegacyFramework"
 let s = "nonisolated(unsafe) static var sharedBridge: Model?"
 let t = "MainActor.assumeIsolated { reload() }"
+let u = "ForEach(items.filter { $0.isVisible }) { item in }"
 `;
   assert.equal(hasSwiftPreconcurrencyUsage(source), false);
   assert.equal(hasSwiftNonisolatedUnsafeUsage(source), false);
   assert.equal(hasSwiftAssumeIsolatedUsage(source), false);
   assert.equal(hasSwiftForEachIndicesUsage(source), false);
+  assert.equal(hasSwiftInlineForEachTransformUsage(source), false);
   assert.equal(hasSwiftContainsUserFilterUsage(source), false);
   assert.equal(hasSwiftGeometryReaderUsage(source), false);
   assert.equal(hasSwiftFontWeightBoldUsage(source), false);
@@ -928,6 +936,65 @@ struct ContentView: View {
   assert.equal(hasSwiftLegacySwiftUiObservableWrapperUsage(modernWrapper), false);
 });
 
+test('hasSwiftNonPrivateStateOwnershipUsage detecta @State y @StateObject no privados', () => {
+  const source = `
+struct DashboardView: View {
+  @State var query = ""
+  @StateObject var viewModel = DashboardViewModel()
+}
+`;
+  const safe = `
+struct DashboardView: View {
+  @State private var query = ""
+  @StateObject private var viewModel = DashboardViewModel()
+  let text = "@State var query = \\"\\""
+  // @State var query = ""
+}
+`;
+
+  assert.equal(hasSwiftNonPrivateStateOwnershipUsage(source), true);
+  assert.equal(hasSwiftNonPrivateStateOwnershipUsage(safe), false);
+});
+
+test('hasSwiftInlineForEachTransformUsage detecta transformaciones inline y preserva colecciones precomputadas', () => {
+  const source = `
+struct FeedView: View {
+  var body: some View {
+    List {
+      ForEach(items.filter { $0.isVisible }) { item in
+        Text(item.title)
+      }
+      ForEach(Array(sections.sorted(by: { $0.title < $1.title }))) { section in
+        Text(section.title)
+      }
+    }
+  }
+}
+`;
+  const safe = `
+struct FeedView: View {
+  let filteredItems: [Item]
+  let sortedSections: [Section]
+
+  var body: some View {
+    List {
+      ForEach(filteredItems) { item in
+        Text(item.title)
+      }
+      ForEach(sortedSections) { section in
+        Text(section.title)
+      }
+    }
+  }
+}
+let ignored = "ForEach(items.filter { $0.isVisible }) { item in }"
+// ForEach(items.filter { $0.isVisible }) { item in }
+`;
+
+  assert.equal(hasSwiftInlineForEachTransformUsage(source), true);
+  assert.equal(hasSwiftInlineForEachTransformUsage(safe), false);
+});
+
 test('hasSwiftPassedValueStateWrapperUsage detecta valores inyectados guardados como @State o @StateObject', () => {
   const invalidOwnership = `
 struct DetailView: View {

package/core/facts/detectors/text/ios.ts

@@ -810,6 +810,13 @@ export const hasSwiftForEachIndicesUsage = (source: string): boolean => {
   );
 };
 
+export const hasSwiftInlineForEachTransformUsage = (source: string): boolean => {
+  const sanitized = sanitizeSwiftSourceForMultilineRegex(source);
+  return /\bForEach\s*\(\s*(?:Array\s*\(\s*)?[A-Za-z_][A-Za-z0-9_]*(?:\.[A-Za-z_][A-Za-z0-9_]*)*\s*\.\s*(?:filter|map|compactMap|sorted)\s*(?:\{|\()/g.test(
+    sanitized
+  );
+};
+
 const isUserSearchIdentifier = (value: string): boolean => {
   return /^(?:query|search(?:Text|Term|Query|Value)?|filter(?:Text|Value)?|text|term|input)$/i.test(
     value
@@ -860,6 +867,17 @@ export const hasSwiftLegacySwiftUiObservableWrapperUsage = (source: string): boo
   return hasSwiftSanitizedRegexMatch(source, /@\s*(?:StateObject|ObservedObject)\b/);
 };
 
+export const hasSwiftNonPrivateStateOwnershipUsage = (source: string): boolean => {
+  return source.split(/\r?\n/).some((line) => {
+    const sanitizedLine = stripSwiftLineForSemanticScan(line);
+    return (
+      /@\s*(?:State|StateObject)\b/.test(sanitizedLine) &&
+      /\bvar\b/.test(sanitizedLine) &&
+      !/\bprivate\b/.test(sanitizedLine)
+    );
+  });
+};
+
 const hasSwiftPassedValueWrapperInitialization = (
   source: string,
   options: {

package/core/facts/extractHeuristicFacts.ts

@@ -675,8 +675,10 @@ const textDetectorRegistry: ReadonlyArray<TextDetectorRegistryEntry> = [
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftAssumeIsolatedUsage, ruleId: 'heuristics.ios.assume-isolated.ast', code: 'HEURISTICS_IOS_ASSUME_ISOLATED_AST', message: 'AST heuristic detected assumeIsolated usage.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftObservableObjectUsage, ruleId: 'heuristics.ios.observable-object.ast', code: 'HEURISTICS_IOS_OBSERVABLE_OBJECT_AST', message: 'AST heuristic detected ObservableObject usage.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftLegacySwiftUiObservableWrapperUsage, ruleId: 'heuristics.ios.legacy-swiftui-observable-wrapper.ast', code: 'HEURISTICS_IOS_LEGACY_SWIFTUI_OBSERVABLE_WRAPPER_AST', message: 'AST heuristic detected @StateObject/@ObservedObject usage in a modern SwiftUI path.' },
+  { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftNonPrivateStateOwnershipUsage, ruleId: 'heuristics.ios.swiftui.non-private-state-ownership.ast', code: 'HEURISTICS_IOS_SWIFTUI_NON_PRIVATE_STATE_OWNERSHIP_AST', message: 'AST heuristic detected @State/@StateObject without private visibility; SwiftUI owned state should be private.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftPassedValueStateWrapperUsage, ruleId: 'heuristics.ios.passed-value-state-wrapper.ast', code: 'HEURISTICS_IOS_PASSED_VALUE_STATE_WRAPPER_AST', message: 'AST heuristic detected a passed value stored as @State/@StateObject via init wrapper ownership.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftForEachIndicesUsage, ruleId: 'heuristics.ios.foreach-indices.ast', code: 'HEURISTICS_IOS_FOREACH_INDICES_AST', message: 'AST heuristic detected ForEach(...indices...) usage where stable element identity may be preferred.' },
+  { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftInlineForEachTransformUsage, ruleId: 'heuristics.ios.swiftui.inline-foreach-transform.ast', code: 'HEURISTICS_IOS_SWIFTUI_INLINE_FOREACH_TRANSFORM_AST', message: 'AST heuristic detected inline filter/map/sort work inside ForEach; prefiltered or cached collections remain the preferred baseline.' },
   { platform: 'ios', pathCheck: isIOSApplicationOrPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftContainsUserFilterUsage, ruleId: 'heuristics.ios.contains-user-filter.ast', code: 'HEURISTICS_IOS_CONTAINS_USER_FILTER_AST', message: 'AST heuristic detected contains() in a user-facing filter where localizedStandardContains() may be preferred.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftGeometryReaderUsage, ruleId: 'heuristics.ios.geometryreader.ast', code: 'HEURISTICS_IOS_GEOMETRYREADER_AST', message: 'AST heuristic detected GeometryReader usage that may be replaceable with modern layout APIs.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftFontWeightBoldUsage, ruleId: 'heuristics.ios.font-weight-bold.ast', code: 'HEURISTICS_IOS_FONT_WEIGHT_BOLD_AST', message: 'AST heuristic detected fontWeight(.bold) usage where bold() may be preferred.' },

package/core/rules/presets/heuristics/ios.ts

@@ -730,6 +730,25 @@ export const iosRules: RuleSet = [
       code: 'HEURISTICS_IOS_LEGACY_SWIFTUI_OBSERVABLE_WRAPPER_AST',
     },
   },
+  {
+    id: 'heuristics.ios.swiftui.non-private-state-ownership.ast',
+    description: 'Detects @State/@StateObject declarations without private visibility in SwiftUI presentation code.',
+    severity: 'WARN',
+    platform: 'ios',
+    locked: true,
+    when: {
+      kind: 'Heuristic',
+      where: {
+        ruleId: 'heuristics.ios.swiftui.non-private-state-ownership.ast',
+      },
+    },
+    then: {
+      kind: 'Finding',
+      message:
+        'AST heuristic detected @State/@StateObject without private visibility; SwiftUI owned state should be private.',
+      code: 'HEURISTICS_IOS_SWIFTUI_NON_PRIVATE_STATE_OWNERSHIP_AST',
+    },
+  },
   {
     id: 'heuristics.ios.passed-value-state-wrapper.ast',
     description: 'Detects passed values stored as @State or @StateObject through init ownership in SwiftUI production code.',
@@ -766,6 +785,24 @@ export const iosRules: RuleSet = [
       code: 'HEURISTICS_IOS_FOREACH_INDICES_AST',
     },
   },
+  {
+    id: 'heuristics.ios.swiftui.inline-foreach-transform.ast',
+    description: 'Detects inline filter/map/sort transformations inside SwiftUI ForEach calls.',
+    severity: 'WARN',
+    platform: 'ios',
+    locked: true,
+    when: {
+      kind: 'Heuristic',
+      where: {
+        ruleId: 'heuristics.ios.swiftui.inline-foreach-transform.ast',
+      },
+    },
+    then: {
+      kind: 'Finding',
+      message: 'AST heuristic detected inline filter/map/sort work inside ForEach; prefiltered or cached collections remain the preferred baseline.',
+      code: 'HEURISTICS_IOS_SWIFTUI_INLINE_FOREACH_TRANSFORM_AST',
+    },
+  },
   {
     id: 'heuristics.ios.contains-user-filter.ast',
     description: 'Detects contains() usage in user-facing filter flows where localizedStandardContains() may be preferred.',

package/integrations/config/skillsDetectorRegistry.ts

@@ -201,6 +201,10 @@ const registryByRuleId: Record<string, SkillsDetectorBinding> = {
     'ios.legacy-swiftui-observable-wrapper',
     ['heuristics.ios.legacy-swiftui-observable-wrapper.ast']
   ),
+  'skills.ios.guideline.ios-swiftui-expert.always-mark-state-and-stateobject-as-private-makes-dependencies-clear': heuristicDetector(
+    'ios.swiftui.non-private-state-ownership',
+    ['heuristics.ios.swiftui.non-private-state-ownership.ast']
+  ),
   'skills.ios.no-passed-value-state-wrapper': heuristicDetector('ios.passed-value-state-wrapper', [
     'heuristics.ios.passed-value-state-wrapper.ast',
   ]),
@@ -225,6 +229,10 @@ const registryByRuleId: Record<string, SkillsDetectorBinding> = {
   'skills.ios.no-foreach-indices': heuristicDetector('ios.foreach-indices', [
     'heuristics.ios.foreach-indices.ast',
   ]),
+  'skills.ios.guideline.ios-swiftui-expert.avoid-inline-filtering-in-foreach-prefilter-and-cache':
+    heuristicDetector('ios.swiftui.inline-foreach-transform', [
+      'heuristics.ios.swiftui.inline-foreach-transform.ast',
+    ]),
   'skills.ios.no-contains-user-filter': heuristicDetector('ios.contains-user-filter', [
     'heuristics.ios.contains-user-filter.ast',
   ]),

package/integrations/config/skillsMarkdownRules.ts

@@ -260,6 +260,13 @@ const normalizeKnownRuleTarget = (
     ) {
       return 'skills.ios.no-legacy-swiftui-observable-wrapper';
     }
+    if (
+      includes('state and stateobject as private') ||
+      includes('stateobject as private') ||
+      (includes('mark state') && includes('private'))
+    ) {
+      return 'skills.ios.guideline.ios-swiftui-expert.always-mark-state-and-stateobject-as-private-makes-dependencies-clear';
+    }
     if (
       includes('passed values as state') ||
       includes('passed values as state or stateobject') ||
@@ -302,6 +309,13 @@ const normalizeKnownRuleTarget = (
     ) {
       return 'skills.ios.no-foreach-indices';
     }
+    if (
+      (includes('inline filtering') && includes('foreach')) ||
+      (includes('no inline filtering') && includes('foreach')) ||
+      (includes('prefilter') && includes('cache') && includes('foreach'))
+    ) {
+      return 'skills.ios.guideline.ios-swiftui-expert.avoid-inline-filtering-in-foreach-prefilter-and-cache';
+    }
     if (
       includes('localizedstandardcontains') ||
       includes('localized standard contains') ||

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pumuki",
-  "version": "6.3.218",
+  "version": "6.3.220",
   "description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
   "main": "index.js",
   "bin": {

package/skills.lock.json

@@ -1,7 +1,7 @@
 {
   "version": "1.0",
   "compilerVersion": "1.0.0",
-  "generatedAt": "2026-05-13T13:40:06.121Z",
+  "generatedAt": "2026-05-13T15:54:55.035Z",
   "bundles": [
     {
       "name": "android-guidelines",
@@ -8632,7 +8632,7 @@
       "name": "ios-swiftui-expert-guidelines",
       "version": "1.0.0",
       "source": "file:vendor/skills/swiftui-expert-skill/SKILL.md",
-      "hash": "05e71c648612ed794d4e8122105fc3f508e09b7f92db94a24bd3daa45335d6b7",
+      "hash": "ad099eaf37bfe92bde672c1042c7d4c18e3af4bbf91a1b9ee6f6a0dc0e5381b5",
       "rules": [
         {
           "id": "skills.ios.guideline.ios-swiftui-expert.always-mark-state-and-stateobject-as-private-makes-dependencies-clear",
@@ -8643,7 +8643,7 @@
           "sourcePath": "vendor/skills/swiftui-expert-skill/SKILL.md",
           "confidence": "MEDIUM",
           "locked": true,
-          "evaluationMode": "DECLARATIVE",
+          "evaluationMode": "AUTO",
           "origin": "core"
         },
         {
@@ -8655,7 +8655,7 @@
           "sourcePath": "vendor/skills/swiftui-expert-skill/SKILL.md",
           "confidence": "MEDIUM",
           "locked": true,
-          "evaluationMode": "DECLARATIVE",
+          "evaluationMode": "AUTO",
           "origin": "core"
         },
         {