pumuki 6.3.217 → 6.3.219

package/core/facts/detectors/text/ios.test.ts

@@ -43,8 +43,10 @@ import {
   hasSwiftNSManagedObjectBoundaryUsage,
   hasSwiftNSManagedObjectStateLeakUsage,
   hasSwiftNavigationViewUsage,
+  hasSwiftNonPrivateStateOwnershipUsage,
   hasSwiftNonIBOutletImplicitlyUnwrappedOptionalUsage,
   hasSwiftObservableObjectUsage,
+  hasSwiftOnAppearTaskUsage,
   hasSwiftOnTapGestureUsage,
   hasSwiftOperationQueueUsage,
   hasSwiftContainsUserFilterUsage,
@@ -186,6 +188,43 @@ Task {
   assert.equal(hasSwiftTaskDetachedUsage(negative), false);
 });
 
+test('hasSwiftOnAppearTaskUsage detecta Task dentro de onAppear y preserva task modifier', () => {
+  const source = `
+struct FeedView: View {
+  var body: some View {
+    List(items) { item in
+      Text(item.title)
+    }
+    .onAppear {
+      Task {
+        await viewModel.load()
+      }
+    }
+  }
+}
+`;
+  const safe = `
+struct FeedView: View {
+  var body: some View {
+    List(items) { item in
+      Text(item.title)
+    }
+    .task {
+      await viewModel.load()
+    }
+    .onAppear {
+      analytics.trackScreen()
+    }
+    let text = ".onAppear { Task { await load() } }"
+    // .onAppear { Task { await load() } }
+  }
+}
+`;
+
+  assert.equal(hasSwiftOnAppearTaskUsage(source), true);
+  assert.equal(hasSwiftOnAppearTaskUsage(safe), false);
+});
+
 test('hasSwiftStrongDelegateReferenceUsage detecta delegates fuertes y preserva weak delegates', () => {
   const positive = `
 final class CheckoutCoordinator {
@@ -890,6 +929,26 @@ struct ContentView: View {
   assert.equal(hasSwiftLegacySwiftUiObservableWrapperUsage(modernWrapper), false);
 });
 
+test('hasSwiftNonPrivateStateOwnershipUsage detecta @State y @StateObject no privados', () => {
+  const source = `
+struct DashboardView: View {
+  @State var query = ""
+  @StateObject var viewModel = DashboardViewModel()
+}
+`;
+  const safe = `
+struct DashboardView: View {
+  @State private var query = ""
+  @StateObject private var viewModel = DashboardViewModel()
+  let text = "@State var query = \\"\\""
+  // @State var query = ""
+}
+`;
+
+  assert.equal(hasSwiftNonPrivateStateOwnershipUsage(source), true);
+  assert.equal(hasSwiftNonPrivateStateOwnershipUsage(safe), false);
+});
+
 test('hasSwiftPassedValueStateWrapperUsage detecta valores inyectados guardados como @State o @StateObject', () => {
   const invalidOwnership = `
 struct DetailView: View {

package/core/facts/detectors/text/ios.ts

@@ -437,6 +437,11 @@ export const hasSwiftTaskDetachedUsage = (source: string): boolean => {
   });
 };
 
+export const hasSwiftOnAppearTaskUsage = (source: string): boolean => {
+  const sanitized = sanitizeSwiftSourceForMultilineRegex(source);
+  return /\.onAppear\s*\{[\s\S]{0,500}?\bTask\s*(?:\([^)]*\))?\s*\{/.test(sanitized);
+};
+
 export const hasSwiftStrongDelegateReferenceUsage = (source: string): boolean => {
   const delegatePropertyPattern =
     /\b(?:var|let)\s+(?:[A-Za-z_][A-Za-z0-9_]*(?:Delegate|DataSource)|delegate|dataSource)\s*:\s*(?:any\s+)?[A-Za-z_][A-Za-z0-9_]*(?:Delegate|DataSource)\b/;
@@ -855,6 +860,17 @@ export const hasSwiftLegacySwiftUiObservableWrapperUsage = (source: string): boo
   return hasSwiftSanitizedRegexMatch(source, /@\s*(?:StateObject|ObservedObject)\b/);
 };
 
+export const hasSwiftNonPrivateStateOwnershipUsage = (source: string): boolean => {
+  return source.split(/\r?\n/).some((line) => {
+    const sanitizedLine = stripSwiftLineForSemanticScan(line);
+    return (
+      /@\s*(?:State|StateObject)\b/.test(sanitizedLine) &&
+      /\bvar\b/.test(sanitizedLine) &&
+      !/\bprivate\b/.test(sanitizedLine)
+    );
+  });
+};
+
 const hasSwiftPassedValueWrapperInitialization = (
   source: string,
   options: {

package/core/facts/extractHeuristicFacts.ts

@@ -646,6 +646,7 @@ const textDetectorRegistry: ReadonlyArray<TextDetectorRegistryEntry> = [
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftDispatchSemaphoreUsage, ruleId: 'heuristics.ios.dispatchsemaphore.ast', code: 'HEURISTICS_IOS_DISPATCHSEMAPHORE_AST', message: 'AST heuristic detected DispatchSemaphore usage.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftOperationQueueUsage, ruleId: 'heuristics.ios.operation-queue.ast', code: 'HEURISTICS_IOS_OPERATION_QUEUE_AST', message: 'AST heuristic detected OperationQueue usage.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftTaskDetachedUsage, ruleId: 'heuristics.ios.task-detached.ast', code: 'HEURISTICS_IOS_TASK_DETACHED_AST', message: 'AST heuristic detected Task.detached usage.' },
+  { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftOnAppearTaskUsage, ruleId: 'heuristics.ios.swiftui.onappear-task.ast', code: 'HEURISTICS_IOS_SWIFTUI_ONAPPEAR_TASK_AST', message: 'AST heuristic detected Task launched from SwiftUI onAppear; .task/.task(id:) provides lifecycle-aware cancellation.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftStrongDelegateReferenceUsage, ruleId: 'heuristics.ios.memory.strong-delegate.ast', code: 'HEURISTICS_IOS_MEMORY_STRONG_DELEGATE_AST', message: 'AST heuristic detected a strong delegate/dataSource reference; weak delegates remain the preferred baseline to avoid retain cycles.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftStrongSelfEscapingClosureUsage, ruleId: 'heuristics.ios.memory.strong-self-escaping-closure.ast', code: 'HEURISTICS_IOS_MEMORY_STRONG_SELF_ESCAPING_CLOSURE_AST', message: 'AST heuristic detected strong self capture in an escaping iOS closure; weak or unowned captures remain the preferred baseline when ownership is not explicit.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftCustomSingletonUsage, ruleId: 'heuristics.ios.architecture.custom-singleton.ast', code: 'HEURISTICS_IOS_ARCHITECTURE_CUSTOM_SINGLETON_AST', message: 'AST heuristic detected a custom static shared singleton in iOS production code; dependency injection remains the preferred baseline for app-owned services.' },
@@ -674,6 +675,7 @@ const textDetectorRegistry: ReadonlyArray<TextDetectorRegistryEntry> = [
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftAssumeIsolatedUsage, ruleId: 'heuristics.ios.assume-isolated.ast', code: 'HEURISTICS_IOS_ASSUME_ISOLATED_AST', message: 'AST heuristic detected assumeIsolated usage.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftObservableObjectUsage, ruleId: 'heuristics.ios.observable-object.ast', code: 'HEURISTICS_IOS_OBSERVABLE_OBJECT_AST', message: 'AST heuristic detected ObservableObject usage.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftLegacySwiftUiObservableWrapperUsage, ruleId: 'heuristics.ios.legacy-swiftui-observable-wrapper.ast', code: 'HEURISTICS_IOS_LEGACY_SWIFTUI_OBSERVABLE_WRAPPER_AST', message: 'AST heuristic detected @StateObject/@ObservedObject usage in a modern SwiftUI path.' },
+  { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftNonPrivateStateOwnershipUsage, ruleId: 'heuristics.ios.swiftui.non-private-state-ownership.ast', code: 'HEURISTICS_IOS_SWIFTUI_NON_PRIVATE_STATE_OWNERSHIP_AST', message: 'AST heuristic detected @State/@StateObject without private visibility; SwiftUI owned state should be private.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftPassedValueStateWrapperUsage, ruleId: 'heuristics.ios.passed-value-state-wrapper.ast', code: 'HEURISTICS_IOS_PASSED_VALUE_STATE_WRAPPER_AST', message: 'AST heuristic detected a passed value stored as @State/@StateObject via init wrapper ownership.' },
   { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftForEachIndicesUsage, ruleId: 'heuristics.ios.foreach-indices.ast', code: 'HEURISTICS_IOS_FOREACH_INDICES_AST', message: 'AST heuristic detected ForEach(...indices...) usage where stable element identity may be preferred.' },
   { platform: 'ios', pathCheck: isIOSApplicationOrPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftContainsUserFilterUsage, ruleId: 'heuristics.ios.contains-user-filter.ast', code: 'HEURISTICS_IOS_CONTAINS_USER_FILTER_AST', message: 'AST heuristic detected contains() in a user-facing filter where localizedStandardContains() may be preferred.' },

package/core/rules/presets/heuristics/ios.ts

@@ -181,6 +181,25 @@ export const iosRules: RuleSet = [
       code: 'HEURISTICS_IOS_TASK_DETACHED_AST',
     },
   },
+  {
+    id: 'heuristics.ios.swiftui.onappear-task.ast',
+    description: 'Detects Task launches from SwiftUI onAppear where .task can provide lifecycle cancellation.',
+    severity: 'WARN',
+    platform: 'ios',
+    locked: true,
+    when: {
+      kind: 'Heuristic',
+      where: {
+        ruleId: 'heuristics.ios.swiftui.onappear-task.ast',
+      },
+    },
+    then: {
+      kind: 'Finding',
+      message:
+        'AST heuristic detected Task launched from SwiftUI onAppear; .task/.task(id:) provides lifecycle-aware cancellation.',
+      code: 'HEURISTICS_IOS_SWIFTUI_ONAPPEAR_TASK_AST',
+    },
+  },
   {
     id: 'heuristics.ios.memory.strong-delegate.ast',
     description: 'Detects strong delegate/dataSource references in iOS production code.',
@@ -711,6 +730,25 @@ export const iosRules: RuleSet = [
       code: 'HEURISTICS_IOS_LEGACY_SWIFTUI_OBSERVABLE_WRAPPER_AST',
     },
   },
+  {
+    id: 'heuristics.ios.swiftui.non-private-state-ownership.ast',
+    description: 'Detects @State/@StateObject declarations without private visibility in SwiftUI presentation code.',
+    severity: 'WARN',
+    platform: 'ios',
+    locked: true,
+    when: {
+      kind: 'Heuristic',
+      where: {
+        ruleId: 'heuristics.ios.swiftui.non-private-state-ownership.ast',
+      },
+    },
+    then: {
+      kind: 'Finding',
+      message:
+        'AST heuristic detected @State/@StateObject without private visibility; SwiftUI owned state should be private.',
+      code: 'HEURISTICS_IOS_SWIFTUI_NON_PRIVATE_STATE_OWNERSHIP_AST',
+    },
+  },
   {
     id: 'heuristics.ios.passed-value-state-wrapper.ast',
     description: 'Detects passed values stored as @State or @StateObject through init ownership in SwiftUI production code.',

package/integrations/config/skillsDetectorRegistry.ts

@@ -201,6 +201,10 @@ const registryByRuleId: Record<string, SkillsDetectorBinding> = {
     'ios.legacy-swiftui-observable-wrapper',
     ['heuristics.ios.legacy-swiftui-observable-wrapper.ast']
   ),
+  'skills.ios.guideline.ios-swiftui-expert.always-mark-state-and-stateobject-as-private-makes-dependencies-clear': heuristicDetector(
+    'ios.swiftui.non-private-state-ownership',
+    ['heuristics.ios.swiftui.non-private-state-ownership.ast']
+  ),
   'skills.ios.no-passed-value-state-wrapper': heuristicDetector('ios.passed-value-state-wrapper', [
     'heuristics.ios.passed-value-state-wrapper.ast',
   ]),
@@ -244,6 +248,14 @@ const registryByRuleId: Record<string, SkillsDetectorBinding> = {
   'skills.ios.no-legacy-onchange': heuristicDetector('ios.legacy-onchange', [
     'heuristics.ios.legacy-onchange.ast',
   ]),
+  'skills.ios.guideline.ios.task-task-id-trabajos-async-con-cancelacio-n-automa-tica': heuristicDetector(
+    'ios.swiftui.onappear-task',
+    ['heuristics.ios.swiftui.onappear-task.ast']
+  ),
+  'skills.ios.guideline.ios-swiftui-expert.use-task-modifier-for-automatic-cancellation-of-async-work': heuristicDetector(
+    'ios.swiftui.onappear-task',
+    ['heuristics.ios.swiftui.onappear-task.ast']
+  ),
   'skills.ios.no-uiscreen-main-bounds': heuristicDetector('ios.uiscreen-main-bounds', [
     'heuristics.ios.uiscreen-main-bounds.ast',
   ]),

package/integrations/config/skillsMarkdownRules.ts

@@ -260,6 +260,13 @@ const normalizeKnownRuleTarget = (
     ) {
       return 'skills.ios.no-legacy-swiftui-observable-wrapper';
     }
+    if (
+      includes('state and stateobject as private') ||
+      includes('stateobject as private') ||
+      (includes('mark state') && includes('private'))
+    ) {
+      return 'skills.ios.guideline.ios-swiftui-expert.always-mark-state-and-stateobject-as-private-makes-dependencies-clear';
+    }
     if (
       includes('passed values as state') ||
       includes('passed values as state or stateobject') ||
@@ -360,6 +367,15 @@ const normalizeKnownRuleTarget = (
     if (includes('uiscreen main bounds') || includes('uiscreen.main.bounds')) {
       return 'skills.ios.no-uiscreen-main-bounds';
     }
+    if (
+      includes('task/.task(id') ||
+      includes('trabajos async con cancelacion automatica') ||
+      includes('trabajos async con cancelacio n automa tica') ||
+      includes('task modifier for automatic cancellation') ||
+      includes('automatic cancellation of async work')
+    ) {
+      return 'skills.ios.guideline.ios-swiftui-expert.use-task-modifier-for-automatic-cancellation-of-async-work';
+    }
     if (
       includes('swift testing over xctest') ||
       includes('prefer import testing') ||

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pumuki",
-  "version": "6.3.217",
+  "version": "6.3.219",
   "description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
   "main": "index.js",
   "bin": {

package/skills.lock.json

@@ -1,7 +1,7 @@
 {
   "version": "1.0",
   "compilerVersion": "1.0.0",
-  "generatedAt": "2026-05-13T13:30:09.135Z",
+  "generatedAt": "2026-05-13T15:50:45.972Z",
   "bundles": [
     {
       "name": "android-guidelines",
@@ -5764,8 +5764,20 @@
       "name": "ios-guidelines",
       "version": "1.0.0",
       "source": "file:vendor/skills/ios-enterprise-rules/SKILL.md",
-      "hash": "c7b96d97cd02175dacf17b64cb8bdd1be7b5978dd2f74c7feb3bf3d462311467",
+      "hash": "2d56094eff6a0b688d9f20ef6970de5945dfa74aaf3a3973dfee2091b9e98542",
       "rules": [
+        {
+          "id": "skills.ios.guideline.ios-swiftui-expert.use-task-modifier-for-automatic-cancellation-of-async-work",
+          "description": ".task/.task(id:) - Trabajos async con cancelación automática",
+          "severity": "WARN",
+          "platform": "ios",
+          "sourceSkill": "ios-guidelines",
+          "sourcePath": "vendor/skills/ios-enterprise-rules/SKILL.md",
+          "confidence": "MEDIUM",
+          "locked": true,
+          "evaluationMode": "AUTO",
+          "origin": "core"
+        },
         {
           "id": "skills.ios.guideline.ios.accessibility-identifiers-para-localizar-elementos",
           "description": "Accessibility identifiers - Para localizar elementos",
@@ -7927,18 +7939,6 @@
           "evaluationMode": "DECLARATIVE",
           "origin": "core"
         },
-        {
-          "id": "skills.ios.guideline.ios.task-task-id-trabajos-async-con-cancelacio-n-automa-tica",
-          "description": ".task/.task(id:) - Trabajos async con cancelación automática",
-          "severity": "WARN",
-          "platform": "ios",
-          "sourceSkill": "ios-guidelines",
-          "sourcePath": "vendor/skills/ios-enterprise-rules/SKILL.md",
-          "confidence": "MEDIUM",
-          "locked": true,
-          "evaluationMode": "DECLARATIVE",
-          "origin": "core"
-        },
         {
           "id": "skills.ios.guideline.ios.taskgroup-para-operaciones-paralelas",
           "description": "TaskGroup - Para operaciones paralelas",
@@ -8632,7 +8632,7 @@
       "name": "ios-swiftui-expert-guidelines",
       "version": "1.0.0",
       "source": "file:vendor/skills/swiftui-expert-skill/SKILL.md",
-      "hash": "33a19bd25ca8546d49f2070956784e4fe3f653a25365c8a9734af5cd46b8ec60",
+      "hash": "b936508c5fea766c83bca01087374a8c0281ba86c4ee022d43db316b89c07cd6",
       "rules": [
         {
           "id": "skills.ios.guideline.ios-swiftui-expert.always-mark-state-and-stateobject-as-private-makes-dependencies-clear",
@@ -8643,7 +8643,7 @@
           "sourcePath": "vendor/skills/swiftui-expert-skill/SKILL.md",
           "confidence": "MEDIUM",
           "locked": true,
-          "evaluationMode": "DECLARATIVE",
+          "evaluationMode": "AUTO",
           "origin": "core"
         },
         {
@@ -8907,7 +8907,7 @@
           "sourcePath": "vendor/skills/swiftui-expert-skill/SKILL.md",
           "confidence": "MEDIUM",
           "locked": true,
-          "evaluationMode": "DECLARATIVE",
+          "evaluationMode": "AUTO",
           "origin": "core"
         },
         {