pumuki 6.3.214 → 6.3.215
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/core/facts/detectors/text/ios.test.ts +29 -0
- package/core/facts/detectors/text/ios.ts +7 -0
- package/core/facts/extractHeuristicFacts.ts +1 -0
- package/core/rules/presets/heuristics/ios.ts +19 -0
- package/integrations/config/skillsDetectorRegistry.ts +4 -0
- package/integrations/config/skillsMarkdownRules.ts +3 -0
- package/package.json +1 -1
- package/skills.lock.json +3 -3
|
@@ -61,6 +61,7 @@ import {
|
|
|
61
61
|
hasSwiftStringFormatUsage,
|
|
62
62
|
hasSwiftStrongDelegateReferenceUsage,
|
|
63
63
|
hasSwiftStrongSelfEscapingClosureUsage,
|
|
64
|
+
hasSwiftSwinjectUsage,
|
|
64
65
|
hasSwiftTabItemUsage,
|
|
65
66
|
hasSwiftTaskDetachedUsage,
|
|
66
67
|
hasSwiftWaitForExpectationsUsage,
|
|
@@ -287,6 +288,34 @@ final class APIClient {
|
|
|
287
288
|
assert.equal(hasSwiftCustomSingletonUsage(ignored), false);
|
|
288
289
|
});
|
|
289
290
|
|
|
291
|
+
test('hasSwiftSwinjectUsage detecta DI de terceros y preserva DI nativa', () => {
|
|
292
|
+
const source = `
|
|
293
|
+
import Swinject
|
|
294
|
+
|
|
295
|
+
final class AppAssembly {
|
|
296
|
+
private let container = Container()
|
|
297
|
+
private let assembler = Assembler([])
|
|
298
|
+
}
|
|
299
|
+
`;
|
|
300
|
+
const native = `
|
|
301
|
+
struct AppDependencies {
|
|
302
|
+
let apiClient: APIClient
|
|
303
|
+
}
|
|
304
|
+
|
|
305
|
+
private struct DependenciesKey: EnvironmentKey {
|
|
306
|
+
static let defaultValue = AppDependencies(apiClient: URLSessionAPIClient())
|
|
307
|
+
}
|
|
308
|
+
`;
|
|
309
|
+
const ignored = `
|
|
310
|
+
let text = "import Swinject"
|
|
311
|
+
// let container = Container()
|
|
312
|
+
`;
|
|
313
|
+
|
|
314
|
+
assert.equal(hasSwiftSwinjectUsage(source), true);
|
|
315
|
+
assert.equal(hasSwiftSwinjectUsage(native), false);
|
|
316
|
+
assert.equal(hasSwiftSwinjectUsage(ignored), false);
|
|
317
|
+
});
|
|
318
|
+
|
|
290
319
|
test('hasSwiftMassiveViewControllerResponsibilityUsage detecta ViewControllers con acceso directo a infraestructura', () => {
|
|
291
320
|
const source = `
|
|
292
321
|
final class CheckoutViewController: UIViewController {
|
|
@@ -528,6 +528,13 @@ export const hasSwiftCustomSingletonUsage = (source: string): boolean => {
|
|
|
528
528
|
});
|
|
529
529
|
};
|
|
530
530
|
|
|
531
|
+
export const hasSwiftSwinjectUsage = (source: string): boolean => {
|
|
532
|
+
return hasSwiftSanitizedRegexMatch(
|
|
533
|
+
source,
|
|
534
|
+
/\bimport\s+Swinject\b|\b(?:Container|Assembler)\s*\(/
|
|
535
|
+
);
|
|
536
|
+
};
|
|
537
|
+
|
|
531
538
|
export const hasSwiftMassiveViewControllerResponsibilityUsage = (source: string): boolean => {
|
|
532
539
|
const sanitized = sanitizeSwiftSourceForMultilineRegex(source);
|
|
533
540
|
const viewControllerPattern =
|
|
@@ -649,6 +649,7 @@ const textDetectorRegistry: ReadonlyArray<TextDetectorRegistryEntry> = [
|
|
|
649
649
|
{ platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftStrongDelegateReferenceUsage, ruleId: 'heuristics.ios.memory.strong-delegate.ast', code: 'HEURISTICS_IOS_MEMORY_STRONG_DELEGATE_AST', message: 'AST heuristic detected a strong delegate/dataSource reference; weak delegates remain the preferred baseline to avoid retain cycles.' },
|
|
650
650
|
{ platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftStrongSelfEscapingClosureUsage, ruleId: 'heuristics.ios.memory.strong-self-escaping-closure.ast', code: 'HEURISTICS_IOS_MEMORY_STRONG_SELF_ESCAPING_CLOSURE_AST', message: 'AST heuristic detected strong self capture in an escaping iOS closure; weak or unowned captures remain the preferred baseline when ownership is not explicit.' },
|
|
651
651
|
{ platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftCustomSingletonUsage, ruleId: 'heuristics.ios.architecture.custom-singleton.ast', code: 'HEURISTICS_IOS_ARCHITECTURE_CUSTOM_SINGLETON_AST', message: 'AST heuristic detected a custom static shared singleton in iOS production code; dependency injection remains the preferred baseline for app-owned services.' },
|
|
652
|
+
{ platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftSwinjectUsage, ruleId: 'heuristics.ios.architecture.swinject.ast', code: 'HEURISTICS_IOS_ARCHITECTURE_SWINJECT_AST', message: 'AST heuristic detected Swinject usage; manual dependency injection or SwiftUI Environment remain the preferred native baseline.' },
|
|
652
653
|
{ platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftMassiveViewControllerResponsibilityUsage, ruleId: 'heuristics.ios.architecture.massive-view-controller.ast', code: 'HEURISTICS_IOS_ARCHITECTURE_MASSIVE_VIEW_CONTROLLER_AST', message: 'AST heuristic detected a UIViewController with direct infrastructure/data access; move data access behind application/domain boundaries.' },
|
|
653
654
|
{ platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftNonIBOutletImplicitlyUnwrappedOptionalUsage, ruleId: 'heuristics.ios.safety.non-iboutlet-iuo.ast', code: 'HEURISTICS_IOS_SAFETY_NON_IBOUTLET_IUO_AST', message: 'AST heuristic detected an implicitly unwrapped optional outside IBOutlet wiring; explicit optionals or initialization guarantees remain the preferred baseline.' },
|
|
654
655
|
{ platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftMagicNumberLayoutUsage, ruleId: 'heuristics.ios.maintainability.magic-number-layout.ast', code: 'HEURISTICS_IOS_MAINTAINABILITY_MAGIC_NUMBER_LAYOUT_AST', message: 'AST heuristic detected SwiftUI layout magic numbers; named constants or design tokens remain the preferred baseline.' },
|
|
@@ -238,6 +238,25 @@ export const iosRules: RuleSet = [
|
|
|
238
238
|
code: 'HEURISTICS_IOS_ARCHITECTURE_CUSTOM_SINGLETON_AST',
|
|
239
239
|
},
|
|
240
240
|
},
|
|
241
|
+
{
|
|
242
|
+
id: 'heuristics.ios.architecture.swinject.ast',
|
|
243
|
+
description: 'Detects Swinject usage in iOS production code.',
|
|
244
|
+
severity: 'WARN',
|
|
245
|
+
platform: 'ios',
|
|
246
|
+
locked: true,
|
|
247
|
+
when: {
|
|
248
|
+
kind: 'Heuristic',
|
|
249
|
+
where: {
|
|
250
|
+
ruleId: 'heuristics.ios.architecture.swinject.ast',
|
|
251
|
+
},
|
|
252
|
+
},
|
|
253
|
+
then: {
|
|
254
|
+
kind: 'Finding',
|
|
255
|
+
message:
|
|
256
|
+
'AST heuristic detected Swinject usage; manual dependency injection or SwiftUI Environment remain the preferred native baseline.',
|
|
257
|
+
code: 'HEURISTICS_IOS_ARCHITECTURE_SWINJECT_AST',
|
|
258
|
+
},
|
|
259
|
+
},
|
|
241
260
|
{
|
|
242
261
|
id: 'heuristics.ios.architecture.massive-view-controller.ast',
|
|
243
262
|
description: 'Detects UIViewController classes with direct infrastructure/data access.',
|
|
@@ -82,6 +82,10 @@ const registryByRuleId: Record<string, SkillsDetectorBinding> = {
|
|
|
82
82
|
'ios.architecture.custom-singleton',
|
|
83
83
|
['heuristics.ios.architecture.custom-singleton.ast']
|
|
84
84
|
),
|
|
85
|
+
'skills.ios.guideline.ios.swinject-prohibido-di-manual-o-environment': heuristicDetector(
|
|
86
|
+
'ios.architecture.swinject',
|
|
87
|
+
['heuristics.ios.architecture.swinject.ast']
|
|
88
|
+
),
|
|
85
89
|
'skills.ios.guideline.ios.magic-numbers-usar-constantes-con-nombres': heuristicDetector(
|
|
86
90
|
'ios.maintainability.magic-number-layout',
|
|
87
91
|
['heuristics.ios.maintainability.magic-number-layout.ast']
|
|
@@ -480,6 +480,9 @@ const normalizeKnownRuleTarget = (
|
|
|
480
480
|
) {
|
|
481
481
|
return 'skills.ios.guideline.ios.magic-numbers-usar-constantes-con-nombres';
|
|
482
482
|
}
|
|
483
|
+
if (includes('swinject')) {
|
|
484
|
+
return 'skills.ios.guideline.ios.swinject-prohibido-di-manual-o-environment';
|
|
485
|
+
}
|
|
483
486
|
if (
|
|
484
487
|
includes('mixing legacy xctest style') ||
|
|
485
488
|
includes('mixed xctest and swift testing') ||
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "pumuki",
|
|
3
|
-
"version": "6.3.
|
|
3
|
+
"version": "6.3.215",
|
|
4
4
|
"description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
|
|
5
5
|
"main": "index.js",
|
|
6
6
|
"bin": {
|
package/skills.lock.json
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
{
|
|
2
2
|
"version": "1.0",
|
|
3
3
|
"compilerVersion": "1.0.0",
|
|
4
|
-
"generatedAt": "2026-05-13T13:
|
|
4
|
+
"generatedAt": "2026-05-13T13:18:11.822Z",
|
|
5
5
|
"bundles": [
|
|
6
6
|
{
|
|
7
7
|
"name": "android-guidelines",
|
|
@@ -5764,7 +5764,7 @@
|
|
|
5764
5764
|
"name": "ios-guidelines",
|
|
5765
5765
|
"version": "1.0.0",
|
|
5766
5766
|
"source": "file:vendor/skills/ios-enterprise-rules/SKILL.md",
|
|
5767
|
-
"hash": "
|
|
5767
|
+
"hash": "45d9315671888e71b9f038d52026b4d1da3e3ac41312749be77c5ed44b52958b",
|
|
5768
5768
|
"rules": [
|
|
5769
5769
|
{
|
|
5770
5770
|
"id": "skills.ios.guideline.ios.accessibility-identifiers-para-localizar-elementos",
|
|
@@ -7912,7 +7912,7 @@
|
|
|
7912
7912
|
"sourcePath": "vendor/skills/ios-enterprise-rules/SKILL.md",
|
|
7913
7913
|
"confidence": "HIGH",
|
|
7914
7914
|
"locked": true,
|
|
7915
|
-
"evaluationMode": "
|
|
7915
|
+
"evaluationMode": "AUTO",
|
|
7916
7916
|
"origin": "core"
|
|
7917
7917
|
},
|
|
7918
7918
|
{
|