pumuki 6.3.211 → 6.3.213

package/core/facts/detectors/text/ios.test.ts

@@ -30,6 +30,7 @@ import {
   hasSwiftLegacySwiftUiObservableWrapperUsage,
   hasSwiftMainThreadBlockingSleepUsage,
   hasSwiftMassiveViewControllerResponsibilityUsage,
+  hasSwiftMagicNumberLayoutUsage,
   hasSwiftMixedTestingFrameworksUsage,
   hasSwiftLegacyXCTestImportUsage,
   hasSwiftModernizableXCTestSuiteUsage,
@@ -339,6 +340,38 @@ final class CheckoutViewController: UIViewController {
   assert.equal(hasSwiftNonIBOutletImplicitlyUnwrappedOptionalUsage(ignored), false);
 });
 
+test('hasSwiftMagicNumberLayoutUsage detecta numeros magicos de layout SwiftUI', () => {
+  const source = `
+struct ProfileView: View {
+  var body: some View {
+    VStack(spacing: 12) {
+      Text("Profile")
+        .padding(16)
+        .frame(width: 320, height: 44)
+    }
+  }
+}
+`;
+  const constants = `
+struct ProfileView: View {
+  private enum Metrics {
+    static let spacing: CGFloat = 12
+    static let cardPadding: CGFloat = 16
+  }
+
+  var body: some View {
+    VStack(spacing: Metrics.spacing) {
+      Text("Profile")
+        .padding(Metrics.cardPadding)
+    }
+  }
+}
+`;
+
+  assert.equal(hasSwiftMagicNumberLayoutUsage(source), true);
+  assert.equal(hasSwiftMagicNumberLayoutUsage(constants), false);
+});
+
 test('detectores de logging iOS detectan logs ad-hoc y PII en produccion', () => {
   const adHoc = `
 print(user.id)

package/core/facts/detectors/text/ios.ts

@@ -559,6 +559,13 @@ export const hasSwiftNonIBOutletImplicitlyUnwrappedOptionalUsage = (source: stri
   });
 };
 
+export const hasSwiftMagicNumberLayoutUsage = (source: string): boolean => {
+  const swiftUiLayoutNumberPattern =
+    /(?:\b(?:VStack|HStack|ZStack|LazyVStack|LazyHStack)\s*\([^)]*\bspacing\s*:\s*|\.(?:padding|frame|offset|position|shadow|blur)\s*\([^)]*(?:\b(?:width|height|spacing|radius|x|y)\s*:\s*)?)\b(?:[3-9]|[1-9][0-9]+)(?:\.[0-9]+)?\b/;
+
+  return collectSwiftRegexLines(source, swiftUiLayoutNumberPattern).length > 0;
+};
+
 export const hasSwiftAdHocLoggingUsage = (source: string): boolean => {
   return collectSwiftRegexLines(
     source,

package/core/facts/extractHeuristicFacts.ts

@@ -651,6 +651,7 @@ const textDetectorRegistry: ReadonlyArray<TextDetectorRegistryEntry> = [
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftCustomSingletonUsage, ruleId: 'heuristics.ios.architecture.custom-singleton.ast', code: 'HEURISTICS_IOS_ARCHITECTURE_CUSTOM_SINGLETON_AST', message: 'AST heuristic detected a custom static shared singleton in iOS production code; dependency injection remains the preferred baseline for app-owned services.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftMassiveViewControllerResponsibilityUsage, ruleId: 'heuristics.ios.architecture.massive-view-controller.ast', code: 'HEURISTICS_IOS_ARCHITECTURE_MASSIVE_VIEW_CONTROLLER_AST', message: 'AST heuristic detected a UIViewController with direct infrastructure/data access; move data access behind application/domain boundaries.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftNonIBOutletImplicitlyUnwrappedOptionalUsage, ruleId: 'heuristics.ios.safety.non-iboutlet-iuo.ast', code: 'HEURISTICS_IOS_SAFETY_NON_IBOUTLET_IUO_AST', message: 'AST heuristic detected an implicitly unwrapped optional outside IBOutlet wiring; explicit optionals or initialization guarantees remain the preferred baseline.' },
+  { platform: 'ios', pathCheck: isIOSPresentationPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftMagicNumberLayoutUsage, ruleId: 'heuristics.ios.maintainability.magic-number-layout.ast', code: 'HEURISTICS_IOS_MAINTAINABILITY_MAGIC_NUMBER_LAYOUT_AST', message: 'AST heuristic detected SwiftUI layout magic numbers; named constants or design tokens remain the preferred baseline.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftAdHocLoggingUsage, ruleId: 'heuristics.ios.logging.adhoc-print.ast', code: 'HEURISTICS_IOS_LOGGING_ADHOC_PRINT_AST', message: 'AST heuristic detected print/debugPrint/dump/NSLog/os_log usage in iOS production code.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftSensitiveLoggingUsage, ruleId: 'heuristics.ios.logging.sensitive-data.ast', code: 'HEURISTICS_IOS_LOGGING_SENSITIVE_DATA_AST', message: 'AST heuristic detected sensitive data in an iOS logging call.' },
   { platform: 'ios', pathCheck: isIOSSwiftPath, excludePaths: [isSwiftTestPath], detect: TextIOS.hasSwiftAlamofireUsage, ruleId: 'heuristics.ios.networking.alamofire.ast', code: 'HEURISTICS_IOS_NETWORKING_ALAMOFIRE_AST', message: 'AST heuristic detected Alamofire usage in iOS production code; URLSession remains the preferred baseline for new code.' },

package/core/rules/presets/heuristics/ios.ts

@@ -257,6 +257,25 @@ export const iosRules: RuleSet = [
       code: 'HEURISTICS_IOS_ARCHITECTURE_MASSIVE_VIEW_CONTROLLER_AST',
     },
   },
+  {
+    id: 'heuristics.ios.maintainability.magic-number-layout.ast',
+    description: 'Detects SwiftUI layout magic numbers in presentation code.',
+    severity: 'WARN',
+    platform: 'ios',
+    locked: true,
+    when: {
+      kind: 'Heuristic',
+      where: {
+        ruleId: 'heuristics.ios.maintainability.magic-number-layout.ast',
+      },
+    },
+    then: {
+      kind: 'Finding',
+      message:
+        'AST heuristic detected SwiftUI layout magic numbers; named constants or design tokens remain the preferred baseline.',
+      code: 'HEURISTICS_IOS_MAINTAINABILITY_MAGIC_NUMBER_LAYOUT_AST',
+    },
+  },
   {
     id: 'heuristics.ios.safety.non-iboutlet-iuo.ast',
     description: 'Detects implicitly unwrapped optionals outside IBOutlet wiring.',

package/integrations/config/skillsDetectorRegistry.ts

@@ -82,6 +82,10 @@ const registryByRuleId: Record<string, SkillsDetectorBinding> = {
     'ios.architecture.custom-singleton',
     ['heuristics.ios.architecture.custom-singleton.ast']
   ),
+  'skills.ios.guideline.ios.magic-numbers-usar-constantes-con-nombres': heuristicDetector(
+    'ios.maintainability.magic-number-layout',
+    ['heuristics.ios.maintainability.magic-number-layout.ast']
+  ),
   'skills.ios.guideline.ios.prohibido-print-y-logs-ad-hoc': heuristicDetector(
     'ios.logging.adhoc-print',
     ['heuristics.ios.logging.adhoc-print.ast']

package/integrations/config/skillsMarkdownRules.ts

@@ -108,6 +108,17 @@ const resolveDefaultStageForKnownRule = (
   return KNOWN_RULE_DEFAULT_STAGE[ruleId];
 };
 
+const KNOWN_RULE_DEFAULT_SEVERITY: Readonly<Record<string, Severity>> = {
+  'skills.ios.guideline.ios.magic-numbers-usar-constantes-con-nombres': 'WARN',
+};
+
+const resolveDefaultSeverityForKnownRule = (
+  ruleId: string,
+  inferredSeverity: Severity
+): Severity => {
+  return KNOWN_RULE_DEFAULT_SEVERITY[ruleId] ?? inferredSeverity;
+};
+
 const isRuleCandidateLine = (line: string): boolean => {
   if (CHECK_RULE_PREFIX.test(line)) {
     return true;
@@ -461,6 +472,14 @@ const normalizeKnownRuleTarget = (
     ) {
       return 'skills.ios.guideline.ios.implicitly-unwrapped-solo-para-iboutlets-y-casos-muy-especi-ficos';
     }
+    if (
+      includes('magic numbers') ||
+      includes('magic number') ||
+      includes('constantes con nombres') ||
+      includes('named constants')
+    ) {
+      return 'skills.ios.guideline.ios.magic-numbers-usar-constantes-con-nombres';
+    }
     if (
       includes('mixing legacy xctest style') ||
       includes('mixed xctest and swift testing') ||
@@ -636,7 +655,9 @@ export const extractCompiledRulesFromSkillMarkdown = (params: {
     rules.push({
       id: nextId,
       description,
-      severity: inferRuleSeverity(rawLine),
+      severity: knownRuleId
+        ? resolveDefaultSeverityForKnownRule(knownRuleId, inferRuleSeverity(rawLine))
+        : inferRuleSeverity(rawLine),
       platform,
       sourceSkill: params.sourceSkill,
       sourcePath: params.sourcePath,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pumuki",
-  "version": "6.3.211",
+  "version": "6.3.213",
   "description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
   "main": "index.js",
   "bin": {

package/skills.lock.json

@@ -1,7 +1,7 @@
 {
   "version": "1.0",
   "compilerVersion": "1.0.0",
-  "generatedAt": "2026-05-13T12:56:51.940Z",
+  "generatedAt": "2026-05-13T13:08:40.281Z",
   "bundles": [
     {
       "name": "android-guidelines",
@@ -5764,7 +5764,7 @@
       "name": "ios-guidelines",
       "version": "1.0.0",
       "source": "file:vendor/skills/ios-enterprise-rules/SKILL.md",
-      "hash": "1395678f8abd2b8eddb9d4270fd205517ed4ce4e3796def5f7846592990ec778",
+      "hash": "8ed400269188d9b92c2a95b660bb2b69bf2992197bbe7d2fc382920444507aeb",
       "rules": [
         {
           "id": "skills.ios.guideline.ios.accessibility-identifiers-para-localizar-elementos",
@@ -6910,13 +6910,13 @@
         {
           "id": "skills.ios.guideline.ios.magic-numbers-usar-constantes-con-nombres",
           "description": "Magic numbers - Usar constantes con nombres",
-          "severity": "ERROR",
+          "severity": "WARN",
           "platform": "ios",
           "sourceSkill": "ios-guidelines",
           "sourcePath": "vendor/skills/ios-enterprise-rules/SKILL.md",
           "confidence": "HIGH",
           "locked": true,
-          "evaluationMode": "DECLARATIVE",
+          "evaluationMode": "AUTO",
           "origin": "core"
         },
         {