pumuki 6.3.187 → 6.3.189

package/VERSION

@@ -1 +1 @@
-v6.3.187
+v6.3.189

package/core/facts/detectors/text/android.test.ts

@@ -10,8 +10,10 @@ import {
   hasKotlinDispatcherMainBoundaryLeakUsage,
   hasKotlinGlobalScopeUsage,
   hasKotlinHardcodedBackgroundDispatcherUsage,
+  hasKotlinJUnit4Usage,
   hasKotlinLiveDataStateExposureUsage,
   hasKotlinLifecycleScopeUsage,
+  hasKotlinSharedPreferencesUsage,
   hasKotlinWithContextUsage,
   hasKotlinManualCoroutineScopeInViewModelUsage,
   hasKotlinRunBlockingUsage,
@@ -247,6 +249,72 @@ class SyncOrdersUseCase {
   assert.equal(hasKotlinLifecycleScopeUsage(source), false);
 });
 
+test('hasKotlinSharedPreferencesUsage detecta SharedPreferences y getSharedPreferences', () => {
+  const typeSource = `
+class PreferencesStore(private val preferences: SharedPreferences) {
+  fun read() = preferences.getString("token", null)
+}
+`;
+  const callSource = `
+class PreferencesStore(private val context: Context) {
+  fun read() = context.getSharedPreferences("user", Context.MODE_PRIVATE)
+}
+`;
+  assert.equal(hasKotlinSharedPreferencesUsage(typeSource), true);
+  assert.equal(hasKotlinSharedPreferencesUsage(callSource), true);
+});
+
+test('hasKotlinSharedPreferencesUsage ignora imports, comentarios, strings y nombres parciales', () => {
+  const source = `
+import android.content.SharedPreferences
+// val preferences: SharedPreferences = legacy()
+val sample = "getSharedPreferences(\"user\")"
+class PreferencesStore {
+  fun read() = customSharedPreferencesProvider()
+}
+`;
+  assert.equal(hasKotlinSharedPreferencesUsage(source), false);
+});
+
+test('hasKotlinJUnit4Usage detecta imports y anotaciones JUnit4 en tests Kotlin Android', () => {
+  const importSource = `
+import org.junit.Test
+import org.junit.Assert
+
+class OrdersViewModelTest {
+  @Test
+  fun loadsOrders() {
+    Assert.assertEquals(1, 1)
+  }
+}
+`;
+  const runnerSource = `
+import org.junit.runner.RunWith
+
+@RunWith(AndroidJUnit4::class)
+class OrdersInstrumentedTest
+`;
+
+  assert.equal(hasKotlinJUnit4Usage(importSource), true);
+  assert.equal(hasKotlinJUnit4Usage(runnerSource), true);
+});
+
+test('hasKotlinJUnit4Usage ignora JUnit5, comentarios y strings', () => {
+  const source = `
+import org.junit.jupiter.api.Test
+// import org.junit.Test
+val sample = "Assert.assertEquals(1, 1)"
+
+class OrdersViewModelTest {
+  @Test
+  fun loadsOrders() {
+    assertEquals(1, 1)
+  }
+}
+`;
+  assert.equal(hasKotlinJUnit4Usage(source), false);
+});
+
 test('hasKotlinSupervisorScopeUsage detecta supervisorScope con parentesis y llaves', () => {
   const parenthesesSource = `
 class SyncOrdersUseCase {

package/core/facts/detectors/text/android.ts

@@ -267,6 +267,21 @@ export const hasKotlinLifecycleScopeUsage = (source: string): boolean => {
   return collectKotlinRegexLines(source, /\blifecycleScope\s*\./).length > 0;
 };
 
+export const hasKotlinSharedPreferencesUsage = (source: string): boolean => {
+  return collectKotlinRegexLines(source, /\b(?:SharedPreferences|PreferenceManager\s*\.|getSharedPreferences\s*\()/).length > 0;
+};
+
+export const hasKotlinJUnit4Usage = (source: string): boolean => {
+  return source.split(/\r?\n/).some((line) => {
+    const sanitized = stripKotlinLineForSemanticScan(line);
+    return (
+      /\bimport\s+org\.junit\.(?:Test|Before|After|BeforeClass|AfterClass|Assert|Rule|ClassRule|runner\.RunWith|rules\.)\b/.test(sanitized) ||
+      /@(?:RunWith|Rule|ClassRule)\b/.test(sanitized) ||
+      /\bAssert\s*\./.test(sanitized)
+    );
+  });
+};
+
 export const hasKotlinSupervisorScopeUsage = (source: string): boolean => {
   return collectKotlinRegexLines(source, /\bsupervisorScope\s*(?:<[^>\n]+>\s*)?(?:\(|\{)/).length > 0;
 };

package/core/facts/extractHeuristicFacts.ts

@@ -161,6 +161,10 @@ const isKotlinTestPath = (path: string): boolean => {
   );
 };
 
+const isAndroidKotlinTestPath = (path: string): boolean => {
+  return isAndroidKotlinPath(path) && isKotlinTestPath(path);
+};
+
 const isExcludedProjectScanPath = (path: string): boolean => {
   const normalized = path.replace(/\\/g, '/').toLowerCase();
   return (
@@ -653,6 +657,8 @@ const textDetectorRegistry: ReadonlyArray<TextDetectorRegistryEntry> = [
   { platform: 'android', pathCheck: isAndroidKotlinPath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasKotlinGlobalScopeUsage, ruleId: 'heuristics.android.globalscope.ast', code: 'HEURISTICS_ANDROID_GLOBAL_SCOPE_AST', message: 'AST heuristic detected GlobalScope coroutine usage in production Kotlin code.' },
   { platform: 'android', pathCheck: isAndroidKotlinPath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasKotlinRunBlockingUsage, ruleId: 'heuristics.android.run-blocking.ast', code: 'HEURISTICS_ANDROID_RUN_BLOCKING_AST', message: 'AST heuristic detected runBlocking usage in production Kotlin code.' },
   { platform: 'android', pathCheck: isAndroidLocalPropertiesPath, excludePaths: [], detect: detectsTrackedFilePresence, ruleId: 'heuristics.android.security.local-properties-tracked.ast', code: 'HEURISTICS_ANDROID_SECURITY_LOCAL_PROPERTIES_TRACKED_AST', message: 'AST heuristic detected tracked Android local.properties file.' },
+  { platform: 'android', pathCheck: isAndroidKotlinPath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasKotlinSharedPreferencesUsage, ruleId: 'heuristics.android.persistence.shared-preferences-usage.ast', code: 'HEURISTICS_ANDROID_PERSISTENCE_SHARED_PREFERENCES_USAGE_AST', message: 'AST heuristic detected SharedPreferences usage in Android production Kotlin code.' },
+  { platform: 'android', pathCheck: isAndroidKotlinTestPath, excludePaths: [], detect: TextAndroid.hasKotlinJUnit4Usage, ruleId: 'heuristics.android.testing.junit4-usage.ast', code: 'HEURISTICS_ANDROID_TESTING_JUNIT4_USAGE_AST', message: 'AST heuristic detected JUnit4 usage in Android Kotlin tests where JUnit5 is preferred.' },
   { platform: 'android', pathCheck: isAndroidPresentationPath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasKotlinLiveDataStateExposureUsage, ruleId: 'heuristics.android.flow.livedata-state-exposure.ast', code: 'HEURISTICS_ANDROID_FLOW_LIVEDATA_STATE_EXPOSURE_AST', message: 'AST heuristic detected LiveData state exposure in Android presentation code where StateFlow or SharedFlow should be preferred.' },
   { platform: 'android', pathCheck: isAndroidPresentationPath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasKotlinManualCoroutineScopeInViewModelUsage, ruleId: 'heuristics.android.coroutines.manual-scope-in-viewmodel.ast', code: 'HEURISTICS_ANDROID_COROUTINES_MANUAL_SCOPE_IN_VIEWMODEL_AST', message: 'AST heuristic detected manual CoroutineScope inside an Android ViewModel where viewModelScope should be preferred.' },
   { platform: 'android', pathCheck: isAndroidNonPresentationKotlinPath, excludePaths: [isKotlinTestPath], detect: TextAndroid.hasKotlinDispatcherMainBoundaryLeakUsage, ruleId: 'heuristics.android.coroutines.dispatchers-main-boundary-leak.ast', code: 'HEURISTICS_ANDROID_COROUTINES_DISPATCHERS_MAIN_BOUNDARY_LEAK_AST', message: 'AST heuristic detected Dispatchers.Main outside Android presentation code.' },

package/core/rules/presets/heuristics/android.test.ts

@@ -3,7 +3,7 @@ import test from 'node:test';
 import { androidRules } from './android';
 
 test('androidRules define reglas heurísticas locked para plataforma android', () => {
-  assert.equal(androidRules.length, 17);
+  assert.equal(androidRules.length, 19);
 
   const ids = androidRules.map((rule) => rule.id);
   assert.deepEqual(ids, [
@@ -12,6 +12,8 @@ test('androidRules define reglas heurísticas locked para plataforma android', (
     'heuristics.android.run-blocking.ast',
     'heuristics.android.flow.livedata-state-exposure.ast',
     'heuristics.android.security.local-properties-tracked.ast',
+    'heuristics.android.persistence.shared-preferences-usage.ast',
+    'heuristics.android.testing.junit4-usage.ast',
     'heuristics.android.coroutines.manual-scope-in-viewmodel.ast',
     'heuristics.android.coroutines.dispatchers-main-boundary-leak.ast',
     'heuristics.android.coroutines.hardcoded-background-dispatcher.ast',
@@ -57,6 +59,14 @@ test('androidRules define reglas heurísticas locked para plataforma android', (
     byId.get('heuristics.android.security.local-properties-tracked.ast')?.then.code,
     'HEURISTICS_ANDROID_SECURITY_LOCAL_PROPERTIES_TRACKED_AST'
   );
+  assert.equal(
+    byId.get('heuristics.android.persistence.shared-preferences-usage.ast')?.then.code,
+    'HEURISTICS_ANDROID_PERSISTENCE_SHARED_PREFERENCES_USAGE_AST'
+  );
+  assert.equal(
+    byId.get('heuristics.android.testing.junit4-usage.ast')?.then.code,
+    'HEURISTICS_ANDROID_TESTING_JUNIT4_USAGE_AST'
+  );
   assert.equal(
     byId.get('heuristics.android.coroutines.manual-scope-in-viewmodel.ast')?.then.code,
     'HEURISTICS_ANDROID_COROUTINES_MANUAL_SCOPE_IN_VIEWMODEL_AST'

package/core/rules/presets/heuristics/android.ts

@@ -95,6 +95,46 @@ export const androidRules: RuleSet = [
       code: 'HEURISTICS_ANDROID_SECURITY_LOCAL_PROPERTIES_TRACKED_AST',
     },
   },
+  {
+    id: 'heuristics.android.persistence.shared-preferences-usage.ast',
+    description:
+      'Detects SharedPreferences usage in Android production Kotlin code where DataStore may be preferred.',
+    severity: 'WARN',
+    platform: 'android',
+    locked: true,
+    when: {
+      kind: 'Heuristic',
+      where: {
+        ruleId: 'heuristics.android.persistence.shared-preferences-usage.ast',
+      },
+    },
+    then: {
+      kind: 'Finding',
+      message:
+        'AST heuristic detected SharedPreferences usage in Android production Kotlin code.',
+      code: 'HEURISTICS_ANDROID_PERSISTENCE_SHARED_PREFERENCES_USAGE_AST',
+    },
+  },
+  {
+    id: 'heuristics.android.testing.junit4-usage.ast',
+    description:
+      'Detects JUnit4 usage in Android Kotlin tests where JUnit5 is preferred.',
+    severity: 'WARN',
+    platform: 'android',
+    locked: true,
+    when: {
+      kind: 'Heuristic',
+      where: {
+        ruleId: 'heuristics.android.testing.junit4-usage.ast',
+      },
+    },
+    then: {
+      kind: 'Finding',
+      message:
+        'AST heuristic detected JUnit4 usage in Android Kotlin tests.',
+      code: 'HEURISTICS_ANDROID_TESTING_JUNIT4_USAGE_AST',
+    },
+  },
   {
     id: 'heuristics.android.coroutines.manual-scope-in-viewmodel.ast',
     description:

package/docs/codex-skills/android-enterprise-rules.md

@@ -137,11 +137,20 @@ app/
 ✅ `skills.android.guideline.android.local-properties-api-keys-no-subir-a-git` debe mapear a señal ejecutable de `local.properties` versionado bajo `apps/android/`.
 ✅ Este baseline no imprime ni analiza valores secretos; solo reporta la presencia del archivo versionado y exige retirarlo del control de versiones.
 
+### Enforcement AST inicial de persistencia Android
+✅ `skills.android.guideline.android.datastore-androidx-datastore-datastore-preferences-reemplazo-de-shared` debe mapear a señal ejecutable de uso legacy de `SharedPreferences` en Kotlin Android production.
+✅ Este baseline no prohíbe `EncryptedSharedPreferences` todavía ni declara cobertura completa de migración a DataStore; solo detecta el uso legacy explícito de `SharedPreferences` / `getSharedPreferences(...)`.
+
 ### Enforcement AST inicial de Flow/StateFlow Android
 ✅ Las reglas de `StateFlow` / `StateFlow-SharedFlow` deben mapear a señales ejecutables de estado observable legacy, empezando por exposición de `LiveData` / `MutableLiveData` en presentation.
 ✅ Este baseline no obliga a que todo ViewModel use Flow; solo detecta una alternativa legacy concreta cuando aparece en código de presentación Android.
 ✅ `Flow`, `collectAsState`, `stateIn`, Room observable queries y SharedFlow events quedan fuera hasta que tengan detectores propios y regresiones dirigidas.
 
+### Enforcement AST inicial de testing Android
+✅ `skills.android.guideline.android.junit5-framework-de-testing-preferido-sobre-junit4` debe mapear a señal ejecutable de uso JUnit4 en tests Kotlin Android.
+✅ Este baseline detecta imports/anotaciones JUnit4 (`org.junit.Test`, `org.junit.Assert`, `@RunWith`, reglas JUnit4) bajo `apps/android/**/test/**` y `apps/android/**/androidTest/**`.
+✅ JUnit5/Jupiter queda preservado como caso limpio; migración completa de runner, Gradle y APIs de assertions queda fuera hasta tener detectores propios.
+
 ### Dependency Injection (Hilt):
 ✅ **Hilt** - DI framework (NO manual factories)
 ✅ **@HiltAndroidApp** - Application class

package/integrations/config/skillsDetectorRegistry.ts

@@ -251,6 +251,14 @@ const registryByRuleId: Record<string, SkillsDetectorBinding> = {
     'android.security.local-properties',
     ['heuristics.android.security.local-properties-tracked.ast']
   ),
+  'skills.android.guideline.android.datastore-androidx-datastore-datastore-preferences-reemplazo-de-shared': heuristicDetector(
+    'android.persistence.shared-preferences',
+    ['heuristics.android.persistence.shared-preferences-usage.ast']
+  ),
+  'skills.android.guideline.android.junit5-framework-de-testing-preferido-sobre-junit4': heuristicDetector(
+    'android.testing.junit4-usage',
+    ['heuristics.android.testing.junit4-usage.ast']
+  ),
   'skills.android.guideline.android.stateflow-estado-mutable-observable': heuristicDetector(
     'android.flow.state-exposure',
     ['heuristics.android.flow.livedata-state-exposure.ast']

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pumuki",
-  "version": "6.3.187",
+  "version": "6.3.189",
   "description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
   "main": "index.js",
   "bin": {

package/skills.lock.json

@@ -1,7 +1,7 @@
 {
   "version": "1.0",
   "compilerVersion": "1.0.0",
-  "generatedAt": "2026-05-12T21:06:58.727Z",
+  "generatedAt": "2026-05-12T21:22:02.797Z",
   "bundles": [
     {
       "name": "android-guidelines",