pumuki 6.3.172 → 6.3.174

package/core/facts/detectors/text/ios.ts

@@ -32,8 +32,6 @@ export type SwiftPresentationSrpMatch = {
   lines: readonly number[];
 };
 
-export type SwiftXCTestSrpMatch = SwiftPresentationSrpMatch;
-
 export type SwiftConcreteDependencyDipMatch = {
   primary_node: SwiftSemanticNodeMatch;
   related_nodes: readonly SwiftSemanticNodeMatch[];
@@ -100,63 +98,6 @@ const hasSwiftSanitizedRegexMatch = (source: string, regex: RegExp): boolean =>
   return regex.test(sanitizeSwiftSourceForMultilineRegex(source));
 };
 
-type SwiftFunctionDeclaration = {
-  signature: string;
-  body: string;
-};
-
-const collectSwiftFunctionDeclarations = (source: string): readonly SwiftFunctionDeclaration[] => {
-  const lines = source.split(/\r?\n/);
-  const functions: SwiftFunctionDeclaration[] = [];
-
-  for (let index = 0; index < lines.length; index += 1) {
-    const firstLine = stripSwiftLineForSemanticScan(lines[index] ?? '');
-    if (!/\bfunc\b/.test(firstLine)) {
-      continue;
-    }
-
-    const signatureLines: string[] = [];
-    let cursor = index;
-    let openingLineIndex = -1;
-    for (; cursor < lines.length && cursor < index + 24; cursor += 1) {
-      const line = stripSwiftLineForSemanticScan(lines[cursor] ?? '');
-      signatureLines.push(line);
-      if (line.includes('{')) {
-        openingLineIndex = cursor;
-        break;
-      }
-      if (line.includes('}')) {
-        break;
-      }
-    }
-
-    if (openingLineIndex < 0) {
-      continue;
-    }
-
-    const bodyLines: string[] = [];
-    let braceDepth = 0;
-    for (let bodyCursor = openingLineIndex; bodyCursor < lines.length; bodyCursor += 1) {
-      const line = stripSwiftLineForSemanticScan(lines[bodyCursor] ?? '');
-      braceDepth += countTokenOccurrences(line, '{');
-      braceDepth -= countTokenOccurrences(line, '}');
-      bodyLines.push(line);
-      if (bodyCursor > openingLineIndex && braceDepth <= 0) {
-        cursor = bodyCursor;
-        break;
-      }
-    }
-
-    functions.push({
-      signature: signatureLines.join('\n'),
-      body: bodyLines.join('\n'),
-    });
-    index = cursor;
-  }
-
-  return functions;
-};
-
 const hasSwiftUiModernizationSnapshotMatch = (source: string, entryId: string): boolean => {
   const entry = getIosSwiftUiModernizationEntry(entryId);
   if (!entry) {
@@ -536,17 +477,6 @@ export const hasSwiftForEachIndicesUsage = (source: string): boolean => {
   );
 };
 
-export const hasSwiftInlineFilteringInForEachUsage = (source: string): boolean => {
-  return hasSwiftSanitizedRegexMatch(
-    source,
-    /\bForEach\s*\(\s*[A-Za-z_][A-Za-z0-9_.]*\s*\.\s*filter\s*\{/g
-  );
-};
-
-export const hasSwiftExplicitColorStaticMemberUsage = (source: string): boolean => {
-  return hasSwiftSanitizedRegexMatch(source, /\bColor\s*\.\s*[a-z][A-Za-z0-9_]*\b/g);
-};
-
 const isUserSearchIdentifier = (value: string): boolean => {
   return /^(?:query|search(?:Text|Term|Query|Value)?|filter(?:Text|Value)?|text|term|input)$/i.test(
     value
@@ -597,36 +527,6 @@ export const hasSwiftLegacySwiftUiObservableWrapperUsage = (source: string): boo
   return hasSwiftSanitizedRegexMatch(source, /@\s*(?:StateObject|ObservedObject)\b/);
 };
 
-export const hasSwiftStateWrapperWithoutPrivateUsage = (source: string): boolean => {
-  const typeDeclarations = parseSwiftTypeDeclarations(source);
-  if (typeDeclarations.length === 0) {
-    return false;
-  }
-
-  const sourceLines = source.split(/\r?\n/);
-  const stateWrapperPattern = /@\s*(?:State|StateObject)\b/;
-
-  for (const typeDeclaration of typeDeclarations) {
-    if (!typeDeclaration.conformances.includes('View')) {
-      continue;
-    }
-
-    const hasViolation = visitSwiftTopLevelTypeBodyLines(sourceLines, typeDeclaration, ({ line }) => {
-      if (!stateWrapperPattern.test(line)) {
-        return false;
-      }
-
-      return !/\bprivate\b/.test(line);
-    });
-
-    if (hasViolation) {
-      return true;
-    }
-  }
-
-  return false;
-};
-
 const hasSwiftPassedValueWrapperInitialization = (
   source: string,
   options: {
@@ -788,10 +688,6 @@ const hasSwiftTestingSuiteAttributeUsage = (source: string): boolean => {
   return hasSwiftSanitizedRegexMatch(source, /\B@(?:Test|Suite)\b/);
 };
 
-const hasSwiftTestingFrameworkMarkerUsage = (source: string): boolean => {
-  return hasSwiftTestingImportUsage(source) || hasSwiftTestingSuiteAttributeUsage(source);
-};
-
 const hasSwiftXCTestCaseSubclassUsage = (source: string): boolean => {
   return hasSwiftSanitizedRegexMatch(
     source,
@@ -804,59 +700,15 @@ const hasSwiftLegacyXCTestMethodUsage = (source: string): boolean => {
     .length > 0;
 };
 
-const hasSwiftMakeSutUsage = (source: string): boolean => {
-  return hasSwiftSanitizedRegexMatch(source, /\bmakeSUT\s*\(/);
-};
-
-const hasSwiftMemoryLeakTrackingUsage = (source: string): boolean => {
-  return hasSwiftSanitizedRegexMatch(source, /\btrackForMemoryLeaks\s*\(/);
-};
-
-const hasSwiftBrownfieldCompatibleXCTestUsage = (source: string): boolean => {
-  if (!hasSwiftXCTestImportUsage(source) || !hasSwiftXCTestCaseSubclassUsage(source)) {
-    return false;
-  }
-
-  if (!hasSwiftLegacyXCTestMethodUsage(source)) {
-    return false;
-  }
-
-  if (hasSwiftTestingImportUsage(source) || hasSwiftTestingSuiteAttributeUsage(source)) {
-    return false;
-  }
-
-  return hasSwiftMakeSutUsage(source) && hasSwiftMemoryLeakTrackingUsage(source);
-};
-
-const hasSwiftXCTestOnlyBrownfieldSuiteUsage = (source: string): boolean => {
-  if (!hasSwiftXCTestImportUsage(source) || !hasSwiftXCTestCaseSubclassUsage(source)) {
-    return false;
-  }
-
-  if (hasSwiftLegacyXCTestUiOrPerformanceUsage(source)) {
-    return false;
-  }
-
-  return !hasSwiftTestingImportUsage(source) && !hasSwiftTestingSuiteAttributeUsage(source);
-};
-
 export const hasSwiftLegacyXCTestImportUsage = (source: string): boolean => {
   if (!hasSwiftXCTestImportUsage(source)) {
     return false;
   }
 
-  if (!hasSwiftXCTestCaseSubclassUsage(source) || !hasSwiftLegacyXCTestMethodUsage(source)) {
-    return false;
-  }
-
   if (hasSwiftLegacyXCTestUiOrPerformanceUsage(source)) {
     return false;
   }
 
-  if (hasSwiftXCTestOnlyBrownfieldSuiteUsage(source)) {
-    return false;
-  }
-
   return true;
 };
 
@@ -877,18 +729,14 @@ export const hasSwiftModernizableXCTestSuiteUsage = (source: string): boolean =>
 };
 
 export const hasSwiftMixedTestingFrameworksUsage = (source: string): boolean => {
-  return hasSwiftXCTestCaseSubclassUsage(source) && hasSwiftTestingFrameworkMarkerUsage(source);
-};
-
-export const hasSwiftXCTestAssertionUsage = (source: string): boolean => {
-  if (hasSwiftLegacyXCTestUiOrPerformanceUsage(source)) {
+  if (!hasSwiftXCTestImportUsage(source) || !hasSwiftXCTestCaseSubclassUsage(source)) {
     return false;
   }
 
-  if (hasSwiftXCTestOnlyBrownfieldSuiteUsage(source)) {
-    return false;
-  }
+  return hasSwiftTestingImportUsage(source) || hasSwiftTestingSuiteAttributeUsage(source);
+};
 
+export const hasSwiftXCTestAssertionUsage = (source: string): boolean => {
   return (
     collectSwiftRegexLines(source, /\bXCTAssert[A-Za-z0-9_]*\s*\(/).length > 0 ||
     collectSwiftRegexLines(source, /\bXCTFail\s*\(/).length > 0
@@ -896,14 +744,6 @@ export const hasSwiftXCTestAssertionUsage = (source: string): boolean => {
 };
 
 export const hasSwiftXCTUnwrapUsage = (source: string): boolean => {
-  if (hasSwiftLegacyXCTestUiOrPerformanceUsage(source)) {
-    return false;
-  }
-
-  if (hasSwiftXCTestOnlyBrownfieldSuiteUsage(source)) {
-    return false;
-  }
-
   return collectSwiftRegexLines(source, /\bXCTUnwrap\s*\(/).length > 0;
 };
 
@@ -916,59 +756,40 @@ const hasSwiftConfirmationUsage = (source: string): boolean => {
 };
 
 export const hasSwiftWaitForExpectationsUsage = (source: string): boolean => {
-  const legacyWaitPattern = /\bwait\s*\(\s*for\s*:|\bwaitForExpectations\s*\(/;
-  return collectSwiftFunctionDeclarations(source).some((declaration) => {
-    if (!/\basync\b/.test(declaration.signature)) {
-      return false;
-    }
-    legacyWaitPattern.lastIndex = 0;
-    return legacyWaitPattern.test(declaration.body);
-  });
+  return hasSwiftSanitizedRegexMatch(
+    source,
+    /\bwait\s*\(\s*for\s*:|\bwaitForExpectations\s*\(/
+  );
 };
 
 export const hasSwiftLegacyExpectationDescriptionUsage = (source: string): boolean => {
-  return collectSwiftFunctionDeclarations(source).some((declaration) => {
-    if (!/\basync\b/.test(declaration.signature)) {
-      return false;
-    }
-    if (!hasSwiftSanitizedRegexMatch(declaration.body, /\bexpectation\s*\(\s*description\s*:/)) {
-      return false;
-    }
-    return !hasSwiftAwaitFulfillmentUsage(declaration.body) && !hasSwiftConfirmationUsage(declaration.body);
-  });
-};
+  const hasLegacyExpectation = collectSwiftRegexLines(
+    source,
+    /\bexpectation\s*\(\s*description\s*:/
+  ).length > 0;
 
-const swiftManagedObjectBoundaryTypePattern = /\bNSManagedObject\b(?!ID\b|Context\b)/;
-const swiftStoredPropertyBoundaryPattern =
-  /\b(?:var|let)\s+[A-Za-z_][A-Za-z0-9_]*\s*:\s*[^=\n]*\bNSManagedObject\b(?!ID\b|Context\b)/;
-const swiftManagedObjectSubclassPattern =
-  /\b(?:final\s+)?class\s+[A-Za-z_][A-Za-z0-9_]*\s*:\s*NSManagedObject\b/;
+  if (!hasLegacyExpectation) {
+    return false;
+  }
 
-const hasSwiftManagedObjectBoundaryTypeUsage = (source: string): boolean => {
-  return collectSwiftFunctionDeclarations(source).some((declaration) =>
-    swiftManagedObjectBoundaryTypePattern.test(declaration.signature)
-  );
+  if (hasSwiftAwaitFulfillmentUsage(source) || hasSwiftConfirmationUsage(source)) {
+    return false;
+  }
+
+  return true;
 };
 
 export const hasSwiftNSManagedObjectBoundaryUsage = (source: string): boolean => {
-  if (hasSwiftManagedObjectBoundaryTypeUsage(source)) {
-    return true;
-  }
-
-  return source.split(/\r?\n/).some((line) => {
-    const sanitized = stripSwiftLineForSemanticScan(line);
-    return (
-      swiftStoredPropertyBoundaryPattern.test(sanitized) &&
-      !swiftManagedObjectSubclassPattern.test(sanitized)
-    );
-  });
+  return hasSwiftSanitizedRegexMatch(
+    source,
+    /\bfunc\b[\s\S]{0,240}\([^)]*\bNSManagedObject\b(?!ID\b|Context\b)[^)]*\)|\b(?:var|let)\s+[A-Za-z_][A-Za-z0-9_]*\s*:\s*(?:\[[^\]]*NSManagedObject\b(?!ID\b|Context\b)[^\]]*\]|NSManagedObject\b(?!ID\b|Context\b))/g
+  );
 };
 
 export const hasSwiftNSManagedObjectAsyncBoundaryUsage = (source: string): boolean => {
-  return collectSwiftFunctionDeclarations(source).some(
-    (declaration) =>
-      /\basync\b/.test(declaration.signature) &&
-      swiftManagedObjectBoundaryTypePattern.test(declaration.signature)
+  return hasSwiftSanitizedRegexMatch(
+    source,
+    /\bfunc\b[\s\S]{0,240}\basync\b[\s\S]{0,200}(?:\([^)]*\bNSManagedObject\b(?!ID\b|Context\b)[^)]*\)|->\s*(?:\[[^\]]*NSManagedObject\b(?!ID\b|Context\b)[^\]]*\]|NSManagedObject\b(?!ID\b|Context\b)))/g
   );
 };
 
@@ -1290,100 +1111,6 @@ export const findSwiftPresentationSrpMatch = (
   };
 };
 
-export const findSwiftXCTestSrpMatch = (source: string): SwiftXCTestSrpMatch | undefined => {
-  if (!hasSwiftXCTestCaseSubclassUsage(source)) {
-    return undefined;
-  }
-
-  const classPattern = /\b(?:final\s+)?class\s+([A-Za-z0-9_]*Tests?)\s*:\s*XCTestCase\b/;
-  const classLines = collectSwiftRegexLines(source, classPattern);
-  if (classLines.length === 0) {
-    return undefined;
-  }
-
-  const classLine = source.split(/\r?\n/)[classLines[0] - 1] ?? '';
-  const className = classLine.match(classPattern)?.[1];
-  if (!className) {
-    return undefined;
-  }
-
-  const sourceLines = source.split(/\r?\n/);
-  const familyPatterns: ReadonlyArray<{
-    key: string;
-    name: string;
-    tokens: readonly string[];
-  }> = [
-    { key: 'configuration', name: 'configuration outcome tests', tokens: ['config', 'configuration', 'update', 'cache'] },
-    { key: 'session', name: 'session routing tests', tokens: ['session', 'login', 'auth', 'valid', 'invalid'] },
-    { key: 'onboarding', name: 'onboarding progress tests', tokens: ['onboarding', 'progress', 'completeonboarding'] },
-    { key: 'permissions', name: 'permissions routing tests', tokens: ['permission', 'camera', 'location', 'notification'] },
-    { key: 'tutorial', name: 'tutorial or feature discovery tests', tokens: ['tutorial', 'featurediscovery'] },
-    { key: 'splash', name: 'splash delay tests', tokens: ['splash', 'delay', 'start'] },
-  ];
-  const matchesFamily = (value: string, tokens: readonly string[]): boolean => {
-    const normalizedValue = value.toLowerCase();
-    return tokens.some((token) => normalizedValue.includes(token));
-  };
-
-  const classFamilyKeys = new Set(
-    familyPatterns
-      .filter((entry) => matchesFamily(className, entry.tokens))
-      .map((entry) => entry.key)
-  );
-  const matchedFamilies = new Map<string, SwiftSemanticNodeMatch>();
-
-  sourceLines.forEach((line, index) => {
-    const sanitizedLine = stripSwiftLineForSemanticScan(line);
-    const methodMatch = sanitizedLine.match(/\bfunc\s+(test[A-Za-z0-9_]+)\s*\(/);
-    const methodName = methodMatch?.[1];
-    if (!methodName) {
-      return;
-    }
-
-    for (const family of familyPatterns) {
-      if (!matchesFamily(methodName, family.tokens)) {
-        continue;
-      }
-      if (classFamilyKeys.has(family.key)) {
-        continue;
-      }
-      if (!matchedFamilies.has(family.key)) {
-        matchedFamilies.set(family.key, {
-          kind: 'member',
-          name: family.name,
-          lines: [index + 1],
-        });
-      }
-    }
-  });
-
-  const relatedNodes = [...matchedFamilies.values()];
-  if (relatedNodes.length < 2) {
-    return undefined;
-  }
-
-  const relatedNodeNames = relatedNodes.map((node) => node.name).join(', ');
-  const allLines = sortedUniqueLines([
-    ...classLines,
-    ...relatedNodes.flatMap((node) => [...node.lines]),
-  ]);
-
-  return {
-    primary_node: {
-      kind: 'class',
-      name: className,
-      lines: classLines,
-    },
-    related_nodes: relatedNodes,
-    why: `${className} mezcla ${relatedNodeNames} dentro del mismo XCTestCase, rompiendo SRP en la suite de tests.`,
-    impact:
-      'La suite acumula múltiples razones de cambio, oculta regresiones por responsabilidad y hace más difícil aislar el baseline afectado antes de PRE_WRITE.',
-    expected_fix:
-      'Divide la suite por responsabilidad observable: configuración, sesión, onboarding, permisos, tutorial o splash deben vivir en XCTestCase separados.',
-    lines: allLines,
-  };
-};
-
 export const findSwiftConcreteDependencyDipMatch = (
   source: string
 ): SwiftConcreteDependencyDipMatch | undefined => {
@@ -1474,7 +1201,7 @@ export const findSwiftOpenClosedSwitchMatch = (
   }
 
   const lines = source.split(/\r?\n/);
-  const discriminatorPattern = /\b(?:kind|type|mode|channel|variant|provider|route|flow|source|experience|outcome|state|status|configuration|config)\b/i;
+  const discriminatorPattern = /\b(?:kind|type|mode|channel|variant|provider|route|flow|source|experience)\b/i;
   const switchPattern = /\bswitch\s+([A-Za-z_][A-Za-z0-9_\.]*)\s*\{/;
 
   for (let index = 0; index < lines.length; index += 1) {