pumuki 6.3.113 → 6.3.115

package/scripts/framework-menu-system-notifications-macos-swift-source.ts

@@ -1,10 +1,6 @@
 export const SWIFT_BLOCKED_DIALOG_SOURCE = String.raw`import AppKit
 import Foundation
 
-final class KeyableFloatingPanel: NSPanel {
-  override var canBecomeKey: Bool { true }
-}
-
 struct DialogConfig {
   let title: String
   let cause: String
@@ -12,7 +8,6 @@ struct DialogConfig {
   let disableButton: String
   let muteButton: String
   let keepButton: String
-  let timeoutSeconds: Double
 }
 
 func parseArguments() -> DialogConfig {
@@ -23,74 +18,18 @@ func parseArguments() -> DialogConfig {
     }
     return args[index + 1]
   }
-  let timeoutRaw = read("--timeout-seconds", fallback: "15")
-  let timeout = Double(timeoutRaw) ?? 15
   return DialogConfig(
     title: read("--title", fallback: "Pumuki bloqueado"),
     cause: read("--cause", fallback: "Bloqueo detectado."),
     remediation: read("--remediation", fallback: "Corrige el bloqueo y vuelve a ejecutar."),
     disableButton: read("--disable-button", fallback: "Desactivar"),
     muteButton: read("--mute-button", fallback: "Silenciar 30 min"),
-    keepButton: read("--keep-button", fallback: "Mantener activas"),
-    timeoutSeconds: max(5, timeout)
+    keepButton: read("--keep-button", fallback: "Mantener activas")
   )
 }
 
-final class DialogController: NSObject, NSApplicationDelegate, NSWindowDelegate {
+final class DialogAppDelegate: NSObject, NSApplicationDelegate {
   private let config: DialogConfig
-  private var window: NSWindow?
-  private var chosenButton: String?
-
-  private func preferredWidth() -> CGFloat {
-    let longest = max(config.title.count, max(config.cause.count, config.remediation.count))
-    let estimated = CGFloat(longest) * 4.9 + 170
-    let visibleFrame = targetVisibleFrame()
-    let maxAllowed = max(360, visibleFrame.width - 40)
-    return min(max(360, estimated), min(620, maxAllowed))
-  }
-
-  private func targetVisibleFrame() -> NSRect {
-    let mouse = NSEvent.mouseLocation
-    if let screen = NSScreen.screens.first(where: { NSMouseInRect(mouse, $0.frame, false) }) {
-      return screen.visibleFrame
-    }
-    if let main = NSScreen.main {
-      return main.visibleFrame
-    }
-    if let first = NSScreen.screens.first {
-      return first.visibleFrame
-    }
-    return NSRect(x: 0, y: 0, width: 1440, height: 900)
-  }
-
-  private func pinWindowToBottomRight() {
-    guard let panel = window else {
-      return
-    }
-    let width = panel.frame.width
-    let height = panel.frame.height
-    let margin: CGFloat = 20
-    let visibleFrame = targetVisibleFrame()
-    let target = NSRect(
-      x: visibleFrame.maxX - width - margin,
-      y: visibleFrame.minY + margin,
-      width: width,
-      height: height
-    )
-    panel.setFrame(target, display: true)
-  }
-
-  private func resizeWindowToContent(root: NSStackView, contentView: NSView) {
-    guard let panel = window else {
-      return
-    }
-    contentView.layoutSubtreeIfNeeded()
-    let fitting = root.fittingSize
-    let visibleFrame = targetVisibleFrame()
-    let width = min(max(panel.frame.width, fitting.width + 30), min(620, visibleFrame.width - 40))
-    let height = min(max(140, fitting.height + 30), max(180, visibleFrame.height - 40))
-    panel.setContentSize(NSSize(width: width, height: height))
-  }
 
   init(config: DialogConfig) {
     self.config = config
@@ -98,149 +37,30 @@ final class DialogController: NSObject, NSApplicationDelegate, NSWindowDelegate
   }
 
   func applicationDidFinishLaunching(_ notification: Notification) {
-    showWindow()
-    startTimeout()
-  }
-
-  private func showWindow() {
-    let width = preferredWidth()
-    let height: CGFloat = 170
-    let margin: CGFloat = 20
-    let screenFrame = targetVisibleFrame()
-    let origin = NSPoint(
-      x: screenFrame.maxX - width - margin,
-      y: screenFrame.minY + margin
-    )
-
-    let panel = KeyableFloatingPanel(
-      contentRect: NSRect(x: origin.x, y: origin.y, width: width, height: height),
-      styleMask: [.titled, .closable, .fullSizeContentView],
-      backing: .buffered,
-      defer: false
-    )
-    panel.becomesKeyOnlyIfNeeded = false
-    panel.level = .floating
-    panel.collectionBehavior = [.canJoinAllSpaces, .fullScreenAuxiliary]
-    panel.titleVisibility = .hidden
-    panel.titlebarAppearsTransparent = true
-    panel.isMovable = true
-    panel.isReleasedWhenClosed = false
-    panel.delegate = self
-    panel.hidesOnDeactivate = false
-    panel.standardWindowButton(.zoomButton)?.isHidden = true
-    panel.standardWindowButton(.miniaturizeButton)?.isHidden = true
-
-    let root = NSStackView()
-    root.orientation = .vertical
-    root.alignment = .leading
-    root.spacing = 12
-    root.translatesAutoresizingMaskIntoConstraints = false
-
-    let titleField = NSTextField(labelWithString: config.title)
-    titleField.font = NSFont.boldSystemFont(ofSize: 15)
-    titleField.lineBreakMode = .byWordWrapping
-    titleField.maximumNumberOfLines = 0
-    titleField.preferredMaxLayoutWidth = width - 48
-    titleField.cell?.lineBreakMode = .byWordWrapping
-    titleField.cell?.usesSingleLineMode = false
-    titleField.cell?.wraps = true
-
-    let causeField = NSTextField(wrappingLabelWithString: "Causa: \(config.cause)")
-    causeField.font = NSFont.systemFont(ofSize: 12)
-    causeField.lineBreakMode = .byWordWrapping
-    causeField.maximumNumberOfLines = 0
-    causeField.preferredMaxLayoutWidth = width - 48
-    causeField.cell?.lineBreakMode = .byWordWrapping
-    causeField.cell?.usesSingleLineMode = false
-    causeField.cell?.wraps = true
-
-    let remediationField = NSTextField(wrappingLabelWithString: "Solución: \(config.remediation)")
-    remediationField.font = NSFont.systemFont(ofSize: 12)
-    remediationField.lineBreakMode = .byWordWrapping
-    remediationField.maximumNumberOfLines = 0
-    remediationField.preferredMaxLayoutWidth = width - 48
-    remediationField.cell?.lineBreakMode = .byWordWrapping
-    remediationField.cell?.usesSingleLineMode = false
-    remediationField.cell?.wraps = true
-
-    let buttons = NSStackView()
-    buttons.orientation = .horizontal
-    buttons.alignment = .centerY
-    buttons.spacing = 10
-
-    let disableButton = NSButton(title: config.disableButton, target: self, action: #selector(disablePressed))
-    disableButton.bezelStyle = .rounded
-    let muteButton = NSButton(title: config.muteButton, target: self, action: #selector(mutePressed))
-    muteButton.bezelStyle = .rounded
-    let keepButton = NSButton(title: config.keepButton, target: self, action: #selector(keepPressed))
-    keepButton.bezelStyle = .rounded
-    keepButton.keyEquivalent = "\r"
-
-    buttons.addArrangedSubview(disableButton)
-    buttons.addArrangedSubview(muteButton)
-    buttons.addArrangedSubview(keepButton)
-
-    root.addArrangedSubview(titleField)
-    root.addArrangedSubview(causeField)
-    root.addArrangedSubview(remediationField)
-    root.addArrangedSubview(buttons)
-
-    panel.contentView = NSView()
-    guard let contentView = panel.contentView else {
-      finish(with: config.keepButton)
-      return
-    }
-    contentView.addSubview(root)
-    NSLayoutConstraint.activate([
-      root.leadingAnchor.constraint(equalTo: contentView.leadingAnchor, constant: 18),
-      root.trailingAnchor.constraint(equalTo: contentView.trailingAnchor, constant: -18),
-      root.topAnchor.constraint(equalTo: contentView.topAnchor, constant: 18),
-      root.bottomAnchor.constraint(equalTo: contentView.bottomAnchor, constant: -18),
-    ])
-
-    self.window = panel
-    resizeWindowToContent(root: root, contentView: contentView)
-    pinWindowToBottomRight()
-    panel.makeKeyAndOrderFront(nil)
-    panel.orderFrontRegardless()
     NSApp.activate(ignoringOtherApps: true)
-    DispatchQueue.main.asyncAfter(deadline: .now() + 0.05) { [weak self] in
-      guard let self else {
-        return
-      }
-      self.resizeWindowToContent(root: root, contentView: contentView)
-      self.pinWindowToBottomRight()
-    }
-  }
 
-  private func startTimeout() {
-    Timer.scheduledTimer(withTimeInterval: config.timeoutSeconds, repeats: false) { [weak self] _ in
-      self?.finish(with: self?.config.keepButton ?? "Mantener activas")
+    let alert = NSAlert()
+    alert.messageText = config.title
+    alert.informativeText = "Causa: \(config.cause)\n\nSolución: \(config.remediation)"
+    alert.alertStyle = .critical
+    alert.addButton(withTitle: config.keepButton)
+    alert.addButton(withTitle: config.muteButton)
+    alert.addButton(withTitle: config.disableButton)
+
+    let response = alert.runModal()
+    let choice: String
+    switch response {
+    case .alertFirstButtonReturn:
+      choice = config.keepButton
+    case .alertSecondButtonReturn:
+      choice = config.muteButton
+    case .alertThirdButtonReturn:
+      choice = config.disableButton
+    default:
+      choice = config.keepButton
     }
-  }
-
-  func windowWillClose(_ notification: Notification) {
-    finish(with: config.keepButton)
-  }
-
-  @objc private func disablePressed() {
-    finish(with: config.disableButton)
-  }
 
-  @objc private func mutePressed() {
-    finish(with: config.muteButton)
-  }
-
-  @objc private func keepPressed() {
-    finish(with: config.keepButton)
-  }
-
-  private func finish(with button: String) {
-    guard chosenButton == nil else {
-      return
-    }
-    chosenButton = button
-    FileHandle.standardOutput.write(Data("button returned:\(button)\n".utf8))
+    FileHandle.standardOutput.write(Data("button returned:\(choice)\n".utf8))
     NSApp.terminate(nil)
   }
 
@@ -252,7 +72,7 @@ final class DialogController: NSObject, NSApplicationDelegate, NSWindowDelegate
 let config = parseArguments()
 let app = NSApplication.shared
 app.setActivationPolicy(.accessory)
-let controller = DialogController(config: config)
-app.delegate = controller
+let delegate = DialogAppDelegate(config: config)
+app.delegate = delegate
 app.run()
 `;

package/scripts/framework-menu-system-notifications-macos.ts

@@ -5,6 +5,7 @@ import {
   type SystemNotificationCommandRunnerWithOutput,
   type SystemNotificationsConfig,
 } from './framework-menu-system-notifications-types';
+import { isTruthyEnvValue } from './framework-menu-system-notifications-env';
 import { resolveBlockedDialogEnabled } from './framework-menu-system-notifications-macos-dialog-enabled';
 import { emitMacOsBannerStage } from './framework-menu-system-notifications-macos-banner-stage';
 import { emitMacOsBlockedDialogStage } from './framework-menu-system-notifications-macos-blocked-stage';
@@ -19,6 +20,9 @@ const shouldSkipMacOsBannerForInteractiveBlockedDialog = (params: {
   config: SystemNotificationsConfig;
   env: NodeJS.ProcessEnv;
 }): boolean => {
+  if (!isTruthyEnvValue(params.env.PUMUKI_MACOS_GATE_BLOCKED_BANNER_DEDUPE)) {
+    return false;
+  }
   if (params.event.kind !== 'gate.blocked') {
     return false;
   }

package/scripts/framework-menu-system-notifications-payloads-blocked.ts

@@ -22,7 +22,7 @@ export const buildGateBlockedPayload = (
     resolveBlockedCauseSummary(event, causeCode),
     72
   );
-  const remediation = resolveBlockedRemediation(event, causeCode, { variant: 'banner' });
+  const remediation = resolveBlockedRemediation(event, causeCode);
   return {
     title: '🔴 Pumuki bloqueado',
     subtitle: `${projectPrefix}${event.stage} · ${causeSummary}`,

package/scripts/framework-menu-system-notifications-text.ts

@@ -7,13 +7,7 @@ export const truncateNotificationText = (value: string, maxLength: number): stri
   if (value.length <= maxLength) {
     return value;
   }
-  const limit = Math.max(1, maxLength - 1);
-  const trimmed = value.slice(0, limit).trimEnd();
-  const boundary = trimmed.lastIndexOf(' ');
-  const shortened = boundary >= Math.floor(limit * 0.6)
-    ? trimmed.slice(0, boundary).trimEnd()
-    : trimmed;
-  return `${shortened}…`;
+  return `${value.slice(0, Math.max(1, maxLength - 1)).trimEnd()}…`;
 };
 
 export const resolveProjectLabel = (params: {

package/scripts/framework-menu.ts

@@ -16,6 +16,7 @@ import {
   runWorkingTreeGateSilent,
   runRepoAndStagedPrePushGateSilent,
   runWorkingTreePrePushGateSilent,
+  runUnstagedGateSilent,
 } from './framework-menu-gate-lib';
 import { createFrameworkMenuPrompts } from './framework-menu-prompts';
 import { resolveDefaultRangeFrom } from './framework-menu-runners';
@@ -24,8 +25,6 @@ import {
   loadAndFormatActiveSkillsBundles,
 } from './framework-menu-skills-lib';
 import { isMenuUiV2Enabled } from './framework-menu-ui-version-lib';
-import { readLifecycleStatus } from '../integrations/lifecycle/status';
-import type { GovernanceConsoleSnapshot } from '../integrations/lifecycle/cliGovernanceConsole';
 export * from './framework-menu-builders';
 export { formatAdvancedMenuView } from './framework-menu-advanced-view-lib';
 export { buildMenuGateParams } from './framework-menu-gate-lib';
@@ -44,20 +43,6 @@ const resolveInitialMenuMode = (): MenuMode => {
   return 'consumer';
 };
 
-const readAdvancedGovernanceConsoleSnapshot = (): GovernanceConsoleSnapshot | null => {
-  try {
-    const status = readLifecycleStatus({ cwd: process.cwd() });
-    return {
-      governanceObservation: status.governanceObservation,
-      governanceNextAction: status.governanceNextAction,
-      policyValidation: status.policyValidation,
-      experimentalFeatures: status.experimentalFeatures,
-    };
-  } catch {
-    return null;
-  }
-};
-
 const menu = async (): Promise<void> => {
   const rl = createInterface({ input, output });
 
@@ -78,7 +63,9 @@ const menu = async (): Promise<void> => {
       runRepoGate: runRepoGateSilent,
       runRepoAndStagedGate: runRepoAndStagedPrePushGateSilent,
       runStagedGate: runStagedGateSilent,
+      runUnstagedGate: runUnstagedGateSilent,
       runWorkingTreeGate: runWorkingTreePrePushGateSilent,
+      runWorkingTreePreCommitGate: runWorkingTreeGateSilent,
       write: (text) => {
         output.write(text);
       },
@@ -89,14 +76,10 @@ const menu = async (): Promise<void> => {
         consumerRuntime.printMenu();
       } else {
         const currentSummary = consumerRuntime.readCurrentSummary();
-        const lastPreflight = consumerRuntime.readLastPreflight();
-        const governanceConsole = lastPreflight ? null : readAdvancedGovernanceConsoleSnapshot();
         if (!isMenuUiV2Enabled()) {
           output.write(
             `\n${formatAdvancedMenuClassicView(advancedActions, {
               evidenceSummary: currentSummary ?? undefined,
-              preflight: lastPreflight ?? undefined,
-              governanceConsole: governanceConsole ?? undefined,
             })}\n`
           );
         } else {
@@ -104,8 +87,6 @@ const menu = async (): Promise<void> => {
             output.write(
               `\n${formatAdvancedMenuView(advancedActions, {
                 evidenceSummary: currentSummary ?? undefined,
-                preflight: lastPreflight ?? undefined,
-                governanceConsole: governanceConsole ?? undefined,
               })}\n`
             );
           } catch {
@@ -113,8 +94,6 @@ const menu = async (): Promise<void> => {
             output.write(
               `\n${formatAdvancedMenuClassicView(advancedActions, {
                 evidenceSummary: currentSummary ?? undefined,
-                preflight: lastPreflight ?? undefined,
-                governanceConsole: governanceConsole ?? undefined,
               })}\n`
             );
           }

package/scripts/package-install-smoke-consumer-git-repo-lib.ts

@@ -39,17 +39,8 @@ export const configureRemoteAndFeatureBranch = (
     workspace.tmpRoot
   );
   runGitStep(workspace, ['remote', 'add', 'origin', workspace.bareRemote], 'git remote add origin');
+  runGitStep(workspace, ['push', '-u', 'origin', 'main'], 'git push origin main');
   runGitStep(workspace, ['checkout', '-b', 'feature/package-smoke'], 'git checkout feature branch');
-  runGitStep(
-    workspace,
-    ['push', '-u', 'origin', 'feature/package-smoke'],
-    'git push origin feature branch'
-  );
-  runGitStep(
-    workspace,
-    ['push', 'origin', 'HEAD:refs/heads/main'],
-    'git push origin main from feature branch'
-  );
   runGitStep(
     workspace,
     ['branch', '--set-upstream-to=origin/main', 'feature/package-smoke'],

package/scripts/package-install-smoke-consumer-npm-lib.ts

@@ -15,11 +15,10 @@ import packageJson from '../package.json';
 const runNpmStep = (
   workspace: SmokeWorkspace,
   args: string[],
-  context: string,
-  env?: NodeJS.ProcessEnv
+  context: string
 ): void => {
   assertSuccess(
-    runCommand({ cwd: workspace.consumerRepo, executable: 'npm', args, env }),
+    runCommand({ cwd: workspace.consumerRepo, executable: 'npm', args }),
     context
   );
 };
@@ -33,14 +32,7 @@ export const installTarballIntoConsumerRepo = (
     'node_modules/\n.ai_evidence.json\n',
     'utf8'
   );
-  runNpmStep(
-    workspace,
-    ['install', workspace.tarballPath ?? ''],
-    'npm install <tarball>',
-    {
-      PUMUKI_SKIP_POSTINSTALL: '1',
-    }
-  );
+  runNpmStep(workspace, ['install', workspace.tarballPath ?? ''], 'npm install <tarball>');
 };
 
 export const verifyInstalledPackageCanBeRequired = (
@@ -59,40 +51,10 @@ export const verifyInstalledPackageCanBeRequired = (
 export const verifyInstalledPumukiBinaryVersion = (
   workspace: SmokeWorkspace
 ): void => {
-  const hasInstalledStatusVersion = (
-    result: ReturnType<typeof runCommand>,
-  ): boolean => {
-    let parsed: unknown;
-    try {
-      parsed = JSON.parse(result.stdout);
-    } catch {
-      return false;
-    }
-
-    const packageVersion =
-      typeof parsed === 'object' && parsed !== null && 'packageVersion' in parsed
-        ? (parsed as { packageVersion?: unknown }).packageVersion
-        : null;
-    const effectiveVersion =
-      typeof parsed === 'object'
-      && parsed !== null
-      && 'version' in parsed
-      && typeof (parsed as { version?: unknown }).version === 'object'
-      && (parsed as { version: { effective?: unknown } }).version !== null
-        ? (parsed as { version: { effective?: unknown } }).version.effective
-        : null;
-
-    return packageVersion === packageJson.version || effectiveVersion === packageJson.version;
-  };
-
   const assertInstalledStatusVersion = (
     result: ReturnType<typeof runCommand>,
     context: string
   ): void => {
-    if (hasInstalledStatusVersion(result)) {
-      return;
-    }
-
     let parsed: unknown;
     try {
       parsed = JSON.parse(result.stdout);
@@ -113,9 +75,11 @@ export const verifyInstalledPumukiBinaryVersion = (
         ? (parsed as { version: { effective?: unknown } }).version.effective
         : null;
 
-    throw new Error(
-      `${context} reported unexpected version (packageVersion=${String(packageVersion)}, effectiveVersion=${String(effectiveVersion)}, expected=${packageJson.version})`
-    );
+    if (packageVersion !== packageJson.version && effectiveVersion !== packageJson.version) {
+      throw new Error(
+        `${context} reported unexpected version (packageVersion=${String(packageVersion)}, effectiveVersion=${String(effectiveVersion)}, expected=${packageJson.version})`
+      );
+    }
   };
 
   const noInstallVersionCheck = runCommand({
@@ -129,8 +93,7 @@ export const verifyInstalledPumukiBinaryVersion = (
     noInstallVersionCheck.exitCode === 0
     && !/Cannot find module|ERR_MODULE_NOT_FOUND|failed to resolve tsx runtime/.test(
       noInstallVersionCheck.combined
-    )
-    && hasInstalledStatusVersion(noInstallVersionCheck);
+    );
   if (noInstallPassed) {
     assertNoFatalOutput(noInstallVersionCheck, 'pumuki status --json smoke');
     assertInstalledStatusVersion(noInstallVersionCheck, 'pumuki status --json smoke');

package/scripts/pumuki-full-surface-smoke-lib.ts

@@ -0,0 +1,37 @@
+import { dirname, join } from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+export type SmokeBinStrategy = 'source' | 'installed';
+
+export const resolveBinStrategy = (raw: string | undefined): SmokeBinStrategy => {
+  const normalized = (raw ?? 'source').trim().toLowerCase();
+  if (normalized === 'installed' || normalized === 'consumer') {
+    return 'installed';
+  }
+  return 'source';
+};
+
+export type SmokeLayout = {
+  pumukiPackageRoot: string;
+  smokeCwd: string;
+  binStrategy: SmokeBinStrategy;
+  binRoot: string;
+};
+
+export const resolveSmokeLayout = (params: {
+  scriptFileUrl: string;
+  env: NodeJS.ProcessEnv;
+}): SmokeLayout => {
+  const pumukiPackageRoot = join(dirname(fileURLToPath(params.scriptFileUrl)), '..');
+  const smokeCwd =
+    (params.env.PUMUKI_SMOKE_REPO_ROOT ?? pumukiPackageRoot).trim() || pumukiPackageRoot;
+  const binStrategy = resolveBinStrategy(params.env.PUMUKI_SMOKE_BIN_STRATEGY);
+  const binRoot =
+    binStrategy === 'installed'
+      ? join(smokeCwd, 'node_modules', 'pumuki')
+      : pumukiPackageRoot;
+  return { pumukiPackageRoot, smokeCwd, binStrategy, binRoot };
+};
+
+export const installedBinMarkerPath = (layout: SmokeLayout): string =>
+  join(layout.binRoot, 'bin', 'pumuki.js');