pumuki-ast-hooks 6.1.10 → 6.1.13

package/scripts/hooks-system/infrastructure/ast/text/__tests__/text-scanner.spec.js

@@ -65,5 +65,65 @@ describe('Text Scanner Module', () => {
       const typeSafety = findings.find(f => f.ruleId === 'ios.optionals.type_safety');
       expect(typeSafety).toBeUndefined();
     });
+
+    it('flags switch-based message provider mapping to string literals', () => {
+      const root = fs.mkdtempSync(path.join(os.tmpdir(), 'ast-text-'));
+      const filePath = path.join(root, 'SupportMessageProvider.swift');
+      const content = [
+        'enum SupportStatus {',
+        '  case active',
+        '  case inactive',
+        '}',
+        '',
+        'struct SupportMessageProvider {',
+        '  func message(for status: SupportStatus) -> String {',
+        '    switch status {',
+        '    case .active:',
+        '      return "support.active"',
+        '    case .inactive:',
+        '      return "support.inactive"',
+        '    }',
+        '  }',
+        '}'
+      ].join('\n');
+
+      fs.writeFileSync(filePath, content, 'utf8');
+
+      const findings = [];
+      runTextScanner(root, findings);
+
+      const ocpFinding = findings.find(f => f.ruleId === 'ios.solid.ocp_switch_to_string');
+      expect(ocpFinding).toBeDefined();
+    });
+  });
+
+  describe('android rules', () => {
+    it('flags when-based message provider mapping to string literals', () => {
+      const root = fs.mkdtempSync(path.join(os.tmpdir(), 'ast-text-'));
+      const filePath = path.join(root, 'SupportMessageProvider.kt');
+      const content = [
+        'enum class SupportStatus {',
+        '  ACTIVE,',
+        '  INACTIVE',
+        '}',
+        '',
+        'class SupportMessageProvider {',
+        '  fun message(status: SupportStatus): String {',
+        '    return when (status) {',
+        '      SupportStatus.ACTIVE -> "support.active"',
+        '      SupportStatus.INACTIVE -> "support.inactive"',
+        '    }',
+        '  }',
+        '}'
+      ].join('\n');
+
+      fs.writeFileSync(filePath, content, 'utf8');
+
+      const findings = [];
+      runTextScanner(root, findings);
+
+      const ocpFinding = findings.find(f => f.ruleId === 'android.solid.ocp_switch_to_string');
+      expect(ocpFinding).toBeDefined();
+    });
   });
 });

package/scripts/hooks-system/infrastructure/ast/text/text-scanner.js

@@ -15,6 +15,58 @@ function walk(dir, acc) {
   }
 }
 
+function hasProviderNameHint(content, filePath) {
+  const providerNamePattern = /\b(class|struct|object)\s+[A-Za-z_][A-Za-z0-9_]*(Message|Notice|Localization|Provider|Presenter|Mapper)[A-Za-z0-9_]*\b/i;
+  if (providerNamePattern.test(content)) return true;
+  const baseName = path.basename(filePath, path.extname(filePath));
+  return /Message|Notice|Localization|Provider|Presenter|Mapper/i.test(baseName);
+}
+
+function hasSwiftMappingHint(content) {
+  return /\brawValue\b/.test(content) || /\bDictionary<[^>]*String\b/.test(content) || /\[[A-Za-z_][A-Za-z0-9_]*\s*:\s*String\]/.test(content);
+}
+
+function hasKotlinMappingHint(content) {
+  return /\bmapOf\s*\(|\bmutableMapOf\s*\(|\bMap<[^>]*String\b/.test(content);
+}
+
+function hasSwiftSwitchToString(content) {
+  const switchPattern = /switch\s+[A-Za-z_][A-Za-z0-9_]*\s*\{[^}]*\}/g;
+  let match;
+  while ((match = switchPattern.exec(content)) !== null) {
+    const block = match[0];
+    if (!/\bcase\b/.test(block)) continue;
+    if (!/\"[^\"]+\"/.test(block)) continue;
+    if (!/case\s+(\.|[A-Za-z_][A-Za-z0-9_]*\.)[A-Za-z_][A-Za-z0-9_]*\s*:/.test(block)) continue;
+    if (/\breturn\b/.test(block) || /case\s+[^\n:]+:\s*\"[^\"]+\"/.test(block)) return true;
+  }
+  return false;
+}
+
+function hasKotlinWhenToString(content) {
+  const whenPattern = /when\s*\([^)]*\)\s*\{[^}]*\}/g;
+  let match;
+  while ((match = whenPattern.exec(content)) !== null) {
+    const block = match[0];
+    if (!/[A-Za-z_][A-Za-z0-9_]*\.[A-Za-z_][A-Za-z0-9_]*\s*->\s*\"[^\"]+\"/.test(block)) continue;
+    return true;
+  }
+  return false;
+}
+
+function shouldFlagMessageProviderSwitch(content, filePath, language) {
+  if (!hasProviderNameHint(content, filePath)) return false;
+  if (language === 'swift') {
+    if (hasSwiftMappingHint(content)) return false;
+    return hasSwiftSwitchToString(content);
+  }
+  if (language === 'kotlin') {
+    if (hasKotlinMappingHint(content)) return false;
+    return hasKotlinWhenToString(content);
+  }
+  return false;
+}
+
 function runTextScanner(root, findings) {
   const files = [];
   let iosAnchorFile = null;
@@ -541,6 +593,11 @@ function runTextScanner(root, findings) {
       if (/Handler\(\)\.post/.test(content) && !/@SuppressLint\("HandlerLeak"\)/.test(content)) {
         pushFileFinding('android.antipattern.handler_leak', 'high', file, 1, 1, 'Handler without weak reference - potential memory leak', findings);
       }
+      const isAnalyzer = /infrastructure\/ast\/|analyzers\/|detectors\/|scanner|analyzer|detector/i.test(file);
+      const isTestFile = /\.(spec|test)\.(js|ts|kt|kts)$/i.test(file);
+      if ((ext === '.kt' || ext === '.kts') && !isAnalyzer && !isTestFile && shouldFlagMessageProviderSwitch(content, file, 'kotlin')) {
+        pushFileFinding('android.solid.ocp_switch_to_string', 'medium', file, 1, 1, 'OCP warning: switch-to-string mapping in message/localization provider - prefer injected map or enum raw values', findings);
+      }
     }
 
     if (plat === 'ios') {
@@ -636,6 +693,9 @@ function runTextScanner(root, findings) {
       if (/Text\(\s*\"[^\"]+\"\s*\)/.test(content) && !/NSLocalizedString|\.localized/.test(content)) {
         pushFileFinding('ios.i18n.hardcoded_strings', 'medium', file, 1, 1, 'Hardcoded string in Text() without localization', findings);
       }
+      if (!isAnalyzer && !isTestFile && shouldFlagMessageProviderSwitch(content, file, 'swift')) {
+        pushFileFinding('ios.solid.ocp_switch_to_string', 'medium', file, 1, 1, 'OCP warning: switch-to-string mapping in message/localization provider - prefer RawRepresentable or injected map', findings);
+      }
       if (/Date\(/.test(content) && !/DateFormatter/.test(content)) {
         pushFileFinding('ios.i18n.missing_date_formatter', 'medium', file, 1, 1, 'Date rendered without DateFormatter', findings);
       }

package/scripts/hooks-system/infrastructure/orchestration/__tests__/intelligent-audit.spec.js

@@ -129,6 +129,46 @@ describe('intelligent-audit', () => {
     expect(updated.timestamp).toBeDefined();
     expect(updated.timestamp).not.toBe(previous.timestamp);
   });
+
+  it('should include medium and low violations in ai_gate output when critical or high exist', async () => {
+    const evidencePath = path.join(process.cwd(), '.AI_EVIDENCE.json');
+    const original = fs.existsSync(evidencePath) ? fs.readFileSync(evidencePath, 'utf8') : null;
+    const minimal = {
+      timestamp: new Date().toISOString(),
+      severity_metrics: {
+        last_updated: new Date().toISOString(),
+        total_violations: 0,
+        by_severity: { CRITICAL: 0, HIGH: 0, MEDIUM: 0, LOW: 0 }
+      },
+      ai_gate: { status: 'ALLOWED', scope: 'staging', last_check: new Date().toISOString(), violations: [], instruction: 'x', mandatory: true }
+    };
+
+    try {
+      fs.writeFileSync(evidencePath, JSON.stringify(minimal, null, 2));
+
+      const mod = require('../intelligent-audit');
+      const violations = [
+        { severity: 'CRITICAL', ruleId: 'rule.critical', filePath: 'apps/a.ts', line: 1, message: 'c' },
+        { severity: 'HIGH', ruleId: 'rule.high', filePath: 'apps/b.ts', line: 2, message: 'h' },
+        { severity: 'MEDIUM', ruleId: 'rule.medium', filePath: 'apps/c.ts', line: 3, message: 'm' },
+        { severity: 'LOW', ruleId: 'rule.low', filePath: 'apps/d.ts', line: 4, message: 'l' }
+      ];
+
+      await mod.updateAIEvidence(violations, { passed: false, blockedBy: 'critical' }, { estimated: 1, percentUsed: 0, remaining: 1 });
+
+      const updated = JSON.parse(fs.readFileSync(evidencePath, 'utf8'));
+      const severities = updated.ai_gate.violations.map(v => v.severity);
+      expect(severities).toEqual(expect.arrayContaining(['CRITICAL', 'HIGH', 'MEDIUM', 'LOW']));
+    } finally {
+      if (original === null) {
+        if (fs.existsSync(evidencePath)) {
+          fs.unlinkSync(evidencePath);
+        }
+      } else {
+        fs.writeFileSync(evidencePath, original);
+      }
+    }
+  });
 });
 
 describe('AI_EVIDENCE.json structure validation', () => {

package/scripts/hooks-system/infrastructure/orchestration/intelligent-audit.js

@@ -736,11 +736,10 @@ async function updateAIEvidence(violations, gateResult, tokenUsage) {
     const mediumViolations = violations.filter(v => v.severity === 'MEDIUM');
     const lowViolations = violations.filter(v => v.severity === 'LOW');
 
-    let gateViolations = [...criticalViolations, ...highViolations];
-    if (gateViolations.length === 0) {
-      gateViolations = [...mediumViolations, ...lowViolations];
-    }
-    const blockingViolations = gateViolations.slice(0, 50);
+    const maxGateViolations = env.getNumber('AI_GATE_MAX_VIOLATIONS', 200);
+    const gateViolationsLimit = Number.isFinite(maxGateViolations) && maxGateViolations > 0 ? maxGateViolations : 200;
+    const gateViolations = [...criticalViolations, ...highViolations, ...mediumViolations, ...lowViolations];
+    const blockingViolations = gateViolations.slice(0, gateViolationsLimit);
 
     const gateScope = String(env.get('AI_GATE_SCOPE', 'staging') || 'staging').trim().toLowerCase();
 

package/scripts/hooks-system/infrastructure/shell/gitflow/__tests__/gitflow-enforcer.spec.js

@@ -0,0 +1,17 @@
+const fs = require('fs');
+const path = require('path');
+
+describe('gitflow-enforcer', () => {
+    const scriptPath = path.join(__dirname, '..', 'gitflow-enforcer.sh');
+
+    test('debe ignorar xcuserdata en atomicidad', () => {
+        const script = fs.readFileSync(scriptPath, 'utf8');
+        expect(script).toMatch(/xcuserdata/);
+    });
+
+    test('debe omitir lint:hooks si no esta configurado', () => {
+        const script = fs.readFileSync(scriptPath, 'utf8');
+        expect(script).toMatch(/lint:hooks/);
+        expect(script).toMatch(/no configurado/);
+    });
+});

package/scripts/hooks-system/infrastructure/shell/gitflow/gitflow-enforcer.sh

@@ -93,11 +93,24 @@ refresh_evidence() {
   printf "${GREEN}✅ Evidencia renovada (${reason}).${NC}\n"
 }
 
+has_lint_hooks_script() {
+  local pkg="$1"
+  if [[ ! -f "$pkg" ]]; then
+    return 1
+  fi
+  if node -e "const fs=require('fs');const p=JSON.parse(fs.readFileSync(process.argv[1],'utf8'));process.exit(p&&p.scripts&&p.scripts['lint:hooks']?0:1);" "$pkg" >/dev/null 2>&1; then
+    return 0
+  fi
+  return 1
+}
+
 lint_hooks_system() {
   local repo_pkg="${REPO_ROOT}/package.json"
   local hooks_pkg="${REPO_ROOT}/scripts/hooks-system/package.json"
+  local ran=0
 
-  if [[ -f "${repo_pkg}" ]]; then
+  if has_lint_hooks_script "${repo_pkg}"; then
+    ran=1
     printf "${CYAN}🔎 Ejecutando lint (repo root)...${NC}\n"
     if npm --prefix "${REPO_ROOT}" run lint:hooks; then
       printf "${GREEN}✅ Lint hooks-system OK.${NC}\n"
@@ -105,7 +118,8 @@ lint_hooks_system() {
     fi
   fi
 
-  if [[ -f "${hooks_pkg}" ]]; then
+  if has_lint_hooks_script "${hooks_pkg}"; then
+    ran=1
     printf "${CYAN}🔎 Ejecutando lint (scripts/hooks-system)...${NC}\n"
     if npm --prefix "${REPO_ROOT}/scripts/hooks-system" run lint:hooks; then
       printf "${GREEN}✅ Lint hooks-system OK.${NC}\n"
@@ -113,6 +127,11 @@ lint_hooks_system() {
     fi
   fi
 
+  if [[ "$ran" -eq 0 ]]; then
+    printf "${YELLOW}ℹ️  lint:hooks no configurado; se omite.${NC}\n"
+    return 0
+  fi
+
   printf "${RED}❌ Lint hooks-system falló.${NC}\n"
   return 1
 }
@@ -178,12 +197,17 @@ verify_atomic_commit() {
   local roots_list=""
   local root_count=0
   for file in "${files[@]}"; do
+    case "$file" in
+      */xcuserdata/*|*/xcuserdatad/*)
+        continue
+        ;;
+    esac
     local root="${file%%/*}"
     if [[ "$root" == "$file" ]]; then
       root="(root)"
     fi
     case "$root" in
-      .AI_EVIDENCE.json|README.md|CHANGELOG.md|docs )
+      .AI_EVIDENCE.json|README.md|CHANGELOG.md|docs|.audit_tmp|.audit-reports|.cursor|.windsurf|xcuserdata|xcuserdatad )
         continue
         ;;
       "" )

package/scripts/hooks-system/infrastructure/watchdog/__tests__/.audit-reports/token-monitor.log

@@ -127,3 +127,24 @@
 {"timestamp":"2026-01-15T14:53:25.770Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"ok","percentUsed":10,"tokensUsed":100000,"maxTokens":1000000,"source":"realtime","stale":false},"context":{"message":"Result level=ok percent=10% used=100000/1000000 source=realtime"}}
 {"timestamp":"2026-01-15T14:53:25.772Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"warning","percentUsed":91,"tokensUsed":910000,"maxTokens":1000000,"source":"fallback","stale":false},"context":{"message":"Result level=warning percent=91% used=910000/1000000 source=fallback"}}
 {"timestamp":"2026-01-15T14:53:25.772Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"critical","percentUsed":98,"tokensUsed":980000,"maxTokens":1000000,"source":"realtime","stale":true},"context":{"message":"Result level=critical percent=98% used=980000/1000000 source=realtime (stale)"}}
+{"timestamp":"2026-01-21T12:12:08.680Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"ok","percentUsed":10,"tokensUsed":100000,"maxTokens":1000000,"source":"realtime","stale":false},"context":{"message":"Result level=ok percent=10% used=100000/1000000 source=realtime"}}
+{"timestamp":"2026-01-21T12:12:08.681Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"warning","percentUsed":91,"tokensUsed":910000,"maxTokens":1000000,"source":"fallback","stale":false},"context":{"message":"Result level=warning percent=91% used=910000/1000000 source=fallback"}}
+{"timestamp":"2026-01-21T12:12:08.681Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"critical","percentUsed":98,"tokensUsed":980000,"maxTokens":1000000,"source":"realtime","stale":true},"context":{"message":"Result level=critical percent=98% used=980000/1000000 source=realtime (stale)"}}
+{"timestamp":"2026-01-21T13:01:16.348Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"ok","percentUsed":10,"tokensUsed":100000,"maxTokens":1000000,"source":"realtime","stale":false},"context":{"message":"Result level=ok percent=10% used=100000/1000000 source=realtime"}}
+{"timestamp":"2026-01-21T13:01:16.349Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"warning","percentUsed":91,"tokensUsed":910000,"maxTokens":1000000,"source":"fallback","stale":false},"context":{"message":"Result level=warning percent=91% used=910000/1000000 source=fallback"}}
+{"timestamp":"2026-01-21T13:01:16.350Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"critical","percentUsed":98,"tokensUsed":980000,"maxTokens":1000000,"source":"realtime","stale":true},"context":{"message":"Result level=critical percent=98% used=980000/1000000 source=realtime (stale)"}}
+{"timestamp":"2026-01-21T13:17:08.086Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"ok","percentUsed":10,"tokensUsed":100000,"maxTokens":1000000,"source":"realtime","stale":false},"context":{"message":"Result level=ok percent=10% used=100000/1000000 source=realtime"}}
+{"timestamp":"2026-01-21T13:17:08.088Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"warning","percentUsed":91,"tokensUsed":910000,"maxTokens":1000000,"source":"fallback","stale":false},"context":{"message":"Result level=warning percent=91% used=910000/1000000 source=fallback"}}
+{"timestamp":"2026-01-21T13:17:08.089Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"critical","percentUsed":98,"tokensUsed":980000,"maxTokens":1000000,"source":"realtime","stale":true},"context":{"message":"Result level=critical percent=98% used=980000/1000000 source=realtime (stale)"}}
+{"timestamp":"2026-01-21T14:08:15.939Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"ok","percentUsed":10,"tokensUsed":100000,"maxTokens":1000000,"source":"realtime","stale":false},"context":{"message":"Result level=ok percent=10% used=100000/1000000 source=realtime"}}
+{"timestamp":"2026-01-21T14:08:15.943Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"warning","percentUsed":91,"tokensUsed":910000,"maxTokens":1000000,"source":"fallback","stale":false},"context":{"message":"Result level=warning percent=91% used=910000/1000000 source=fallback"}}
+{"timestamp":"2026-01-21T14:08:15.945Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"critical","percentUsed":98,"tokensUsed":980000,"maxTokens":1000000,"source":"realtime","stale":true},"context":{"message":"Result level=critical percent=98% used=980000/1000000 source=realtime (stale)"}}
+{"timestamp":"2026-01-21T14:14:45.047Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"ok","percentUsed":10,"tokensUsed":100000,"maxTokens":1000000,"source":"realtime","stale":false},"context":{"message":"Result level=ok percent=10% used=100000/1000000 source=realtime"}}
+{"timestamp":"2026-01-21T14:14:45.048Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"warning","percentUsed":91,"tokensUsed":910000,"maxTokens":1000000,"source":"fallback","stale":false},"context":{"message":"Result level=warning percent=91% used=910000/1000000 source=fallback"}}
+{"timestamp":"2026-01-21T14:14:45.048Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"critical","percentUsed":98,"tokensUsed":980000,"maxTokens":1000000,"source":"realtime","stale":true},"context":{"message":"Result level=critical percent=98% used=980000/1000000 source=realtime (stale)"}}
+{"timestamp":"2026-01-21T14:19:16.416Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"ok","percentUsed":10,"tokensUsed":100000,"maxTokens":1000000,"source":"realtime","stale":false},"context":{"message":"Result level=ok percent=10% used=100000/1000000 source=realtime"}}
+{"timestamp":"2026-01-21T14:19:16.417Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"warning","percentUsed":91,"tokensUsed":910000,"maxTokens":1000000,"source":"fallback","stale":false},"context":{"message":"Result level=warning percent=91% used=910000/1000000 source=fallback"}}
+{"timestamp":"2026-01-21T14:19:16.418Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"critical","percentUsed":98,"tokensUsed":980000,"maxTokens":1000000,"source":"realtime","stale":true},"context":{"message":"Result level=critical percent=98% used=980000/1000000 source=realtime (stale)"}}
+{"timestamp":"2026-01-21T14:43:17.747Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"ok","percentUsed":10,"tokensUsed":100000,"maxTokens":1000000,"source":"realtime","stale":false},"context":{"message":"Result level=ok percent=10% used=100000/1000000 source=realtime"}}
+{"timestamp":"2026-01-21T14:43:17.748Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"warning","percentUsed":91,"tokensUsed":910000,"maxTokens":1000000,"source":"fallback","stale":false},"context":{"message":"Result level=warning percent=91% used=910000/1000000 source=fallback"}}
+{"timestamp":"2026-01-21T14:43:17.749Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"critical","percentUsed":98,"tokensUsed":980000,"maxTokens":1000000,"source":"realtime","stale":true},"context":{"message":"Result level=critical percent=98% used=980000/1000000 source=realtime (stale)"}}