pumuki-ast-hooks 6.0.7 → 6.0.9

package/docs/RELEASE_NOTES.md

@@ -1,3 +1,31 @@
+# Release Notes - v6.0.9
+
+**Release Date**: January 13, 2026  
+**Type**: Patch Release  
+**Compatibility**: Fully backward compatible with 6.0.x
+
+---
+
+## ✅ Fixes
+
+- **iOS DIP detector**: protocol-named types like `LoginUseCase` are treated as abstract unless they are `*Impl`.
+
+---
+
+# Release Notes - v6.0.8
+
+**Release Date**: January 13, 2026  
+**Type**: Patch Release  
+**Compatibility**: Fully backward compatible with 6.0.x
+
+---
+
+## ✅ Fixes
+
+- **iOS DIP detector**: protocol-constrained generics (e.g. `<Client: APIClientProtocol>`) are treated as abstract dependencies.
+
+---
+
 # Release Notes - v6.0.7
 
 **Release Date**: January 13, 2026  

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pumuki-ast-hooks",
-  "version": "6.0.7",
+  "version": "6.0.9",
   "description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
   "main": "index.js",
   "bin": {
@@ -135,4 +135,4 @@
     "./skills": "./skills/skill-rules.json",
     "./hooks": "./hooks/index.js"
   }
-}
+}

package/scripts/hooks-system/.audit_tmp/hook-metrics.jsonl

@@ -790,3 +790,7 @@
 {"timestamp":1768290665489,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
 {"timestamp":1768290665489,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
 {"timestamp":1768290665489,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768293907758,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768293907758,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1768293907758,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1768293907758,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}

package/scripts/hooks-system/application/__tests__/DIValidationService.spec.js

@@ -35,13 +35,7 @@ describe('DIValidationService', () => {
                 "'TestViewModel' depends on concrete 'APIClient' - use protocol"
             );
 
-            expect(mockAnalyzer.pushFinding).toHaveBeenCalledWith(
-                'ios.solid.dip.concrete_dependency',
-                'high',
-                'TestViewModel.swift',
-                10,
-                "'TestViewModel' depends on concrete 'UserRepository' - use protocol"
-            );
+            expect(mockAnalyzer.pushFinding).toHaveBeenCalledTimes(1);
         });
 
         it('should skip allowed types', async () => {
@@ -77,5 +71,39 @@ describe('DIValidationService', () => {
 
             expect(mockAnalyzer.pushFinding).not.toHaveBeenCalled();
         });
+
+        it('should skip generic constraints that bind to protocols', async () => {
+            mockAnalyzer.fileContent = 'final class TestViewModel<Client: APIClientProtocol> { }';
+            const properties = [
+                { 'key.name': 'apiClient', 'key.typename': 'Client' }
+            ];
+
+            await diValidationService.validateDependencyInjection(
+                mockAnalyzer,
+                properties,
+                'TestViewModel.swift',
+                'TestViewModel',
+                10
+            );
+
+            expect(mockAnalyzer.pushFinding).not.toHaveBeenCalled();
+        });
+
+        it('should skip protocol-named concrete-like types', async () => {
+            const properties = [
+                { 'key.name': 'loginUseCase', 'key.typename': 'LoginUseCase' },
+                { 'key.name': 'logoutUseCase', 'key.typename': 'LogoutUseCase' }
+            ];
+
+            await diValidationService.validateDependencyInjection(
+                mockAnalyzer,
+                properties,
+                'AuthLoginRepositoryImpl.swift',
+                'AuthLoginRepositoryImpl',
+                1
+            );
+
+            expect(mockAnalyzer.pushFinding).not.toHaveBeenCalled();
+        });
     });
 });

package/scripts/hooks-system/domain/strategies/ConcreteDependencyStrategy.js

@@ -18,7 +18,7 @@ class ConcreteDependencyStrategy extends DIStrategy {
             const typename = prop['key.typename'] || '';
             const propName = prop['key.name'] || '';
 
-            if (this._shouldSkipType(typename, propName, className)) {
+            if (this._shouldSkipType(typename, propName, className, context)) {
                 continue;
             }
 
@@ -34,15 +34,23 @@ class ConcreteDependencyStrategy extends DIStrategy {
         return violations;
     }
 
-    _shouldSkipType(typename, propName, className) {
+    _shouldSkipType(typename, propName, className, context) {
         if (this.config.allowedTypes.includes(typename)) {
             return true;
         }
 
+        if (this._isLikelyProtocolType(typename)) {
+            return true;
+        }
+
         if (this._isGenericTypeParameter(typename, propName, className)) {
             return true;
         }
 
+        if (this._isGenericConstraintType(typename, className, context)) {
+            return true;
+        }
+
         return false;
     }
 
@@ -62,6 +70,23 @@ class ConcreteDependencyStrategy extends DIStrategy {
         return isSingleLetter || (isCamelCase && hasContextHint);
     }
 
+    _isGenericConstraintType(typename, className, context) {
+        const content = context?.analyzer?.fileContent || '';
+        if (!content) return false;
+
+        const classPattern = new RegExp(`\\b(class|struct)\\s+${className}\\s*<([^>]+)>`);
+        const match = content.match(classPattern);
+        if (!match) return false;
+
+        const genericClause = match[2];
+        const constraints = genericClause.split(',').map((part) => part.trim());
+
+        return constraints.some((constraint) => {
+            const [name, bound] = constraint.split(':').map((value) => value.trim());
+            return name === typename && bound;
+        });
+    }
+
     _isConcreteService(typename) {
         const hasConcretePattern = this.config.concretePatterns.some(pattern =>
             new RegExp(pattern).test(typename)
@@ -73,6 +98,13 @@ class ConcreteDependencyStrategy extends DIStrategy {
 
         return hasConcretePattern && !hasProtocolIndicator;
     }
+
+    _isLikelyProtocolType(typename) {
+        if (/Impl$/.test(typename)) {
+            return false;
+        }
+        return /UseCase$|Repository$/.test(typename);
+    }
 }
 
 module.exports = ConcreteDependencyStrategy;