pumuki-ast-hooks 5.6.12 → 5.6.14

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pumuki-ast-hooks",
-  "version": "5.6.12",
+  "version": "5.6.14",
   "description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
   "main": "index.js",
   "bin": {

package/scripts/hooks-system/.audit-reports/auto-recovery.log

@@ -9,3 +9,4 @@
 {"timestamp":"2026-01-11T18:48:20.329Z","level":"info","component":"AutoRecovery","event":"NotificationCenterService shutdown","data":{"totalEnqueued":0,"totalSent":0,"totalDeduplicated":0,"totalCooldownSkipped":0,"totalFailed":0,"totalRetries":0,"queueSize":0,"deduplication":{"size":0},"cooldowns":{"activeCooldowns":0}},"context":{}}
 {"timestamp":"2026-01-11T18:54:50.282Z","level":"info","component":"AutoRecovery","event":"NotificationCenterService shutdown","data":{"totalEnqueued":0,"totalSent":0,"totalDeduplicated":0,"totalCooldownSkipped":0,"totalFailed":0,"totalRetries":0,"queueSize":0,"deduplication":{"size":0},"cooldowns":{"activeCooldowns":0}},"context":{}}
 {"timestamp":"2026-01-11T19:08:34.232Z","level":"info","component":"AutoRecovery","event":"NotificationCenterService shutdown","data":{"totalEnqueued":0,"totalSent":0,"totalDeduplicated":0,"totalCooldownSkipped":0,"totalFailed":0,"totalRetries":0,"queueSize":0,"deduplication":{"size":0},"cooldowns":{"activeCooldowns":0}},"context":{}}
+{"timestamp":"2026-01-11T20:43:24.310Z","level":"info","component":"AutoRecovery","event":"NotificationCenterService shutdown","data":{"totalEnqueued":0,"totalSent":0,"totalDeduplicated":0,"totalCooldownSkipped":0,"totalFailed":0,"totalRetries":0,"queueSize":0,"deduplication":{"size":0},"cooldowns":{"activeCooldowns":0}},"context":{}}

package/scripts/hooks-system/.audit-reports/install-wizard.log

@@ -42,3 +42,7 @@
 {"timestamp":"2026-01-11T19:08:34.083Z","level":"info","component":"InstallWizard","event":"INSTALL_WIZARD_CONFIG_EXISTS","data":{"configPath":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system/.hook-system/config.json"},"context":{}}
 {"timestamp":"2026-01-11T19:08:34.083Z","level":"error","component":"InstallWizard","event":"INSTALL_WIZARD_SYMLINK_FAILED","data":{"error":"EEXIST: file already exists, symlink '/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system/scripts/hooks-system/bin/guard-supervisor.js' -> '/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system/.git/hooks/guard-supervisor'"},"context":{}}
 {"timestamp":"2026-01-11T19:08:34.083Z","level":"info","component":"InstallWizard","event":"INSTALL_WIZARD_COMPLETED","data":{},"context":{}}
+{"timestamp":"2026-01-11T20:43:24.451Z","level":"info","component":"InstallWizard","event":"INSTALL_WIZARD_START","data":{"repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"},"context":{}}
+{"timestamp":"2026-01-11T20:43:24.460Z","level":"info","component":"InstallWizard","event":"INSTALL_WIZARD_CONFIG_EXISTS","data":{"configPath":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system/.hook-system/config.json"},"context":{}}
+{"timestamp":"2026-01-11T20:43:24.461Z","level":"error","component":"InstallWizard","event":"INSTALL_WIZARD_SYMLINK_FAILED","data":{"error":"EEXIST: file already exists, symlink '/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system/scripts/hooks-system/bin/guard-supervisor.js' -> '/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system/.git/hooks/guard-supervisor'"},"context":{}}
+{"timestamp":"2026-01-11T20:43:24.461Z","level":"info","component":"InstallWizard","event":"INSTALL_WIZARD_COMPLETED","data":{},"context":{}}

package/scripts/hooks-system/.audit_tmp/hook-metrics.jsonl

@@ -502,3 +502,31 @@
 {"timestamp":1768158974401,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
 {"timestamp":1768158974401,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
 {"timestamp":1768158974402,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768162663136,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768162663136,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1768162663136,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1768162663136,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768164204308,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768164204309,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1768164204309,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1768164204309,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1768164204310,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}

package/scripts/hooks-system/infrastructure/ast/common/__tests__/ast-common.spec.js

@@ -58,6 +58,132 @@ describe('AST Common Module', () => {
       expect(findings.some(f => f.ruleId === 'common.testing.missing_makesut')).toBe(false);
       expect(findings.some(f => f.ruleId === 'common.testing.missing_track_for_memory_leaks')).toBe(false);
     });
+
+    it('does not report false positives for Swift test files when getFullText is non-empty but incomplete (prefer disk)', () => {
+      const project = new Project({
+        useInMemoryFileSystem: true,
+        skipAddingFilesFromTsConfig: true,
+      });
+
+      const swiftPath = '/tmp/DomainAPIEndpointTests.spec.swift';
+      const swiftContent = [
+        'import XCTest',
+        'final class DomainAPIEndpointTests: XCTestCase {',
+        '  private func makeSUT() -> Foo { Foo() }',
+        '  func test_example() {',
+        '    let sut = makeSUT()',
+        '    trackForMemoryLeaks(sut, testCase: self, file: #file, line: #line)',
+        '  }',
+        '}',
+      ].join('\n');
+
+      const sf = project.createSourceFile(swiftPath, swiftContent);
+      jest.spyOn(sf, 'getFullText').mockReturnValue('import XCTest\nfinal class DomainAPIEndpointTests: XCTestCase {}');
+      jest.spyOn(fs, 'readFileSync').mockReturnValue(swiftContent);
+
+      const findings = [];
+      runCommonIntelligence(project, findings);
+
+      expect(findings.some(f => f.ruleId === 'common.testing.missing_makesut')).toBe(false);
+      expect(findings.some(f => f.ruleId === 'common.testing.missing_track_for_memory_leaks')).toBe(false);
+    });
+
+    it('does not report false positives for simple value type tests (Ruralgo case)', () => {
+      const project = new Project({
+        useInMemoryFileSystem: true,
+        skipAddingFilesFromTsConfig: true,
+      });
+
+      const swiftPath = '/tmp/DomainAPIEndpointTests.spec.swift';
+      const simpleValueTypeTest = `import Domain
+import XCTest
+
+final class DomainAPIEndpointTests: XCTestCase {
+  func test_givenCustomInit_whenAccessingProperties_thenReturnsExpectedValues() {
+    let body = Data([0x01, 0x02])
+    let queryItems = [URLQueryItem(name: "page", value: "1")]
+
+    let endpointPatch = APIEndpoint(
+      path: "/any", method: .patch, body: body, queryItems: queryItems)
+
+    XCTAssertEqual(endpointPatch.path, "/any")
+    XCTAssertEqual(endpointPatch.method, .patch)
+    XCTAssertEqual(endpointPatch.body, body)
+    XCTAssertEqual(endpointPatch.queryItems, queryItems)
+  }
+}`;
+
+      const sf = project.createSourceFile(swiftPath, simpleValueTypeTest);
+      jest.spyOn(fs, 'readFileSync').mockReturnValue(simpleValueTypeTest);
+
+      const findings = [];
+      runCommonIntelligence(project, findings);
+
+      expect(findings.some(f => f.ruleId === 'common.testing.missing_makesut')).toBe(false);
+      expect(findings.some(f => f.ruleId === 'common.testing.missing_track_for_memory_leaks')).toBe(false);
+    });
+
+    it('does apply rules to complex tests with async/classes', () => {
+      const project = new Project({
+        useInMemoryFileSystem: true,
+        skipAddingFilesFromTsConfig: true,
+      });
+
+      const swiftPath = '/tmp/NetworkClientTests.spec.swift';
+      const complexTest = `import XCTest
+
+final class NetworkClientTests: XCTestCase {
+  override func setUp() {
+    super.setUp()
+  }
+
+  func test_load_deliversErrorOnClientError() async {
+    let client = HTTPClient()
+    let result = await client.load()
+    XCTAssertNotNil(result)
+  }
+}`;
+
+      const sf = project.createSourceFile(swiftPath, complexTest);
+      jest.spyOn(fs, 'readFileSync').mockReturnValue(complexTest);
+
+      const findings = [];
+      runCommonIntelligence(project, findings);
+
+      expect(findings.some(f => f.ruleId === 'common.testing.missing_makesut')).toBe(true);
+      expect(findings.some(f => f.ruleId === 'common.testing.missing_track_for_memory_leaks')).toBe(true);
+    });
+
+    it('respects ast-ignore comments', () => {
+      const project = new Project({
+        useInMemoryFileSystem: true,
+        skipAddingFilesFromTsConfig: true,
+      });
+
+      const swiftPath = '/tmp/SomeTests.spec.swift';
+      const testWithIgnore = `import XCTest
+// ast-ignore: missing_makesut, missing_track_for_memory_leaks
+
+final class SomeTests: XCTestCase {
+  override func setUp() {
+    super.setUp()
+  }
+
+  func test_something() async {
+    let result = await someAsyncCall()
+    XCTAssertNotNil(result)
+  }
+}`;
+
+      const sf = project.createSourceFile(swiftPath, testWithIgnore);
+      jest.spyOn(fs, 'readFileSync').mockReturnValue(testWithIgnore);
+
+      const findings = [];
+      runCommonIntelligence(project, findings);
+
+      expect(findings.some(f => f.ruleId === 'common.testing.missing_makesut')).toBe(false);
+      expect(findings.some(f => f.ruleId === 'common.testing.missing_track_for_memory_leaks')).toBe(false);
+    });
   });
 
   describe('exports', () => {

package/scripts/hooks-system/infrastructure/ast/common/ast-common.js

@@ -71,6 +71,66 @@ function hasTrackForMemoryLeaksEvidence(content) {
   return hasTrackForMemoryLeaks(content) || hasMakeSUT(content);
 }
 
+/**
+ * Detect if a test file is a simple value type test that doesn't need makeSUT/trackForMemoryLeaks.
+ * Simple tests typically:
+ * - Have no async/await or closures capturing self
+ * - Have no class instantiation patterns (reference types)
+ * - Test only property access or simple assertions
+ * - Have no setUp/tearDown methods
+ */
+function isSimpleValueTypeTest(content) {
+  // If it has setUp/tearDown, it's not simple - needs proper patterns
+  if (/\boverride\s+func\s+(setUp|tearDown)/.test(content)) return false;
+
+  // If it has async/await, needs memory tracking
+  if (/\basync\b|\bawait\b|\bexpectation\(|\bwaitForExpectations\b/.test(content)) return false;
+
+  // If it has closures that might capture self, needs tracking
+  if (/\[\s*(weak|unowned)?\s*self\s*\]/.test(content)) return false;
+
+  // If it has completion handlers or callbacks, needs tracking
+  if (/completion\s*:|\@escaping|\bresult\s*in\b/i.test(content)) return false;
+
+  // If it creates classes (not structs), needs makeSUT pattern
+  // Look for "= ClassName(" but not "= StructName(" - heuristic: classes often have "Client", "Service", "Manager", "Repository"
+  if (/=\s*\w*(Client|Service|Manager|Repository|UseCase|Interactor|Presenter|ViewModel|Controller)\s*\(/.test(content)) return false;
+
+  // If it's a very short test (likely simple property test), skip rules
+  const lines = content.split('\n').filter(l => l.trim().length > 0);
+  if (lines.length <= 40) return true;
+
+  // If it only has XCTAssertEqual for properties, it's likely a simple value type test
+  const testMethods = content.match(/func\s+test_[^{]+\{[^}]+\}/gs) || [];
+  if (testMethods.length > 0) {
+    const allSimple = testMethods.every(method => {
+      // Simple test: mostly XCTAssert* calls, no complex setup
+      const hasOnlyAsserts = /XCTAssert(Equal|True|False|Nil|NotNil)/.test(method);
+      const hasNoComplexSetup = !/\bsut\b|makeSUT|\bawait\b|completion/.test(method);
+      return hasOnlyAsserts && hasNoComplexSetup;
+    });
+    if (allSimple && testMethods.length <= 3) return true;
+  }
+
+  return false;
+}
+
+/**
+ * Check for ast-ignore comments in content
+ * Supports: // ast-ignore: rule_name or // ast-ignore: rule1, rule2
+ */
+function hasAstIgnoreComment(content, ruleId) {
+  const ignorePattern = /\/\/\s*ast-ignore:\s*([^\n]+)/gi;
+  let match;
+  while ((match = ignorePattern.exec(content)) !== null) {
+    const rules = match[1].split(',').map(r => r.trim().toLowerCase());
+    if (rules.includes(ruleId.toLowerCase()) || rules.includes('all')) {
+      return true;
+    }
+  }
+  return false;
+}
+
 function detectMockSignals(content) {
   const signals = [
     /\bjest\.mock\s*\(/,
@@ -214,9 +274,12 @@ function runCommonIntelligence(project, findings) {
       const ext = path.extname(filePath).toLowerCase();
       const isSwiftOrKotlinTest = ext === '.swift' || ext === '.kt' || ext === '.kts';
 
-      if (isSwiftOrKotlinTest && (!content || content.trim().length === 0)) {
+      if (isSwiftOrKotlinTest) {
         try {
-          content = fs.readFileSync(filePath, 'utf8');
+          const diskContent = fs.readFileSync(filePath, 'utf8');
+          if (diskContent && diskContent.trim().length > 0) {
+            content = diskContent;
+          }
         } catch (error) {
           if (process.env.DEBUG) {
             console.debug(`[ast-common] Failed to read test file content for ${filePath}: ${error.message}`);
@@ -225,7 +288,12 @@ function runCommonIntelligence(project, findings) {
       }
 
       if (isSwiftOrKotlinTest) {
-        if (!shouldSkipMakeSUTRule(filePath) && !hasMakeSUT(content)) {
+        const isSimple = isSimpleValueTypeTest(content);
+
+        if (!shouldSkipMakeSUTRule(filePath) &&
+          !hasMakeSUT(content) &&
+          !isSimple &&
+          !hasAstIgnoreComment(content, 'missing_makesut')) {
           pushFinding(
             'common.testing.missing_makesut',
             'high',
@@ -236,7 +304,10 @@ function runCommonIntelligence(project, findings) {
           );
         }
 
-        if (!shouldSkipTrackForMemoryLeaksRule(filePath) && !hasTrackForMemoryLeaksEvidence(content)) {
+        if (!shouldSkipTrackForMemoryLeaksRule(filePath) &&
+          !hasTrackForMemoryLeaksEvidence(content) &&
+          !isSimple &&
+          !hasAstIgnoreComment(content, 'missing_track_for_memory_leaks')) {
           pushFinding(
             'common.testing.missing_track_for_memory_leaks',
             'critical',

package/scripts/hooks-system/infrastructure/watchdog/__tests__/.audit-reports/token-monitor.log

@@ -25,3 +25,6 @@
 {"timestamp":"2026-01-11T19:08:37.452Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"ok","percentUsed":10,"tokensUsed":100000,"maxTokens":1000000,"source":"realtime","stale":false},"context":{"message":"Result level=ok percent=10% used=100000/1000000 source=realtime"}}
 {"timestamp":"2026-01-11T19:08:37.467Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"warning","percentUsed":91,"tokensUsed":910000,"maxTokens":1000000,"source":"fallback","stale":false},"context":{"message":"Result level=warning percent=91% used=910000/1000000 source=fallback"}}
 {"timestamp":"2026-01-11T19:08:37.468Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"critical","percentUsed":98,"tokensUsed":980000,"maxTokens":1000000,"source":"realtime","stale":true},"context":{"message":"Result level=critical percent=98% used=980000/1000000 source=realtime (stale)"}}
+{"timestamp":"2026-01-11T20:43:25.680Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"ok","percentUsed":10,"tokensUsed":100000,"maxTokens":1000000,"source":"realtime","stale":false},"context":{"message":"Result level=ok percent=10% used=100000/1000000 source=realtime"}}
+{"timestamp":"2026-01-11T20:43:25.683Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"warning","percentUsed":91,"tokensUsed":910000,"maxTokens":1000000,"source":"fallback","stale":false},"context":{"message":"Result level=warning percent=91% used=910000/1000000 source=fallback"}}
+{"timestamp":"2026-01-11T20:43:25.683Z","level":"info","component":"TokenMonitor","event":"TOKEN_MONITOR_RESULT","data":{"level":"critical","percentUsed":98,"tokensUsed":980000,"maxTokens":1000000,"source":"realtime","stale":true},"context":{"message":"Result level=critical percent=98% used=980000/1000000 source=realtime (stale)"}}