pumuki-ast-hooks 5.6.11 → 5.6.13

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pumuki-ast-hooks",
-  "version": "5.6.11",
+  "version": "5.6.13",
   "description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
   "main": "index.js",
   "bin": {
@@ -116,6 +116,7 @@
     "skills/",
     "hooks/",
     "docs/",
+    "assets/",
     "index.js",
     "README.md",
     "LICENSE"

package/scripts/hooks-system/.audit_tmp/hook-metrics.jsonl

@@ -498,3 +498,11 @@
 {"timestamp":1768158514231,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
 {"timestamp":1768158514231,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
 {"timestamp":1768158514232,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768158974401,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768158974401,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1768158974401,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1768158974402,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768162663136,"hook":"audit_logger","operation":"constructor","status":"started","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}
+{"timestamp":1768162663136,"hook":"audit_logger","operation":"ensure_dir","status":"started"}
+{"timestamp":1768162663136,"hook":"audit_logger","operation":"ensure_dir","status":"success"}
+{"timestamp":1768162663136,"hook":"audit_logger","operation":"constructor","status":"success","repoRoot":"/Users/juancarlosmerlosalbarracin/Developer/Projects/ast-intelligence-hooks/scripts/hooks-system"}

package/scripts/hooks-system/infrastructure/ast/common/__tests__/ast-common.spec.js

@@ -2,6 +2,7 @@ jest.mock('../BDDTDDWorkflowRules', () => ({
   BDDTDDWorkflowRules: jest.fn().mockImplementation(() => ({ analyze: jest.fn() }))
 }));
 
+const fs = require('fs');
 const { Project } = require('../../ast-core');
 const { runCommonIntelligence } = require('../ast-common');
 
@@ -28,6 +29,64 @@ describe('AST Common Module', () => {
       expect(findings.some(f => f.ruleId === 'common.testing.missing_makesut')).toBe(false);
       expect(findings.some(f => f.ruleId === 'common.testing.missing_track_for_memory_leaks')).toBe(false);
     });
+
+    it('does not report false positives for Swift test files when getFullText is empty (fallback to disk)', () => {
+      const project = new Project({
+        useInMemoryFileSystem: true,
+        skipAddingFilesFromTsConfig: true,
+      });
+
+      const swiftPath = '/tmp/FooTests.spec.swift';
+      const swiftContent = [
+        'import XCTest',
+        'final class FooTests: XCTestCase {',
+        '  private func makeSUT() -> Foo { Foo() }',
+        '  func test_example() {',
+        '    let sut = makeSUT()',
+        '    trackForMemoryLeaks(sut, testCase: self, file: #file, line: #line)',
+        '  }',
+        '}',
+      ].join('\n');
+
+      const sf = project.createSourceFile(swiftPath, swiftContent);
+      jest.spyOn(sf, 'getFullText').mockReturnValue('');
+      jest.spyOn(fs, 'readFileSync').mockReturnValue(swiftContent);
+
+      const findings = [];
+      runCommonIntelligence(project, findings);
+
+      expect(findings.some(f => f.ruleId === 'common.testing.missing_makesut')).toBe(false);
+      expect(findings.some(f => f.ruleId === 'common.testing.missing_track_for_memory_leaks')).toBe(false);
+    });
+
+    it('does not report false positives for Swift test files when getFullText is non-empty but incomplete (prefer disk)', () => {
+      const project = new Project({
+        useInMemoryFileSystem: true,
+        skipAddingFilesFromTsConfig: true,
+      });
+
+      const swiftPath = '/tmp/DomainAPIEndpointTests.spec.swift';
+      const swiftContent = [
+        'import XCTest',
+        'final class DomainAPIEndpointTests: XCTestCase {',
+        '  private func makeSUT() -> Foo { Foo() }',
+        '  func test_example() {',
+        '    let sut = makeSUT()',
+        '    trackForMemoryLeaks(sut, testCase: self, file: #file, line: #line)',
+        '  }',
+        '}',
+      ].join('\n');
+
+      const sf = project.createSourceFile(swiftPath, swiftContent);
+      jest.spyOn(sf, 'getFullText').mockReturnValue('import XCTest\nfinal class DomainAPIEndpointTests: XCTestCase {}');
+      jest.spyOn(fs, 'readFileSync').mockReturnValue(swiftContent);
+
+      const findings = [];
+      runCommonIntelligence(project, findings);
+
+      expect(findings.some(f => f.ruleId === 'common.testing.missing_makesut')).toBe(false);
+      expect(findings.some(f => f.ruleId === 'common.testing.missing_track_for_memory_leaks')).toBe(false);
+    });
   });
 
   describe('exports', () => {

package/scripts/hooks-system/infrastructure/ast/common/ast-common.js

@@ -1,4 +1,5 @@
 const path = require('path');
+const fs = require('fs');
 const { pushFinding, SyntaxKind, platformOf, getRepoRoot } = require(path.join(__dirname, '../ast-core'));
 const { BDDTDDWorkflowRules } = require(path.join(__dirname, 'BDDTDDWorkflowRules'));
 
@@ -208,11 +209,24 @@ function runCommonIntelligence(project, findings) {
     if (/\/ast-(?:backend|frontend|android|ios|common|core|intelligence)\.js$/.test(filePath)) return;
 
     if (isTestFilePath(filePath)) {
-      const content = sf.getFullText();
+      let content = sf.getFullText();
 
       const ext = path.extname(filePath).toLowerCase();
       const isSwiftOrKotlinTest = ext === '.swift' || ext === '.kt' || ext === '.kts';
 
+      if (isSwiftOrKotlinTest) {
+        try {
+          const diskContent = fs.readFileSync(filePath, 'utf8');
+          if (diskContent && diskContent.trim().length > 0) {
+            content = diskContent;
+          }
+        } catch (error) {
+          if (process.env.DEBUG) {
+            console.debug(`[ast-common] Failed to read test file content for ${filePath}: ${error.message}`);
+          }
+        }
+      }
+
       if (isSwiftOrKotlinTest) {
         if (!shouldSkipMakeSUTRule(filePath) && !hasMakeSUT(content)) {
           pushFinding(