pumuki-ast-hooks 5.5.55 → 5.5.57

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pumuki-ast-hooks",
-  "version": "5.5.55",
+  "version": "5.5.57",
   "description": "Enterprise-grade AST Intelligence System with multi-platform support (iOS, Android, Backend, Frontend) and Feature-First + DDD + Clean Architecture enforcement. Includes dynamic violations API for intelligent querying.",
   "main": "index.js",
   "bin": {

package/scripts/hooks-system/infrastructure/ast/ios/detectors/ios-ast-intelligent-strategies.js

@@ -232,15 +232,19 @@ function analyzeClassAST(analyzer, node, filePath) {
         analyzer.pushFinding('ios.naming.god_naming', 'medium', filePath, line, `Suspicious class name '${name}' - often indicates SRP violation`);
     }
 
-    const unusedProps = findUnusedPropertiesAST(analyzer, properties, methods);
-    for (const prop of unusedProps) {
-        analyzer.pushFinding(
-            'ios.solid.isp.unused_dependency',
-            'high',
-            filePath,
-            line,
-            `Unused property '${prop}' in '${name}' - ISP violation`
-        );
+    // Skip ISP validation for test files - spies/mocks are allowed to have unused properties
+    const isTestFile = /Tests?\/|Spec|Mock|Spy|Stub|Fake|Dummy/.test(filePath);
+    if (!isTestFile) {
+        const unusedProps = findUnusedPropertiesAST(analyzer, properties, methods);
+        for (const prop of unusedProps) {
+            analyzer.pushFinding(
+                'ios.solid.isp.unused_dependency',
+                'high',
+                filePath,
+                line,
+                `Unused property '${prop}' in '${name}' - ISP violation`
+            );
+        }
     }
 
     checkDependencyInjectionAST(analyzer, properties, filePath, name, line);
@@ -658,6 +662,17 @@ function checkDependencyInjectionAST(analyzer, properties, filePath, className,
             continue;
         }
 
+        // Skip generic type parameters (e.g., "Client" in LoginUseCaseImpl<Client: APIClientProtocol>)
+        // These are not concrete dependencies - they are constrained by protocols
+        const propName = prop['key.name'] || '';
+        const isGenericTypeParameter = typename.length === 1 ||
+            (typename.match(/^[A-Z][a-z]*$/) && !typename.includes('Impl') &&
+                (className.includes('<') || propName === 'apiClient' || propName === 'client'));
+
+        if (isGenericTypeParameter) {
+            continue;
+        }
+
         const isConcreteService = /Service$|Repository$|UseCase$|Client$/.test(typename) && !typename.includes('Protocol') && !typename.includes('any ') && !typename.includes('some ');
 
         if (isConcreteService) {