pumuki-ast-hooks 5.5.50 → 5.5.51

package/scripts/hooks-system/infrastructure/shell/gitflow/gitflow-enforcer.sh

@@ -25,7 +25,6 @@ AUTO_MERGE_PR=${GITFLOW_AUTO_MERGE:-false}
 PR_BASE_BRANCH=${GITFLOW_PR_BASE:-develop}
 STRICT_ATOMIC=${GITFLOW_STRICT_ATOMIC:-true}
 REQUIRE_TEST_RELATIONS=${GITFLOW_REQUIRE_TESTS:-true}
-STRICT_CHECK=${GITFLOW_STRICT_CHECK:-false}
 
 print_section() {
   printf "${BLUE}═══════════════════════════════════════════════════════════════${NC}\n"
@@ -168,17 +167,16 @@ verify_atomic_commit() {
     return 0
   fi
 
-  local files=()
+  local -a files=()
   while IFS= read -r file; do
-    [[ -z "$file" ]] && continue
-    files+=("$file")
+    [[ -n "$file" ]] && files+=("$file")
   done < <($GIT_BIN diff --name-only "${commit}^..${commit}")
   if [[ "${#files[@]}" -eq 0 ]]; then
     return 0
   fi
 
-  local roots_list
-  roots_list=()
+  local roots_list=""
+  local root_count=0
   for file in "${files[@]}"; do
     local root="${file%%/*}"
     if [[ "$root" == "$file" ]]; then
@@ -193,36 +191,24 @@ verify_atomic_commit() {
         ;;
     esac
 
-    local seen=0
-    local existing
-    if (( ${#roots_list[@]:-0} > 0 )); then
-      for existing in "${roots_list[@]}"; do
-        if [[ "$existing" == "$root" ]]; then
-          seen=1
-          break
-        fi
-      done
-    fi
-    if [[ "$seen" -eq 0 ]]; then
-      roots_list+=("$root")
+    if [[ " $roots_list " != *" $root "* ]]; then
+      roots_list="${roots_list}${root} "
+      root_count=$((root_count + 1))
     fi
   done
 
-  local root_count=${#roots_list[@]}
   if (( root_count > 1 )); then
     local has_scripts=0
     local has_tests=0
-    for root in "${roots_list[@]}"; do
+    for root in $roots_list; do
       [[ "$root" == "scripts" ]] && has_scripts=1
       [[ "$root" == "tests" ]] && has_tests=1
     done
-    
     if [[ $has_scripts -eq 1 && $has_tests -eq 1 && $root_count -eq 2 ]]; then
       printf "${GREEN}✅ Commit %s toca scripts + tests (permitido para bugfixes/features con tests).${NC}\n" "$commit"
       return 0
     fi
-    
-    printf "${RED}❌ Commit %s toca múltiples raíces (%s). Divide los cambios en commits atómicos.${NC}\n" "$commit" "$(printf "%s " "${roots_list[@]}")"
+    printf "${RED}❌ Commit %s toca múltiples raíces (%s). Divide los cambios en commits atómicos.${NC}\n" "$commit" "$roots_list"
     return 1
   fi
   if (( root_count == 0 )); then
@@ -230,7 +216,7 @@ verify_atomic_commit() {
     return 0
   fi
   local root_name
-  for root_name in "${roots_list[@]}"; do
+  for root_name in $roots_list; do
     printf "${GREEN}✅ Commit %s cumple atomicidad (raíz %s).${NC}\n" "$commit" "$root_name"
   done
   return 0
@@ -250,10 +236,9 @@ verify_pending_commits_atomic() {
     return $?
   fi
 
-  local commits=()
+  local -a commits=()
   while IFS= read -r commit; do
-    [[ -z "$commit" ]] && continue
-    commits+=("$commit")
+    [[ -n "$commit" ]] && commits+=("$commit")
   done < <($GIT_BIN rev-list "${base_ref}..${branch}")
   local failed=0
   for commit in "${commits[@]}"; do
@@ -384,50 +369,22 @@ cmd_check() {
   local branch
   branch=$(current_branch)
   printf "${CYAN}📍 Rama actual: %s${NC}\n" "$branch"
-  local failed=0
-
-  if [[ "${STRICT_CHECK}" == "true" ]]; then
-    ensure_evidence_fresh || failed=1
-    lint_hooks_system || failed=1
-    run_mobile_checks || failed=1
-  else
-    ensure_evidence_fresh || true
-    lint_hooks_system || true
-    run_mobile_checks || true
-  fi
+  ensure_evidence_fresh || true
+  lint_hooks_system || true
+  run_mobile_checks || true
   print_sync_table
   print_cleanup_candidates
-  if [[ "${STRICT_CHECK}" == "true" ]]; then
-    verify_atomic_commit "HEAD" || failed=1
-    if [[ "$REQUIRE_TEST_RELATIONS" == "true" ]]; then
-      verify_related_files_commit "HEAD" || failed=1
-    fi
-    if ! verify_pending_commits_atomic "$branch"; then
-      failed=1
-    fi
-    if [[ "$REQUIRE_TEST_RELATIONS" == "true" ]]; then
-      if ! verify_pending_commits_related "$branch"; then
-        failed=1
-      fi
-    fi
-  else
-    verify_atomic_commit "HEAD" || true
-    if [[ "$REQUIRE_TEST_RELATIONS" == "true" ]]; then
-      verify_related_files_commit "HEAD" || true
-    fi
+  verify_atomic_commit "HEAD" || true
+  if [[ "$REQUIRE_TEST_RELATIONS" == "true" ]]; then
+    verify_related_files_commit "HEAD" || true
   fi
   local pending
   pending=$(unpushed_commits "$branch")
   if [[ "$pending" != "0" ]]; then
     printf "${YELLOW}⚠️  Commits sin subir (${pending}). Ejecuta git push.${NC}\n"
-    if [[ "${STRICT_CHECK}" == "true" ]]; then
-      failed=1
-    fi
   else
     printf "${GREEN}✅ No hay commits pendientes de push.${NC}\n"
   fi
-
-  return $failed
 }
 
 cmd_cycle() {
@@ -580,7 +537,6 @@ main() {
       ;;
   esac
 }
-
 is_test_file() {
   local file="$1"
   case "$file" in
@@ -681,14 +637,12 @@ verify_pending_commits_related() {
   local base_ref="origin/${branch}"
 
   if ! $GIT_BIN show-ref --verify --quiet "refs/remotes/origin/${branch}"; then
-    verify_related_files_commit "HEAD"
-    return $?
+    return verify_related_files_commit "HEAD"
   fi
 
-  local commits=()
+  local -a commits=()
   while IFS= read -r commit; do
-    [[ -z "$commit" ]] && continue
-    commits+=("$commit")
+    [[ -n "$commit" ]] && commits+=("$commit")
   done < <($GIT_BIN rev-list "${base_ref}..${branch}")
   local failed=0
   local commit