pumuki-ast-hooks 5.3.20 → 5.3.22

package/scripts/hooks-system/application/services/installation/IdeIntegrationService.js

@@ -2,10 +2,6 @@ const McpConfigurator = require('./McpConfigurator');
 const HookInstaller = require('./HookInstaller');
 const VSCodeTaskConfigurator = require('./VSCodeTaskConfigurator');
 
-const {
-    createMetricScope: createMetricScope
-} = require('../../../infrastructure/telemetry/metric-scope');
-
 const COLORS = {
     reset: '\x1b[0m',
     green: '\x1b[32m',
@@ -15,12 +11,6 @@ const COLORS = {
 
 class IdeIntegrationService {
     constructor(targetRoot, hookSystemRoot, logger = null) {
-        const m_constructor = createMetricScope({
-            hook: 'ide_integration_service',
-            operation: 'constructor'
-        });
-
-        m_constructor.started();
         this.targetRoot = targetRoot || process.cwd();
         this.hookSystemRoot = hookSystemRoot;
         this.logger = logger;
@@ -28,7 +18,6 @@ class IdeIntegrationService {
         this.mcpConfigurator = new McpConfigurator(this.targetRoot, this.hookSystemRoot, this.logger);
         this.hookInstaller = new HookInstaller(this.targetRoot, this.hookSystemRoot, this.logger);
         this.vscodeConfigurator = new VSCodeTaskConfigurator(this.targetRoot, this.logger);
-        m_constructor.success();
     }
 
     installCursorHooks(platforms) {

package/scripts/hooks-system/application/services/installation/InstallService.js

@@ -8,10 +8,6 @@ const ConfigurationGeneratorService = require('./ConfigurationGeneratorService')
 const IdeIntegrationService = require('./IdeIntegrationService');
 const UnifiedLogger = require('../logging/UnifiedLogger');
 
-const {
-    createMetricScope: createMetricScope
-} = require('../../../infrastructure/telemetry/metric-scope');
-
 const COLORS = {
     reset: '\x1b[0m',
     blue: '\x1b[34m',
@@ -23,12 +19,6 @@ const COLORS = {
 
 class InstallService {
     constructor() {
-        const m_constructor = createMetricScope({
-            hook: 'install_service',
-            operation: 'constructor'
-        });
-
-        m_constructor.started();
         this.targetRoot = process.cwd();
         // Assuming this script is located at scripts/hooks-system/application/services/installation/InstallService.js
         this.hookSystemRoot = path.resolve(__dirname, '../../../');
@@ -40,13 +30,7 @@ class InstallService {
             path.resolve(this.hookSystemRoot, '../package.json'),
             path.resolve(this.hookSystemRoot, '../../package.json'),
             (() => {
-                try {
-                    m_constructor.success();
-                    return require.resolve('pumuki-ast-hooks/package.json');
-                } catch {
-                    m_constructor.success();
-                    return null;
-                }
+                try { return require.resolve('pumuki-ast-hooks/package.json'); } catch { return null; }
             })()
         ].filter(Boolean);
 
@@ -89,16 +73,9 @@ class InstallService {
         this.fsInstaller = new FileSystemInstallerService(this.targetRoot, this.hookSystemRoot, this.logger);
         this.configGenerator = new ConfigurationGeneratorService(this.targetRoot, this.hookSystemRoot);
         this.ideIntegration = new IdeIntegrationService(this.targetRoot, this.hookSystemRoot, this.logger);
-        m_constructor.success();
     }
 
     async run() {
-        const m_run = createMetricScope({
-            hook: 'install_service',
-            operation: 'run'
-        });
-
-        m_run.started();
         this.logger.info('INSTALLATION_STARTED', { targetRoot: this.targetRoot });
         this.printHeader();
 
@@ -147,7 +124,6 @@ class InstallService {
 
         this.logger.info('INSTALLATION_COMPLETED_SUCCESSFULLY');
         this.printFooter();
-        m_run.success();
     }
 
     printHeader() {

package/scripts/hooks-system/application/services/installation/McpConfigurator.js

@@ -3,10 +3,7 @@ const path = require('path');
 const { execSync } = require('child_process');
 const crypto = require('crypto');
 const os = require('os');
-
-const {
-    createMetricScope: createMetricScope
-} = require('../../../infrastructure/telemetry/metric-scope');
+const env = require('../../../config/env');
 
 const COLORS = {
     reset: '\x1b[0m',
@@ -35,7 +32,7 @@ function computeRepoFingerprint(repoRoot) {
 
 function computeServerIdForRepo(repoRoot) {
     const legacyServerId = 'ast-intelligence-automation';
-    const forced = (process.env.MCP_SERVER_ID || '').trim();
+    const forced = (env.get('MCP_SERVER_ID', '') || '').trim();
     if (forced.length > 0) return forced;
 
     const repoName = path.basename(repoRoot || process.cwd());
@@ -46,26 +43,12 @@ function computeServerIdForRepo(repoRoot) {
 
 class McpConfigurator {
     constructor(targetRoot, hookSystemRoot, logger = null) {
-        const m_constructor = createMetricScope({
-            hook: 'mcp_configurator',
-            operation: 'constructor'
-        });
-
-        m_constructor.started();
         this.targetRoot = targetRoot;
         this.hookSystemRoot = hookSystemRoot;
         this.logger = logger;
-        m_constructor.success();
     }
 
     getGlobalWindsurfConfigPath() {
-        const m_get_global_windsurf_config_path = createMetricScope({
-            hook: 'mcp_configurator',
-            operation: 'get_global_windsurf_config_path'
-        });
-
-        m_get_global_windsurf_config_path.started();
-        m_get_global_windsurf_config_path.success();
         return path.join(os.homedir(), '.codeium', 'windsurf', 'mcp_config.json');
     }
 

package/scripts/hooks-system/application/services/installation/PlatformDetectorService.js

@@ -1,20 +1,9 @@
 const glob = require('glob');
 
-const {
-    createMetricScope: createMetricScope
-} = require('../../../infrastructure/telemetry/metric-scope');
-
 class PlatformDetectorService {
     constructor(targetRoot) {
-        const m_constructor = createMetricScope({
-            hook: 'platform_detector_service',
-            operation: 'constructor'
-        });
-
-        m_constructor.started();
         this.targetRoot = targetRoot || process.cwd();
         this.platforms = [];
-        m_constructor.success();
     }
 
     detect() {

package/scripts/hooks-system/application/services/installation/VSCodeTaskConfigurator.js

@@ -1,18 +1,8 @@
 const fs = require('fs');
 const path = require('path');
 
-const {
-    createMetricScope: createMetricScope
-} = require('../../../infrastructure/telemetry/metric-scope');
-
 class VSCodeTaskConfigurator {
     constructor(targetRoot, logger = null) {
-        const m_constructor = createMetricScope({
-            hook: 'vscode_task_configurator',
-            operation: 'constructor'
-        });
-
-        m_constructor.started();
         this.targetRoot = targetRoot;
         this.logger = logger;
         this.COLORS = {
@@ -21,7 +11,6 @@ class VSCodeTaskConfigurator {
             yellow: '\x1b[33m',
             cyan: '\x1b[36m'
         };
-        m_constructor.success();
     }
 
     configure() {

package/scripts/hooks-system/application/services/logging/AuditLogger.js

@@ -3,11 +3,6 @@ const path = require('path');
 
 // Import recordMetric for prometheus metrics
 const { recordMetric } = require('../../../infrastructure/telemetry/metrics-logger');
-
-const {
-    createMetricScope: createMetricScope
-} = require('../../../infrastructure/telemetry/metric-scope');
-
 class AuditLogger {
     /**
      * @param {Object} options
@@ -22,7 +17,6 @@ class AuditLogger {
             status: 'started',
             repoRoot: repoRoot.substring(0, 100)
         });
-
         this.repoRoot = repoRoot;
         this.logger = logger;
         this.logPath = filename
@@ -151,7 +145,6 @@ class AuditLogger {
             status: 'started',
             metaKeys: Object.keys(meta || {}).length
         });
-
         const forbidden = ['token', 'password', 'secret', 'authorization', 'auth', 'apiKey'];
         const clone = {};
         Object.entries(meta).forEach(([k, v]) => {
@@ -169,7 +162,6 @@ class AuditLogger {
             status: 'success',
             metaKeys: Object.keys(clone).length
         });
-
         return clone;
     }
 }

package/scripts/hooks-system/application/services/logging/UnifiedLogger.js

@@ -2,10 +2,6 @@ const fs = require('fs');
 const path = require('path');
 const { ConfigurationError } = require('../../../domain/errors');
 
-const {
-    createMetricScope: createMetricScope
-} = require('../../../infrastructure/telemetry/metric-scope');
-
 class UnifiedLogger {
     constructor({
         component = 'HookSystem',
@@ -13,12 +9,6 @@ class UnifiedLogger {
         file: fileConfig = { enabled: false },
         defaultData = {}
     } = {}) {
-        const m_constructor = createMetricScope({
-            hook: 'unified_logger',
-            operation: 'constructor'
-        });
-
-        m_constructor.started();
         this.component = component;
         this.consoleConfig = {
             enabled: consoleConfig.enabled !== false,
@@ -51,7 +41,6 @@ class UnifiedLogger {
                 // Directory creation might fail if race condition, can be ignored as next write will retry or fail
             }
         }
-        m_constructor.success();
     }
 
     debug(event, data = {}, context = {}) {
@@ -108,10 +97,19 @@ class UnifiedLogger {
             this.rotateFileIfNeeded();
             fs.appendFileSync(this.fileConfig.path, `${JSON.stringify(entry)}\n`, 'utf8');
         } catch (error) {
-            if (process.env.DEBUG) {
-                console.error('[UnifiedLogger] Failed to write log file', {
-                    path: this.fileConfig.path,
-                    error: error.message
+            try {
+                const env = require('../../../config/env');
+                if (env.getBool('DEBUG', false)) {
+                    console.error('[UnifiedLogger] Failed to write log file', {
+                        path: this.fileConfig.path,
+                        error: error.message
+                    });
+                } else {
+                    console.warn('[UnifiedLogger] File logging skipped due to error');
+                }
+            } catch (secondaryError) {
+                console.error('[UnifiedLogger] Secondary logging failure', {
+                    error: secondaryError.message
                 });
             }
         }

package/scripts/hooks-system/application/services/monitoring/ActivityMonitor.js

@@ -1,40 +1,22 @@
 const fs = require('fs');
 const path = require('path');
 
-const {
-    createMetricScope: createMetricScope
-} = require('../../../infrastructure/telemetry/metric-scope');
-
 class ActivityMonitor {
     constructor({
         repoRoot = process.cwd(),
         inactivityGraceMs = 420000, // 7 minutes
         logger = console
     } = {}) {
-        const m_constructor = createMetricScope({
-            hook: 'activity_monitor',
-            operation: 'constructor'
-        });
-
-        m_constructor.started();
         this.repoRoot = repoRoot;
         this.inactivityGraceMs = inactivityGraceMs;
         this.logger = logger;
         this.lastUserActivityAt = Date.now();
         this.watcher = null;
         this.debounceTimer = null;
-        m_constructor.success();
     }
 
     start() {
-        const m_start = createMetricScope({
-            hook: 'activity_monitor',
-            operation: 'start'
-        });
-
-        m_start.started();
         if (this.watcher) {
-            m_start.success();
             return;
         }
 
@@ -60,16 +42,9 @@ class ActivityMonitor {
         } catch (error) {
             this.logger.error('[ActivityMonitor] Failed to start watcher:', { error: error.message });
         }
-        m_start.success();
     }
 
     stop() {
-        const m_stop = createMetricScope({
-            hook: 'activity_monitor',
-            operation: 'stop'
-        });
-
-        m_stop.started();
         if (this.watcher) {
             this.watcher.close();
             this.watcher = null;
@@ -78,7 +53,6 @@ class ActivityMonitor {
             clearTimeout(this.debounceTimer);
             this.debounceTimer = null;
         }
-        m_stop.success();
     }
 
     recordActivity(source = 'unknown') {
@@ -99,13 +73,6 @@ class ActivityMonitor {
     }
 
     getLastActivityTime() {
-        const m_get_last_activity_time = createMetricScope({
-            hook: 'activity_monitor',
-            operation: 'get_last_activity_time'
-        });
-
-        m_get_last_activity_time.started();
-        m_get_last_activity_time.success();
         return this.lastUserActivityAt;
     }
 }

package/scripts/hooks-system/application/services/monitoring/AstMonitor.js

@@ -2,10 +2,6 @@ const fs = require('fs');
 const path = require('path');
 const { spawn } = require('child_process');
 
-const {
-    createMetricScope: createMetricScope
-} = require('../../../infrastructure/telemetry/metric-scope');
-
 class AstMonitor {
     constructor({
         repoRoot = process.cwd(),
@@ -15,12 +11,6 @@ class AstMonitor {
         logger = console,
         notificationService = null
     } = {}) {
-        const m_constructor = createMetricScope({
-            hook: 'ast_monitor',
-            operation: 'constructor'
-        });
-
-        m_constructor.started();
         this.repoRoot = repoRoot;
         this.debounceMs = debounceMs;
         this.cooldownMs = cooldownMs;
@@ -36,24 +26,15 @@ class AstMonitor {
         this.evidencePath = path.join(repoRoot, '.AI_EVIDENCE.json');
         this.tempDir = path.join(repoRoot, '.audit_tmp');
         this.astScript = path.join(repoRoot, 'infrastructure', 'ast', 'ast-intelligence.js');
-        m_constructor.success();
     }
 
     start() {
-        const m_start = createMetricScope({
-            hook: 'ast_monitor',
-            operation: 'start'
-        });
-
-        m_start.started();
         if (!this.enabled) {
             this.logger.info('[AstMonitor] AST Watch disabled');
-            m_start.success();
             return;
         }
 
         if (this.watcher) {
-            m_start.success();
             return;
         }
 
@@ -77,16 +58,9 @@ class AstMonitor {
         } catch (error) {
             this.logger.error('[AstMonitor] Failed to start watchers:', { error: error.message });
         }
-        m_start.success();
     }
 
     stop() {
-        const m_stop = createMetricScope({
-            hook: 'ast_monitor',
-            operation: 'stop'
-        });
-
-        m_stop.started();
         // fs.watch returns FSWatcher which has close(). 
         // Since we might have multiple watchers (one per dir), we should track them if we want to close properly.
         // For simplicity in this iteration, we assume the process exit handles it, or we rely on the debounce timer clear.
@@ -96,7 +70,6 @@ class AstMonitor {
             this.timer = null;
         }
         // Ideally we would close all FSWatchers here
-        m_stop.success();
     }
 
     scheduleAnalysis() {

package/scripts/hooks-system/application/services/monitoring/DevDocsMonitor.js

@@ -1,10 +1,6 @@
 const fs = require('fs');
 const path = require('path');
 
-const {
-    createMetricScope: createMetricScope
-} = require('../../../infrastructure/telemetry/metric-scope');
-
 class DevDocsMonitor {
     constructor({
         repoRoot = process.cwd(),
@@ -14,12 +10,6 @@ class DevDocsMonitor {
         logger = console,
         notificationService = null
     } = {}) {
-        const m_constructor = createMetricScope({
-            hook: 'dev_docs_monitor',
-            operation: 'constructor'
-        });
-
-        m_constructor.started();
         this.repoRoot = repoRoot;
         this.checkIntervalMs = checkIntervalMs;
         this.staleThresholdMs = staleThresholdMs;
@@ -28,19 +18,11 @@ class DevDocsMonitor {
         this.notificationService = notificationService;
         this.timer = null;
         this.docsStatePath = path.join(repoRoot, '.audit_tmp', 'dev-docs-state.json');
-        m_constructor.success();
     }
 
     start() {
-        const m_start = createMetricScope({
-            hook: 'dev_docs_monitor',
-            operation: 'start'
-        });
-
-        m_start.started();
         if (!this.autoRefreshEnabled) {
             this.logger.info('[DevDocsMonitor] Auto-refresh disabled');
-            m_start.success();
             return;
         }
 
@@ -50,21 +32,13 @@ class DevDocsMonitor {
             this.timer.unref();
         }
         this.logger.info('[DevDocsMonitor] Started');
-        m_start.success();
     }
 
     stop() {
-        const m_stop = createMetricScope({
-            hook: 'dev_docs_monitor',
-            operation: 'stop'
-        });
-
-        m_stop.started();
         if (this.timer) {
             clearInterval(this.timer);
             this.timer = null;
         }
-        m_stop.success();
     }
 
     async checkDocs() {

package/scripts/hooks-system/application/services/monitoring/EvidenceMonitor.js

@@ -3,18 +3,8 @@ const path = require('path');
 const { execSync } = require('child_process');
 const { ConfigurationError, DomainError } = require('../../../domain/errors');
 
-const {
-    createMetricScope: createMetricScope
-} = require('../../../infrastructure/telemetry/metric-scope');
-
 class EvidenceMonitor {
     constructor(repoRoot, options = {}) {
-        const m_constructor = createMetricScope({
-            hook: 'evidence_monitor',
-            operation: 'constructor'
-        });
-
-        m_constructor.started();
         this.repoRoot = repoRoot;
         this.staleThresholdMs = options.staleThresholdMs || 180000;
         this.pollIntervalMs = options.pollIntervalMs || 30000;
@@ -24,7 +14,6 @@ class EvidenceMonitor {
         this.evidencePath = path.join(repoRoot, '.AI_EVIDENCE.json');
         this.tempDir = path.join(repoRoot, '.audit_tmp');
         this.updateScript = this.resolveUpdateEvidenceScript();
-        m_constructor.success();
     }
 
     resolveUpdateEvidenceScript() {
@@ -105,17 +94,10 @@ class EvidenceMonitor {
     }
 
     stop() {
-        const m_stop = createMetricScope({
-            hook: 'evidence_monitor',
-            operation: 'stop'
-        });
-
-        m_stop.started();
         if (this.pollTimer) {
             clearInterval(this.pollTimer);
             this.pollTimer = null;
         }
-        m_stop.success();
     }
 }
 

package/scripts/hooks-system/application/services/monitoring/EvidenceMonitorService.js

@@ -1,10 +1,7 @@
 const fs = require('fs');
 const path = require('path');
 const { execSync } = require('child_process');
-
-const {
-    createMetricScope: createMetricScope
-} = require('../../../infrastructure/telemetry/metric-scope');
+const env = require('../../../config/env');
 
 function resolveUpdateEvidenceScript(repoRoot) {
     const candidates = [
@@ -29,18 +26,12 @@ class EvidenceMonitorService {
         updateScriptPath = resolveUpdateEvidenceScript(repoRoot) || path.join(process.cwd(), 'scripts', 'hooks-system', 'bin', 'update-evidence.sh'),
         notifier = () => { },
         logger = console,
-        autoRefreshEnabled = process.env.HOOK_GUARD_AUTO_REFRESH !== 'false',
-        autoRefreshCooldownMs = Number(process.env.HOOK_GUARD_AUTO_REFRESH_COOLDOWN || 180000),
-        staleThresholdMs = Number(process.env.HOOK_GUARD_EVIDENCE_STALE_THRESHOLD || 10 * 60 * 1000),
+        autoRefreshEnabled = env.getBool('HOOK_GUARD_AUTO_REFRESH', true),
+        autoRefreshCooldownMs = env.getNumber('HOOK_GUARD_AUTO_REFRESH_COOLDOWN', 180000),
+        staleThresholdMs = env.getNumber('HOOK_GUARD_EVIDENCE_STALE_THRESHOLD', 10 * 60 * 1000),
         fsModule = fs,
         execFn = execSync
     } = {}) {
-        const m_constructor = createMetricScope({
-            hook: 'evidence_monitor_service',
-            operation: 'constructor'
-        });
-
-        m_constructor.started();
         this.repoRoot = repoRoot;
         this.evidencePath = evidencePath;
         this.updateScriptPath = updateScriptPath;
@@ -53,28 +44,14 @@ class EvidenceMonitorService {
         this.exec = execFn;
         this.watchers = [];
         this.lastAutoRefresh = 0;
-        m_constructor.success();
     }
 
     start() {
-        const m_start = createMetricScope({
-            hook: 'evidence_monitor_service',
-            operation: 'start'
-        });
-
-        m_start.started();
         this.performInitialChecks();
         this.watchEvidenceFreshness();
-        m_start.success();
     }
 
     stop() {
-        const m_stop = createMetricScope({
-            hook: 'evidence_monitor_service',
-            operation: 'stop'
-        });
-
-        m_stop.started();
         this.watchers.forEach(watcher => {
             try {
                 watcher.close();
@@ -83,7 +60,6 @@ class EvidenceMonitorService {
             }
         });
         this.watchers = [];
-        m_stop.success();
     }
 
     performInitialChecks() {