pumuki-ast-hooks 5.3.16 → 5.3.18

package/scripts/hooks-system/config/env.js

@@ -0,0 +1,33 @@
+const ENV = (process.env.NODE_ENV || 'development').toLowerCase();
+
+function normalizeBool(val, defaultValue = false) {
+    if (val === undefined) return defaultValue;
+    if (typeof val === 'boolean') return val;
+    const str = String(val).trim().toLowerCase();
+    if (str === '') return defaultValue;
+    return !(['false', '0', 'no', 'off'].includes(str));
+}
+
+function get(name, defaultValue = undefined) {
+    return process.env[name] !== undefined ? process.env[name] : defaultValue;
+}
+
+function getNumber(name, defaultValue = 0) {
+    const raw = process.env[name];
+    const parsed = Number(raw);
+    return Number.isFinite(parsed) ? parsed : defaultValue;
+}
+
+function getBool(name, defaultValue = false) {
+    return normalizeBool(process.env[name], defaultValue);
+}
+
+module.exports = {
+    env: ENV,
+    isProd: ENV === 'production',
+    isStg: ENV === 'staging' || ENV === 'stage' || ENV === 'stg',
+    isDev: ENV === 'development' || ENV === 'dev',
+    get,
+    getNumber,
+    getBool,
+};

package/scripts/hooks-system/domain/events/__tests__/EventBus.spec.js

@@ -0,0 +1,33 @@
+const { EventBus, DomainEvent } = require('..');
+
+describe('EventBus', () => {
+    test('no reprocesa eventos duplicados (idempotencia por id)', async () => {
+        const bus = new EventBus();
+        const handled = [];
+        bus.subscribe('TEST_EVENT', async (evt) => {
+            handled.push(evt.id);
+        });
+
+        const evt = new DomainEvent('TEST_EVENT', { foo: 'bar' });
+        await bus.publish(evt);
+        await bus.publish(evt); // segunda vez mismo id
+
+        expect(handled).toHaveLength(1);
+        expect(handled[0]).toBe(evt.id);
+    });
+
+    test('recorta processedIds al superar maxProcessed', async () => {
+        const bus = new EventBus();
+        bus.maxProcessed = 3;
+        bus.subscribe('*', async () => { });
+
+        const idsBefore = [];
+        for (let i = 0; i < 5; i++) {
+            const evt = new DomainEvent('TEST_EVENT', { seq: i });
+            idsBefore.push(evt.id);
+            await bus.publish(evt);
+        }
+
+        expect(bus.processedIds.size).toBeLessThanOrEqual(bus.maxProcessed);
+    });
+});

package/scripts/hooks-system/domain/events/index.js

@@ -1,3 +1,5 @@
+const { ValidationError } = require('../errors');
+
 class DomainEvent {
     constructor(type, payload) {
         this.type = type;
@@ -7,8 +9,8 @@ class DomainEvent {
     }
 
     validate() {
-        if (!this.type) throw new Error('Event type is required');
-        if (!this.payload) throw new Error('Event payload is required');
+        if (!this.type) throw new ValidationError('Event type is required', 'type', this.type);
+        if (!this.payload) throw new ValidationError('Event payload is required', 'payload', this.payload);
         return true;
     }
 
@@ -29,7 +31,9 @@ class EvidenceStaleEvent extends DomainEvent {
 
     validate() {
         super.validate();
-        if (!this.payload.evidencePath) throw new Error('Evidence path is required');
+        if (!this.payload.evidencePath) {
+            throw new ValidationError('Evidence path is required', 'payload.evidencePath', this.payload.evidencePath);
+        }
     }
 }
 
@@ -41,8 +45,12 @@ class GitFlowViolationEvent extends DomainEvent {
 
     validate() {
         super.validate();
-        if (!this.payload.branch) throw new Error('Branch name is required');
-        if (!this.payload.violation) throw new Error('Violation details are required');
+        if (!this.payload.branch) {
+            throw new ValidationError('Branch name is required', 'payload.branch', this.payload.branch);
+        }
+        if (!this.payload.violation) {
+            throw new ValidationError('Violation details are required', 'payload.violation', this.payload.violation);
+        }
     }
 }
 
@@ -54,7 +62,9 @@ class AstCriticalFoundEvent extends DomainEvent {
 
     validate() {
         super.validate();
-        if (!Array.isArray(this.payload.findings)) throw new Error('Findings must be an array');
+        if (!Array.isArray(this.payload.findings)) {
+            throw new ValidationError('Findings must be an array', 'payload.findings', this.payload.findings);
+        }
     }
 }
 
@@ -75,6 +85,8 @@ class AnalysisCompletedEvent extends DomainEvent {
 class EventBus {
     constructor() {
         this.subscribers = new Map();
+        this.processedIds = new Set();
+        this.maxProcessed = 500;
     }
 
     subscribe(eventType, handler) {
@@ -94,11 +106,25 @@ class EventBus {
     }
 
     async publish(event) {
+        if (event?.id && this.processedIds.has(event.id)) {
+            return event;
+        }
         const handlers = this.subscribers.get(event.type) || [];
         const wildcardHandlers = this.subscribers.get('*') || [];
         const allHandlers = [...handlers, ...wildcardHandlers];
 
         await Promise.all(allHandlers.map(handler => handler(event)));
+
+        if (event?.id) {
+            this.processedIds.add(event.id);
+            if (this.processedIds.size > this.maxProcessed) {
+                const iter = this.processedIds.values();
+                for (let i = 0; i < 50 && this.processedIds.size > this.maxProcessed; i++) {
+                    const next = iter.next();
+                    if (!next.done) this.processedIds.delete(next.value);
+                }
+            }
+        }
         return event;
     }
 

package/scripts/hooks-system/infrastructure/ast/android/analyzers/AndroidAnalysisOrchestrator.js

@@ -40,8 +40,9 @@ class AndroidAnalysisOrchestrator {
             return 0.6745 * (x - med) / madValue;
         };
 
-        const pOutlier = Number(process.env.AST_GODCLASS_P_OUTLIER || 90);
-        const pExtreme = Number(process.env.AST_GODCLASS_P_EXTREME || 97);
+        const env = require('../../../../config/env');
+        const pOutlier = env.getNumber('AST_GODCLASS_P_OUTLIER', 90);
+        const pExtreme = env.getNumber('AST_GODCLASS_P_EXTREME', 97);
 
         const methods = this.godClassCandidates.map(c => c.methodsCount);
         const props = this.godClassCandidates.map(c => c.propertiesCount);

package/scripts/hooks-system/infrastructure/ast/ast-core.js

@@ -2,6 +2,7 @@
 const { Project, Node, SyntaxKind, ScriptTarget, ModuleKind } = require("ts-morph");
 const path = require("path");
 const fs = require("fs");
+const env = require("../../config/env");
 
 let SeverityEvaluator = null;
 let severityEvaluatorInstance = null;
@@ -19,7 +20,7 @@ function getSeverityEvaluator() {
   return severityEvaluatorInstance;
 }
 
-let INTELLIGENT_SEVERITY_ENABLED = process.env.INTELLIGENT_SEVERITY === 'true';
+let INTELLIGENT_SEVERITY_ENABLED = env.getBool('INTELLIGENT_SEVERITY', false);
 
 /**
  * Get repository root directory (portable - dynamic detection)
@@ -179,18 +180,18 @@ function pushFinding(ruleId, severity, sf, node, message, findings, metrics = {}
   let mappedSeverity = mapToLevel(severity);
   const isCleanLayerMarkerRule = ruleId === 'backend.clean.domain' || ruleId === 'backend.clean.application' || ruleId === 'backend.clean.infrastructure' || ruleId === 'backend.clean.presentation';
   let isStrictCriticalRule = false;
-  if (process.env.AUDIT_STRICT === '1' && !isCleanLayerMarkerRule) {
+  if (env.get('AUDIT_STRICT', '0') === '1' && !isCleanLayerMarkerRule) {
     const defaultStrictCriticalRegex = '(solid\\.|architecture\\.|clean\\.|cqrs\\.|tdd\\.|bdd\\.|security\\.|error\\.|testing\\.|performance\\.|metrics\\.|observability\\.|validation\\.|i18n\\.|accessibility\\.|naming\\.)';
     const defaultStrictCriticalRegexLibrary = '(solid\\.|architecture\\.|clean\\.|cqrs\\.|tdd\\.|bdd\\.|security\\.|error\\.|testing\\.|validation\\.|naming\\.)';
-    const strictRegexSource = process.env.AST_STRICT_CRITICAL_RULES_REGEX ||
-      (process.env.AUDIT_LIBRARY === 'true'
-        ? (process.env.AST_STRICT_CRITICAL_RULES_REGEX_LIBRARY || defaultStrictCriticalRegexLibrary)
+    const strictRegexSource = env.get('AST_STRICT_CRITICAL_RULES_REGEX',
+      env.getBool('AUDIT_LIBRARY', false)
+        ? env.get('AST_STRICT_CRITICAL_RULES_REGEX_LIBRARY', defaultStrictCriticalRegexLibrary)
         : defaultStrictCriticalRegex);
     let strictRegex;
     try {
       strictRegex = new RegExp(strictRegexSource, 'i');
     } catch {
-      strictRegex = new RegExp(process.env.AUDIT_LIBRARY === 'true' ? defaultStrictCriticalRegexLibrary : defaultStrictCriticalRegex, 'i');
+      strictRegex = new RegExp(env.getBool('AUDIT_LIBRARY', false) ? defaultStrictCriticalRegexLibrary : defaultStrictCriticalRegex, 'i');
     }
     isStrictCriticalRule = strictRegex.test(ruleId);
     if (isStrictCriticalRule) {
@@ -241,18 +242,18 @@ function pushFileFinding(ruleId, severity, filePath, line, column, message, find
   let mappedSeverity = mapToLevel(severity);
   const isCleanLayerMarkerRule = ruleId === 'backend.clean.domain' || ruleId === 'backend.clean.application' || ruleId === 'backend.clean.infrastructure' || ruleId === 'backend.clean.presentation';
   let isStrictCriticalRule = false;
-  if (process.env.AUDIT_STRICT === '1' && !isCleanLayerMarkerRule) {
+  if (env.get('AUDIT_STRICT', '0') === '1' && !isCleanLayerMarkerRule) {
     const defaultStrictCriticalRegex = '(solid\\.|architecture\\.|clean\\.|cqrs\\.|tdd\\.|bdd\\.|security\\.|error\\.|testing\\.|performance\\.|metrics\\.|observability\\.|validation\\.|i18n\\.|accessibility\\.|naming\\.)';
     const defaultStrictCriticalRegexLibrary = '(solid\\.|architecture\\.|clean\\.|cqrs\\.|tdd\\.|bdd\\.|security\\.|error\\.|testing\\.|validation\\.|naming\\.)';
-    const strictRegexSource = process.env.AST_STRICT_CRITICAL_RULES_REGEX ||
-      (process.env.AUDIT_LIBRARY === 'true'
-        ? (process.env.AST_STRICT_CRITICAL_RULES_REGEX_LIBRARY || defaultStrictCriticalRegexLibrary)
+    const strictRegexSource = env.get('AST_STRICT_CRITICAL_RULES_REGEX',
+      env.getBool('AUDIT_LIBRARY', false)
+        ? env.get('AST_STRICT_CRITICAL_RULES_REGEX_LIBRARY', defaultStrictCriticalRegexLibrary)
         : defaultStrictCriticalRegex);
     let strictRegex;
     try {
       strictRegex = new RegExp(strictRegexSource, 'i');
     } catch {
-      strictRegex = new RegExp(process.env.AUDIT_LIBRARY === 'true' ? defaultStrictCriticalRegexLibrary : defaultStrictCriticalRegex, 'i');
+      strictRegex = new RegExp(env.getBool('AUDIT_LIBRARY', false) ? defaultStrictCriticalRegexLibrary : defaultStrictCriticalRegex, 'i');
     }
     isStrictCriticalRule = strictRegex.test(ruleId);
     if (isStrictCriticalRule) {
@@ -332,15 +333,6 @@ function mapToLevel(severity) {
 function platformOf(filePath) {
   const p = filePath.replace(/\\/g, "/");
 
-  if (p.includes("/infrastructure/ast/") && process.env.AUDIT_LIBRARY !== 'true') return null;
-
-  if (process.env.AUDIT_LIBRARY === 'true') {
-    if (p.includes("/infrastructure/ast/backend/") || p.includes("/scripts/hooks-system/infrastructure/ast/backend/")) return "backend";
-    if (p.includes("/infrastructure/ast/frontend/") || p.includes("/scripts/hooks-system/infrastructure/ast/frontend/")) return "frontend";
-    if (p.includes("/infrastructure/ast/android/") || p.includes("/scripts/hooks-system/infrastructure/ast/android/")) return "android";
-    if (p.includes("/infrastructure/ast/ios/") || p.includes("/scripts/hooks-system/infrastructure/ast/ios/")) return "ios";
-  }
-
   if (p.includes("/apps/backend/") || p.includes("apps/backend/")) return "backend";
   if (p.includes("/apps/admin/") || p.includes("/admin-dashboard/")) return "frontend";
   if (p.includes("/apps/mobile-ios/") || p.includes("/apps/ios/")) return "ios";

package/scripts/hooks-system/infrastructure/ast/ast-intelligence.js

@@ -1,6 +1,7 @@
 
 const path = require("path");
 const fs = require("fs");
+const env = require("../../config/env");
 
 const astModulesPath = __dirname;
 const { createProject, platformOf, mapToLevel } = require(path.join(astModulesPath, "ast-core"));
@@ -27,13 +28,7 @@ async function runASTIntelligence() {
     const { getRepoRoot } = require('./ast-core');
     const root = getRepoRoot();
 
-    const isLibraryAudit = process.env.AUDIT_LIBRARY === 'true';
-
-    const allFiles = listSourceFiles(root).filter(f => {
-      const p = String(f || '').replace(/\\/g, '/');
-      if (!isLibraryAudit && p.includes('/infrastructure/ast/')) return false;
-      return true;
-    });
+    const allFiles = listSourceFiles(root);
 
     const project = createProject(allFiles);
     const findings = [];
@@ -75,9 +70,9 @@ async function runASTIntelligence() {
 }
 
 function runProjectHardcodedThresholdAudit(root, allFiles, findings) {
-  if (process.env.AST_INSIGHTS !== '1') return;
+  if (env.get('AST_INSIGHTS', '0') !== '1') return;
 
-  const maxFindings = Number(process.env.AST_INSIGHTS_PROJECT_MAX || 200);
+  const maxFindings = env.getNumber('AST_INSIGHTS_PROJECT_MAX', 200);
   if (!Number.isFinite(maxFindings) || maxFindings <= 0) return;
 
   const isExcludedPath = (filePath) => {
@@ -160,7 +155,7 @@ function runProjectHardcodedThresholdAudit(root, allFiles, findings) {
 }
 
 function runHardcodedThresholdAudit(root, findings) {
-  if (process.env.AST_INSIGHTS !== '1') return;
+  if (env.get('AST_INSIGHTS', '0') !== '1') return;
 
   const ruleDirs = [
     path.join(root, 'infrastructure', 'ast'),
@@ -317,7 +312,7 @@ async function runPlatformAnalysis(project, findings, context) {
       }
     } catch (error) {
       console.error(`[ERROR] Error processing platform ${platform}:`, error.message);
-      if (process.env.DEBUG_AST) {
+      if (env.getBool('DEBUG_AST', false)) {
         console.error(error.stack);
       }
     }
@@ -376,7 +371,7 @@ function generateOutput(findings, context, project, root) {
  * Save detailed JSON report
  */
 function saveDetailedReport(findings, levelTotals, platformTotals, project, root) {
-  const outDir = process.env.AUDIT_TMP || path.join(root, ".audit_tmp");
+  const outDir = env.get('AUDIT_TMP', path.join(root, ".audit_tmp"));
   try {
     fs.mkdirSync(outDir, { recursive: true });
 
@@ -532,7 +527,7 @@ function checkForMigrations(root) {
  * List source files recursively
  */
 function listSourceFiles(root) {
-  if (process.env.STAGING_ONLY_MODE === "1") {
+  if (env.get('STAGING_ONLY_MODE', '0') === "1") {
     const { execSync } = require("child_process");
     try {
       const allStaged = execSync("git diff --cached --name-only --diff-filter=ACM", {
@@ -600,11 +595,6 @@ function listSourceFiles(root) {
 function shouldIgnore(file) {
   const p = file.replace(/\\/g, "/");
   if (p.includes("node_modules/")) return true;
-
-  const isLibraryAudit = process.env.AUDIT_LIBRARY === 'true';
-
-  if (!isLibraryAudit && p.includes("scripts/hooks-system/")) return true;
-  if (!isLibraryAudit && p.includes("/infrastructure/ast/")) return true;
   if (p.includes("/.cursor/")) return true;
   if (/\.bak/i.test(p)) return true;
   if (p.includes("/.next/")) return true;

package/scripts/hooks-system/infrastructure/ast/backend/analyzers/BackendPatternDetector.js

@@ -1,5 +1,6 @@
 const fs = require('fs');
 const path = require('path');
+const env = require('../../../../config/env');
 
 class BackendPatternDetector {
   constructor(projectRoot) {
@@ -11,7 +12,7 @@ class BackendPatternDetector {
       const fullPath = path.join(this.projectRoot, relativePath);
       return fs.readFileSync(fullPath, 'utf-8');
     } catch (error) {
-      if (process.env.DEBUG) {
+      if (env.getBool('DEBUG', false)) {
         console.debug(`[BackendPatternDetector] Failed to read file ${relativePath}: ${error.message}`);
       }
       return '';

package/scripts/hooks-system/infrastructure/ast/backend/ast-backend.js

@@ -1,11 +1,13 @@
-
 const path = require('path');
+const env = require('../../../config/env');
 const {
+  platformOf,
   pushFinding,
+  pushFileFinding,
   mapToLevel,
-  SyntaxKind,
+  positionOf,
   isTestFile,
-  platformOf,
+  SyntaxKind,
   hasImport,
   hasDecorator,
   findStringLiterals,
@@ -119,7 +121,7 @@ function runBackendIntelligence(project, findings, platform) {
       const filePath = sf.getFilePath();
       if (platformOf(filePath) !== 'backend') return;
       if (/\/ast-[^/]+\.js$/.test(filePath)) return;
-      if (process.env.AUDIT_LIBRARY !== 'true') {
+      if (!env.getBool('AUDIT_LIBRARY', false)) {
         if (/scripts\/hooks-system\/infrastructure\/ast\//i.test(filePath) || /\/infrastructure\/ast\//i.test(filePath)) return;
       }
       if (isTestFile(filePath)) return;
@@ -144,8 +146,8 @@ function runBackendIntelligence(project, findings, platform) {
 
     if (metrics.length === 0) return null;
 
-    const pOutlier = Number(process.env.AST_GODCLASS_P_OUTLIER || 90);
-    const pExtreme = Number(process.env.AST_GODCLASS_P_EXTREME || 97);
+    const pOutlier = env.getNumber('AST_GODCLASS_P_OUTLIER', 90);
+    const pExtreme = env.getNumber('AST_GODCLASS_P_EXTREME', 97);
 
     const methods = metrics.map(m => m.methodsCount);
     const props = metrics.map(m => m.propertiesCount);
@@ -202,12 +204,12 @@ function runBackendIntelligence(project, findings, platform) {
     if (platformOf(filePath) !== "backend") return;
 
     if (/\/ast-[^/]+\.js$/.test(filePath)) return;
-    if (process.env.AUDIT_LIBRARY !== 'true') {
+    if (!env.getBool('AUDIT_LIBRARY', false)) {
       if (/scripts\/hooks-system\/infrastructure\/ast\//i.test(filePath) || /\/infrastructure\/ast\//i.test(filePath)) return;
     }
 
     const fullText = sf.getFullText();
-    const insightsEnabled = process.env.AST_INSIGHTS === '1';
+    const insightsEnabled = env.get('AST_INSIGHTS', '0') === '1';
     const isSpecFile = /\.(spec|test)\.(ts|tsx|js|jsx)$/.test(filePath);
     const secretPattern = /(password|secret|key|token)\s*[:=]\s*['"`]([^'"]{8,})['"`]/gi;
     const matches = Array.from(fullText.matchAll(secretPattern));