pulse-updates 1.0.5 → 1.0.7

package/android/src/main/java/app/pulse/updates/PulseController.kt

@@ -99,6 +99,10 @@ class PulseController private constructor() {
     private var embeddedManifest: EmbeddedManifest? = null
     private val executor = Executors.newSingleThreadExecutor()
 
+    // Cached manifest from last check (to avoid duplicate requests in fetch)
+    // Only valid for the immediate check->fetch sequence, cleared on use or new check
+    private var lastCheckManifest: ManifestModel? = null
+
     // Embedded asset hashes set for download optimization
     internal val embeddedAssetHashes: Set<String>
         get() = embeddedManifest?.assets
@@ -526,11 +530,26 @@ class PulseController private constructor() {
         }
 
         executor.execute {
-            PulseRemoteLoader.checkForUpdate(cfg, launchedUpdate?.updateId, callback)
+            // Clear any previous cached manifest before new check
+            lastCheckManifest = null
+
+            PulseRemoteLoader.checkForUpdate(cfg, launchedUpdate?.updateId) { result ->
+                // Cache the manifest if update is available (for use by fetchUpdate)
+                result.fold(
+                    onSuccess = { checkResult ->
+                        if (checkResult.isAvailable && checkResult.manifest != null) {
+                            lastCheckManifest = checkResult.manifest
+                            pulseLog(TAG, "checkForUpdate: cached manifest for fetch")
+                        }
+                    },
+                    onFailure = { }
+                )
+                callback(result)
+            }
         }
     }
 
-    fun fetchUpdate(callback: (Result<FetchResult>) -> Unit) {
+    fun fetchUpdate(cachedManifest: ManifestModel? = null, callback: (Result<FetchResult>) -> Unit) {
         val cfg = config
         val ctx = context
         val dir = directory
@@ -545,8 +564,18 @@ class PulseController private constructor() {
             return
         }
 
+        // Use cached manifest from recent check if available
+        var manifestToUse = cachedManifest
+        if (manifestToUse == null && lastCheckManifest != null) {
+            pulseLog(TAG, "fetchUpdate: using cached manifest from recent check")
+            manifestToUse = lastCheckManifest
+        }
+
+        // Clear the cache after using it
+        lastCheckManifest = null
+
         executor.execute {
-            PulseRemoteLoader.fetchUpdate(cfg, database, dir, callback)
+            PulseRemoteLoader.fetchUpdate(cfg, database, dir, manifestToUse, callback)
         }
     }
 
@@ -1141,8 +1170,22 @@ object PulseRemoteLoader {
         config: PulseUpdatesConfig,
         database: PulseDatabase?,
         directory: File,
+        cachedManifest: ManifestModel? = null,
         callback: (Result<FetchResult>) -> Unit
     ) {
+        // If we already have a manifest from a previous check, use it directly
+        if (cachedManifest != null) {
+            pulseLog(TAG, "fetchUpdate: using cached manifest, skipping check")
+            downloadUpdate(cachedManifest, config, database, directory) { downloadResult ->
+                downloadResult.fold(
+                    onSuccess = { callback(Result.success(FetchResult(isNew = true, manifest = cachedManifest))) },
+                    onFailure = { callback(Result.failure(it)) }
+                )
+            }
+            return
+        }
+
+        // No cached manifest, need to check first
         checkForUpdate(config, PulseController.getInstance().launchedUpdate?.updateId) { result ->
             result.fold(
                 onSuccess = { checkResult ->
@@ -1265,6 +1308,10 @@ object PulseRemoteLoader {
 
         // Download assets and link them to the update
         val embeddedHashes = PulseController.getInstance().embeddedAssetHashes
+        pulseLog(TAG, "downloadUpdate: embeddedHashes count=${embeddedHashes.size}")
+        if (embeddedHashes.isNotEmpty()) {
+            pulseLog(TAG, "downloadUpdate: first few embedded hashes: ${embeddedHashes.take(3).map { it.take(16) }}")
+        }
 
         for (asset in manifest.assets) {
             val assetHash = asset.hash.lowercase()

package/ios/PulseUpdates/AppLauncher/PulseAppLauncher.swift

@@ -473,8 +473,8 @@ struct PulseEmbeddedAsset {
         self.hash = hash
         self.key = json["key"] as? String
         self.type = json["type"] as? String ?? json["contentType"] as? String
-        self.nsBundleDir = json["nsBundleDir"] as? String
-        self.nsBundleFilename = json["nsBundleFilename"] as? String
+        self.nsBundleDir = json["mainBundleDir"] as? String ?? json["nsBundleDir"] as? String
+        self.nsBundleFilename = json["mainBundleFilename"] as? String ?? json["nsBundleFilename"] as? String
     }
 }
 

package/ios/PulseUpdates/PulseController.swift

@@ -66,6 +66,10 @@ public final class PulseController {
     internal var embeddedAssetHashes: [String: URL] = [:]
     private var embeddedBundleHash: String?
 
+    // Cached manifest from last check (to avoid duplicate requests in fetch)
+    // Only valid for the immediate check->fetch sequence, cleared on use or new check
+    private var lastCheckManifest: PulseManifestModel?
+
     // MARK: - Native Config (from Info.plist, like expo-updates)
 
     /// Load config from Info.plist (called before JS starts)
@@ -404,12 +408,12 @@ public final class PulseController {
     private func performBackgroundUpdateCheck() {
         pulseLog("Performing background update check")
 
-        checkForUpdate { [weak self] result in
+        checkForUpdate { [weak self] (result: Result<PulseCheckResult, Error>) in
             switch result {
             case .success(let checkResult):
                 if checkResult.isAvailable {
                     pulseLog("Background check: update available, fetching...")
-                    self?.fetchUpdate { fetchResult in
+                    self?.fetchUpdate { (fetchResult: Result<PulseFetchResult, Error>) in
                         switch fetchResult {
                         case .success(let fetch):
                             if fetch.isNew {
@@ -475,15 +479,24 @@ public final class PulseController {
             return
         }
 
+        // Clear any previous cached manifest before new check
+        lastCheckManifest = nil
+
         PulseRemoteLoader.checkForUpdate(
             config: config,
-            currentUpdateId: launchedUpdate?.updateId,
-            completion: completion
-        )
+            currentUpdateId: launchedUpdate?.updateId
+        ) { [weak self] (result: Result<PulseCheckResult, Error>) in
+            // Cache the manifest for subsequent fetchUpdate call
+            if case .success(let checkResult) = result, checkResult.isAvailable {
+                self?.lastCheckManifest = checkResult.manifest
+            }
+            completion(result)
+        }
     }
 
     /// Fetch and download an update
-    public func fetchUpdate(completion: @escaping (Result<PulseFetchResult, Error>) -> Void) {
+    /// - Parameter cachedManifest: Optional manifest from a previous checkForUpdate call to avoid duplicate request
+    public func fetchUpdate(cachedManifest: PulseManifestModel? = nil, completion: @escaping (Result<PulseFetchResult, Error>) -> Void) {
         guard let config = config else {
             completion(.failure(PulseUpdatesError.notConfigured))
             return
@@ -494,10 +507,21 @@ public final class PulseController {
             return
         }
 
+        // Use cached manifest from recent checkForUpdate if available
+        var manifestToUse = cachedManifest
+        if manifestToUse == nil, let cached = lastCheckManifest {
+            pulseLog("fetchUpdate: using cached manifest from recent check")
+            manifestToUse = cached
+        }
+
+        // Clear cache after use
+        lastCheckManifest = nil
+
         PulseRemoteLoader.fetchUpdate(
             config: config,
             database: database,
             directory: directory,
+            cachedManifest: manifestToUse,
             completion: completion
         )
     }
@@ -594,7 +618,7 @@ public final class PulseController {
             }
         }
 
-        pulseLog("Loaded embedded manifest: \(embeddedManifest?.updateId ?? "unknown")")
+        pulseLog("Loaded embedded manifest: \(embeddedManifest?.updateId ?? "unknown"), embeddedAssetHashes count: \(embeddedAssetHashes.count)")
     }
 
     private func seedEmbeddedUpdateIfNeeded() {
@@ -661,7 +685,7 @@ public final class PulseController {
 
         self.launcher = launcher
 
-        launcher.launch { [weak self] success, error in
+        launcher.launch { [weak self] (success: Bool, error: Error?) in
             guard let self = self else {
                 completion(false)
                 return
@@ -931,10 +955,25 @@ final class PulseRemoteLoader {
         config: PulseUpdatesConfig,
         database: PulseDatabase?,
         directory: URL,
+        cachedManifest: PulseManifestModel? = nil,
         completion: @escaping (Result<PulseFetchResult, Error>) -> Void
     ) {
-        // First check for update
-        checkForUpdate(config: config, currentUpdateId: PulseController.shared.launchedUpdate?.updateId) { result in
+        // If we already have a manifest from a previous check, use it directly
+        if let manifest = cachedManifest {
+            pulseLog("fetchUpdate: using cached manifest, skipping check")
+            downloadUpdate(manifest: manifest, config: config, database: database, directory: directory) { (downloadResult: Result<Void, Error>) in
+                switch downloadResult {
+                case .failure(let error):
+                    completion(.failure(error))
+                case .success:
+                    completion(.success(PulseFetchResult(isNew: true, manifest: manifest)))
+                }
+            }
+            return
+        }
+
+        // No cached manifest, need to check first
+        checkForUpdate(config: config, currentUpdateId: PulseController.shared.launchedUpdate?.updateId) { (result: Result<PulseCheckResult, Error>) in
             switch result {
             case .failure(let error):
                 completion(.failure(error))
@@ -946,7 +985,7 @@ final class PulseRemoteLoader {
                 }
 
                 // Download the update
-                downloadUpdate(manifest: manifest, config: config, database: database, directory: directory) { downloadResult in
+                downloadUpdate(manifest: manifest, config: config, database: database, directory: directory) { (downloadResult: Result<Void, Error>) in
                     switch downloadResult {
                     case .failure(let error):
                         completion(.failure(error))
@@ -1019,7 +1058,7 @@ final class PulseRemoteLoader {
         try? database?.addUpdate(update)
 
         // Download bundle
-        downloadBundle(manifest: manifest, directory: directory, stagingDir: stagingDir, database: database, updateId: updateId) { bundleResult in
+        downloadBundle(manifest: manifest, directory: directory, stagingDir: stagingDir, database: database, updateId: updateId) { (bundleResult: Result<Void, Error>) in
             switch bundleResult {
             case .failure(let error):
                 try? database?.setStatus(.failed, forUpdateId: updateId)
@@ -1028,7 +1067,7 @@ final class PulseRemoteLoader {
 
             case .success:
                 // Download assets
-                downloadAssets(manifest: manifest, directory: directory, stagingDir: stagingDir, database: database, updateId: updateId) { assetsResult in
+                downloadAssets(manifest: manifest, directory: directory, stagingDir: stagingDir, database: database, updateId: updateId) { (assetsResult: Result<Void, Error>) in
                     switch assetsResult {
                     case .failure(let error):
                         try? database?.setStatus(.failed, forUpdateId: updateId)
@@ -1082,7 +1121,7 @@ final class PulseRemoteLoader {
 
         let tempPath = stagingDir.appendingPathComponent("bundle.tmp")
 
-        downloadFile(from: url, to: tempPath) { result in
+        downloadFile(from: url, to: tempPath) { (result: Result<Void, Error>) in
             switch result {
             case .failure(let error):
                 completion(.failure(error))
@@ -1123,6 +1162,12 @@ final class PulseRemoteLoader {
         let group = DispatchGroup()
         var downloadError: Error?
 
+        let embeddedHashes = PulseController.shared.embeddedAssetHashes
+        pulseLog("downloadAssets: embeddedAssetHashes count=\(embeddedHashes.count)")
+        if !embeddedHashes.isEmpty {
+            pulseLog("downloadAssets: first few embedded hashes: \(Array(embeddedHashes.keys.prefix(3)).map { String($0.prefix(16)) })")
+        }
+
         for asset in assets {
             group.enter()
 
@@ -1152,7 +1197,7 @@ final class PulseRemoteLoader {
 
             let tempPath = stagingDir.appendingPathComponent("asset-\(assetHash).tmp")
 
-            downloadFile(from: url, to: tempPath) { result in
+            downloadFile(from: url, to: tempPath) { (result: Result<Void, Error>) in
                 switch result {
                 case .failure(let error):
                     downloadError = error

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pulse-updates",
-  "version": "1.0.5",
+  "version": "1.0.7",
   "description": "OTA updates for React Native - lightweight alternative to expo-updates",
   "main": "lib/commonjs/index.js",
   "module": "lib/module/index.js",