pulse-js-framework 1.11.3 → 1.11.4

package/cli/docs-test.js

@@ -8,7 +8,7 @@
  * - .pulse file compilation check
  */
 
-import { readFileSync, existsSync, readdirSync, statSync } from 'fs';
+import { readFileSync, readdirSync, accessSync } from 'fs';
 import { join, dirname, relative } from 'path';
 import { fileURLToPath } from 'url';
 import { createServer } from 'http';
@@ -27,18 +27,23 @@ const SKIP_DIRS = ['node_modules', '.git', 'dist', 'build', '.next', '.nuxt', 'c
  * Collect all JS files recursively
  */
 function collectJsFiles(dir, files = []) {
-  if (!existsSync(dir)) return files;
+  let entries;
+  try {
+    entries = readdirSync(dir, { withFileTypes: true });
+  } catch (e) {
+    if (e.code === 'ENOENT') return files;
+    throw e;
+  }
 
-  for (const entry of readdirSync(dir)) {
+  for (const entry of entries) {
     // Skip common non-source directories
-    if (SKIP_DIRS.includes(entry)) continue;
+    if (SKIP_DIRS.includes(entry.name)) continue;
 
-    const fullPath = join(dir, entry);
-    const stat = statSync(fullPath);
+    const fullPath = join(dir, entry.name);
 
-    if (stat.isDirectory()) {
+    if (entry.isDirectory()) {
       collectJsFiles(fullPath, files);
-    } else if (entry.endsWith('.js')) {
+    } else if (entry.name.endsWith('.js')) {
       files.push(fullPath);
     }
   }
@@ -50,18 +55,23 @@ function collectJsFiles(dir, files = []) {
  * Collect all .pulse files recursively
  */
 function collectPulseFiles(dir, files = []) {
-  if (!existsSync(dir)) return files;
+  let entries;
+  try {
+    entries = readdirSync(dir, { withFileTypes: true });
+  } catch (e) {
+    if (e.code === 'ENOENT') return files;
+    throw e;
+  }
 
-  for (const entry of readdirSync(dir)) {
+  for (const entry of entries) {
     // Skip common non-source directories
-    if (SKIP_DIRS.includes(entry)) continue;
+    if (SKIP_DIRS.includes(entry.name)) continue;
 
-    const fullPath = join(dir, entry);
-    const stat = statSync(fullPath);
+    const fullPath = join(dir, entry.name);
 
-    if (stat.isDirectory()) {
+    if (entry.isDirectory()) {
       collectPulseFiles(fullPath, files);
-    } else if (entry.endsWith('.pulse')) {
+    } else if (entry.name.endsWith('.pulse')) {
       files.push(fullPath);
     }
   }
@@ -194,10 +204,16 @@ function resolveImport(importPath, fromFile) {
 
   // Add .js extension if missing
   if (!resolved.endsWith('.js') && !resolved.endsWith('.pulse')) {
-    if (existsSync(resolved + '.js')) {
+    try {
+      accessSync(resolved + '.js');
       resolved += '.js';
-    } else if (existsSync(resolved + '/index.js')) {
-      resolved = join(resolved, 'index.js');
+    } catch (e) {
+      try {
+        accessSync(resolved + '/index.js');
+        resolved = join(resolved, 'index.js');
+      } catch (_e) {
+        // Neither exists, return as-is
+      }
     }
   }
 
@@ -224,7 +240,9 @@ function validateImports(filePath) {
     // Skip pulse-js-framework imports
     if (importPath.includes('pulse-js-framework')) continue;
 
-    if (!existsSync(resolved)) {
+    try {
+      accessSync(resolved);
+    } catch (_e) {
       errors.push({
         file: filePath,
         importPath,
@@ -310,21 +328,22 @@ function startTestServer(port = 0) {
 
       const filePath = join(docsDir, pathname);
 
-      if (existsSync(filePath) && statSync(filePath).isFile()) {
-        const content = readFileSync(filePath);
-        const ext = pathname.split('.').pop();
-        const mimeTypes = {
-          'html': 'text/html',
-          'js': 'application/javascript',
-          'css': 'text/css',
-          'json': 'application/json'
-        };
-        res.writeHead(200, { 'Content-Type': mimeTypes[ext] || 'text/plain' });
-        res.end(content);
-      } else {
-        res.writeHead(404);
-        res.end('Not Found');
+      let content;
+      try {
+        content = readFileSync(filePath);
+      } catch (err) {
+        if (err.code === 'ENOENT' || err.code === 'EISDIR') { res.writeHead(404); res.end('Not Found'); return; }
+        throw err;
       }
+      const ext = pathname.split('.').pop();
+      const mimeTypes = {
+        'html': 'text/html',
+        'js': 'application/javascript',
+        'css': 'text/css',
+        'json': 'application/json'
+      };
+      res.writeHead(200, { 'Content-Type': mimeTypes[ext] || 'text/plain' });
+      res.end(content);
     });
 
     // Disable keep-alive timeout

package/cli/index.js

@@ -6,7 +6,7 @@
 
 import { fileURLToPath } from 'url';
 import { dirname, join, resolve, relative } from 'path';
-import { existsSync, mkdirSync, writeFileSync, readFileSync, readdirSync, watch, cpSync, statSync } from 'fs';
+import { mkdirSync, writeFileSync, readFileSync, readdirSync, watch, accessSync } from 'fs';
 import { log } from './logger.js';
 import { findPulseFiles, parseArgs } from './utils/file-utils.js';
 import { runHelp } from './help.js';
@@ -218,7 +218,9 @@ function copyExampleTemplate(templateName, projectPath, projectName) {
   const examplesDir = join(__dirname, '..', 'examples');
   const templateDir = join(examplesDir, templateName);
 
-  if (!existsSync(templateDir)) {
+  try {
+    accessSync(templateDir);
+  } catch (e) {
     throw new Error(`Template "${templateName}" not found at ${templateDir}`);
   }
 
@@ -226,9 +228,7 @@ function copyExampleTemplate(templateName, projectPath, projectName) {
    * Recursively copy directory, transforming JS files
    */
   function copyDir(src, dest) {
-    if (!existsSync(dest)) {
-      mkdirSync(dest, { recursive: true });
-    }
+    mkdirSync(dest, { recursive: true });
 
     const entries = readdirSync(src, { withFileTypes: true });
 
@@ -272,17 +272,24 @@ function copyExampleTemplate(templateName, projectPath, projectName) {
 
   // Copy src directory
   const srcDir = join(templateDir, 'src');
-  if (existsSync(srcDir)) {
+  try {
+    readdirSync(srcDir);
     copyDir(srcDir, join(projectPath, 'src'));
+  } catch (e) {
+    if (e.code !== 'ENOENT') throw e;
+    // No src directory in template, skip
   }
 
   // Copy index.html if exists
   const indexHtml = join(templateDir, 'index.html');
-  if (existsSync(indexHtml)) {
+  try {
     let content = readFileSync(indexHtml, 'utf-8');
     // Update title to project name
     content = content.replace(/<title>[^<]*<\/title>/, `<title>${projectName}</title>`);
     writeFileSync(join(projectPath, 'index.html'), content);
+  } catch (e) {
+    if (e.code !== 'ENOENT') throw e;
+    // No index.html in template, skip
   }
 
   return true;
@@ -312,9 +319,13 @@ async function createProject(args) {
 
   const projectPath = resolve(process.cwd(), projectName);
 
-  if (existsSync(projectPath)) {
+  try {
+    accessSync(projectPath);
     log.error(`Directory "${projectName}" already exists.`);
     process.exit(1);
+  } catch (e) {
+    if (e.code !== 'ENOENT') throw e;
+    // Path doesn't exist, safe to create
   }
 
   const useTypescript = options.typescript || options.ts || false;
@@ -675,34 +686,30 @@ async function initProject(args) {
   log.info(`Initializing Pulse project in current directory${useTypescript ? ' (TypeScript)' : ''}...`);
 
   // Create src directory if it doesn't exist
-  if (!existsSync(join(cwd, 'src'))) {
-    mkdirSync(join(cwd, 'src'));
-  }
+  mkdirSync(join(cwd, 'src'), { recursive: true });
 
   // Create public directory if it doesn't exist
-  if (!existsSync(join(cwd, 'public'))) {
-    mkdirSync(join(cwd, 'public'));
-  }
+  mkdirSync(join(cwd, 'public'), { recursive: true });
 
   // Check for existing package.json
   const pkgPath = join(cwd, 'package.json');
   let pkg = {};
 
-  if (existsSync(pkgPath)) {
-    try {
-      const pkgContent = readFileSync(pkgPath, 'utf-8');
-      if (!pkgContent.trim()) {
-        log.warn('Existing package.json is empty, creating new one.');
-      } else {
-        pkg = JSON.parse(pkgContent);
-        log.info('Found existing package.json, merging...');
-      }
-    } catch (e) {
-      if (e instanceof SyntaxError) {
-        log.warn(`Invalid JSON in package.json: ${e.message}. Creating new one.`);
-      } else {
-        log.warn(`Could not read package.json: ${e.message}. Creating new one.`);
-      }
+  try {
+    const pkgContent = readFileSync(pkgPath, 'utf-8');
+    if (!pkgContent.trim()) {
+      log.warn('Existing package.json is empty, creating new one.');
+    } else {
+      pkg = JSON.parse(pkgContent);
+      log.info('Found existing package.json, merging...');
+    }
+  } catch (e) {
+    if (e.code === 'ENOENT') {
+      // No existing package.json, will create new one
+    } else if (e instanceof SyntaxError) {
+      log.warn(`Invalid JSON in package.json: ${e.message}. Creating new one.`);
+    } else {
+      log.warn(`Could not read package.json: ${e.message}. Creating new one.`);
     }
   }
 
@@ -742,7 +749,7 @@ async function initProject(args) {
   const viteConfigExt = useTypescript ? 'ts' : 'js';
   const viteConfigPath = join(cwd, `vite.config.${viteConfigExt}`);
 
-  if (!existsSync(viteConfigPath) && !existsSync(join(cwd, 'vite.config.js')) && !existsSync(join(cwd, 'vite.config.ts'))) {
+  {
     const viteConfig = `import { defineConfig } from 'vite';
 import pulse from 'pulse-js-framework/vite';
 
@@ -750,12 +757,17 @@ export default defineConfig({
   plugins: [pulse()]
 });
 `;
-    writeFileSync(viteConfigPath, viteConfig);
-    log.success(`Created vite.config.${viteConfigExt}`);
+    // Use atomic wx flag to avoid TOCTOU race (no existsSync check needed)
+    try {
+      writeFileSync(viteConfigPath, viteConfig, { flag: 'wx' });
+      log.success(`Created vite.config.${viteConfigExt}`);
+    } catch (e) {
+      if (e.code !== 'EEXIST') throw e;
+    }
   }
 
-  // Create tsconfig if TypeScript
-  if (useTypescript && !existsSync(join(cwd, 'tsconfig.json'))) {
+  // Create tsconfig if TypeScript (use wx flag to avoid TOCTOU race)
+  if (useTypescript) {
     const tsConfig = {
       compilerOptions: {
         target: 'ES2022',
@@ -777,13 +789,17 @@ export default defineConfig({
       exclude: ['node_modules', 'dist']
     };
 
-    writeFileSync(join(cwd, 'tsconfig.json'), JSON.stringify(tsConfig, null, 2));
-    log.success('Created tsconfig.json');
+    try {
+      writeFileSync(join(cwd, 'tsconfig.json'), JSON.stringify(tsConfig, null, 2), { flag: 'wx' });
+      log.success('Created tsconfig.json');
+    } catch (e) {
+      if (e.code !== 'EEXIST') throw e;
+    }
   }
 
   // Create index.html if it doesn't exist
   const indexHtmlPath = join(cwd, 'index.html');
-  if (!existsSync(indexHtmlPath)) {
+  {
     const mainExt = useTypescript ? 'ts' : 'js';
     const indexHtml = `<!DOCTYPE html>
 <html lang="en">
@@ -798,14 +814,18 @@ export default defineConfig({
 </body>
 </html>
 `;
-    writeFileSync(indexHtmlPath, indexHtml);
-    log.success('Created index.html');
+    try {
+      writeFileSync(indexHtmlPath, indexHtml, { flag: 'wx' });
+      log.success('Created index.html');
+    } catch (e) {
+      if (e.code !== 'EEXIST') throw e;
+    }
   }
 
   // Create main entry file if it doesn't exist
   const mainExt = useTypescript ? 'ts' : 'js';
   const mainPath = join(cwd, 'src', `main.${mainExt}`);
-  if (!existsSync(mainPath)) {
+  {
     const mainContent = useTypescript
       ? `import App from './App.pulse';
 
@@ -821,13 +841,17 @@ if (import.meta.hot) {
 
 App.mount('#app');
 `;
-    writeFileSync(mainPath, mainContent);
-    log.success(`Created src/main.${mainExt}`);
+    try {
+      writeFileSync(mainPath, mainContent, { flag: 'wx' });
+      log.success(`Created src/main.${mainExt}`);
+    } catch (e) {
+      if (e.code !== 'EEXIST') throw e;
+    }
   }
 
   // Create App.pulse if it doesn't exist
   const appPulsePath = join(cwd, 'src', 'App.pulse');
-  if (!existsSync(appPulsePath)) {
+  {
     const appPulse = `@page App
 
 // Welcome to Pulse Framework!
@@ -970,20 +994,28 @@ style {
   }
 }
 `;
-    writeFileSync(appPulsePath, appPulse);
-    log.success('Created src/App.pulse');
+    try {
+      writeFileSync(appPulsePath, appPulse, { flag: 'wx' });
+      log.success('Created src/App.pulse');
+    } catch (e) {
+      if (e.code !== 'EEXIST') throw e;
+    }
   }
 
   // Create .gitignore if it doesn't exist
   const gitignorePath = join(cwd, '.gitignore');
-  if (!existsSync(gitignorePath)) {
+  {
     const gitignore = `node_modules
 dist
 .DS_Store
 *.local
 ${useTypescript ? '*.tsbuildinfo\n' : ''}`;
-    writeFileSync(gitignorePath, gitignore);
-    log.success('Created .gitignore');
+    try {
+      writeFileSync(gitignorePath, gitignore, { flag: 'wx' });
+      log.success('Created .gitignore');
+    } catch (e) {
+      if (e.code !== 'EEXIST') throw e;
+    }
   }
 
   log.info(`
@@ -1283,9 +1315,7 @@ async function compileFiles(args) {
         if (result.success) {
           // Ensure output directory exists
           const outDir = dirname(outputFile);
-          if (!existsSync(outDir)) {
-            mkdirSync(outDir, { recursive: true });
-          }
+          mkdirSync(outDir, { recursive: true });
           writeFileSync(outputFile, result.code);
           log.info(`Compiled: ${relPath} -> ${relOutput}`);
           writtenCount++;

package/cli/mobile.js

@@ -3,7 +3,7 @@
  * Zero-dependency mobile platform for Pulse Framework
  */
 
-import { existsSync, mkdirSync, readFileSync, writeFileSync, cpSync, readdirSync } from 'fs';
+import { mkdirSync, readFileSync, writeFileSync, cpSync, readdirSync } from 'fs';
 import { join, dirname } from 'path';
 import { fileURLToPath } from 'url';
 import { execSync } from 'child_process';
@@ -19,7 +19,7 @@ const CONFIG_FILE = 'pulse.mobile.json';
 // ============================================================================
 
 /** Create directory if it doesn't exist */
-const mkdirp = (path) => !existsSync(path) && mkdirSync(path, { recursive: true });
+const mkdirp = (path) => mkdirSync(path, { recursive: true });
 
 /** Create multiple directories at once */
 const mkdirs = (base, dirs) => dirs.forEach(d => mkdirp(join(base, d)));
@@ -83,24 +83,31 @@ async function initMobile(args) {
   console.log('Initializing Pulse Mobile...\n');
 
   // Check if dist exists
-  if (!existsSync(join(root, 'dist'))) {
-    console.warn('Warning: No dist/ folder found. Run "pulse build" first.\n');
+  try {
+    readdirSync(join(root, 'dist'));
+  } catch (e) {
+    if (e.code === 'ENOENT') {
+      console.warn('Warning: No dist/ folder found. Run "pulse build" first.\n');
+    } else {
+      throw e;
+    }
   }
 
   // Create mobile directory
-  if (!existsSync(mobileDir)) {
-    mkdirSync(mobileDir, { recursive: true });
-  }
+  mkdirSync(mobileDir, { recursive: true });
 
   // Read project name from package.json
   let projectName = 'PulseApp';
   let packageId = 'com.pulse.app';
 
   const packageJsonPath = join(root, 'package.json');
-  if (existsSync(packageJsonPath)) {
+  try {
     const pkg = JSON.parse(readFileSync(packageJsonPath, 'utf-8'));
     projectName = toPascalCase(pkg.name || 'PulseApp');
     packageId = `com.pulse.${pkg.name?.toLowerCase().replace(/[^a-z0-9]/g, '') || 'app'}`;
+  } catch (e) {
+    if (e.code !== 'ENOENT') throw e;
+    // No package.json, use defaults
   }
 
   // Create default config
@@ -122,54 +129,70 @@ async function initMobile(args) {
   };
 
   // Write config if not exists
-  if (!existsSync(configPath)) {
-    writeFileSync(configPath, JSON.stringify(config, null, 2));
+  try {
+    writeFileSync(configPath, JSON.stringify(config, null, 2), { flag: 'wx' });
     console.log(`Created ${CONFIG_FILE}`);
-  } else {
-    console.log(`${CONFIG_FILE} already exists, skipping...`);
+  } catch (err) {
+    if (err.code === 'EEXIST') {
+      console.log(`${CONFIG_FILE} already exists, skipping...`);
+    } else {
+      throw err;
+    }
   }
 
   // Copy Android template
   const androidTemplateDir = join(__dirname, '..', 'mobile', 'templates', 'android');
   const androidDir = join(mobileDir, 'android');
 
-  if (!existsSync(androidDir)) {
-    if (existsSync(androidTemplateDir)) {
+  try {
+    readdirSync(androidDir);
+    console.log('Android directory exists, skipping...');
+  } catch (e) {
+    if (e.code !== 'ENOENT') throw e;
+    try {
+      readdirSync(androidTemplateDir);
       console.log('Initializing Android project...');
       copyAndProcessTemplate(androidTemplateDir, androidDir, config);
       console.log('Android project created.');
-    } else {
+    } catch (te) {
+      if (te.code !== 'ENOENT') throw te;
       console.log('Creating Android project structure...');
       createAndroidProject(androidDir, config);
       console.log('Android project created.');
     }
-  } else {
-    console.log('Android directory exists, skipping...');
   }
 
   // Copy iOS template
   const iosTemplateDir = join(__dirname, '..', 'mobile', 'templates', 'ios');
   const iosDir = join(mobileDir, 'ios');
 
-  if (!existsSync(iosDir)) {
-    if (existsSync(iosTemplateDir)) {
+  try {
+    readdirSync(iosDir);
+    console.log('iOS directory exists, skipping...');
+  } catch (e) {
+    if (e.code !== 'ENOENT') throw e;
+    try {
+      readdirSync(iosTemplateDir);
       console.log('Initializing iOS project...');
       copyAndProcessTemplate(iosTemplateDir, iosDir, config);
       console.log('iOS project created.');
-    } else {
+    } catch (te) {
+      if (te.code !== 'ENOENT') throw te;
       console.log('Creating iOS project structure...');
       createIOSProject(iosDir, config);
       console.log('iOS project created.');
     }
-  } else {
-    console.log('iOS directory exists, skipping...');
   }
 
   // Copy bridge script to dist if it exists
   const bridgeSource = join(__dirname, '..', 'mobile', 'bridge', 'pulse-native.js');
-  if (existsSync(join(root, 'dist')) && existsSync(bridgeSource)) {
+  try {
+    readdirSync(join(root, 'dist'));
     cpSync(bridgeSource, join(root, 'dist', 'pulse-native.js'));
     console.log('Native bridge script copied to dist/');
+  } catch (e) {
+    if (e.code !== 'ENOENT') throw e;
+    // dist or bridge source doesn't exist, skip
   }
 
   console.log(`
@@ -202,7 +225,10 @@ async function buildMobile(args) {
   const config = loadConfig(root);
 
   // First, ensure web build exists
-  if (!existsSync(join(root, config.webDir))) {
+  try {
+    readdirSync(join(root, config.webDir));
+  } catch (e) {
+    if (e.code !== 'ENOENT') throw e;
     console.log('Building web app first...');
     const { buildProject } = await import('./build.js');
     await buildProject([]);
@@ -268,9 +294,14 @@ async function syncAssets(args) {
 async function syncWebAssets(root, platform, config) {
   const webDir = join(root, config.webDir);
 
-  if (!existsSync(webDir)) {
-    console.error(`Web directory "${config.webDir}" not found. Run "pulse build" first.`);
-    process.exit(1);
+  try {
+    readdirSync(webDir);
+  } catch (e) {
+    if (e.code === 'ENOENT' || e.code === 'ENOTDIR') {
+      console.error(`Web directory "${config.webDir}" not found. Run "pulse build" first.`);
+      process.exit(1);
+    }
+    throw e;
   }
 
   let assetsDir;
@@ -288,8 +319,11 @@ async function syncWebAssets(root, platform, config) {
 
   // Copy native bridge
   const bridgeSource = join(__dirname, '..', 'mobile', 'bridge', 'pulse-native.js');
-  if (existsSync(bridgeSource)) {
+  try {
     cpSync(bridgeSource, join(assetsDir, 'pulse-native.js'));
+  } catch (e) {
+    if (e.code !== 'ENOENT') throw e;
+    // Bridge source not found, skip
   }
 
   console.log(`Web assets synced to ${platform}`);
@@ -301,9 +335,14 @@ async function syncWebAssets(root, platform, config) {
 async function buildAndroid(root, config) {
   const androidDir = join(root, MOBILE_DIR, 'android');
 
-  if (!existsSync(androidDir)) {
-    console.error('Android project not found. Run "pulse mobile init" first.');
-    process.exit(1);
+  try {
+    readdirSync(androidDir);
+  } catch (e) {
+    if (e.code === 'ENOENT' || e.code === 'ENOTDIR') {
+      console.error('Android project not found. Run "pulse mobile init" first.');
+      process.exit(1);
+    }
+    throw e;
   }
 
   console.log('Building Android APK...\n');
@@ -341,9 +380,14 @@ async function buildIOS(root, config) {
 
   const iosDir = join(root, MOBILE_DIR, 'ios');
 
-  if (!existsSync(iosDir)) {
-    console.error('iOS project not found. Run "pulse mobile init" first.');
-    process.exit(1);
+  try {
+    readdirSync(iosDir);
+  } catch (e) {
+    if (e.code === 'ENOENT' || e.code === 'ENOTDIR') {
+      console.error('iOS project not found. Run "pulse mobile init" first.');
+      process.exit(1);
+    }
+    throw e;
   }
 
   console.log('Building iOS app...\n');
@@ -443,17 +487,25 @@ async function runIOS(root, config) {
 function loadConfig(root) {
   const configPath = join(root, CONFIG_FILE);
 
-  if (!existsSync(configPath)) {
-    console.error(`No ${CONFIG_FILE} found. Run "pulse mobile init" first.`);
-    process.exit(1);
+  try {
+    return JSON.parse(readFileSync(configPath, 'utf-8'));
+  } catch (e) {
+    if (e.code === 'ENOENT') {
+      console.error(`No ${CONFIG_FILE} found. Run "pulse mobile init" first.`);
+      process.exit(1);
+    }
+    throw e;
   }
-
-  return JSON.parse(readFileSync(configPath, 'utf-8'));
 }
 
 /** Copy and process template files */
 function copyAndProcessTemplate(src, dest, config) {
-  if (!existsSync(src)) return;
+  try {
+    readdirSync(src);
+  } catch (e) {
+    if (e.code === 'ENOENT') return;
+    throw e;
+  }
   mkdirp(dest);
 
   for (const file of readdirSync(src, { withFileTypes: true })) {