pulsar-client 1.3.0 → 1.3.2

package/.eslintrc.json

@@ -1,5 +1,5 @@
 {
-  "extends": "airbnb-base",
+  "extends": ["airbnb-base","plugin:jest/recommended"],
   "rules": {
     "class-methods-use-this": "warn",
     "no-await-in-loop": "warn",

package/README.md

@@ -42,10 +42,11 @@ Compatibility between each version of the Node.js client and the C++ client is a
 
 | Node.js client | C++ client     |
 |----------------|----------------|
-| 1.0.0          | 2.3.0 or later |
-| 1.1.0          | 2.4.0 or later |
-| 1.2.0          | 2.5.0 or later |
-| 1.3.0          | 2.7.0 or later |
+| 1.0.x          | 2.3.0 or later |
+| 1.1.x          | 2.4.0 or later |
+| 1.2.x          | 2.5.0 or later |
+| 1.3.x          | 2.7.0 or later |
+| 1.4.x          | 2.8.0 or later |
 
 If an incompatible version of the C++ client is installed, you may fail to build or run this library.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pulsar-client",
-  "version": "1.3.0",
+  "version": "1.3.2",
   "description": "Pulsar Node.js client",
   "main": "index.js",
   "types": "index.d.ts",
@@ -37,22 +37,23 @@
     "clang-format": "^1.4.0",
     "commander": "^6.1.0",
     "delay": "^4.4.0",
-    "dtslint": "^4.0.6",
+    "dtslint": "^3.4.2",
     "eslint": "^7.8.1",
     "eslint-config-airbnb-base": "^14.2.0",
     "eslint-plugin-import": "^2.22.0",
-    "grunt": "^1.3.0",
+    "eslint-plugin-jest": "^24.3.6",
+    "grunt": "^1.4.1",
     "grunt-license-report": "^0.0.8",
     "hdr-histogram-js": "^2.0.1",
-    "jest": "^26.4.2",
+    "jest": "^27.2.4",
     "license-check-and-add": "^2.3.6",
-    "lodash": "^4.17.20",
+    "lodash": "^4.17.21",
     "typescript": "^4.1.3"
   },
   "dependencies": {
     "bindings": "^1.5.0",
     "node-addon-api": "^3.0.0",
-    "node-gyp": "^7.1.0",
+    "node-gyp": "^8.2.0",
     "node-pre-gyp": "^0.15.0"
   },
   "binary": {

package/src/Message.cc

@@ -100,7 +100,7 @@ Napi::Value Message::GetData(const Napi::CallbackInfo &info) {
   }
   void *data = const_cast<void *>(pulsar_message_get_data(this->cMessage));
   size_t size = (size_t)pulsar_message_get_length(this->cMessage);
-  return Napi::Buffer<char>::New(env, (char *)data, size);
+  return Napi::Buffer<char>::Copy(env, (char *)data, size);
 }
 
 Napi::Value Message::GetMessageId(const Napi::CallbackInfo &info) {

package/src/MessageId.cc

@@ -17,6 +17,8 @@
  * under the License.
  */
 
+#include <stdlib.h>
+
 #include "MessageId.h"
 #include <pulsar/c/message.h>
 #include <pulsar/c/message_id.h>
@@ -87,13 +89,15 @@ Napi::Value MessageId::Latest(const Napi::CallbackInfo &info) {
   return obj;
 }
 
+void serializeFinalizeCallback(Napi::Env env, char *ptr) { free(ptr); }
+
 Napi::Value MessageId::Serialize(const Napi::CallbackInfo &info) {
   Napi::Env env = info.Env();
 
   int len;
   void *ptr = pulsar_message_id_serialize(GetCMessageId(), &len);
 
-  return Napi::Buffer<char>::New(env, (char *)ptr, len);
+  return Napi::Buffer<char>::New(env, (char *)ptr, len, serializeFinalizeCallback);
 }
 
 Napi::Value MessageId::Deserialize(const Napi::CallbackInfo &info) {
@@ -117,7 +121,10 @@ Napi::Value MessageId::Deserialize(const Napi::CallbackInfo &info) {
 pulsar_message_id_t *MessageId::GetCMessageId() { return this->cMessageId; }
 
 Napi::Value MessageId::ToString(const Napi::CallbackInfo &info) {
-  return Napi::String::New(info.Env(), pulsar_message_id_str(this->cMessageId));
+  char *cStr = pulsar_message_id_str(this->cMessageId);
+  std::string s(cStr);
+  free(cStr);
+  return Napi::String::New(info.Env(), s);
 }
 
 MessageId::~MessageId() {

package/tests/consumer.test.js

@@ -21,10 +21,19 @@ const Pulsar = require('../index.js');
 
 (() => {
   describe('Consumer', () => {
-    const client = new Pulsar.Client({
-      serviceUrl: 'pulsar://localhost:6650',
-      operationTimeoutSeconds: 30,
+    let client;
+
+    beforeAll(() => {
+      client = new Pulsar.Client({
+        serviceUrl: 'pulsar://localhost:6650',
+        operationTimeoutSeconds: 30,
+      });
     });
+
+    afterAll(async () => {
+      await client.close();
+    });
+
     describe('Create', () => {
       test('No Topic', async () => {
         await expect(client.subscribe({

package/tests/producer.test.js

@@ -21,10 +21,19 @@ const Pulsar = require('../index.js');
 
 (() => {
   describe('Producer', () => {
-    const client = new Pulsar.Client({
-      serviceUrl: 'pulsar://localhost:6650',
-      operationTimeoutSeconds: 30,
+    let client;
+
+    beforeAll(() => {
+      client = new Pulsar.Client({
+        serviceUrl: 'pulsar://localhost:6650',
+        operationTimeoutSeconds: 30,
+      });
     });
+
+    afterAll(async () => {
+      await client.close();
+    });
+
     describe('Create', () => {
       test('No Topic', async () => {
         await expect(client.createProducer({

package/tests/reader.test.js

@@ -21,52 +21,50 @@ const Pulsar = require('../index.js');
 
 (() => {
   describe('Reader', () => {
-    describe('Create', () => {
-      test('No Topic', async () => {
-        const client = new Pulsar.Client({
-          serviceUrl: 'pulsar://localhost:6650',
-          operationTimeoutSeconds: 30,
-        });
-        await expect(client.createReader({
-          startMessageId: Pulsar.MessageId.earliest(),
-        })).rejects.toThrow('Topic is required and must be specified as a string when creating reader');
-        await client.close();
+    test('No Topic', async () => {
+      const client = new Pulsar.Client({
+        serviceUrl: 'pulsar://localhost:6650',
+        operationTimeoutSeconds: 30,
       });
+      await expect(client.createReader({
+        startMessageId: Pulsar.MessageId.earliest(),
+      })).rejects.toThrow('Topic is required and must be specified as a string when creating reader');
+      await client.close();
+    });
 
-      test('No Topic', async () => {
-        const client = new Pulsar.Client({
-          serviceUrl: 'pulsar://localhost:6650',
-          operationTimeoutSeconds: 30,
-        });
-        await expect(client.createReader({
-          topic: 0,
-          startMessageId: Pulsar.MessageId.earliest(),
-        })).rejects.toThrow('Topic is required and must be specified as a string when creating reader');
-        await client.close();
+    test('Not String Topic', async () => {
+      const client = new Pulsar.Client({
+        serviceUrl: 'pulsar://localhost:6650',
+        operationTimeoutSeconds: 30,
       });
+      await expect(client.createReader({
+        topic: 0,
+        startMessageId: Pulsar.MessageId.earliest(),
+      })).rejects.toThrow('Topic is required and must be specified as a string when creating reader');
+      await client.close();
+    });
 
-      test('No StartMessageId', async () => {
-        const client = new Pulsar.Client({
-          serviceUrl: 'pulsar://localhost:6650',
-          operationTimeoutSeconds: 30,
-        });
-        await expect(client.createReader({
-          topic: 'persistent://public/default/topic',
-        })).rejects.toThrow('StartMessageId is required and must be specified as a MessageId object when creating reader');
-        await client.close();
+    test('No StartMessageId', async () => {
+      const client = new Pulsar.Client({
+        serviceUrl: 'pulsar://localhost:6650',
+        operationTimeoutSeconds: 30,
       });
+      await expect(client.createReader({
+        topic: 'persistent://public/default/topic',
+      })).rejects.toThrow('StartMessageId is required and must be specified as a MessageId object when creating reader');
+      await client.close();
+    });
 
-      test('Not StartMessageId as MessageId', async () => {
-        const client = new Pulsar.Client({
-          serviceUrl: 'pulsar://localhost:6650',
-          operationTimeoutSeconds: 30,
-        });
-        await expect(client.createReader({
-          topic: 'persistent://public/default/topic',
-          startMessageId: 'not MessageId',
-        })).rejects.toThrow('StartMessageId is required and must be specified as a MessageId object when creating reader');
-        await client.close();
+    test('Not StartMessageId as MessageId', async () => {
+      const client = new Pulsar.Client({
+        serviceUrl: 'pulsar://localhost:6650',
+        operationTimeoutSeconds: 30,
       });
+      await expect(client.createReader({
+        topic: 'persistent://public/default/topic',
+        startMessageId: 'not MessageId',
+      })).rejects.toThrow('StartMessageId is required and must be specified as a MessageId object when creating reader');
+      await client.close();
     });
   });
 })();

package/tslint.json

@@ -2,6 +2,7 @@
   "extends": "dtslint/dtslint.json",
   "rules": {
     "no-unnecessary-class": false,
-    "no-relative-import-in-test": false
+    "no-relative-import-in-test": false,
+    "strict-export-declare-modifiers": false
   }
 }