publishport-opencli 1.8.5-pp.2 → 1.8.5-pp.21

package/clis/slock/errors.test.js

@@ -1,29 +0,0 @@
-import { describe, it, expect } from 'vitest';
-import { ArgumentError, AuthRequiredError, CommandExecutionError, ConfigError } from '@jackwener/opencli/errors';
-import { dispatchEvaluateResult } from './errors.js';
-
-describe('dispatchEvaluateResult', () => {
-  it('returns rows on kind:"ok"', () => {
-    const rows = dispatchEvaluateResult({ kind: 'ok', rows: [{ a: 1 }] });
-    expect(rows).toEqual([{ a: 1 }]);
-  });
-
-  it('throws AuthRequiredError on kind:"auth"', () => {
-    expect(() => dispatchEvaluateResult({ kind: 'auth', detail: 'x' })).toThrow(AuthRequiredError);
-  });
-
-  it('throws CommandExecutionError on kind:"http" with status + where', () => {
-    expect(() => dispatchEvaluateResult({ kind: 'http', status: 500, where: '/messages' }))
-      .toThrow(/HTTP 500.*\/messages/);
-  });
-
-  it('throws ConfigError on kind:"no-server"', () => {
-    expect(() => dispatchEvaluateResult({ kind: 'no-server', detail: 'no slug' }))
-      .toThrow(ConfigError);
-  });
-
-  it('throws ArgumentError on kind:"unresolvable"', () => {
-    expect(() => dispatchEvaluateResult({ kind: 'unresolvable', detail: 'short id had 0 matches' }))
-      .toThrow(ArgumentError);
-  });
-});

package/clis/slock/in-page.test.js

@@ -1,362 +0,0 @@
-import { describe, it, expect, vi } from 'vitest';
-import { buildFetchSnippet, buildChannelScopedSnippet, channelResolveFragment } from './in-page.js';
-import { SLOCK_API_BASE } from './shared.js';
-
-const UUID_A = '11111111-1111-1111-1111-111111111111';
-
-// Run a snippet in this realm with fetch + localStorage stubbed.
-// async + awaited inside try/finally so globals are restored only AFTER
-// the snippet's async IIFE fully settles.
-async function runSnippet(snippet, fetchImpl, lsMap = {}) {
-  const realFetch = globalThis.fetch;
-  const realLS = globalThis.localStorage;
-  const realLocation = globalThis.location;
-  const store = { ...lsMap };
-  globalThis.fetch = fetchImpl;
-  globalThis.localStorage = {
-    getItem: (k) => (k in store ? store[k] : null),
-    setItem: (k, v) => { store[k] = String(v); },
-  };
-  // authHeadersFragment now opens with a page-readiness loop that waits until
-  // location.href contains 'app.slock.ai' (so localStorage on an opaque
-  // interstitial origin doesn't throw SecurityError). Stub a satisfied
-  // location so the snippet doesn't burn 3s of fake time.
-  globalThis.location = { href: 'https://app.slock.ai/' };
-  try {
-    // eslint-disable-next-line no-eval
-    return await eval(`(async () => { ${snippet} })()`);
-  } finally {
-    globalThis.fetch = realFetch;
-    globalThis.localStorage = realLS;
-    globalThis.location = realLocation;
-  }
-}
-
-describe('buildFetchSnippet', () => {
-  it('GET with no body returns the ok envelope on 200', async () => {
-    const snippet = buildFetchSnippet({ method: 'GET', path: '/channels/', serverScoped: true });
-    const fakeFetch = vi.fn()
-      .mockResolvedValueOnce({ ok: true, status: 200, json: async () => [{ id: 's1', slug: 'eng' }] })  // GET /servers/
-      .mockResolvedValueOnce({ ok: true, status: 200, json: async () => [{ id: 'c1', name: 'general' }] });
-    const result = await runSnippet(snippet, fakeFetch, {
-      slock_access_token: 'tkn',
-      slock_last_server_slug: 'eng',
-    });
-    expect(result).toEqual({ kind: 'ok', rows: [{ id: 'c1', name: 'general' }] });
-  });
-
-  it('POST sends the JSON body with content-type header', async () => {
-    const snippet = buildFetchSnippet({
-      method: 'POST',
-      path: '/messages',
-      body: { channelId: 'c1', content: 'hi' },
-      serverScoped: true,
-    });
-    const fakeFetch = vi.fn()
-      .mockResolvedValueOnce({ ok: true, status: 200, json: async () => [{ id: 's1', slug: 'eng' }] })
-      .mockResolvedValueOnce({ ok: true, status: 200, json: async () => ({ id: 'm1' }) });
-    await runSnippet(snippet, fakeFetch, {
-      slock_access_token: 'tkn',
-      slock_last_server_slug: 'eng',
-    });
-    const call = fakeFetch.mock.calls[1];
-    expect(call[0]).toBe(SLOCK_API_BASE + '/messages');
-    expect(call[1].method).toBe('POST');
-    expect(call[1].headers['content-type']).toBe('application/json');
-    expect(JSON.parse(call[1].body)).toEqual({ channelId: 'c1', content: 'hi' });
-  });
-
-  it('server-scoped path injects X-Server-Id from resolved slug', async () => {
-    const snippet = buildFetchSnippet({ method: 'GET', path: '/channels/', serverScoped: true });
-    const fakeFetch = vi.fn()
-      .mockResolvedValueOnce({ ok: true, status: 200, json: async () => [{ id: 'sid-1', slug: 'eng' }] })
-      .mockResolvedValueOnce({ ok: true, status: 200, json: async () => [] });
-    await runSnippet(snippet, fakeFetch, {
-      slock_access_token: 'tkn',
-      slock_last_server_slug: 'eng',
-    });
-    expect(fakeFetch.mock.calls[1][1].headers['x-server-id']).toBe('sid-1');
-  });
-
-  it('non-server-scoped path does NOT include X-Server-Id', async () => {
-    const snippet = buildFetchSnippet({ method: 'GET', path: '/auth/me', serverScoped: false });
-    const fakeFetch = vi.fn().mockResolvedValueOnce({ ok: true, status: 200, json: async () => ({ id: 'u1' }) });
-    await runSnippet(snippet, fakeFetch, { slock_access_token: 'tkn' });
-    expect(fakeFetch.mock.calls[0][1].headers['x-server-id']).toBeUndefined();
-  });
-
-  it('returns kind:"auth" envelope on 401', async () => {
-    const snippet = buildFetchSnippet({ method: 'GET', path: '/auth/me', serverScoped: false });
-    const fakeFetch = vi.fn().mockResolvedValueOnce({ ok: false, status: 401, json: async () => ({}) });
-    const result = await runSnippet(snippet, fakeFetch, { slock_access_token: 'tkn' });
-    expect(result).toMatchObject({ kind: 'auth' });
-  });
-
-  it('returns kind:"no-server" when localStorage slug is missing on a server-scoped call', async () => {
-    const snippet = buildFetchSnippet({ method: 'GET', path: '/channels/', serverScoped: true });
-    const fakeFetch = vi.fn();
-    const result = await runSnippet(snippet, fakeFetch, { slock_access_token: 'tkn' });
-    expect(result).toMatchObject({ kind: 'no-server' });
-    expect(fakeFetch.mock.calls.length).toBe(0);
-  });
-});
-
-// Red-line: body is always JSON.stringify'd — no string concatenation, so injection is impossible.
-describe('buildFetchSnippet [red-line] injection safety', () => {
-  for (const evil of [
-    `'); alert('x'); ('`,
-    `</script><script>1</script>`,
-    `pizza 🍕 + surrogate 💊`,
-  ]) {
-    it(`content ${JSON.stringify(evil).slice(0, 40)}... round-trips byte-equal`, async () => {
-      const snippet = buildFetchSnippet({
-        method: 'POST',
-        path: '/messages',
-        body: { content: evil, channelId: 'c1' },
-        serverScoped: true,
-      });
-      const fakeFetch = vi.fn()
-        .mockResolvedValueOnce({ ok: true, status: 200, json: async () => [{ id: 'sid', slug: 'eng' }] })
-        .mockResolvedValueOnce({ ok: true, status: 200, json: async () => ({ id: 'm1' }) });
-      await runSnippet(snippet, fakeFetch, {
-        slock_access_token: 'tkn',
-        slock_last_server_slug: 'eng',
-      });
-      const sentBody = JSON.parse(fakeFetch.mock.calls[1][1].body);
-      expect(sentBody.content).toBe(evil);
-    });
-  }
-});
-
-describe('buildChannelScopedSnippet', () => {
-  it('UUID channel + server override: single fetch straight to /channels/:id<suffix>', async () => {
-    const snippet = buildChannelScopedSnippet({
-      channelInput: UUID_A, method: 'GET', pathSuffix: '/members', serverIdOverride: '22222222-2222-2222-2222-222222222222',
-    });
-    const fakeFetch = vi.fn().mockResolvedValueOnce({ ok: true, status: 200, json: async () => [{ id: 'u1' }] });
-    const result = await runSnippet(snippet, fakeFetch, { slock_access_token: 'tkn' });
-    // No /servers/ resolve (override) and no /channels/ resolve (uuid) — one call.
-    expect(fakeFetch).toHaveBeenCalledTimes(1);
-    expect(fakeFetch.mock.calls[0][0]).toBe(`${SLOCK_API_BASE}/channels/${UUID_A}/members`);
-    expect(fakeFetch.mock.calls[0][1].headers['x-server-id']).toBe('22222222-2222-2222-2222-222222222222');
-    expect(result).toEqual({ kind: 'ok', rows: [{ id: 'u1' }] });
-  });
-
-  it('#name channel: resolves slug→sid, then name→id, then hits the target', async () => {
-    const snippet = buildChannelScopedSnippet({
-      channelInput: '#general', method: 'POST', pathSuffix: '/read-all',
-    });
-    const fakeFetch = vi.fn()
-      .mockResolvedValueOnce({ ok: true, status: 200, json: async () => [{ id: 'sid-1', slug: 'eng' }] })   // /servers/
-      .mockResolvedValueOnce({ ok: true, status: 200, json: async () => [{ id: 'chan-7', name: 'general' }] }) // /channels/
-      .mockResolvedValueOnce({ ok: true, status: 200, json: async () => ({ ok: true, seq: 42 }) });            // target
-    const result = await runSnippet(snippet, fakeFetch, {
-      slock_access_token: 'tkn', slock_last_server_slug: 'eng',
-    });
-    expect(fakeFetch.mock.calls[2][0]).toBe(SLOCK_API_BASE + '/channels/chan-7/read-all');
-    expect(result).toEqual({ kind: 'ok', rows: { ok: true, seq: 42 } });
-  });
-
-  it('unresolvable channel name → kind:"unresolvable", no target fetch', async () => {
-    const snippet = buildChannelScopedSnippet({
-      channelInput: '#ghost', method: 'GET', serverIdOverride: '22222222-2222-2222-2222-222222222222',
-    });
-    const fakeFetch = vi.fn()
-      .mockResolvedValueOnce({ ok: true, status: 200, json: async () => [{ id: 'chan-7', name: 'general' }] }); // /channels/
-    const result = await runSnippet(snippet, fakeFetch, { slock_access_token: 'tkn' });
-    expect(result).toMatchObject({ kind: 'unresolvable' });
-    expect(fakeFetch).toHaveBeenCalledTimes(1); // only the resolve, no target
-  });
-});
-
-describe('channelResolveFragment', () => {
-  it('embeds the lowercased bare name (leading # stripped) as the lookup key', () => {
-    const frag = channelResolveFragment('#General');
-    // The name-lookup key is lowercased with the # stripped...
-    expect(frag).toContain('=== "general"');
-    // ...and never lowercases/strips into a different key.
-    expect(frag).not.toContain('=== "#general"');
-  });
-});
-
-describe('authHeadersFragment R1 — --server slug resolution', () => {
-  // R1 — old behavior: `--server <slug>` was passed RAW as X-Server-Id, server
-  // returned 500 because it only accepts UUIDs. Fix: resolve override slug
-  // against /servers/ the same way active-slug does. UUID overrides bypass
-  // the lookup (already an id).
-  it('UUID override bypasses /servers/ lookup and goes straight to the target with x-server-id=<uuid>', async () => {
-    const snippet = buildFetchSnippet({
-      method: 'GET',
-      path: '/channels/',
-      serverScoped: true,
-      serverIdOverride: '33333333-3333-3333-3333-333333333333',
-    });
-    const fakeFetch = vi.fn().mockResolvedValueOnce({ ok: true, status: 200, json: async () => [{ id: 'c1' }] });
-    const result = await runSnippet(snippet, fakeFetch, { slock_access_token: 'tkn' });
-    // Exactly one fetch — the target. No /servers/ resolve needed.
-    expect(fakeFetch).toHaveBeenCalledTimes(1);
-    expect(fakeFetch.mock.calls[0][0]).toBe(SLOCK_API_BASE + '/channels/');
-    expect(fakeFetch.mock.calls[0][1].headers['x-server-id']).toBe('33333333-3333-3333-3333-333333333333');
-    expect(result.kind).toBe('ok');
-  });
-
-  it('[R1 critical] slug override resolves via /servers/ — NEVER sent raw as x-server-id', async () => {
-    const snippet = buildFetchSnippet({
-      method: 'GET',
-      path: '/channels/',
-      serverScoped: true,
-      serverIdOverride: 'community',
-    });
-    const fakeFetch = vi.fn()
-      .mockResolvedValueOnce({ ok: true, status: 200, json: async () => [
-        { id: 'sid-community-uuid', slug: 'community' },
-        { id: 'sid-botiverse-uuid', slug: 'botiverse' },
-      ] })  // /servers/ lookup
-      .mockResolvedValueOnce({ ok: true, status: 200, json: async () => [{ id: 'c1' }] }); // target
-    const result = await runSnippet(snippet, fakeFetch, {
-      slock_access_token: 'tkn',
-      slock_last_server_slug: 'botiverse',  // active is botiverse — override must win
-    });
-    // First call: /servers/ — resolving the override slug "community".
-    expect(fakeFetch.mock.calls[0][0]).toBe(SLOCK_API_BASE + '/servers/');
-    // Second call: target — with the RESOLVED sid, NOT the raw "community".
-    expect(fakeFetch.mock.calls[1][0]).toBe(SLOCK_API_BASE + '/channels/');
-    const sentSid = fakeFetch.mock.calls[1][1].headers['x-server-id'];
-    expect(sentSid).toBe('sid-community-uuid');
-    expect(sentSid).not.toBe('community'); // regression catch: raw slug must NEVER be sent
-    expect(result.kind).toBe('ok');
-  });
-
-  it('[R1 critical] slug override wins over active slug in localStorage', async () => {
-    // Whether user has done server-use, the override must steer.
-    const snippet = buildFetchSnippet({
-      method: 'GET', path: '/channels/', serverScoped: true, serverIdOverride: 'community',
-    });
-    const fakeFetch = vi.fn()
-      .mockResolvedValueOnce({ ok: true, status: 200, json: async () => [
-        { id: 'sid-community-uuid', slug: 'community' },
-        { id: 'sid-botiverse-uuid', slug: 'botiverse' },
-      ] })
-      .mockResolvedValueOnce({ ok: true, status: 200, json: async () => [] });
-    await runSnippet(snippet, fakeFetch, {
-      slock_access_token: 'tkn',
-      slock_last_server_slug: 'botiverse',
-    });
-    // It MUST have looked up 'community' (not 'botiverse'). Easiest check:
-    // the resolved sid is the community one.
-    expect(fakeFetch.mock.calls[1][1].headers['x-server-id']).toBe('sid-community-uuid');
-  });
-
-  it('slug override that does NOT exist in /servers/ fails loud with no-server + known slugs hint', async () => {
-    const snippet = buildFetchSnippet({
-      method: 'GET', path: '/channels/', serverScoped: true, serverIdOverride: 'no-such-slug',
-    });
-    const fakeFetch = vi.fn()
-      .mockResolvedValueOnce({ ok: true, status: 200, json: async () => [{ id: 's1', slug: 'community' }, { id: 's2', slug: 'botiverse' }] });
-    const result = await runSnippet(snippet, fakeFetch, { slock_access_token: 'tkn' });
-    expect(result.kind).toBe('no-server');
-    expect(result.detail).toMatch(/no-such-slug/);
-    expect(result.detail).toMatch(/--server/);
-    expect(result.detail).toMatch(/community/);   // hint lists known slugs
-    expect(fakeFetch).toHaveBeenCalledTimes(1);   // bailed before target fetch
-  });
-
-  it('with no override and no active-slug, fails loud with `no-server` mentioning server-use AND --server', async () => {
-    const snippet = buildFetchSnippet({ method: 'GET', path: '/channels/', serverScoped: true });
-    const fakeFetch = vi.fn();
-    const result = await runSnippet(snippet, fakeFetch, { slock_access_token: 'tkn' });
-    expect(result.kind).toBe('no-server');
-    expect(result.detail).toMatch(/server-use/);
-    expect(result.detail).toMatch(/--server/);
-    expect(fakeFetch).not.toHaveBeenCalled();
-  });
-});
-
-describe('authHeadersFragment page-readiness loop', () => {
-  // qatester live-flagged a SecurityError on first command after page.goto:
-  // page.goto returned before app.slock.ai actually loaded, leaving location
-  // on an opaque interstitial — localStorage on opaque origin throws. The
-  // fix is a polled wait inside authHeadersFragment for the SPA host. These
-  // cases lock the wait shape so a future refactor can't quietly strip it.
-
-  it('emits a polled wait that gates on BOTH location AND token-hydrated BEFORE the fetch', () => {
-    const snippet = buildFetchSnippet({ method: 'GET', path: '/whoami', serverScoped: false });
-    // (a) location.href check — guards SecurityError on opaque origins.
-    expect(snippet).toContain("location.href.indexOf('app.slock.ai')");
-    // (b) localStorage token check INSIDE the loop — guards silent-empty
-    // (page is on app.slock.ai but SPA has not yet written the token, so
-    // fetches went out with empty Authorization and server returned []).
-    expect(snippet).toContain("localStorage.getItem('slock_access_token')");
-    // The wait MUST sit before the final fetch; otherwise it doesn't
-    // prevent the SecurityError. Pin order by index.
-    const waitIdx = snippet.indexOf("location.href.indexOf('app.slock.ai')");
-    const fetchIdx = snippet.indexOf('await fetch(');
-    expect(waitIdx).toBeGreaterThan(-1);
-    expect(fetchIdx).toBeGreaterThan(-1);
-    expect(waitIdx).toBeLessThan(fetchIdx);
-  });
-
-  it('has a hard timeout that returns fail-loud kind:http rather than hanging', () => {
-    const snippet = buildFetchSnippet({ method: 'GET', path: '/whoami', serverScoped: false });
-    // Timeout ceiling pinned at 3000ms — change requires intentional bump.
-    expect(snippet).toContain('3000');
-    expect(snippet).toContain("'page-readiness timeout");
-    // Must return a typed envelope (not throw / hang) so the CLI surfaces
-    // a clean error.
-    expect(snippet).toMatch(/return\s*\{\s*kind:\s*'http'/);
-  });
-
-  it('silent-empty guard: on app.slock.ai but token not yet hydrated → timeout fail-loud, never fetches', async () => {
-    const snippet = buildFetchSnippet({ method: 'GET', path: '/whoami', serverScoped: false });
-    const realFetch = globalThis.fetch;
-    const realLS = globalThis.localStorage;
-    const realLocation = globalThis.location;
-    const realSetTimeout = globalThis.setTimeout;
-    globalThis.fetch = vi.fn();
-    // localStorage exists but slock_access_token never appears (the silent-empty
-    // case qatester live-flagged: SPA hadn't hydrated yet).
-    globalThis.localStorage = { getItem: () => null, setItem: () => {} };
-    globalThis.location = { href: 'https://app.slock.ai/' };
-    globalThis.setTimeout = (cb) => realSetTimeout(cb, 0);
-    try {
-      // eslint-disable-next-line no-eval
-      const result = await eval(`(async () => { ${snippet} })()`);
-      expect(result.kind).toBe('http');
-      expect(result.where).toMatch(/not yet hydrated/);
-      // Never fetched, because the loop never broke.
-      expect(globalThis.fetch).not.toHaveBeenCalled();
-    } finally {
-      globalThis.fetch = realFetch;
-      globalThis.localStorage = realLS;
-      globalThis.location = realLocation;
-      globalThis.setTimeout = realSetTimeout;
-    }
-  });
-
-  it('the wait actually triggers when location is NOT app.slock.ai (timeout path returns fail-loud)', async () => {
-    const snippet = buildFetchSnippet({ method: 'GET', path: '/whoami', serverScoped: false });
-    // Stub globals; location stays on a foreign origin so the loop will time out.
-    const realFetch = globalThis.fetch;
-    const realLS = globalThis.localStorage;
-    const realLocation = globalThis.location;
-    const realSetTimeout = globalThis.setTimeout;
-    globalThis.fetch = vi.fn();
-    globalThis.localStorage = { getItem: () => 'fake-token', setItem: () => {} };
-    globalThis.location = { href: 'https://example.com/' };
-    // Fast-forward setTimeout so the 3000ms loop completes instantly under test.
-    globalThis.setTimeout = (cb) => realSetTimeout(cb, 0);
-    try {
-      // eslint-disable-next-line no-eval
-      const result = await eval(`(async () => { ${snippet} })()`);
-      expect(result.kind).toBe('http');
-      expect(result.where).toMatch(/page-readiness timeout/);
-      // fetch must NEVER have been called because we never got past the loop.
-      expect(globalThis.fetch).not.toHaveBeenCalled();
-    } finally {
-      globalThis.fetch = realFetch;
-      globalThis.localStorage = realLS;
-      globalThis.location = realLocation;
-      globalThis.setTimeout = realSetTimeout;
-    }
-  });
-});

package/clis/slock/inbox-done.test.js

@@ -1,21 +0,0 @@
-import { describe, it, expect, vi } from 'vitest';
-import { getRegistry } from '@jackwener/opencli/registry';
-import './inbox-done.js';
-
-function makePage(result = { kind: 'ok', rows: { ok: true } }) {
-  return { goto: vi.fn(), evaluate: vi.fn().mockResolvedValue(result) };
-}
-
-describe('slock inbox-done', () => {
-  const command = getRegistry().get('slock/inbox-done');
-
-  it('resolves a #name channel and POSTs channelId in the body of /inbox/done', async () => {
-    const page = makePage();
-    const rows = await command.func(page, { channel: '#general' });
-    const script = page.evaluate.mock.calls[0][0];
-    expect(script).toContain('"general"');          // channel-name resolution embedded
-    expect(script).toContain('/channels/inbox/done'); // fixed path, channelId in body
-    expect(script).toContain('channelId');
-    expect(rows[0]).toMatchObject({ channel: '#general', result: 'done' });
-  });
-});

package/clis/slock/inbox-read-all.test.js

@@ -1,20 +0,0 @@
-import { describe, it, expect, vi } from 'vitest';
-import { getRegistry } from '@jackwener/opencli/registry';
-import './inbox-read-all.js';
-
-function makePage(result = { kind: 'ok', rows: { ok: true, markedCount: 7 } }) {
-  return { goto: vi.fn(), evaluate: vi.fn().mockResolvedValue(result) };
-}
-
-describe('slock inbox-read-all', () => {
-  const command = getRegistry().get('slock/inbox-read-all');
-
-  it('POSTs /channels/inbox/read-all and surfaces markedCount', async () => {
-    const page = makePage();
-    const rows = await command.func(page, {});
-    const script = page.evaluate.mock.calls[0][0];
-    expect(script).toContain('/channels/inbox/read-all');
-    expect(script).toContain('"POST"');
-    expect(rows[0]).toMatchObject({ result: 'read-all', markedCount: 7 });
-  });
-});

package/clis/slock/inbox.test.js

@@ -1,46 +0,0 @@
-import { describe, it, expect, vi } from 'vitest';
-import { ArgumentError } from '@jackwener/opencli/errors';
-import { getRegistry } from '@jackwener/opencli/registry';
-import './inbox.js';
-
-function makePage(result) {
-  return { goto: vi.fn(), evaluate: vi.fn().mockResolvedValue(result) };
-}
-
-describe('slock inbox', () => {
-  const command = getRegistry().get('slock/inbox');
-
-  it('rejects an unknown --filter before navigation', async () => {
-    const page = makePage({ kind: 'ok', rows: { items: [] } });
-    await expect(command.func(page, { filter: 'starred' }))
-      .rejects.toBeInstanceOf(ArgumentError);
-    expect(page.goto).not.toHaveBeenCalled();
-  });
-
-  it('threads filter/limit/offset through the query string', async () => {
-    const page = makePage({ kind: 'ok', rows: { items: [] } });
-    await command.func(page, { filter: 'unread', limit: 5, offset: 10 });
-    const script = page.evaluate.mock.calls[0][0];
-    expect(script).toContain('filter=unread');
-    expect(script).toContain('limit=5');
-    expect(script).toContain('offset=10');
-  });
-
-  it('rejects invalid pagination before navigation', async () => {
-    const page = makePage({ kind: 'ok', rows: { items: [] } });
-    await expect(command.func(page, { limit: 0 })).rejects.toBeInstanceOf(ArgumentError);
-    await expect(command.func(page, { limit: 101 })).rejects.toBeInstanceOf(ArgumentError);
-    await expect(command.func(page, { offset: -1 })).rejects.toBeInstanceOf(ArgumentError);
-    expect(page.goto).not.toHaveBeenCalled();
-  });
-
-  it('flattens channel and thread items into a uniform row shape', async () => {
-    const page = makePage({ kind: 'ok', rows: { items: [
-      { kind: 'channel', channelId: 'c1', channelName: 'general', unreadCount: 3, hasMention: true, lastMessageAt: 't1', lastMessagePreview: 'hi' },
-      { kind: 'thread', threadChannelId: 'th1', parentChannelName: 'eng', unreadCount: 1, hasMention: false, lastActivityAt: 't2', latestActivityPreview: 'reply' },
-    ] } });
-    const rows = await command.func(page, {});
-    expect(rows[0]).toMatchObject({ kind: 'channel', id: 'c1', name: 'general', unreadCount: 3, hasMention: true });
-    expect(rows[1]).toMatchObject({ kind: 'thread', id: 'th1', name: 'eng', unreadCount: 1, preview: 'reply' });
-  });
-});

package/clis/slock/message-read.test.js

@@ -1,83 +0,0 @@
-import { describe, it, expect, vi } from 'vitest';
-import { ArgumentError } from '@jackwener/opencli/errors';
-import { getRegistry } from '@jackwener/opencli/registry';
-import './message-read.js';
-
-function makePage(result) {
-  return { goto: vi.fn(), evaluate: vi.fn().mockResolvedValue(result) };
-}
-
-describe('slock message-read', () => {
-  const command = getRegistry().get('slock/message-read');
-
-  it('happy: returns mapped rows for a channel-uuid target', async () => {
-    const page = makePage({ kind: 'ok', rows: [
-      { id: 'm1', seq: 100, sender: { name: 'A' }, content: 'hi', createdAt: 't' },
-    ], meta: { threadsAvailable: true, threadsMap: {} }});
-    const rows = await command.func(page, { channel: '11111111-1111-1111-1111-111111111111' });
-    expect(rows[0]).toMatchObject({
-      id: 'm1', seq: 100, senderName: 'A', content: 'hi',
-      threadChannelId: null, replyCount: 0,
-    });
-  });
-
-  it('thread target "#name:short" passes the resolution shape into the snippet', async () => {
-    const page = makePage({ kind: 'ok', rows: [], meta: { threadsAvailable: true, threadsMap: {} } });
-    await command.func(page, { channel: '#general:8af3cbbb' });
-    const script = page.evaluate.mock.calls[0][0];
-    expect(script).toContain('"general"');
-    expect(script).toContain('"8af3cbbb"');
-    expect(script).toContain('/messages/context/');
-  });
-
-  it('thread target with NO_THREAD result returns a single hint row', async () => {
-    const page = makePage({ kind: 'no-thread', parent: '#general:abc12345' });
-    const rows = await command.func(page, { channel: '#general:abc12345' });
-    expect(rows.length).toBe(1);
-    expect(rows[0].content).toMatch(/no thread yet/);
-    expect(rows[0].seq).toBeNull();
-  });
-
-  it('--after with a UUID value embeds the resolution path into the snippet', async () => {
-    const page = makePage({ kind: 'ok', rows: [], meta: { threadsAvailable: true, threadsMap: {} } });
-    await command.func(page, {
-      channel: '11111111-1111-1111-1111-111111111111',
-      after: '22222222-2222-2222-2222-222222222222',
-    });
-    const script = page.evaluate.mock.calls[0][0];
-    expect(script).toContain('"22222222-2222-2222-2222-222222222222"');
-    expect(script).toContain('/messages/context/');
-  });
-
-  it('rejects invalid --limit and --before before navigation', async () => {
-    const page = makePage({ kind: 'ok', rows: [] });
-    await expect(command.func(page, { channel: '#general', limit: 0 })).rejects.toBeInstanceOf(ArgumentError);
-    await expect(command.func(page, { channel: '#general', before: 'abc' })).rejects.toBeInstanceOf(ArgumentError);
-    await expect(command.func(page, { channel: '#general', before: '0' })).rejects.toBeInstanceOf(ArgumentError);
-    expect(page.goto).not.toHaveBeenCalled();
-  });
-
-  it('--no-threads omits the threads enrichment fetch from the snippet', async () => {
-    const page = makePage({ kind: 'ok', rows: [], meta: { threadsAvailable: false, threadsMap: {} } });
-    await command.func(page, {
-      channel: '11111111-1111-1111-1111-111111111111',
-      'no-threads': true,
-    });
-    const script = page.evaluate.mock.calls[0][0];
-    expect(script).not.toContain('/threads');
-  });
-
-  it('threads enrichment failure → replyCount=null and a warning row is prepended', async () => {
-    const page = makePage({ kind: 'ok', rows: [
-      { id: 'm1', seq: 100, sender: { name: 'A' }, content: 'hi', createdAt: 't' },
-    ], meta: { threadsAvailable: false, threadsMap: null, threadsDegraded: true } });
-    const rows = await command.func(page, { channel: '11111111-1111-1111-1111-111111111111' });
-    expect(rows[0].content).toMatch(/threads-enrichment unavailable/);
-    expect(rows[1].replyCount).toBeNull();
-  });
-
-  it('[anti-drift] non-array rows throws instead of silently returning empty', async () => {
-    const page = makePage({ kind: 'ok', rows: { wrong: 'shape' } });
-    await expect(command.func(page, { channel: '11111111-1111-1111-1111-111111111111' })).rejects.toThrow(/expected array/);
-  });
-});

package/clis/slock/message-search.test.js

@@ -1,61 +0,0 @@
-import { describe, it, expect, vi } from 'vitest';
-import { ArgumentError, CommandExecutionError } from '@jackwener/opencli/errors';
-import { getRegistry } from '@jackwener/opencli/registry';
-import './message-search.js';
-
-function makePage(result) {
-  return { goto: vi.fn(), evaluate: vi.fn().mockResolvedValue(result) };
-}
-
-describe('slock message-search', () => {
-  const command = getRegistry().get('slock/message-search');
-
-  it('happy: returns mapped rows for a query', async () => {
-    const page = makePage({ kind: 'ok', rows: [
-      { id: 'm1', content: 'hello', channelId: 'c1', sender: { name: 'A' }, createdAt: 't' },
-    ]});
-    const rows = await command.func(page, { query: 'hello' });
-    expect(rows[0]).toMatchObject({ id: 'm1', content: 'hello', channelId: 'c1' });
-  });
-
-  it('--channel filter: snippet contains channelId param', async () => {
-    const page = makePage({ kind: 'ok', rows: [] });
-    await command.func(page, { query: 'x', channel: '#general' });
-    expect(page.evaluate.mock.calls[0][0]).toContain('channelId=');
-  });
-
-  it('rejects non-positive --limit before navigation', async () => {
-    const page = makePage({ kind: 'ok', rows: [] });
-    await expect(command.func(page, { query: 'hello', limit: 0 })).rejects.toBeInstanceOf(ArgumentError);
-    expect(page.goto).not.toHaveBeenCalled();
-  });
-
-  // F2-b — qatester live dump: real shape is { results, hasMore }. If a future
-  // refactor strips data.results out of the in-page unwrap chain, the command
-  // silently returns [] even when matches exist. Pin the unwrap order so the
-  // drift is caught pre-network.
-  it('[F2-b drift] in-page snippet unwraps data.results FIRST in the fallback chain', async () => {
-    const page = makePage({ kind: 'ok', rows: [] });
-    await command.func(page, { query: 'x' });
-    const snippet = page.evaluate.mock.calls[0][0];
-    // results before messages before data — order matters because legacy
-    // shapes used data.messages and data.data, but the live server now
-    // returns data.results and only data.results.
-    expect(snippet).toMatch(/data\.results\s*\|\|\s*data\.messages\s*\|\|\s*data\.data/);
-  });
-
-  it('[anti-drift] non-array search rows throw typed instead of TypeError', async () => {
-    const page = makePage({ kind: 'ok', rows: { wrong: 'shape' } });
-    await expect(command.func(page, { query: 'hello' })).rejects.toBeInstanceOf(CommandExecutionError);
-  });
-
-  it('[red-line] a --channel name with a quote cannot break out of the snippet string', async () => {
-    const page = makePage({ kind: 'unresolvable', detail: 'x' });
-    await command.func(page, { query: 'x', channel: "#ev'il" }).catch(() => {});
-    const script = page.evaluate.mock.calls[0][0];
-    // Vulnerable form would embed the name raw as `matches #ev'il`, letting the
-    // quote close the string literal. The name must only appear JSON-encoded.
-    expect(script).not.toContain("no channel matches #ev'il");
-    expect(script).toContain('"#ev\'il"');
-  });
-});