ps-access 0.0.1 → 0.0.3

package/README.md

@@ -17,7 +17,9 @@ yourself.
 ## Requirements
 
 - The controller connected by **USB-C** (the profile channel isn’t available over Bluetooth).
-- CLI: Node.js (tested on v26) with `node-hid` (`npm install`).
+- CLI: Node.js (tested on v26). `node-hid` is an **optional** dependency (installed
+  automatically) needed only to talk to the controller; commands that don't touch the device
+  (`presets`, `share`, `show-share`, `help`) and the web tool work even if it isn't built.
 - Web tool: Chrome or Edge (desktop) for WebHID.
 - macOS may prompt for **Input Monitoring** permission for the terminal/Chrome on first use.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ps-access",
-  "version": "0.0.1",
+  "version": "0.0.3",
   "description": "Read/write PlayStation Access Controller profiles from a PC (no PS5). CLI + WebHID tool + PC input bridge.",
   "type": "module",
   "bin": {
@@ -46,7 +46,7 @@
     "url": "https://github.com/johnhenry/ps-access/issues"
   },
   "author": "johnhenry",
-  "dependencies": {
+  "optionalDependencies": {
     "node-hid": "^3.1.2"
   },
   "license": "MIT"

package/web/xmb.js

@@ -619,27 +619,46 @@ async function load() {
 async function connectOnce() {
   try {
     const before = controllers.length;
-    const ds = await requestControllers();
-    if (!ds.length) { toast("No controller selected", 2500); return; }
-    await addDevices(ds);
-    toast(controllers.length > before ? "Controller connected" : "Controller already connected", 2000);
+    await requestControllers();                      // user grants one in the chooser (this gesture)
+    await addDevices(await grantedControllers());    // reconcile: add every granted controller not yet present
+    const added = controllers.length - before;
+    if (added > 0) toast(added > 1 ? `${added} controllers connected` : "Controller connected", 2200);
+    else toast("That one's already connected — to add another, pick the *other* “Access Controller” in the chooser.", 5500);
   } catch (e) { toast(String(e.message || e), 4000); }
 }
-async function addDevices(devices) {
+
+// Serialize addDevices: granting a device in the chooser fires the `connect` event, whose handler
+// also calls addDevices — running both concurrently on the same new device interleaves its
+// feature-report reads and corrupts the add. Chaining guarantees one batch finishes before the next.
+let _addChain = Promise.resolve();
+function addDevices(devices) {
+  const run = _addChain.then(() => _addDevices(devices));
+  _addChain = run.catch(() => {});  // keep the chain alive even if a batch throws
+  return run;
+}
+async function _addDevices(devices) {
+  let added = 0;
   for (const device of devices) {
     if (controllers.some((c) => c.device === device)) continue;
-    await ensureOpen(device);
-    device.addEventListener("inputreport", onInputReport); // physical buttons + stick, live
-    const profiles = [];
-    for (let s = 1; s <= PROFILE_COUNT; s++) {
-      const p = parseProfile(await readProfileRaw(device, s));
-      p._physOrient = p.ports[0].kind === "stick" ? p.ports[0].orientation : 3;
-      profiles.push(p);
+    try {
+      await ensureOpen(device);
+      const profiles = [];
+      for (let s = 1; s <= PROFILE_COUNT; s++) {
+        const p = parseProfile(await readProfileRaw(device, s));
+        p._physOrient = p.ports[0].kind === "stick" ? p.ports[0].orientation : 3;
+        profiles.push(p);
+      }
+      if (controllers.some((c) => c.device === device)) continue; // defensive: added while awaiting
+      device.addEventListener("inputreport", onInputReport);       // attach only after a clean read
+      controllers.push({ device, name: `Controller ${controllers.length + 1}`, profiles });
+      added++;
+    } catch (e) {
+      toast(`Couldn't read a controller: ${e.message || e}`, 4000);
     }
-    controllers.push({ device, name: `Controller ${controllers.length + 1}`, profiles });
   }
   updateDeviceStatus();
   render();
+  return added;
 }
 function updateDeviceStatus() {
   const c = controllers[activeCtrl];
@@ -866,28 +885,48 @@ function closeHelp() {
 // Nav scheme (per design): center/stick-click = confirm; any perimeter button = back; stick = directions.
 const inputEdge = {};
 let dirRepeatAt = 0;
+// Latest decoded physical state per connected controller. Navigation/highlighting is driven by the
+// *union* of all of them (either controller can move the cursor, confirm, back), while the
+// active-profile indicator, wave tint and monitor follow the controller being edited (activeCtrl).
+const ctrlState = new Map(); // device -> { buttons:Set, axes:[x,y] }
+function mergedInput() {
+  const buttons = new Set();
+  let axes = [0, 0], best = 0;
+  for (const c of controllers) {
+    const st = ctrlState.get(c.device);
+    if (!st) continue;
+    for (const b of st.buttons) buttons.add(b);
+    const mag = Math.abs(st.axes[0]) + Math.abs(st.axes[1]); // whichever stick is pushed furthest steers
+    if (mag > best) { best = mag; axes = st.axes; }
+  }
+  return { buttons, axes };
+}
 function onInputReport(e) {
-  if (e.device !== controllers[activeCtrl]?.device) return;
+  if (!controllers.some((c) => c.device === e.device)) return; // ignore reports from a device mid-add
   const d = new Uint8Array(e.data.buffer.slice(e.data.byteOffset, e.data.byteOffset + e.data.byteLength));
   lastInputAt = performance.now();
   waveConnected = true; // a report is streaming -> the wave is visible
   const { buttons, axes, profile } = decodePhysical(d);
-  liveAxes = axes;
-  phys = buttons;
-  // Track the controller's *active* profile (changed with the device's profile button). When it
-  // changes, refresh the top-bar indicator and, if the monitor is open, re-render it for that profile.
-  if (profile && profile - 1 !== deviceProfile) {
+  ctrlState.set(e.device, { buttons, axes });
+  const isActive = e.device === controllers[activeCtrl]?.device;
+  // Active-profile tracking is per-device — only the *edited* controller's profile drives the
+  // indicator/wave/monitor. (Refresh the top bar, wave and "✓ Active" marker when it changes.)
+  if (isActive && profile && profile - 1 !== deviceProfile) {
     deviceProfile = profile - 1;
     updateProfileTag();
-    setWaveProfile(deviceProfile); // fade the wave's leading curves to match the active profile
+    setWaveProfile(deviceProfile);
     if (monitorMode) $("#mon-render").innerHTML = profileSVG(controllers[activeCtrl].profiles[deviceProfile]);
-    else if (!monitorArm && !nav.drill) render(); // refresh the "✓ Active on controller" marker
+    else if (!monitorArm && !nav.drill) render();
   }
-  if (monitorMode) { updateMonitor(buttons, axes, d); setGpStatus(true); return; }
-  if (monitorArm) { handleArmInput(buttons, axes); setGpStatus(true); return; }
-  handlePhysInput(buttons, axes);
-  updateLive();
+  // Unified live input (union of every connected controller) drives highlighting + navigation.
+  const m = mergedInput();
+  liveAxes = m.axes;
+  phys = m.buttons;
   setGpStatus(true);
+  if (monitorMode) { if (isActive) updateMonitor(buttons, axes, d); return; } // monitor observes the edited controller
+  if (monitorArm) { handleArmInput(m.buttons, m.axes); return; }
+  handlePhysInput(m.buttons, m.axes);
+  updateLive();
 }
 
 function handlePhysInput(buttons, axes) {
@@ -1031,6 +1070,7 @@ function init() {
       const idx = controllers.findIndex((c) => c.device === e.device);
       if (idx !== -1) {
         e.device.removeEventListener("inputreport", onInputReport);
+        ctrlState.delete(e.device);
         controllers.splice(idx, 1);
         if (activeCtrl >= controllers.length) activeCtrl = Math.max(0, controllers.length - 1);
         deviceProfile = null;