prsmith 2.0.0 → 2.1.0

package/bin/cli.js

@@ -135,6 +135,19 @@ program
 
       // Post to GitHub if specified
       if (options.github || options.pr || options.repo) {
+        const token = config.githubToken || process.env.GITHUB_TOKEN;
+        if (!token) {
+          console.error(
+            chalk.red('\n❌ Error: GitHub Personal Access Token not found!')
+          );
+          console.error(
+            chalk.yellow(
+              "Please configure 'githubToken' in your local ~/.prsmith.json file or set the GITHUB_TOKEN environment variable.\n"
+            )
+          );
+          process.exit(1);
+        }
+
         const detectedRepo = detectGithubRepo();
         let owner = '';
         let repoName = '';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prsmith",
-  "version": "2.0.0",
+  "version": "2.1.0",
   "description": "Forge professional pull request review comments from simple prompts.",
   "keywords": [
     "pull-request",

package/src/batch.js

@@ -113,6 +113,19 @@ export async function runBatchReview(config = {}) {
         console.error(chalk.red(`Failed to write file: ${err.message}`));
       }
     } else if (action.includes('Post')) {
+      const token = config.githubToken || process.env.GITHUB_TOKEN;
+      if (!token) {
+        console.log(
+          chalk.red('\n❌ Error: GitHub Personal Access Token not found!')
+        );
+        console.log(
+          chalk.yellow(
+            "Please configure 'githubToken' in your local ~/.prsmith.json file or set the GITHUB_TOKEN environment variable.\n"
+          )
+        );
+        continue;
+      }
+
       const repo = config.githubRepo || detectGithubRepo();
       const defaultOwner = repo ? repo.owner : '';
       const defaultRepo = repo ? repo.repo : '';

package/src/config.js

@@ -15,12 +15,24 @@ export function loadConfig() {
       try {
         const fileContent = fs.readFileSync(configPath, 'utf-8');
         const parsed = JSON.parse(fileContent);
+
         if (parsed.templates) {
           mergedConfig.templates = {
             ...mergedConfig.templates,
             ...parsed.templates,
           };
         }
+
+        if (parsed.editor) {
+          mergedConfig.editor = parsed.editor;
+        }
+
+        // Also merge any other config properties (tokens, providers, etc.)
+        Object.keys(parsed).forEach((key) => {
+          if (key !== 'templates') {
+            mergedConfig[key] = parsed[key];
+          }
+        });
       } catch (err) {
         console.warn(
           `Warning: Could not parse config at ${configPath} - ${err.message}`
@@ -29,5 +41,17 @@ export function loadConfig() {
     }
   }
 
+  // Senior Guardrail: Prevent the general public from getting stuck in Vim (no instructions)
+  // If the user has not set EDITOR/VISUAL globally, and did not set 'editor' in .prsmith.json,
+  // we default the spawned editor in our process to 'nano' on macOS/Linux.
+  // 'nano' has friendly, visible exit instructions at the bottom of the terminal by default!
+  if (mergedConfig.editor) {
+    process.env.EDITOR = mergedConfig.editor;
+  } else if (!process.env.EDITOR && !process.env.VISUAL) {
+    if (process.platform !== 'win32') {
+      process.env.EDITOR = 'nano';
+    }
+  }
+
   return mergedConfig;
 }

package/src/prompts.js

@@ -35,7 +35,8 @@ export async function getReviewData(options = {}, config = {}) {
     coreQuestions.push({
       type: 'editor',
       name: 'issue',
-      message: 'Describe the issue:',
+      message:
+        'Describe the issue (Vim: i to write, Esc then :wq to save & exit. Nano: Ctrl+O, Enter, Ctrl+X):',
     });
   }
 
@@ -43,7 +44,8 @@ export async function getReviewData(options = {}, config = {}) {
     coreQuestions.push({
       type: 'editor',
       name: 'fix',
-      message: 'Suggested fix:',
+      message:
+        'Suggested fix (Vim: i to write, Esc then :wq to save & exit. Nano: Ctrl+O, Enter, Ctrl+X):',
     });
   }
 
@@ -102,12 +104,14 @@ export async function getReviewData(options = {}, config = {}) {
         {
           type: 'editor',
           name: 'before',
-          message: 'Original Code (Before):',
+          message:
+            'Original Code (Before) (Vim: i to write, Esc then :wq to save & exit. Nano: Ctrl+O, Enter, Ctrl+X):',
         },
         {
           type: 'editor',
           name: 'after',
-          message: 'Proposed Code (After):',
+          message:
+            'Proposed Code (After) (Vim: i to write, Esc then :wq to save & exit. Nano: Ctrl+O, Enter, Ctrl+X):',
         },
       ]);
     }

package/tests/features.test.js

@@ -3,6 +3,7 @@ import fs from 'fs';
 import { generateMarkdown } from '../src/formatter.js';
 import { detectGithubRepo } from '../src/github.js';
 import { polishText } from '../src/ai.js';
+import { loadConfig } from '../src/config.js';
 
 describe('v2.0.0 Features Test Suite', () => {
   let existsSyncSpy;
@@ -207,4 +208,46 @@ describe('v2.0.0 Features Test Suite', () => {
       );
     });
   });
+
+  describe('Editor Config Guardrails', () => {
+    it('should dynamically set process.env.EDITOR to nano on non-windows systems if not defined', () => {
+      const originalPlatform = Object.getOwnPropertyDescriptor(
+        process,
+        'platform'
+      );
+      const originalEditor = process.env.EDITOR;
+      const originalVisual = process.env.VISUAL;
+
+      delete process.env.EDITOR;
+      delete process.env.VISUAL;
+
+      Object.defineProperty(process, 'platform', {
+        value: 'darwin',
+        configurable: true,
+      });
+
+      existsSyncSpy.mockReturnValue(false);
+
+      loadConfig();
+
+      expect(process.env.EDITOR).toBe('nano');
+
+      // Restore original state
+      Object.defineProperty(process, 'platform', originalPlatform);
+      if (originalEditor !== undefined) process.env.EDITOR = originalEditor;
+      if (originalVisual !== undefined) process.env.VISUAL = originalVisual;
+    });
+
+    it('should respect editor defined in config', () => {
+      const originalEditor = process.env.EDITOR;
+      existsSyncSpy.mockReturnValue(true);
+      readFileSyncSpy.mockReturnValue(JSON.stringify({ editor: 'vim-mock' }));
+
+      loadConfig();
+
+      expect(process.env.EDITOR).toBe('vim-mock');
+
+      if (originalEditor !== undefined) process.env.EDITOR = originalEditor;
+    });
+  });
 });