prreviewbuddy 0.63.0 → 0.64.2

package/CHANGELOG.md

@@ -1,5 +1,61 @@
 # Changelog
 
+## 0.64.2
+
+**Review state says whether you have reviewed a change, in those words.** On the Reviews page the
+filter reads `Review state: All / Queue / Not reviewed / Reviewed`, and a card you have opened but
+not marked says `Not reviewed` where it said `In progress`. The menus and the bulk bar say
+`Mark not reviewed` for the way back. This is a separate question from where a review sits in
+Active, Waiting and Done, so `Not reviewed` and `Done` together is a card you have put away
+without marking it reviewed, not a contradiction.
+
+`New` still marks a review you have never opened. The `Not reviewed` filter includes those as well,
+because a review nobody has opened has not been reviewed either. Mark not reviewed from a review's
+own page now always lands on `Not reviewed`, never back on `New`, as it already did from the list.
+Links to the old filter keep working.
+
+## 0.64.1
+
+**The author filter names people.** On the Reviews page it reads `Author: Everyone`, like Status
+and PR beside it, and lists each person by their GitHub name with their login beside it:
+`Amy Li · @amy`. Someone with no public name on GitHub is listed by login alone. The list is in
+alphabetical order of what you read, and if someone changes their name on GitHub the filter shows
+the name from their newest review. Author and PR both carry the GitHub mark, because both are
+answered from GitHub. Status is yours, so it has none.
+
+## 0.64.0
+
+**Choose the findings you want to raise, and copy them as one message.** Issues and Questions each
+have a Prepare feedback button now. Press it and every card gets a checkbox; tick the ones you want
+to take to the author. Your choices stay as you move between Issues and Questions, and a bar at the
+foot of the review keeps count: `5 chosen · 2 issues · 3 questions`. Each count takes you back to
+its list. The rail shows `2 chosen` under each. Clear empties your choice, and Done leaves it
+altogether.
+
+Prepare feedback in that bar opens your choices, large enough to read, issues first, then
+questions, each in the order the review lists them. Preview shows the message as the author will
+read it; Markdown shows the text behind it, to edit. They are one draft: an edit is in the preview
+as soon as you switch back, and Copy Markdown copies what you edited. Each item starts as exactly
+what that card's own Copy gives you: the finding, why it matters, and where it points. Severity and
+status are left out, because they are how PR Review Buddy sorts findings for you, not part of what
+you tell the author. Dismissing or answering a finding you chose leaves your draft exactly as you
+left it. Change what you chose, even to take a tick back, and the draft is made again from the new
+choice. Nothing is rewritten by AI.
+
+A choice belongs to the review you made it on. Another review starts with none, and reloading the
+page starts over. Dismiss and Mark answered work as before, while choosing or not.
+
+Lists are drawn as GitHub draws them, in the feedback preview and in Buddy AI's answers. A list
+with blank lines between its items is one list, numbered on from its first number. A paragraph
+indented under an item stays in that item, and a list indented under an item is drawn inside it,
+one level deep, with its own paragraphs. What counts is how far a line is indented under its item,
+so a list indented the same throughout is still one list. Before, each item after a blank line was
+numbered 1, and a nested list was drawn as more items of the outer one, so a finding with numbered
+steps of its own previewed them as further findings.
+
+KISS's Copy draft comment and Copy recommendations now say Copied in their own words after a
+click, and then go back to their names. Before, the first click left them as a bare icon.
+
 ## 0.63.0
 
 **Telemetry now records first use.** With telemetry on, PR Review Buddy sends one more event,

package/dist/{delete_review-CeJo9t7h.js → delete_review-l4p_p6oh.js}

@@ -4278,7 +4278,7 @@ function normalise(ids) {
 * What happens next with a change, as the reviewer says it: still in play, parked until something
 * moves, or finished with.
 *
-* A separate axis from New / In progress / Reviewed, which says what the reviewer has *done*. A
+* A separate axis from New / Not reviewed / Reviewed, which says what the reviewer has *done*. A
 * change can be reviewed and waiting for another push, or reviewed and done, and one field cannot
 * hold both answers.
 *
@@ -4988,7 +4988,8 @@ function summarise(workspace) {
 		prNumber: workspace.changeSet.data.pullRequest?.number || workspace.prContext?.pullRequest.number,
 		commitSha: workspace.session.metadata?.commitSha || (workspace.changeSet.targetType === "commit" ? workspace.changeSet.data.pullRequest.head.sha : "") || void 0,
 		author: describeAuthorship(workspace.changeSet, workspace.prContext?.pullRequest)?.label,
-		authorHandle: workspace.prContext?.pullRequest.author?.handle || void 0
+		authorHandle: workspace.prContext?.pullRequest.author?.handle || void 0,
+		authorName: workspace.prContext?.pullRequest.author?.name || void 0
 	};
 }
 /**
@@ -10260,16 +10261,57 @@ function diagramFigure(code, label) {
 	const id = `prb-md-mermaid-source-${++diagramCount}`;
 	return `<figure class="prb-md-mermaid" data-md-mermaid data-state="source"><div class="prb-md-mermaid-canvas" data-md-mermaid-canvas role="img" aria-label="${escapeHtml(label)}" hidden></div><p class="prb-md-mermaid-error" data-md-mermaid-error hidden>This diagram couldn\u2019t be displayed.</p><button type="button" class="prb-md-mermaid-toggle" data-md-mermaid-toggle aria-expanded="true" aria-controls="${id}" hidden>Hide source</button>` + codeBlock(code, "Copy source", "Copy source", ` id="${id}" data-md-mermaid-source`) + `</figure>`;
 }
+/**
+* The column after `whitespace`, written from column `from`. A tab moves to the next multiple of
+* four, as CommonMark's tab stops do, so "-\t" and "- " both put text at column 2 and 4 alike.
+*/
+function columnAfter(whitespace, from = 0) {
+	let column = from;
+	for (const char of whitespace) column = char === "	" ? column + 4 - column % 4 : column + 1;
+	return column;
+}
+/** How far a line is indented, in columns. */
+function indentOf(raw) {
+	return columnAfter(raw.match(/^[ \t]*/)[0]);
+}
+/**
+* A list marker line: its kind, an ordered one's number, its text, and its content column, where a
+* line has to start to belong inside the item. Spaces or tabs may follow the marker, counted to tab
+* stops. Five or more columns of them make the text an indented code line in CommonMark, so content
+* then sits one column after the marker.
+*/
+function markerOf(raw) {
+	const match = raw.match(/^([ \t]*)(?:([-*+])|(\d{1,9})[.)])([ \t]+)(\S.*)$/);
+	if (!match) return null;
+	const [, lead, bullet, number, gap, text] = match;
+	const afterMarker = columnAfter(lead) + (bullet ? 1 : number.length + 1);
+	const afterGap = columnAfter(gap, afterMarker);
+	return {
+		tag: bullet ? "ul" : "ol",
+		start: bullet ? 1 : Number(number),
+		text: text.trim(),
+		content: afterGap - afterMarker > 4 ? afterMarker + 1 : afterGap
+	};
+}
 function renderBlocks(text, lifted) {
 	const out = [];
 	let paragraph = [];
 	let quote = [];
 	let list = null;
+	const startAttr = (l) => l.tag === "ol" && l.start !== 1 ? ` start="${l.start}"` : "";
 	let html = null;
 	const flush = () => {
 		if (paragraph.length) out.push(`<p>${renderInline(paragraph.join(" "), lifted)}</p>`);
 		if (quote.length) out.push(`<blockquote>${renderInline(quote.join(" "), lifted)}</blockquote>`);
-		if (list) out.push(`<${list.tag}>${list.items.map((item) => `<li>${renderInline(item, lifted)}</li>`).join("")}</${list.tag}>`);
+		if (list) {
+			const paragraphs = (texts) => texts.length === 1 ? renderInline(texts[0], lifted) : texts.map((text) => `<p>${renderInline(text, lifted)}</p>`).join("");
+			const nested = (l) => `<${l.tag}${startAttr(l)}>${l.items.map((item) => `<li>${paragraphs(item.paras)}</li>`).join("")}</${l.tag}>`;
+			const item = ({ blocks }) => {
+				const inline = blocks.filter((block) => typeof block === "string").length === 1;
+				return blocks.map((block) => typeof block !== "string" ? nested(block) : inline ? renderInline(block, lifted) : `<p>${renderInline(block, lifted)}</p>`).join("");
+			};
+			out.push(`<${list.tag}${startAttr(list)}>${list.items.map((entry) => `<li>${item(entry)}</li>`).join("")}</${list.tag}>`);
+		}
 		paragraph = [];
 		quote = [];
 		list = null;
@@ -10285,9 +10327,45 @@ function renderBlocks(text, lifted) {
 			html = null;
 		}
 		if (!line) {
-			flush();
+			if (list && !paragraph.length && !quote.length) list.gap = true;
+			else flush();
 			continue;
 		}
+		if (list?.items.length) {
+			const item = list.items[list.items.length - 1];
+			const tail = item.blocks[item.blocks.length - 1];
+			const inner = typeof tail === "string" ? null : tail;
+			const innerItem = inner?.items[inner.items.length - 1] ?? null;
+			const indent = indentOf(raw);
+			const marker = markerOf(raw);
+			const gap = list.gap;
+			list.gap = false;
+			if (marker && indent >= item.content) {
+				const joins = inner && innerItem && (indent >= innerItem.content || inner.tag === marker.tag);
+				const entry = {
+					paras: [marker.text],
+					content: marker.content
+				};
+				if (joins) inner.items.push(entry);
+				else item.blocks.push({
+					tag: marker.tag,
+					start: marker.start,
+					items: [entry]
+				});
+				continue;
+			}
+			if (!marker && gap) {
+				if (innerItem && indent >= innerItem.content) {
+					innerItem.paras.push(line);
+					continue;
+				}
+				if (indent >= item.content) {
+					item.blocks.push(line);
+					continue;
+				}
+				flush();
+			} else if (marker && gap && marker.tag !== list.tag) flush();
+		}
 		if (lifted && startsHtmlBlock(line, lifted)) {
 			flush();
 			html = [escapeHtml(line)];
@@ -10310,28 +10388,22 @@ function renderBlocks(text, lifted) {
 			out.push(`<h${level}>${renderInline(heading[2], lifted)}</h${level}>`);
 			continue;
 		}
-		const bullet = line.match(/^[-*+]\s+(.+)$/);
-		if (bullet) {
-			if (list?.tag !== "ul") {
+		const marker = markerOf(raw);
+		if (marker) {
+			let open = list;
+			if (open?.tag !== marker.tag) {
 				flush();
-				list = {
-					tag: "ul",
-					items: []
+				open = list = {
+					tag: marker.tag,
+					start: marker.start,
+					items: [],
+					gap: false
 				};
 			}
-			list.items.push(bullet[1]);
-			continue;
-		}
-		const ordered = line.match(/^\d{1,9}[.)]\s+(.+)$/);
-		if (ordered) {
-			if (list?.tag !== "ol") {
-				flush();
-				list = {
-					tag: "ol",
-					items: []
-				};
-			}
-			list.items.push(ordered[1]);
+			open.items.push({
+				blocks: [marker.text],
+				content: marker.content
+			});
 			continue;
 		}
 		const quoted = line.match(/^>\s?(.*)$/);
@@ -10341,7 +10413,13 @@ function renderBlocks(text, lifted) {
 			continue;
 		}
 		if (list && list.items.length) {
-			list.items[list.items.length - 1] += ` ${line}`;
+			const { blocks } = list.items[list.items.length - 1];
+			const last = blocks[blocks.length - 1];
+			if (typeof last === "string") blocks[blocks.length - 1] = `${last} ${line}`;
+			else {
+				const paras = last.items[last.items.length - 1].paras;
+				paras[paras.length - 1] += ` ${line}`;
+			}
 			continue;
 		}
 		if (quote.length) {

package/dist/main.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-import { $n as loadWorkspace, $r as detectAgents, $t as bootstrapUrl, A as reanalyseReview, B as telemetryUploadEnabled, Bn as clearClaim, En as checkReview, F as record$1, Fn as PHASES, Gn as groupByLineage, Gr as readAgentPreference, Hn as isClaimed, Hr as resolveAgent, I as stamp, Ir as WITHHELD_REASON, Jr as STORE_ROOT, Kr as writeAgentPreference, Kt as modelHelpLines, L as deliver, Lr as kissOutcome, M as startJob, Mn as isTerminal, N as append, Nn as loadJob, Qt as readIndexToken, R as recordTelemetryUploadConsent, Rn as progressSteps, Rr as resolveTarget, Ur as resolveModel, Ut as readMarker, Vn as driverGone, Vr as git, Wn as followedRefName, Wt as removeWorktree, Xr as DEFAULT_AGENT_ID, Xt as queueForReview, Yr as AGENT_IDS, Zn as lineageKeyFor, Zr as agentById, _ as liveUpdateFor, a as wasBlocked, ar as recentWorkspaces, b as recordKissRun, cn as workspaceUrl, cr as summarise, d as mergeUpdateInto, dn as PACKAGE_NAME, er as matchingWorkspaceIds, f as updateReview, g as UpdateAlreadyRunningError, gn as parseWorkspacePort, hn as MIN_WORKSPACE_PORT, i as liveJobsFor, j as runJob, kn as allJobs, mn as MAX_WORKSPACE_PORT, n as deleteReview$1, nr as positionInLineage, pn as DEFAULT_WORKSPACE_PORT, qr as CONFIG_PATH, qt as relativeTime, rn as reviewsUrl, sn as stopServer, sr as reviewedRepositories, tn as ensureServer, tr as mutateWorkspace, un as BUILD_VERSION, v as runningJobs, vn as statedWorkspacePort, xn as forgeResolver, yn as writePortPreference, z as telemetryUploadConsent, zn as purposeOf, zr as displayRef, zt as MANAGED_ROOT } from "./delete_review-CeJo9t7h.js";
+import { $n as loadWorkspace, $r as detectAgents, $t as bootstrapUrl, A as reanalyseReview, B as telemetryUploadEnabled, Bn as clearClaim, En as checkReview, F as record$1, Fn as PHASES, Gn as groupByLineage, Gr as readAgentPreference, Hn as isClaimed, Hr as resolveAgent, I as stamp, Ir as WITHHELD_REASON, Jr as STORE_ROOT, Kr as writeAgentPreference, Kt as modelHelpLines, L as deliver, Lr as kissOutcome, M as startJob, Mn as isTerminal, N as append, Nn as loadJob, Qt as readIndexToken, R as recordTelemetryUploadConsent, Rn as progressSteps, Rr as resolveTarget, Ur as resolveModel, Ut as readMarker, Vn as driverGone, Vr as git, Wn as followedRefName, Wt as removeWorktree, Xr as DEFAULT_AGENT_ID, Xt as queueForReview, Yr as AGENT_IDS, Zn as lineageKeyFor, Zr as agentById, _ as liveUpdateFor, a as wasBlocked, ar as recentWorkspaces, b as recordKissRun, cn as workspaceUrl, cr as summarise, d as mergeUpdateInto, dn as PACKAGE_NAME, er as matchingWorkspaceIds, f as updateReview, g as UpdateAlreadyRunningError, gn as parseWorkspacePort, hn as MIN_WORKSPACE_PORT, i as liveJobsFor, j as runJob, kn as allJobs, mn as MAX_WORKSPACE_PORT, n as deleteReview$1, nr as positionInLineage, pn as DEFAULT_WORKSPACE_PORT, qr as CONFIG_PATH, qt as relativeTime, rn as reviewsUrl, sn as stopServer, sr as reviewedRepositories, tn as ensureServer, tr as mutateWorkspace, un as BUILD_VERSION, v as runningJobs, vn as statedWorkspacePort, xn as forgeResolver, yn as writePortPreference, z as telemetryUploadConsent, zn as purposeOf, zr as displayRef, zt as MANAGED_ROOT } from "./delete_review-l4p_p6oh.js";
 import { basename, dirname, join, resolve } from "node:path";
 import { spawn } from "node:child_process";
 import { existsSync, mkdirSync, readdirSync, realpathSync, rmSync, statSync, writeFileSync } from "node:fs";