prreviewbuddy 0.59.50 → 0.63.0

package/CHANGELOG.md

@@ -1,5 +1,108 @@
 # Changelog
 
+## 0.63.0
+
+**Telemetry now records first use.** With telemetry on, PR Review Buddy sends one more event,
+`installation_started`, once per installation: the first time you run `prreviewbuddy` on its own,
+`review`, `open` or `agents`. It marks first use, not when the package was installed, and it adds
+no field. It carries the installation id, version, platform and a timestamp, and no agent. If it
+cannot reach the server it is tried again on your next such command, and never again once it
+arrives. The server keeps one per installation, so a repeat is acknowledged and not stored. Until now only reviews were counted, so somebody who tried PR Review Buddy and stopped
+before a review was invisible. Installations from before this version send it once, on their first
+command after upgrading.
+
+`prreviewbuddy` on its own now shows the one-time telemetry notice too, because it can now send.
+Its usage text is unchanged. An installation that already saw the telemetry notice, or turned telemetry
+on, is told once about this one addition; one that turned it off is told nothing. `--help`, `--version` and `config` send nothing and show no notice.
+`prreviewbuddy config set telemetry-upload off` and `PRB_TELEMETRY=off` stop this event exactly as
+they stop the others. The privacy page lists it: https://prreviewbuddy.com/privacy
+
+## 0.62.0
+
+**Buddy AI has its own keys.** On a review, ⌘K B opens a Buddy AI menu. B O opens Buddy AI with
+the cursor in its question, which is what ⌘K S B used to do; Sections now lists the review's own
+content only.
+
+**Choose a prompt without leaving the keyboard.** ⌘K B P lists your prompts, the ones under Your
+prompts in Buddy AI, in the same order. Type to narrow them by name or wording. The first ten shown
+are numbered, and pressing a number picks that prompt; the numbers follow what you have typed, so
+the best match is always 1. The arrows, or J and K once you are in the list, reach the rest, and
+Enter picks. The prompt goes into your question exactly as clicking it does, with Buddy AI open
+and ready for you to carry on. Escape goes back to the Buddy AI menu.
+
+## 0.61.1
+
+**J and K show the ends of the list.** Walking the Reviews list stopped with the first or last
+review flush against the edge of the window, leaving the count, Select and the section's name above
+it, or Load more below it, scrolled out of sight. Reaching the first review now scrolls the list
+right back to its top, reaching the last scrolls it to its bottom, arriving at the first review of a
+section brings that section's heading with it, and every other review stops a little short of the
+edge. The same goes for notifications.
+
+**The highlight on a notification has its corners.** On the first or last notification shown, the
+list's rounded corners cut the highlight off; it is now rounded to match.
+
+## 0.61.0
+
+**Search and Filters inside the command palette.** On the Reviews list, ⌘K S now turns the palette
+into a search: type, and the matching reviews appear under the field as you go; Enter or a click
+opens one. ⌘K F shows the list's filters there, each with its current choice. Both are the toolbar's
+own search and filters, so whatever you choose in one shows in the other, and the toolbar is still
+there for the mouse. Escape takes you back to the palette's commands, and a second Escape closes it.
+
+**J and K on Notifications.** Move through the notifications with J and K, open one with Enter or
+in a new tab with Shift+Enter, and come back to it with Back, as on the Reviews list.
+
+**The Reviews list's ring now sits on the card's own edge**, with no gap between them.
+
+## 0.60.0
+
+**Keyboard commands across the workspace.** Press **⌘K** on a Mac, or **Ctrl+K** elsewhere, to open
+the command palette. It lists what you can do on the page you are on, and after a key that leads
+somewhere (on a review **S** for Sections, **M** for Mark and **A** for Actions, on the Reviews
+list **L** for its sections), it shows the keys that can follow. It stays open until you choose
+something, press Escape or click away. A key it does not know just closes it.
+
+- **Anywhere:** ⌘K R goes to Reviews, ⌘K N to Notifications, and ⌘K ? opens the full table of
+  keyboard shortcuts.
+- **On a review:** ⌘K S then K, I, G, Q, F or B goes to KISS, Issues, Diagrams, Questions, Files or
+  Buddy AI. With a section expanded, the one you go to arrives expanded. **\\** expands or collapses
+  the section you are on, and Escape still leaves focus mode. ⌘K M then R, W or D marks the review
+  reviewed, waiting or done. ⌘K A then C checks for updates, U updates the review (wherever the
+  Update review button is offered), Q adds it to the review queue or takes it out, and D opens the
+  delete confirmation, with Cancel ready, and deletes nothing by itself.
+- **On the Reviews list:** J and K move through the reviews on screen, drawing a ring around the
+  one Enter opens; Shift+Enter opens it in a new tab. The ring stays put while the mouse moves, is
+  separate from the ticks of Select, and comes back to the review you opened when you go Back. ⌘K S
+  puts you in search, ⌘K F on the filters, and ⌘K L then P, A, W or D folds or opens Pinned,
+  Active, Waiting or Done, with the palette saying which are open.
+
+A command that cannot apply right now, such as Mark waiting on an older review of a branch, is shown
+dimmed and does nothing, as is anything that would change where the review stands while another
+such change is still on its way to the server. Single keys never act while you are typing in a
+field. The **…** menu on a review shows each action's shortcut beside it, and Help has the same
+table under Keyboard.
+
+## 0.59.52
+
+**The Reviews page remembers which sections you fold.** Pinned, Active, Waiting and Done each keep
+the state you left them in through a refresh, the page's own live updates and a restart of the
+workspace. A review arriving in a section you folded does not open it, though the count beside its
+name still changes. Until you fold or open a section yourself it starts as before, with Done folded
+and the rest open. The choice is stored on your machine, alongside the theme and the Buddy AI width.
+
+## 0.59.51
+
+**A merge no longer marks a Done review as changed.** A review you had marked Done showed
+**Changed since done** as soon as its pull request merged or closed, even with no new commits, which
+read as a contradiction beside **Review up to date**. It now shows that only when new commits land
+after you marked it Done, including commits pushed just before a merge. A pull request reopened after
+Done shows **Reopened since done**.
+
+**Keep done settles a changed review.** On a Done review showing either of those, the menu now says
+**Keep done** where it used to offer **Mark done** again. It clears the note and leaves the review in
+Done. Waiting reviews are unchanged: any new activity, a merge included, still brings them back.
+
 ## 0.59.50
 
 **A click on the Architecture background clears the selection.** Clicking empty space in the

package/dist/{delete_review-TsYWWNVr.js → delete_review-CeJo9t7h.js}

@@ -4343,6 +4343,11 @@ var ACTIVITY_LABELS = {
 	closed: "Closed",
 	reopened: "Reopened"
 };
+/** An activity as the `data-activity-*` attributes carry it, so the pages can recompute the chip. */
+function activityAttributes(activity) {
+	const moved = activity.movedAt === void 0 ? "" : ` data-activity-moved-at="${activity.movedAt}"`;
+	return ` data-activity-at="${activity.at}" data-activity-kind="${activity.kind}"${moved}`;
+}
 function activityLabel(kind) {
 	return ACTIVITY_LABELS[kind];
 }
@@ -4361,10 +4366,21 @@ function sectionOf(lifecycle, activity) {
 	if (lifecycle.state === "waiting" && changedSince(lifecycle, activity)) return "active";
 	return lifecycle.state;
 }
-/** The chip that says why a card is where it is, or absent when its section already says it. */
+/**
+* The chip that says why a card is where it is, or absent when its section already says it.
+*
+* Waiting is answered by any movement, a merge included: that is often what it was waiting for.
+* Done is answered only by what could change the verdict. A push after Done means the code is no
+* longer the code that was reviewed, even when the request merged afterwards. A reopen can make it
+* relevant again. A merge or close on its own is the request finishing after the review did, which
+* confirms Done rather than unsettling it.
+*/
 function lifecycleChip(lifecycle, activity) {
-	if (!lifecycle || !changedSince(lifecycle, activity)) return void 0;
-	return lifecycle.state === "waiting" ? "Changed while waiting" : "Changed since done";
+	if (!lifecycle || !activity) return void 0;
+	if (lifecycle.state === "waiting") return changedSince(lifecycle, activity) ? "Changed while waiting" : void 0;
+	if (activity.kind === "reopened" && activity.at > lifecycle.at) return "Reopened since done";
+	const movedAt = activity.movedAt ?? (activity.kind === "updated" ? activity.at : void 0);
+	return movedAt !== void 0 && movedAt > lifecycle.at ? "Changed since done" : void 0;
 }
 function changedSince(lifecycle, activity) {
 	return activity !== void 0 && activity.kind !== "created" && activity.at > lifecycle.at;
@@ -4381,6 +4397,15 @@ function offersLifecycle(target, lifecycle, activity) {
 	if (lifecycleChip(lifecycle, activity) !== void 0) return true;
 	return target !== (lifecycle?.state ?? "active");
 }
+/**
+* A lifecycle item's words. The settle item on a changed Done review is "Keep done": "Mark done" on
+* something already Done reads as a no-op. Waiting keeps "Mark waiting", because a changed Waiting
+* review is drawn in Active, where parking it again is what the words already say.
+*/
+function lifecycleItemLabel(target, lifecycle, activity) {
+	if (target === "done" && lifecycle?.state === "done" && lifecycleChip(lifecycle, activity) !== void 0) return "Keep done";
+	return lifecycleAction(target);
+}
 //#endregion
 //#region ../../packages/review-harness/src/workspace/store.ts
 var WORKSPACES_DIR = join(STORE_ROOT, "workspaces");
@@ -13561,6 +13586,13 @@ var TIMEOUT_MS = 1500;
 */
 function project(record) {
 	const event = record.event;
+	if (event.event === "installation_started") return {
+		event: event.event,
+		installationId: record.anonymousId,
+		cliVersion: record.cliVersion,
+		platform: record.platform,
+		occurredAt: record.at
+	};
 	if (event.event !== "review_started" && event.event !== "review_finished") return null;
 	const base = {
 		event: event.event,
@@ -13589,13 +13621,38 @@ function send(record) {
 		if (!telemetryUploadEnabled()) return;
 		const payload = project(record);
 		if (!payload) return;
-		fetch(endpoint(), {
+		post(payload);
+	} catch {}
+}
+/**
+* Send one record and say whether the server took it. Never rejects.
+*
+* For the one caller that has to know: `installation_started` is sent until it lands, so it needs
+* a yes it can trust, which is a 2xx and nothing else. Asks the same question `send` does before
+* anything goes over the wire.
+*/
+async function deliver(record) {
+	try {
+		if (!telemetryUploadEnabled()) return false;
+		const payload = project(record);
+		return payload ? await post(payload) : false;
+	} catch {
+		return false;
+	}
+}
+async function post(payload) {
+	try {
+		const response = await fetch(endpoint(), {
 			method: "POST",
 			headers: { "content-type": "application/json" },
 			body: JSON.stringify(payload),
 			signal: AbortSignal.timeout(TIMEOUT_MS)
-		}).catch(() => {});
-	} catch {}
+		});
+		await response.body?.cancel().catch(() => {});
+		return response.ok;
+	} catch {
+		return false;
+	}
 }
 /**
 * Where to. Overridable so the endpoint can be pointed at a local server while it is being built,
@@ -13620,29 +13677,44 @@ var LOG_PATH = join(STORE_ROOT, "events.jsonl");
 * The gate is on **transmission only**. Writing a file the developer owns and can read, delete or
 * disable is a different act from sending to a server, and the consent that suits one does not
 * carry to the other, so `events.jsonl` keeps recording the full event union either way and the
-* question asked on first run is about the wire. Nineteen events are written here; two of them,
+* question asked on first run is about the wire. Twenty events are written here; three of them,
 * carrying eight fields between them, are the most that is ever sent.
 */
 function record(event) {
 	try {
-		const config = loadConfig();
-		if (!config.telemetry) return;
-		const line = {
-			anonymousId: config.anonymousId,
-			cliVersion: BUILD_VERSION,
-			platform: platformName(),
-			at: (/* @__PURE__ */ new Date()).toISOString(),
-			event
-		};
-		mkdirSync(STORE_ROOT, { recursive: true });
-		appendFileSync(LOG_PATH, `${JSON.stringify(line)}\n`, { mode: 384 });
+		const line = stamp(event);
+		if (!line) return;
+		append(line);
 		send(line);
 	} catch {}
 }
+/**
+* The line an event would be logged as, or `null` when the log is switched off.
+*
+* Split from `record` for `installation_started`, which is built and sent first and logged only
+* once the server has it: logging each attempt would leave one line per failed try for an event
+* that happens once.
+*/
+function stamp(event) {
+	const config = loadConfig();
+	if (!config.telemetry) return null;
+	return {
+		anonymousId: config.anonymousId,
+		cliVersion: BUILD_VERSION,
+		platform: platformName(),
+		at: (/* @__PURE__ */ new Date()).toISOString(),
+		event
+	};
+}
+/** Write one line to the log. Throws on a failed write; callers decide what that costs. */
+function append(line) {
+	mkdirSync(STORE_ROOT, { recursive: true });
+	appendFileSync(LOG_PATH, `${JSON.stringify(line)}\n`, { mode: 384 });
+}
 /** This review's own events, oldest first. The only reader, used to derive the rollup. */
 function readEvents(reviewId) {
 	try {
-		return readFileSync(LOG_PATH, "utf8").split("\n").filter(Boolean).map((line) => JSON.parse(line)).filter((entry) => entry.event?.reviewId === reviewId).map((entry) => entry.event);
+		return readFileSync(LOG_PATH, "utf8").split("\n").filter(Boolean).map((line) => JSON.parse(line)).map((entry) => entry.event).filter((event) => event !== void 0 && "reviewId" in event && event.reviewId === reviewId);
 	} catch {
 		return [];
 	}
@@ -16127,4 +16199,4 @@ function lineageIds(id) {
 	return [.../* @__PURE__ */ new Set([id, ...lineage.map((review) => review.id)])];
 }
 //#endregion
-export { REPOSITORY_SCOPE as $, presentedKissRunOf as $n, reviewsUrl as $t, reanalyseReview as A, saveJob as An, describeAuthorship as Ar, renderInlineText as At, RUNTIME_WORDS as B, followedRefName as Bn, readAgentPreference as Br, removeWorktree as Bt, track as C, followedBranch as Cn, isIssueOutstanding as Cr, authorPreview as Ct, endRun as D, fail as Dn, reviewerDispositions as Dr, CODE_BLOCK_CLASS as Dt, completeRun as E, endedAt as En, questionsOutstanding as Er, renderMarkdown as Et, recordTelemetryUploadConsent as F, purposeOf as Fn, isCommitReview as Fr, MANAGED_ROOT as Ft, partFiles as G, kissDecisionsOf as Gn, DEFAULT_AGENT_ID as Gr, compactQueue as Gt, ARCHITECTURE_DIR as H, indexKeptIds as Hn, CONFIG_PATH as Hr, modelHelpLines as Ht, telemetryUploadConsent as I, clearClaim as In, git as Ir, createWorktree as It, storeArchitecture as J, lineagePosition as Jn, detectAgents as Jr, readIndexToken as Jt, readArchitecture as K, latestKissRun as Kn, agentById as Kr, queueForReview as Kt, waitingHistory as L, driverGone as Ln, resolveAgent as Lr, holdWorktree as Lt, startJob as M, isLiveJob as Mn, kissOutcome as Mr, extractJsonText as Mt, readEvents as N, phasesFor as Nn, resolveTarget as Nr, objectWithAnyOf as Nt, reportRun as O, isTerminal as On, processDiscussion as Or, CODE_COPY_CLASS as Ot, record as P, progressSteps as Pn, displayRef as Pr, ReviewBeingDeletedError as Pt, QUOTE_LIMITS as Q, positionInLineage as Qn, readServerRecord as Qt, mapRuntimes as R, isClaimed as Rn, resolveModel as Rr, isWorktreeHeld as Rt, isDriving as S, checkReview as Sn, doneVerb as Sr, UNESTABLISHED_MOTIVATION as St, beginRun as T, allJobs as Tn, issuesOutstanding as Tr, GITHUB_MARKDOWN as Tt, checkArchitecture as U, indexReviewGroups as Un, STORE_ROOT as Ur, relativeTime as Ut, describeRuntimes as V, groupByLineage as Vn, writeAgentPreference as Vr, requestJobStop as Vt, loadArchitecture as W, kissDecisionRefusal as Wn, AGENT_IDS as Wr, activateQueued as Wt, trackedFiles as X, matchingWorkspaceIds as Xn, AgentUnavailableError as Xr, clearServerRecordOwnedBy as Xt, storedScopes as Y, loadWorkspace as Yn, AgentCancelledError as Yr, bootstrapUrl as Yt, ownersOf as Z, mutateWorkspace as Zn, ensureServer as Zt, liveUpdateFor as _, forgeResolver as _n, queueAdd as _r, removeNotification as _t, wasBlocked as a, writeServerRecord as an, touchWorkspace as ar, subjectOf as at, recordKissRun as b, fillFileUrlTemplate as bn, queueStamp as br, withUsageRecorded as bt, RefreshUnavailableError as c, feedbackUrl as cn, LIFECYCLES as cr, createPrUpdate as ct, mergeUpdateInto as d, MIN_WORKSPACE_PORT as dn, lifecycleAction as dr, listNotifications as dt, serverEntryExists as en, previousKissResult as er, ancestorsOf as et, updateReview as f, parseWorkspacePort as fn, lifecycleChip as fr, markAllRead as ft, UpdateAlreadyRunningError as g, claimRequestUrl as gn, sectionOf as gr, readNotification as gt, askCheckout as h, writePortPreference as hn, parseLifecycle as hr, pruneNotifications as ht, liveJobsFor as i, workspaceUrl as in, summarise as ir, branchOf as it, runJob as j, PHASES as jn, WITHHELD_REASON as jr, asString as jt, stopRun as k, loadJob as kn, recommendationsOf as kr, escapeHtml as kt, cancelUpdate as l, DEFAULT_WORKSPACE_PORT as ln, activityLabel as lr, eventName as lt, isUnchanged as m, statedWorkspacePort as mn, offersLifecycle as mr, markReadForReview as mt, deleteReview as n, stopChild as nn, reviewedCommit as nr, writeJsonAtomically as nt, discardJob as o, BUILD_VERSION as on, workspaceRevision as or, createArchitectureNotification as ot, refreshPrContext as p, resolveWorkspacePort as pn, lifecyclePill as pr, markRead as pt, repositoryKey as q, lineageKeyFor as qn, agentFor as qr, settleQueue as qt, lineageIds as r, stopServer as rn, reviewedRepositories as rr, announceJob as rt, FETCH_TIMEOUT_MS as s, PACKAGE_NAME as sn, workspaceStamps as sr, createPrState as st, deleteLineage as t, spawnServer as tn, recentWorkspaces as tr, isArchitectureId as tt, cancellableHere as u, MAX_WORKSPACE_PORT as un, isLifecycle as ur, headline as ut, runningJobs as v, forgeFor as vn, queueAddMany as vr, toneOf as vt, RUN_KINDS as w, reviewedShaOf as wn, isQuestionOutstanding as wr, hasAuthorContent as wt, startKissJob as x, checkCodeFreshness as xn, readQueue as xr, EXPLAIN_SIMPLY_PROMPT as xt, agentEnvOf as y, remoteHost as yn, queueRemove as yr, unreadCount as yt, recordRuntimeBestEffort as z, decideKissRecommendation as zn, clearAgentPreference as zr, readMarker as zt };
+export { storedScopes as $, loadWorkspace as $n, detectAgents as $r, bootstrapUrl as $t, reanalyseReview as A, endedAt as An, issuesOutstanding as Ar, renderMarkdown as At, telemetryUploadEnabled as B, clearClaim as Bn, isCommitReview as Br, createWorktree as Bt, track as C, remoteHost as Cn, queueAddMany as Cr, unreadCount as Ct, endRun as D, followedBranch as Dn, doneVerb as Dr, authorPreview as Dt, completeRun as E, checkReview as En, readQueue as Er, UNESTABLISHED_MOTIVATION as Et, record as F, PHASES as Fn, describeAuthorship as Fr, asString as Ft, describeRuntimes as G, groupByLineage as Gn, readAgentPreference as Gr, requestJobStop as Gt, mapRuntimes as H, isClaimed as Hn, resolveAgent as Hr, isWorktreeHeld as Ht, stamp as I, isLiveJob as In, WITHHELD_REASON as Ir, extractJsonText as It, loadArchitecture as J, kissDecisionRefusal as Jn, STORE_ROOT as Jr, activateQueued as Jt, ARCHITECTURE_DIR as K, indexKeptIds as Kn, writeAgentPreference as Kr, modelHelpLines as Kt, deliver as L, phasesFor as Ln, kissOutcome as Lr, objectWithAnyOf as Lt, startJob as M, isTerminal as Mn, reviewerDispositions as Mr, CODE_COPY_CLASS as Mt, append as N, loadJob as Nn, processDiscussion as Nr, escapeHtml as Nt, reportRun as O, reviewedShaOf as On, isIssueOutstanding as Or, hasAuthorContent as Ot, readEvents as P, saveJob as Pn, recommendationsOf as Pr, renderInlineText as Pt, storeArchitecture as Q, lineagePosition as Qn, agentFor as Qr, readIndexToken as Qt, recordTelemetryUploadConsent as R, progressSteps as Rn, resolveTarget as Rr, ReviewBeingDeletedError as Rt, isDriving as S, forgeFor as Sn, queueAdd as Sr, toneOf as St, beginRun as T, checkCodeFreshness as Tn, queueStamp as Tr, EXPLAIN_SIMPLY_PROMPT as Tt, recordRuntimeBestEffort as U, decideKissRecommendation as Un, resolveModel as Ur, readMarker as Ut, waitingHistory as V, driverGone as Vn, git as Vr, holdWorktree as Vt, RUNTIME_WORDS as W, followedRefName as Wn, clearAgentPreference as Wr, removeWorktree as Wt, readArchitecture as X, latestKissRun as Xn, DEFAULT_AGENT_ID as Xr, queueForReview as Xt, partFiles as Y, kissDecisionsOf as Yn, AGENT_IDS as Yr, compactQueue as Yt, repositoryKey as Z, lineageKeyFor as Zn, agentById as Zr, settleQueue as Zt, liveUpdateFor as _, resolveWorkspacePort as _n, lifecycleItemLabel as _r, markRead as _t, wasBlocked as a, spawnServer as an, recentWorkspaces as ar, isArchitectureId as at, recordKissRun as b, claimRequestUrl as bn, parseLifecycle as br, readNotification as bt, RefreshUnavailableError as c, workspaceUrl as cn, summarise as cr, branchOf as ct, mergeUpdateInto as d, PACKAGE_NAME as dn, workspaceStamps as dr, createPrState as dt, AgentCancelledError as ei, clearServerRecordOwnedBy as en, matchingWorkspaceIds as er, trackedFiles as et, updateReview as f, feedbackUrl as fn, LIFECYCLES as fr, createPrUpdate as ft, UpdateAlreadyRunningError as g, parseWorkspacePort as gn, lifecycleChip as gr, markAllRead as gt, askCheckout as h, MIN_WORKSPACE_PORT as hn, isLifecycle as hr, listNotifications as ht, liveJobsFor as i, serverEntryExists as in, previousKissResult as ir, ancestorsOf as it, runJob as j, fail as jn, questionsOutstanding as jr, CODE_BLOCK_CLASS as jt, stopRun as k, allJobs as kn, isQuestionOutstanding as kr, GITHUB_MARKDOWN as kt, cancelUpdate as l, writeServerRecord as ln, touchWorkspace as lr, subjectOf as lt, isUnchanged as m, MAX_WORKSPACE_PORT as mn, activityLabel as mr, headline as mt, deleteReview as n, readServerRecord as nn, positionInLineage as nr, QUOTE_LIMITS as nt, discardJob as o, stopChild as on, reviewedCommit as or, writeJsonAtomically as ot, refreshPrContext as p, DEFAULT_WORKSPACE_PORT as pn, activityAttributes as pr, eventName as pt, checkArchitecture as q, indexReviewGroups as qn, CONFIG_PATH as qr, relativeTime as qt, lineageIds as r, reviewsUrl as rn, presentedKissRunOf as rr, REPOSITORY_SCOPE as rt, FETCH_TIMEOUT_MS as s, stopServer as sn, reviewedRepositories as sr, announceJob as st, deleteLineage as t, AgentUnavailableError as ti, ensureServer as tn, mutateWorkspace as tr, ownersOf as tt, cancellableHere as u, BUILD_VERSION as un, workspaceRevision as ur, createArchitectureNotification as ut, runningJobs as v, statedWorkspacePort as vn, lifecyclePill as vr, markReadForReview as vt, RUN_KINDS as w, fillFileUrlTemplate as wn, queueRemove as wr, withUsageRecorded as wt, startKissJob as x, forgeResolver as xn, sectionOf as xr, removeNotification as xt, agentEnvOf as y, writePortPreference as yn, offersLifecycle as yr, pruneNotifications as yt, telemetryUploadConsent as z, purposeOf as zn, displayRef as zr, MANAGED_ROOT as zt };

package/dist/main.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-import { $t as reviewsUrl, A as reanalyseReview, Bn as followedRefName, Br as readAgentPreference, Bt as removeWorktree, F as recordTelemetryUploadConsent, Fn as purposeOf, Ft as MANAGED_ROOT, Gr as DEFAULT_AGENT_ID, Hr as CONFIG_PATH, Ht as modelHelpLines, I as telemetryUploadConsent, In as clearClaim, Ir as git, Jr as detectAgents, Jt as readIndexToken, Kr as agentById, Kt as queueForReview, Ln as driverGone, Lr as resolveAgent, M as startJob, Mr as kissOutcome, Nr as resolveTarget, On as isTerminal, P as record$1, Pn as progressSteps, Pr as displayRef, Qn as positionInLineage, Rn as isClaimed, Rr as resolveModel, Sn as checkReview, Tn as allJobs, Ur as STORE_ROOT, Ut as relativeTime, Vn as groupByLineage, Vr as writeAgentPreference, Wr as AGENT_IDS, Xn as matchingWorkspaceIds, Yn as loadWorkspace, Yt as bootstrapUrl, Zn as mutateWorkspace, Zt as ensureServer, _ as liveUpdateFor, _n as forgeResolver, a as wasBlocked, b as recordKissRun, d as mergeUpdateInto, dn as MIN_WORKSPACE_PORT, f as updateReview, fn as parseWorkspacePort, g as UpdateAlreadyRunningError, hn as writePortPreference, i as liveJobsFor, in as workspaceUrl, ir as summarise, j as runJob, jn as PHASES, jr as WITHHELD_REASON, kn as loadJob, ln as DEFAULT_WORKSPACE_PORT, mn as statedWorkspacePort, n as deleteReview$1, on as BUILD_VERSION, qn as lineageKeyFor, rn as stopServer, rr as reviewedRepositories, sn as PACKAGE_NAME, tr as recentWorkspaces, un as MAX_WORKSPACE_PORT, v as runningJobs, zt as readMarker } from "./delete_review-TsYWWNVr.js";
+import { $n as loadWorkspace, $r as detectAgents, $t as bootstrapUrl, A as reanalyseReview, B as telemetryUploadEnabled, Bn as clearClaim, En as checkReview, F as record$1, Fn as PHASES, Gn as groupByLineage, Gr as readAgentPreference, Hn as isClaimed, Hr as resolveAgent, I as stamp, Ir as WITHHELD_REASON, Jr as STORE_ROOT, Kr as writeAgentPreference, Kt as modelHelpLines, L as deliver, Lr as kissOutcome, M as startJob, Mn as isTerminal, N as append, Nn as loadJob, Qt as readIndexToken, R as recordTelemetryUploadConsent, Rn as progressSteps, Rr as resolveTarget, Ur as resolveModel, Ut as readMarker, Vn as driverGone, Vr as git, Wn as followedRefName, Wt as removeWorktree, Xr as DEFAULT_AGENT_ID, Xt as queueForReview, Yr as AGENT_IDS, Zn as lineageKeyFor, Zr as agentById, _ as liveUpdateFor, a as wasBlocked, ar as recentWorkspaces, b as recordKissRun, cn as workspaceUrl, cr as summarise, d as mergeUpdateInto, dn as PACKAGE_NAME, er as matchingWorkspaceIds, f as updateReview, g as UpdateAlreadyRunningError, gn as parseWorkspacePort, hn as MIN_WORKSPACE_PORT, i as liveJobsFor, j as runJob, kn as allJobs, mn as MAX_WORKSPACE_PORT, n as deleteReview$1, nr as positionInLineage, pn as DEFAULT_WORKSPACE_PORT, qr as CONFIG_PATH, qt as relativeTime, rn as reviewsUrl, sn as stopServer, sr as reviewedRepositories, tn as ensureServer, tr as mutateWorkspace, un as BUILD_VERSION, v as runningJobs, vn as statedWorkspacePort, xn as forgeResolver, yn as writePortPreference, z as telemetryUploadConsent, zn as purposeOf, zr as displayRef, zt as MANAGED_ROOT } from "./delete_review-CeJo9t7h.js";
 import { basename, dirname, join, resolve } from "node:path";
 import { spawn } from "node:child_process";
 import { existsSync, mkdirSync, readdirSync, realpathSync, rmSync, statSync, writeFileSync } from "node:fs";
@@ -107,15 +107,24 @@ var AUDIENCES = {
 	reviewer: "writes it for somebody reviewing somebody else's work, with whether each one is worth raising"
 };
 function parse(argv) {
-	if (argv.length === 0) return { name: "help" };
+	if (argv.length === 0) return {
+		name: "help",
+		via: "bare"
+	};
 	const [head, ...rest] = argv;
-	if (head === "--help" || head === "-h" || head === "help") return { name: "help" };
+	if (head === "--help" || head === "-h" || head === "help") return {
+		name: "help",
+		via: "asked"
+	};
 	if (head === "--version" || head === "-v") return { name: "version" };
 	if (head === void 0 || !(head in VALUED)) return {
 		name: "error",
 		message: unknownCommand(head)
 	};
-	if (rest.includes("--help") || rest.includes("-h")) return { name: "help" };
+	if (rest.includes("--help") || rest.includes("-h")) return {
+		name: "help",
+		via: "asked"
+	};
 	const values = {};
 	const flags = /* @__PURE__ */ new Set();
 	const positional = [];
@@ -1217,12 +1226,26 @@ function unknownSetting(key, known) {
 * little else is attached to it. "Anonymous" is a word with a technical meaning strong enough to be
 * challenged on, and the claim below does not need it to be true.
 */
+/**
+* The one addition since the notice an installation already saw, or the yes it already gave. Not the
+* notice again: repeating what somebody was told reads as something else having changed.
+*/
+function telemetryFirstUseNotice() {
+	return [
+		"",
+		"Usage telemetry now also records first use: one event, once per installation, with the",
+		"same version, platform and timestamp fields as before. Nothing else changed.",
+		"Turn it off: `prreviewbuddy config set telemetry-upload off`",
+		"Details: https://prreviewbuddy.com/privacy",
+		""
+	].join("\n");
+}
 function telemetryNotice() {
 	return [
 		"",
-		"Non-identifying usage telemetry is on by default: review start and finish, version,",
-		"platform, agent, success and duration. Never your code, diffs, repository names or",
-		"review content.",
+		"Non-identifying usage telemetry is on by default: first use, review start and finish,",
+		"version, platform, agent, success and duration. Never your code, diffs, repository",
+		"names or review content.",
 		"Turn it off: `prreviewbuddy config set telemetry-upload off`",
 		"Details: https://prreviewbuddy.com/privacy",
 		""
@@ -3413,6 +3436,7 @@ async function uninstall(command, deps = REAL) {
 */
 var GREETING = "onboarding-shown";
 var TELEMETRY_NOTICE = "telemetry-notice-shown";
+var FIRST_USE_NOTICE = "telemetry-first-use-notice-shown";
 /** Whether this machine has been greeted. */
 function greeted() {
 	return shown(GREETING);
@@ -3433,6 +3457,13 @@ function telemetryNoticed() {
 function recordTelemetryNotice() {
 	record(TELEMETRY_NOTICE);
 }
+/** Whether this machine has been told that 0.63.0 added `installation_started` to what is sent. */
+function firstUseNoticed() {
+	return shown(FIRST_USE_NOTICE);
+}
+function recordFirstUseNotice() {
+	record(FIRST_USE_NOTICE);
+}
 /**
 * Unreadable reads as already shown.
 *
@@ -3473,16 +3504,108 @@ function record(name) {
 * Both are left alone, which is why the claim everywhere else is "every installation whose
 * behaviour changes is told once" rather than "every machine is told".
 *
+* **0.63.0 is such a change for everybody who sends.** `installation_started` joined what leaves
+* the machine, so an installation told the old list, or that said yes to it, is told once about the
+* addition, under its own marker. A no is still told nothing.
+*
 * **No terminal check.** The old question could not be asked without one. A disclosure has nobody
 * to wait for, and a headless install that transmits is exactly the install that must not be the
 * one nobody ever told. It costs a CI log three lines on a persisted home, once.
 */
 function noticeTelemetry(write) {
 	if (process.env.PRB_TELEMETRY === "off") return;
-	if (telemetryUploadConsent() !== null) return;
-	if (telemetryNoticed()) return;
-	write(telemetryNotice());
-	recordTelemetryNotice();
+	const consent = telemetryUploadConsent();
+	if (consent === false) return;
+	if (consent === null && !telemetryNoticed()) {
+		write(telemetryNotice());
+		recordTelemetryNotice();
+		recordFirstUseNotice();
+		return;
+	}
+	if (firstUseNoticed()) return;
+	write(telemetryFirstUseNotice());
+	recordFirstUseNotice();
+}
+//#endregion
+//#region src/product_commands.ts
+/**
+* Whether this command is somebody using the product, rather than asking about the binary or
+* changing a setting.
+*
+* One answer for two things, on purpose. These commands print the one-time telemetry notice, and
+* they are the commands that may send `installation_started`. If the lists ever differed, a
+* command could transmit before the installation had been told telemetry is on.
+*
+* `prreviewbuddy` on its own counts: it is somebody entering the product to see what it does.
+* `--help` and `--version` do not, nor `config` (where the setting is changed, and turning it off
+* must not need a disclosure first) or `uninstall`.
+*/
+function isProductCommand(command) {
+	switch (command.name) {
+		case "review":
+		case "open":
+		case "agents": return true;
+		case "help": return command.via === "bare";
+		default: return false;
+	}
+}
+//#endregion
+//#region ../../packages/review-harness/src/telemetry/installation_started.ts
+/**
+* Tell the server, once, that this installation was used.
+*
+* The review events only fire from inside a review job, so an installation that was tried and
+* left before its first review was invisible: nothing told "nobody installs this" apart from
+* "people install it and stop before reviewing". This is the event that sits in front of them.
+*
+* It means first meaningful use that telemetry saw, and the name has to survive that reading:
+* an installation from before the event existed sends it on its first command after upgrading,
+* and nothing on this machine knows when the package was actually installed.
+*
+* **Sent until it lands.** Every other event is best effort, because losing one review out of a
+* thousand changes nothing. Losing this one loses the installation from the funnel, so the marker
+* is written only after a 2xx, and every meaningful command until then tries again. Any failure
+* retries, a 422 included: a CLI that reached somebody before the API learned the event recovers
+* on its own once it has. `occurredAt` is the attempt's own time, never a remembered first try,
+* because the server refuses a timestamp more than two days from when it arrives and a stored
+* one would be refused forever.
+*
+* **Once is kept by the server, not here.** This side cannot know that a request it saw fail was
+* not stored: an acknowledgement lost after the row committed looks exactly like a failure, and two
+* commands started together on one home both pass the marker check before either has written it.
+* Both resend. The API holds one `installation_started` per installation under a unique index and
+* answers a repeat with a 200 it does not store, which also stops the retrying. The marker only
+* saves requests.
+*/
+var MARKER = join(STORE_ROOT, "installation-started-sent");
+/**
+* Send `installation_started` if this installation has not had it accepted yet. Never rejects.
+*
+* Asks whether it may send before it reads anything, so under `PRB_TELEMETRY=off` it creates no
+* identity, no marker and no log line: the kill switch is not a decision, and a machine that
+* unsets it tomorrow has still never been counted.
+*/
+async function announceInstallation() {
+	try {
+		if (!telemetryUploadEnabled()) return;
+		if (announced()) return;
+		const line = stamp({ event: "installation_started" });
+		if (!line || !await deliver(line)) return;
+		writeMarker();
+		append(line);
+	} catch {}
+}
+/** An unreadable home counts as already sent: failing closed on repetition. */
+function announced() {
+	try {
+		return existsSync(MARKER);
+	} catch {
+		return true;
+	}
+}
+function writeMarker() {
+	mkdirSync(STORE_ROOT, { recursive: true });
+	writeFileSync(MARKER, `${(/* @__PURE__ */ new Date()).toISOString()}\n`, { mode: 384 });
 }
 //#endregion
 //#region src/main.ts
@@ -3520,28 +3643,33 @@ function greet(command) {
 /**
 * The one-time telemetry disclosure, printed after the hello and before the work.
 *
-* The greeting's commands minus `config`, which is where the setting is changed: somebody typing
+* On the commands `isProductCommand` names, which are also the ones that may send
+* `installation_started`, so nothing is transmitted from a command that could not have disclosed
+* it. Not `config`, which is where the setting is changed: somebody typing
 * `config set telemetry-upload off` should be able to turn it off without being told first that it
-* is on. That was true when this was a question and it is still true now it is a notice.
+* is on.
 *
 * On stderr, like every other line here that is not a result, so `prreviewbuddy review | pbcopy`
 * still copies a URL. Unlike the question it replaced it takes no input and checks for no terminal:
 * there is nobody to wait for, and a headless install that transmits is the one that most needs
 * telling.
 */
-var NOTIFIED = [
-	"review",
-	"open",
-	"agents"
-];
 function notify(command) {
-	if (!NOTIFIED.includes(command.name)) return;
+	if (!isProductCommand(command)) return;
 	noticeTelemetry((chunk) => void process.stderr.write(chunk));
 }
 async function main(argv) {
 	const command = parse(argv);
 	greet(command);
 	notify(command);
+	const announced = isProductCommand(command) ? announceInstallation() : Promise.resolve();
+	try {
+		return await run(command);
+	} finally {
+		await announced;
+	}
+}
+async function run(command) {
 	switch (command.name) {
 		case "help":
 			out(HELP);