prreviewbuddy 0.50.1 → 0.52.2

package/CHANGELOG.md

@@ -1,5 +1,87 @@
 # Changelog
 
+## 0.52.2
+
+**Continue reviewing is gone from the Reviews page.** The banner opened whatever was first in your
+review queue, which the Queue view already shows as its first card. The queue itself is unchanged:
+the **Queue** filter lists your queued reviews in order, marking one Reviewed takes it out, and the
+card menus and select mode still add and remove reviews.
+
+## 0.52.1
+
+**Fetching remote updates moved to where it applies.** A fetch only refreshes reviews that follow a
+remote branch, such as `origin/feature`. Pull request reviews are checked automatically, and a fetch
+cannot move a local branch. So the **Fetch updates** button is gone from the Reviews toolbar, where
+it read as the way the list checks for updates and sat disabled for most people. Instead:
+
+- A card that follows a remote branch has **Fetch remote updates** in its `...` menu.
+- A review that follows one has **Fetch remote updates** in its `...` menu, beside Check for
+  updates. Check for updates still only reads what is on your machine. After the fetch the review
+  checks again, so the freshness banner reflects what came in.
+- In select mode, **Fetch selected** appears only when the selection includes a review that can be
+  fetched.
+
+What a fetch did, such as "Fetched 1 repository", now appears as a notice in the corner.
+
+## 0.52.0
+
+**Saved is now Pinned, and pinned reviews have their own section.** The Reviews page lists
+**Pinned**, **Active**, **Waiting** and **Done** in that order, each under a heading with its count.
+Pinning a review moves it into Pinned straight away, and unpinning moves it back. A pinned review
+keeps its lifecycle: a pinned Waiting or Done review says so on its card, and a Waiting one that
+changes says "Changed while waiting" there instead of jumping to Active. Pinning no longer changes
+the order. Every section, Pinned included, is sorted by what last happened to each change.
+
+The Status filter no longer has a Saved option, since the Pinned section does that job. A link to
+the old Saved view opens the whole list. On a review's own page, the menu item is now **Pin review**
+or **Unpin review**. Pinned reviews are still kept for ninety days.
+
+Under the **Queue** filter the list stays in the order you queued it: a pinned review keeps its
+place in the queue and shows its star. Select mode acts on reviews top to bottom as they are shown,
+so **Add to review queue** queues them in that order. The star cannot be pressed again until the
+last press has been saved, so quick clicks can no longer leave it showing the opposite of what was
+stored.
+
+## 0.51.2
+
+**The review queue counts what it shows.** When a queued branch was analysed again, the queue kept
+pointing at the older review. The Queue count included it, the Queue view had no card for it,
+Continue reviewing opened the older review, and the card's menu could not take it out. A new review
+of a queued branch now takes that branch's place in the queue. Opening the Reviews page repairs a
+queue that already has older reviews in it, and a branch queued twice keeps its earlier place.
+
+## 0.51.1
+
+**The workspace fits a phone-width window.** Below about 600px the review's top bar ran off the
+right edge and the whole page scrolled sideways; below about 450px the thin bar above it did too.
+The review bar now wraps onto a second row (what the review is of, then its facts and controls),
+and the thin bar keeps every control and the version by tightening its spacing and showing Send
+feedback as an icon.
+
+Buddy AI, opened in a narrow window, now covers exactly the review below the bars instead of
+assuming how tall they are, so it no longer sits over a banner such as the freshness notice. The
+review's `...` menu now opens over the Buddy AI tab rather than under it.
+
+## 0.51.0
+
+**KISS recommendations read in seconds.** Each card now leads with the point: a sentence or two on
+what the change adds and why the requirements do not need it, then the simpler approach, a short
+line of what acting on it gains, and where to start. The full reasoning (the evidence, why the
+requirements do not call for it, the trade-offs and the other files involved) is one click away
+under **Evidence & trade-offs**. A trade-off that could change your decision is shown on the card
+itself.
+
+Titles now say what to do rather than naming the idea, such as "Remove key readback until hardware
+supports it" instead of "Defer device-reported key support".
+
+A recommendation is shown only when it comes with a summary, a simpler approach, the evidence and
+reasoning behind it, and a file that exists in the reviewed commit. One that falls short, including
+one that points only at files that do not exist, is no longer shown as a card. The review says how many were held back, both in the workspace and
+in the terminal. If every recommendation came back incomplete, the review says the analysis was
+incomplete rather than calling the change appropriately simple.
+
+KISS reviews you already have keep working, in the new layout.
+
 ## 0.50.1
 
 **Copy and Ask Buddy look and behave as a pair.** On every issue and question, both icons are the

package/dist/{delete_review-BIXqUnpx.js → delete_review-BiV1aBpx.js}

@@ -3187,6 +3187,20 @@ async function hasCommit(root, sha) {
 	}
 }
 //#endregion
+//#region ../../packages/review-harness/src/domain/kiss/outcome.ts
+/**
+* What a recommendation needs in order to be shown, said the same way wherever a withheld one is.
+*
+* The page and the terminal both explain why something was held back, and the rule behind it lives
+* in two places (`parse.ts` for the fields, `validate.ts` for the files). One sentence, so the
+* explanation cannot fall behind either of them.
+*/
+var WITHHELD_REASON = "missing a summary, its evidence and reasoning, a simpler approach, or a file that exists in the reviewed commit";
+function kissOutcome(result, audit) {
+	if (result.recommendations.length > 0) return "recommendations";
+	return (audit.withheldRecommendations ?? 0) > 0 ? "incomplete" : "proportionate";
+}
+//#endregion
 //#region ../../packages/review-harness/src/workspace/authorship.ts
 function describeAuthorship(changeSet, pullRequest) {
 	const author = pullRequest?.author;
@@ -4371,10 +4385,24 @@ function createWorkspace(input) {
 		...input
 	};
 	writeWorkspace(workspace);
+	forwardQueueTo(workspace);
 	pruneOldWorkspaces();
 	return workspace;
 }
 /**
+* A new review of a queued branch takes the branch's place in the queue. See `forwardQueue`.
+*
+* Reads only the queued reviews, not the store: the queue is capped and the store is not. A failed
+* queue write is left alone, because the reviews index settles the same thing when it next loads.
+*/
+function forwardQueueTo(workspace) {
+	updateQueue((current) => {
+		const queued = current.map(loadWorkspace).filter((one) => one !== null);
+		if (queued.length === 0) return null;
+		return forwardQueue(current, groupByLineage([...queued, workspace].map(summarise)));
+	});
+}
+/**
 * Save a review that already exists, and nothing else.
 *
 * The existence check is what makes deleting a review stick. Every caller here is holding a
@@ -4733,6 +4761,24 @@ function groupByLineage(reviews) {
 	}).sort((a, b) => b.latest.createdAt - a.latest.createdAt);
 }
 /**
+* The queue with every entry naming the newest review of its branch, or null when it already does.
+*
+* The queue holds a branch, written down as one review's id, and a card takes its queue position
+* from its newest review only. An entry left on an older review is counted by the pill and drawn by
+* no card, and the card's Remove cannot reach it. So a superseded id
+* becomes the newest one, and a branch queued twice keeps the earlier of its places.
+*
+* An id no group knows is left where it is. Dropping deleted reviews is `compactQueue`'s job, and
+* the groups can be older than the file the result is applied to: a review queued since they were
+* read is not in them.
+*/
+function forwardQueue(queue, groups) {
+	const newest = /* @__PURE__ */ new Map();
+	for (const group of groups) for (const review of group.history) newest.set(review.id, group.latest.id);
+	const forwarded = [...new Set(queue.map((id) => newest.get(id) ?? id))];
+	return forwarded.length === queue.length && forwarded.every((id, at) => id === queue[at]) ? null : forwarded;
+}
+/**
 * Where one review sits in its branch's history.
 *
 * Answered from the store rather than from anything written on the workspace, for the reason
@@ -4915,7 +4961,8 @@ function startKissRun(workspace, start) {
 		error: null,
 		audit: {
 			unknownPaths: [],
-			unlocatedRecommendations: 0
+			unlocatedRecommendations: 0,
+			withheldRecommendations: 0
 		}
 	};
 	workspace.kissRuns = [...workspace.kissRuns ?? [], run];
@@ -7733,6 +7780,20 @@ function compactQueue(stored) {
 	return updateQueue((current) => livePart(current)) ?? stored;
 }
 /**
+* The queue with every entry on the newest review of its branch, stored when that changed it.
+*
+* `createWorkspace` keeps this true from the moment a branch is analysed again; this is for the
+* entries a store written before that already holds. Forwarded again under the lock rather than
+* written from `read`, so an id somebody queued since is kept. On a failed write the forwarded copy
+* still stands in, so the page counts what it can draw.
+*/
+function settleQueue(groups) {
+	const read = readQueue();
+	const forwarded = forwardQueue(read, groups);
+	if (forwarded === null) return read;
+	return updateQueue((current) => forwardQueue(current, groups)) ?? forwarded;
+}
+/**
 * Put one review on the queue, the way the index's Add does, and say how that went.
 *
 * **A Reviewed review is queued like any other.** Reviewed says what the reviewer has done with it,
@@ -9344,6 +9405,17 @@ Emit a recommendation only when you can do all five of these. If you cannot, say
 5. Say what acting on it is worth, and what it would cost.
 Never emit a recommendation resting on naming preference, personal taste, or a requirement nobody has yet.`;
 /**
+* The five checks above are how to reason, not how to write.
+*
+* Schema 1 gave each check its own output field, and the result was the reasoning printed five
+* times over: one argument restated under five headings, with the conclusion fourth. The checks stay
+* as the gate; this block asks for the conclusion first and keeps the checks as the audit trail.
+*/
+var DISTIL = `How to write a recommendation:
+Work through all five checks first. Then distil what you found. A reviewer should understand the recommendation from "title", "gist", "simplerDirection" and "gains" alone, in a few seconds, without reading anything else.
+"evidence", "whyNotJustified" and "payoffAndTradeoffs" are the audit trail for somebody who wants to check or challenge you. They carry the detail. They must not restate the gist. "evidence" and "whyNotJustified" are required: a recommendation without a basis somebody can check is withheld, however good its summary.
+Name each piece of machinery where it matters and do not repeat the same argument in every field. One argument, stated once, then supported.`;
+/**
 * How to read the pull request conversation, for a lens that is not attributing anything to it.
 *
 * KISS needs the conversation for one reason and it is the load-bearing one: `whyNotJustified`
@@ -9382,6 +9454,9 @@ var RUBRIC = `What to look at:
 - repeated wrappers or conversions that could collapse
 - abstractions justified only by a hypothetical second implementation
 
+Fewer lines is evidence, not the objective. A twenty-line explicit implementation can be simpler than a five-line generic one. Judge simplicity by fewer concepts, fewer states, fewer sources of truth, fewer speculative abstractions, fewer indirections and less machinery needed to understand the behaviour.
+This is not a style review. Naming preferences, "extract this method", small tidy-ups and repetition that costs nobody any understanding are not recommendations.
+
 This is a list of things to look at, not a list of things to report. Every item here is sometimes exactly right. One implementation does not make an interface wrong: it may be a real external boundary, a testing seam, or a repository convention. More files do not make code worse. Judge what each thing is for and what it costs.`;
 var WORTH_KEEPING = `Complexity worth keeping:
 Look actively for complexity that is doing a job, and say so. This is not a politeness section — it is how the reader can tell you understood the change rather than counted its abstractions.
@@ -9415,14 +9490,16 @@ var KISS_OUTPUT_INSTRUCTIONS = `Respond with a single JSON object, no markdown a
     "id": string,
     "title": string,
     "payoff": "high_value" | "worth_considering" | "nit",
-    "complexity": string,
+    "gist": string,
+    "simplerDirection": string,
+    "gains": [string],
+    "reductionEstimate": string,
+    "caveat": string,
     "evidence": string,
     "whyNotJustified": string,
-    "simplerDirection": string,
     "payoffAndTradeoffs": string,
     "commentWorthiness": "strong" | "consider" | "leave",
     "draftComment": string,
-    "reductionEstimate": string,
     "locations": [{ "path": string, "line": number, "primary": boolean }]
   }],
   "justifiedComplexity": [{
@@ -9439,17 +9516,19 @@ Field guidance:
 - "summary": what drives that assessment and where the largest opportunities are, if there are any. A few sentences.
 - "recommendations": ordered by what acting on them is worth — reduction in concepts and code, maintenance impact, your confidence, and what the change would cost to make. Never ordered by file, and never by line count alone. An empty list is a valid and complete answer; return one rather than finding something to say.
 - "id": short, stable and unique within this response, e.g. "pdf-source-layers".
-- "title": the simplification, in a few words. "Collapse the four PDF source types into one".
+- "title": the simplification itself, in a few words, as the action where that is accurate. "Collapse the four PDF source types into one", "Use the existing retry helper instead of adding a second", "Remove the cache; the store already memoises", "Keep the formatter local until it has a second caller". Name what to do, not the architectural concept: "Remove key readback until a device supports it", not "Defer device-reported key support".
 - "payoff": "high_value" for a substantial reduction in code, concepts, risk or maintenance with strong evidence. "worth_considering" for a credible simplification with meaningful but non-critical payoff, or a real trade-off. "nit" for small and cheap. Use "nit" sparingly: a report that is mostly nits buries the recommendation that mattered.
-- "complexity": what was introduced, named concretely — the types, layers, files, flags or machinery, by name.
-- "evidence": what in this change shows it. Point at the code, not at the idea.
-- "whyNotJustified": why the current requirements and this repository do not call for it. This is the field that separates a recommendation from a preference.
-- "simplerDirection": what to do instead, concretely enough to act on.
-- "payoffAndTradeoffs": what is gained, and honestly what is lost or risked. If there is a good reason somebody might keep it as it is, say so here.
+- "gist": one or two sentences, at most 45 words: what this change adds and why the current requirements do not need it. The reader's first contact with the recommendation, so it must carry the point on its own. Name the machinery as a concept ("a dismissal flow", "a readback capability"), not as a list of identifiers: the identifiers belong in "simplerDirection", and listing them in both is the repetition this card exists to avoid.
+- "simplerDirection": the simpler implementation, concretely, in at most 50 words: what to remove, collapse or replace, naming the identifiers, and what to keep. "Simplify this" or "consider consolidating" is not a direction. Required: without one there is no recommendation.
+- "gains": one to four short phrases, at most six words each, naming what acting on it gains: "one less abstraction", "fewer states", "one source of truth", "no hypothetical capability". Every one must be supported by the evidence. No numbers here.
+- "reductionEstimate": optional and explicitly approximate, at most eight words, e.g. "~35–50 lines" or "four types become one". Omit it when you are not confident. It will be shown as an estimate and must never read as a measurement.
+- "caveat": optional, one sentence. Only a trade-off or uncertainty, shown by the evidence, that could change whether somebody acts on this. Never a hypothetical ("if readers later find…"). When there is none, omit the key entirely rather than writing "None"; routine trade-offs belong in "payoffAndTradeoffs".
+- "evidence": required. What in this change shows it, in detail. Point at the code, not at the idea.
+- "whyNotJustified": required. Why the current requirements and this repository do not call for it, in detail. This is the field that separates a recommendation from a preference.
+- "payoffAndTradeoffs": optional. What is gained and, honestly, what is lost or risked, in detail. If there is a good reason somebody might keep it as it is, say so here.
 - "commentWorthiness": REVIEWER FRAMING ONLY — omit the field entirely on an author review. "strong" for worth raising directly, "consider" for worth mentioning, "leave" for a valid observation not worth a comment.
 - "draftComment": REVIEWER FRAMING ONLY, and only where a comment is worth making. Omit it otherwise. A short, constructive pull request comment in the reviewer's voice.
-- "reductionEstimate": optional and explicitly approximate, e.g. "four types become one" or "roughly 180 lines". Omit it when you are not confident. It will be shown as an estimate and must never read as a measurement.
-- "locations": where this complexity lives. Prefer the changed files responsible for it, named exactly as they appear in the diff. If an unchanged repository file is where the complexity actually sits and no changed file represents it, cite that file too, but never describe an unchanged file as part of this change. "line" is optional. Set "primary": true on exactly one location — the one place a reader should open first, which should be a changed file wherever one represents the concern — and false on the rest.
+- "locations": required, at least one. Where this complexity lives. Prefer the changed files responsible for it, named exactly as they appear in the diff. If an unchanged repository file is where the complexity actually sits and no changed file represents it, cite that file too, but never describe an unchanged file as part of this change. "line" is optional. Set "primary": true on exactly one location — the one place a reader should open first, which should be a changed file wherever one represents the concern — and false on the rest.
 - "justifiedComplexity": complexity in this change that is doing a real job. Empty list when there is nothing worth the note.
 - "aggregateEstimate": optional, one phrase, across the whole change. Omit it unless it is defensible.`;
 function buildKissPrompt(pr, options) {
@@ -9475,6 +9554,8 @@ ${SCOPE_BOUNDARY}
 
 ${EVIDENCE_THRESHOLD}
 
+${DISTIL}
+
 ---
 
 ${RUBRIC}
@@ -9731,7 +9812,7 @@ var WORTHINESSES = [
 	"consider",
 	"leave"
 ];
-function parseKissResult(raw) {
+function parseKissAnswer(raw) {
 	const jsonText = extractJsonText(raw);
 	let parsed;
 	try {
@@ -9744,13 +9825,17 @@ function parseKissResult(raw) {
 	const assessment = asString(obj.assessment);
 	const summary = asString(obj.summary);
 	if (!assessment && !summary && !Array.isArray(obj.recommendations) && !Array.isArray(obj.justifiedComplexity)) throw new Error("The agent returned valid JSON, but not in the shape a KISS review takes (missing assessment/summary/recommendations/justifiedComplexity). This usually means the model ignored the requested schema.");
+	const { kept, withheld } = normalizeRecommendations(obj.recommendations);
 	return {
-		schemaVersion: 1,
-		assessment,
-		summary,
-		recommendations: normalizeRecommendations(obj.recommendations),
-		justifiedComplexity: normalizeJustified(obj.justifiedComplexity),
-		...optional("aggregateEstimate", asString(obj.aggregateEstimate))
+		result: {
+			schemaVersion: 2,
+			assessment,
+			summary,
+			recommendations: kept,
+			justifiedComplexity: normalizeJustified(obj.justifiedComplexity),
+			...optional("aggregateEstimate", asString(obj.aggregateEstimate))
+		},
+		withheldRecommendations: withheld
 	};
 }
 /** Absent rather than empty, so "the model said nothing here" has one representation. */
@@ -9758,36 +9843,53 @@ function optional(key, value) {
 	return value ? { [key]: value } : {};
 }
 /**
-* A recommendation with nothing to act on is dropped rather than rendered.
+* A recommendation is kept only when it can stand on the card by itself.
 *
-* The threshold the prompt sets is that a recommendation names complexity and says what to do
-* instead. An entry missing both halves is not a recommendation the model made and we failed to
-* display; it is one that was never made, and a card carrying a payoff pill and no text reads as
-* the first.
+* That takes a title, a gist, a simpler direction and somewhere to open, which is what the card
+* shows without expanding anything, and the evidence and requirements reasoning behind it, which is
+* what makes it auditable. A polished summary with no basis a reader can check is a claim rather
+* than a recommendation. The trade-offs stay optional: some recommendations genuinely cost nothing. What fails is withheld and counted,
+* never padded or truncated, so the page can say that something came back incomplete.
 */
 function normalizeRecommendations(value) {
-	if (!Array.isArray(value)) return [];
-	return value.filter((item) => typeof item === "object" && item !== null).map((item, index) => {
-		const title = asString(item.title);
-		const simplerDirection = asString(item.simplerDirection);
+	if (!Array.isArray(value)) return {
+		kept: [],
+		withheld: 0
+	};
+	const entries = value.filter((item) => typeof item === "object" && item !== null);
+	const kept = entries.map((item, index) => {
 		const worthiness = WORTHINESSES.includes(item.commentWorthiness) ? item.commentWorthiness : void 0;
-		const draftComment = asString(item.draftComment);
-		const reductionEstimate = asString(item.reductionEstimate);
+		const gains = asStringArray(item.gains).map((gain) => gain.trim()).filter((gain) => gain !== "");
 		return {
 			id: asString(item.id) || `kiss-${index + 1}`,
-			title,
+			title: asString(item.title),
 			payoff: PAYOFFS.includes(item.payoff) ? item.payoff : "worth_considering",
-			complexity: asString(item.complexity),
+			gist: asString(item.gist),
 			evidence: asString(item.evidence),
 			whyNotJustified: asString(item.whyNotJustified),
-			simplerDirection,
+			simplerDirection: asString(item.simplerDirection),
+			...gains.length > 0 ? { gains } : {},
+			...optional("caveat", unlessPlaceholder(asString(item.caveat))),
 			payoffAndTradeoffs: asString(item.payoffAndTradeoffs),
 			...worthiness ? { commentWorthiness: worthiness } : {},
-			...draftComment ? { draftComment } : {},
-			...reductionEstimate ? { reductionEstimate } : {},
+			...optional("draftComment", asString(item.draftComment)),
+			...optional("reductionEstimate", asString(item.reductionEstimate)),
 			locations: normalizeLocations(item.locations)
 		};
-	}).filter((rec) => rec.title !== "" || rec.complexity !== "" || rec.simplerDirection !== "");
+	}).filter((rec) => rec.title !== "" && rec.gist !== "" && rec.simplerDirection !== "" && rec.evidence !== "" && rec.whyNotJustified !== "" && rec.locations.length > 0);
+	return {
+		kept,
+		withheld: entries.length - kept.length
+	};
+}
+/**
+* An optional sentence the model filled with a word for "nothing".
+*
+* Seen on real runs: asked to omit the caveat when there is none, the model wrote "None", which the
+* card would show as a trade-off called None. Only a bare placeholder is caught, never a sentence.
+*/
+function unlessPlaceholder(value) {
+	return /^(none|n\/a|null|nil|-+|no caveat|not applicable)\.?$/i.test(value.trim()) ? "" : value;
 }
 function normalizeJustified(value) {
 	if (!Array.isArray(value)) return [];
@@ -9860,8 +9962,9 @@ var KissRejected = class extends Error {
 };
 async function validateKiss(raw, changedPaths, existingPaths) {
 	let result;
+	let withheldRecommendations;
 	try {
-		result = parseKissResult(raw);
+		({result, withheldRecommendations} = parseKissAnswer(raw));
 	} catch (error) {
 		throw new KissRejected(error instanceof Error ? error.message : String(error), raw);
 	}
@@ -9896,13 +9999,20 @@ async function validateKiss(raw, changedPaths, existingPaths) {
 		}
 		return surviving;
 	};
-	for (const recommendation of result.recommendations) recommendation.locations = keep(recommendation.locations);
+	let withheldForLocations = 0;
+	result.recommendations = result.recommendations.filter((recommendation) => {
+		recommendation.locations = keep(recommendation.locations);
+		if (recommendation.locations.length > 0) return true;
+		withheldForLocations++;
+		return false;
+	});
 	for (const entry of result.justifiedComplexity) entry.locations = keep(entry.locations);
 	return {
 		result,
 		audit: {
 			unknownPaths: [...unknownPaths].sort(),
-			unlocatedRecommendations: result.recommendations.filter((r) => r.locations.length === 0).length
+			unlocatedRecommendations: 0,
+			withheldRecommendations: withheldRecommendations + withheldForLocations
 		}
 	};
 }
@@ -10743,7 +10853,7 @@ async function startJob(input) {
 			jobId: job.id,
 			audience: review.audience,
 			reviewedSha: target.sha,
-			promptVersion: "1",
+			promptVersion: "2",
 			agentId: agent.id,
 			...input.requestedModel ? { requestedModel: input.requestedModel } : {}
 		});
@@ -11348,7 +11458,7 @@ async function recordKissRun(input) {
 			jobId: job.id,
 			audience: input.audience,
 			reviewedSha: sha,
-			promptVersion: "1",
+			promptVersion: "2",
 			agentId: agent.id,
 			...input.requestedModel ? { requestedModel: input.requestedModel } : {}
 		});
@@ -12881,4 +12991,4 @@ function lineageIds(id) {
 	return [.../* @__PURE__ */ new Set([id, ...lineage.map((review) => review.id)])];
 }
 //#endregion
-export { compactQueue as $, matchingWorkspaceIds as $t, createPrState as A, processDiscussion as An, reviewedShaOf as At, toneOf as B, writeAgentPreference as Bn, progressSteps as Bt, readEvents as C, readQueue as Cn, forgeResolver as Ct, announceJob as D, issuesOutstanding as Dn, checkCodeFreshness as Dt, telemetryUploadConsent as E, isQuestionOutstanding as En, fillFileUrlTemplate as Et, markAllRead as F, git as Fn, loadJob as Ft, extractJsonText as G, agentById as Gn, followedRefName as Gt, withUsageRecorded as H, STORE_ROOT as Hn, clearClaim as Ht, markRead as I, resolveAgent as In, saveJob as It, readMarker as J, AgentCancelledError as Jn, indexReviewGroups as Jt, ReviewBeingDeletedError as K, agentFor as Kn, groupByLineage as Kt, pruneNotifications as L, resolveModel as Ln, PHASES as Lt, eventName as M, resolveTarget as Mn, endedAt as Mt, headline as N, displayRef as Nn, fail as Nt, branchOf as O, questionsOutstanding as On, checkReview as Ot, listNotifications as P, isCommitReview as Pn, isTerminal as Pt, activateQueued as Q, loadWorkspace as Qt, readNotification as R, clearAgentPreference as Rn, isLiveJob as Rt, startJob as S, queueStamp as Sn, claimRequestUrl as St, recordTelemetryUploadConsent as T, isIssueOutstanding as Tn, remoteHost as Tt, EXPLAIN_SIMPLY_PROMPT as U, AGENT_IDS as Un, driverGone as Ut, unreadCount as V, CONFIG_PATH as Vn, purposeOf as Vt, asString as W, DEFAULT_AGENT_ID as Wn, isClaimed as Wt, modelHelpLines as X, lineageKeyFor as Xt, removeWorktree as Y, AgentUnavailableError as Yn, latestKissRun as Yt, relativeTime as Z, lineagePosition as Zt, agentEnvOf as _, parseLifecycle as _n, MIN_WORKSPACE_PORT as _t, wasBlocked as a, reviewedRepositories as an, readServerRecord as at, reanalyseReview as b, queueAddMany as bn, statedWorkspacePort as bt, RefreshUnavailableError as c, workspaceRevision as cn, spawnServer as ct, refreshPrContext as d, activityLabel as dn, writeServerRecord as dt, mutateWorkspace as en, queueForReview as et, isUnchanged as f, isLifecycle as fn, BUILD_VERSION as ft, runningJobs as g, offersLifecycle as gn, MAX_WORKSPACE_PORT as gt, liveUpdateFor as h, lifecyclePill as hn, DEFAULT_WORKSPACE_PORT as ht, liveJobsFor as i, reviewedCommit as in, ensureServer as it, createPrUpdate as j, describeAuthorship as jn, allJobs as jt, subjectOf as k, reviewerDispositions as kn, followedBranch as kt, mergeUpdateInto as l, workspaceStamps as ln, stopServer as lt, UpdateAlreadyRunningError as m, lifecycleChip as mn, feedbackUrl as mt, deleteReview as n, previousKissResult as nn, bootstrapUrl as nt, discardJob as o, summarise as on, reviewsUrl as ot, askCheckout as p, lifecycleAction as pn, PACKAGE_NAME as pt, MANAGED_ROOT as q, detectAgents as qn, indexKeptIds as qt, lineageIds as r, recentWorkspaces as rn, clearServerRecord as rt, FETCH_TIMEOUT_MS as s, touchWorkspace as sn, serverEntryExists as st, deleteLineage as t, positionInLineage as tn, readIndexToken as tt, updateReview as u, LIFECYCLES as un, workspaceUrl as ut, recordKissRun as v, sectionOf as vn, parseWorkspacePort as vt, record as w, doneVerb as wn, forgeFor as wt, runJob as x, queueRemove as xn, writePortPreference as xt, startKissJob as y, queueAdd as yn, resolveWorkspacePort as yt, removeNotification as z, readAgentPreference as zn, phasesFor as zt };
+export { compactQueue as $, loadWorkspace as $t, createPrState as A, reviewerDispositions as An, followedBranch as At, toneOf as B, resolveModel as Bn, phasesFor as Bt, readEvents as C, queueStamp as Cn, claimRequestUrl as Ct, announceJob as D, isQuestionOutstanding as Dn, fillFileUrlTemplate as Dt, telemetryUploadConsent as E, isIssueOutstanding as En, remoteHost as Et, markAllRead as F, resolveTarget as Fn, isTerminal as Ft, extractJsonText as G, STORE_ROOT as Gn, isClaimed as Gt, withUsageRecorded as H, readAgentPreference as Hn, purposeOf as Ht, markRead as I, displayRef as In, loadJob as It, readMarker as J, agentById as Jn, indexKeptIds as Jt, ReviewBeingDeletedError as K, AGENT_IDS as Kn, followedRefName as Kt, pruneNotifications as L, isCommitReview as Ln, saveJob as Lt, eventName as M, describeAuthorship as Mn, allJobs as Mt, headline as N, WITHHELD_REASON as Nn, endedAt as Nt, branchOf as O, issuesOutstanding as On, checkCodeFreshness as Ot, listNotifications as P, kissOutcome as Pn, fail as Pt, activateQueued as Q, AgentUnavailableError as Qn, lineagePosition as Qt, readNotification as R, git as Rn, PHASES as Rt, startJob as S, queueRemove as Sn, writePortPreference as St, recordTelemetryUploadConsent as T, doneVerb as Tn, forgeFor as Tt, EXPLAIN_SIMPLY_PROMPT as U, writeAgentPreference as Un, clearClaim as Ut, unreadCount as V, clearAgentPreference as Vn, progressSteps as Vt, asString as W, CONFIG_PATH as Wn, driverGone as Wt, modelHelpLines as X, detectAgents as Xn, latestKissRun as Xt, removeWorktree as Y, agentFor as Yn, indexReviewGroups as Yt, relativeTime as Z, AgentCancelledError as Zn, lineageKeyFor as Zt, agentEnvOf as _, offersLifecycle as _n, MAX_WORKSPACE_PORT as _t, wasBlocked as a, reviewedCommit as an, ensureServer as at, reanalyseReview as b, queueAdd as bn, resolveWorkspacePort as bt, RefreshUnavailableError as c, touchWorkspace as cn, serverEntryExists as ct, refreshPrContext as d, LIFECYCLES as dn, workspaceUrl as dt, matchingWorkspaceIds as en, queueForReview as et, isUnchanged as f, activityLabel as fn, writeServerRecord as ft, runningJobs as g, lifecyclePill as gn, DEFAULT_WORKSPACE_PORT as gt, liveUpdateFor as h, lifecycleChip as hn, feedbackUrl as ht, liveJobsFor as i, recentWorkspaces as in, clearServerRecord as it, createPrUpdate as j, processDiscussion as jn, reviewedShaOf as jt, subjectOf as k, questionsOutstanding as kn, checkReview as kt, mergeUpdateInto as l, workspaceRevision as ln, spawnServer as lt, UpdateAlreadyRunningError as m, lifecycleAction as mn, PACKAGE_NAME as mt, deleteReview as n, positionInLineage as nn, readIndexToken as nt, discardJob as o, reviewedRepositories as on, readServerRecord as ot, askCheckout as p, isLifecycle as pn, BUILD_VERSION as pt, MANAGED_ROOT as q, DEFAULT_AGENT_ID as qn, groupByLineage as qt, lineageIds as r, previousKissResult as rn, bootstrapUrl as rt, FETCH_TIMEOUT_MS as s, summarise as sn, reviewsUrl as st, deleteLineage as t, mutateWorkspace as tn, settleQueue as tt, updateReview as u, workspaceStamps as un, stopServer as ut, recordKissRun as v, parseLifecycle as vn, MIN_WORKSPACE_PORT as vt, record as w, readQueue as wn, forgeResolver as wt, runJob as x, queueAddMany as xn, statedWorkspacePort as xt, startKissJob as y, sectionOf as yn, parseWorkspacePort as yt, removeNotification as z, resolveAgent as zn, isLiveJob as zt };

package/dist/main.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-import { $t as matchingWorkspaceIds, Bn as writeAgentPreference, Bt as progressSteps, Ct as forgeResolver, E as telemetryUploadConsent, Fn as git, Ft as loadJob, Gn as agentById, Gt as followedRefName, Hn as STORE_ROOT, Ht as clearClaim, In as resolveAgent, J as readMarker, Kt as groupByLineage, Ln as resolveModel, Lt as PHASES, Mn as resolveTarget, Nn as displayRef, Ot as checkReview, Pt as isTerminal, Qt as loadWorkspace, S as startJob, T as recordTelemetryUploadConsent, Un as AGENT_IDS, Ut as driverGone, Vn as CONFIG_PATH, Vt as purposeOf, Wn as DEFAULT_AGENT_ID, Wt as isClaimed, X as modelHelpLines, Xt as lineageKeyFor, Y as removeWorktree, Z as relativeTime, _t as MIN_WORKSPACE_PORT, a as wasBlocked, an as reviewedRepositories, b as reanalyseReview, bt as statedWorkspacePort, en as mutateWorkspace, et as queueForReview, ft as BUILD_VERSION, g as runningJobs, gt as MAX_WORKSPACE_PORT, h as liveUpdateFor, ht as DEFAULT_WORKSPACE_PORT, i as liveJobsFor, it as ensureServer, jt as allJobs, l as mergeUpdateInto, lt as stopServer, m as UpdateAlreadyRunningError, n as deleteReview$1, nt as bootstrapUrl, on as summarise, ot as reviewsUrl, pt as PACKAGE_NAME, q as MANAGED_ROOT, qn as detectAgents, rn as recentWorkspaces, tn as positionInLineage, tt as readIndexToken, u as updateReview, ut as workspaceUrl, v as recordKissRun, vt as parseWorkspacePort, w as record$1, x as runJob, xt as writePortPreference, zn as readAgentPreference } from "./delete_review-BIXqUnpx.js";
+import { $t as loadWorkspace, Bn as resolveModel, E as telemetryUploadConsent, Fn as resolveTarget, Ft as isTerminal, Gn as STORE_ROOT, Gt as isClaimed, Hn as readAgentPreference, Ht as purposeOf, In as displayRef, It as loadJob, J as readMarker, Jn as agentById, Kn as AGENT_IDS, Kt as followedRefName, Mt as allJobs, Nn as WITHHELD_REASON, Pn as kissOutcome, Rn as git, Rt as PHASES, S as startJob, St as writePortPreference, T as recordTelemetryUploadConsent, Un as writeAgentPreference, Ut as clearClaim, Vt as progressSteps, Wn as CONFIG_PATH, Wt as driverGone, X as modelHelpLines, Xn as detectAgents, Y as removeWorktree, Z as relativeTime, Zt as lineageKeyFor, _t as MAX_WORKSPACE_PORT, a as wasBlocked, at as ensureServer, b as reanalyseReview, dt as workspaceUrl, en as matchingWorkspaceIds, et as queueForReview, g as runningJobs, gt as DEFAULT_WORKSPACE_PORT, h as liveUpdateFor, i as liveJobsFor, in as recentWorkspaces, kt as checkReview, l as mergeUpdateInto, m as UpdateAlreadyRunningError, mt as PACKAGE_NAME, n as deleteReview$1, nn as positionInLineage, nt as readIndexToken, on as reviewedRepositories, pt as BUILD_VERSION, q as MANAGED_ROOT, qn as DEFAULT_AGENT_ID, qt as groupByLineage, rt as bootstrapUrl, sn as summarise, st as reviewsUrl, tn as mutateWorkspace, u as updateReview, ut as stopServer, v as recordKissRun, vt as MIN_WORKSPACE_PORT, w as record$1, wt as forgeResolver, x as runJob, xt as statedWorkspacePort, yt as parseWorkspacePort, zn as resolveAgent } from "./delete_review-BiV1aBpx.js";
 import { basename, dirname, join, resolve } from "node:path";
 import { spawn } from "node:child_process";
 import { existsSync, mkdirSync, readdirSync, realpathSync, rmSync, statSync, writeFileSync } from "node:fs";
@@ -1386,8 +1386,8 @@ function reviewFinished(url, summary, conversation) {
 * worth saying plainly: somebody who ran this wants to know the change is proportionate, and a
 * bare zero leaves them wondering whether the analysis ran.
 */
-function kissFinished(url, recommendations) {
-	return `\nKISS review ready · ${recommendations === 0 ? "No material simplifications were identified." : count(recommendations, "recommendation")}\n${url}`;
+function kissFinished(url, outcome, recommendations, withheld = 0) {
+	return `\nKISS review ready · ${outcome === "proportionate" ? "No material simplifications were identified." : outcome === "incomplete" ? `${count(withheld, "recommendation")} came back incomplete and ${withheld === 1 ? "was" : "were"} withheld (${WITHHELD_REASON}). This is not a finding that the change is simple; run it again.` : `${count(recommendations, "recommendation")}${withheld > 0 ? ` (${withheld} more withheld as incomplete)` : ""}`}\n${url}`;
 }
 function cap(word) {
 	return word.charAt(0).toUpperCase() + word.slice(1);
@@ -2746,12 +2746,13 @@ async function drive(workspaceId, url, kissRun) {
 	}
 	const done = loadWorkspace(workspaceId);
 	if (kissRun) {
-		const answer = (done.kissRuns ?? []).find((candidate) => candidate.jobId === kissRun.jobId)?.result;
-		if (!answer) {
+		const finished = (done.kissRuns ?? []).find((candidate) => candidate.jobId === kissRun.jobId);
+		const answer = finished?.result;
+		if (!finished || !answer) {
 			err(reviewFailed("The analysis finished without recording an answer.", link));
 			return 1;
 		}
-		out(kissFinished(link, answer.recommendations.length));
+		out(kissFinished(link, kissOutcome(answer, finished.audit), answer.recommendations.length, finished.audit.withheldRecommendations ?? 0));
 		return 0;
 	}
 	out(reviewFinished(link, summarise(done), settled.job.conversation));