prreviewbuddy 0.43.0 → 0.45.0

package/dist/main.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-import { $ as ensureServer, $t as reviewedRepositories, An as AGENT_IDS, At as loadJob, Bt as followedRefName, Cn as resolveAgent, Ct as checkReview, Dn as writeAgentPreference, E as telemetryUploadConsent, En as readAgentPreference, Et as allJobs, Ft as progressSteps, G as MANAGED_ROOT, It as purposeOf, J as modelHelpLines, Jt as mutateWorkspace, K as readMarker, Kt as loadWorkspace, Lt as clearClaim, Mn as agentById, Mt as PHASES, On as CONFIG_PATH, Pn as detectAgents, Rt as driverGone, S as startJob, Sn as git, T as recordTelemetryUploadConsent, Vt as groupByLineage, Wt as lineageKeyFor, X as readIndexToken, Y as relativeTime, Yt as positionInLineage, Z as bootstrapUrl, Zt as recentWorkspaces, a as wasBlocked, at as workspaceUrl, b as reanalyseReview, bn as displayRef, ct as PACKAGE_NAME, dt as MAX_WORKSPACE_PORT, en as summarise, ft as MIN_WORKSPACE_PORT, g as runningJobs, gt as writePortPreference, h as liveUpdateFor, ht as statedWorkspacePort, i as liveJobsFor, it as stopServer, jn as DEFAULT_AGENT_ID, kn as STORE_ROOT, kt as isTerminal, l as mergeUpdateInto, m as UpdateAlreadyRunningError, n as deleteReview$1, pt as parseWorkspacePort, q as removeWorktree, qt as matchingWorkspaceIds, st as BUILD_VERSION, tt as reviewsUrl, u as updateReview, ut as DEFAULT_WORKSPACE_PORT, v as recordKissRun, vt as forgeResolver, w as record$1, wn as resolveModel, x as runJob, yn as resolveTarget, zt as isClaimed } from "./delete_review-DPRL5IPt.js";
+import { $ as bootstrapUrl, $t as recentWorkspaces, An as STORE_ROOT, Bt as driverGone, Cn as git, Dn as readAgentPreference, E as telemetryUploadConsent, Fn as detectAgents, G as MANAGED_ROOT, Ht as followedRefName, J as modelHelpLines, Jt as loadWorkspace, K as readMarker, Kt as lineageKeyFor, Lt as progressSteps, Mn as DEFAULT_AGENT_ID, Mt as loadJob, Nn as agentById, On as writeAgentPreference, Ot as allJobs, Pt as PHASES, Q as readIndexToken, Rt as purposeOf, S as startJob, T as recordTelemetryUploadConsent, Tn as resolveModel, Tt as checkReview, Ut as groupByLineage, Vt as isClaimed, Xt as mutateWorkspace, Y as relativeTime, Yt as matchingWorkspaceIds, Z as queueForReview, Zt as positionInLineage, _t as statedWorkspacePort, a as wasBlocked, b as reanalyseReview, bn as resolveTarget, bt as forgeResolver, ft as DEFAULT_WORKSPACE_PORT, g as runningJobs, h as liveUpdateFor, ht as parseWorkspacePort, i as liveJobsFor, jn as AGENT_IDS, jt as isTerminal, kn as CONFIG_PATH, l as mergeUpdateInto, lt as BUILD_VERSION, m as UpdateAlreadyRunningError, mt as MIN_WORKSPACE_PORT, n as deleteReview$1, nn as summarise, ot as stopServer, pt as MAX_WORKSPACE_PORT, q as removeWorktree, rt as reviewsUrl, st as workspaceUrl, tn as reviewedRepositories, tt as ensureServer, u as updateReview, ut as PACKAGE_NAME, v as recordKissRun, vt as writePortPreference, w as record$1, wn as resolveAgent, x as runJob, xn as displayRef, zt as clearClaim } from "./delete_review-BWMmO81Q.js";
 import { basename, dirname, join, resolve } from "node:path";
 import { spawn } from "node:child_process";
 import { existsSync, mkdirSync, readdirSync, realpathSync, rmSync, statSync, writeFileSync } from "node:fs";
@@ -33,7 +33,8 @@ var BARE = {
 		"--update",
 		"--reanalyse",
 		"--delete",
-		"--yes"
+		"--yes",
+		"--queue"
 	],
 	open: [],
 	agents: [],
@@ -117,16 +118,21 @@ function parse(argv) {
 	const values = {};
 	const flags = /* @__PURE__ */ new Set();
 	const positional = [];
+	/** The flag each positional came after, as typed, so a stray URL can be told where it went wrong. */
+	const after = /* @__PURE__ */ new Map();
+	let lastFlag;
 	/** Every URL `--pr` took. `review` has no positionals, so what follows `--pr` up to the next flag is its. */
 	const prs = [];
 	for (let index = 0; index < rest.length; index += 1) {
 		const argument = rest[index];
 		if (!argument.startsWith("--")) {
 			positional.push(argument);
+			if (lastFlag && !after.has(argument)) after.set(argument, lastFlag);
 			continue;
 		}
 		const equals = argument.indexOf("=");
 		const name = equals === -1 ? argument : argument.slice(0, equals);
+		lastFlag = name;
 		if (VALUED[head]?.includes(name)) {
 			const value = equals === -1 ? rest[index + 1] : argument.slice(equals + 1);
 			if (!value) return {
@@ -153,10 +159,18 @@ function parse(argv) {
 			message: `\`${head}\` does not take ${name}. Run \`prreviewbuddy --help\` to see what it takes.`
 		};
 	}
-	if (head === "review" && positional[0]) return {
-		name: "error",
-		message: strayArgument(positional[0])
-	};
+	if (head === "review" && positional[0]) {
+		const stray = positional[0];
+		const flag = after.get(stray);
+		if (prs.length > 0 && flag && LOOKS_LIKE_A_REQUEST.test(stray)) return {
+			name: "error",
+			message: `\`${stray}\` comes after \`${flag}\`, so \`--pr\` did not take it: \`--pr\` takes the URLs straight after it, up to the next flag. Put all the URLs together after \`--pr\`, and the other flags before or after them.`
+		};
+		return {
+			name: "error",
+			message: strayArgument(stray)
+		};
+	}
 	if (head === "uninstall" && positional[0]) return {
 		name: "error",
 		message: `\`uninstall\` removes everything on this machine, so it takes no target and \`${positional[0]}\` means nothing to it. It takes \`--keep-reviews\`, \`--yes\` and \`--force\`.`
@@ -184,7 +198,8 @@ function parse(argv) {
 			...values["--concurrency"] ? { concurrency: Number(values["--concurrency"]) } : {},
 			...values["--agent"] ? { agentId: values["--agent"] } : {},
 			...values["--model"] ? { requestedModel: values["--model"] } : {},
-			...flags.has("--fresh") ? { operation: "fresh" } : {}
+			...flags.has("--fresh") ? { operation: "fresh" } : {},
+			...flags.has("--queue") ? { queue: true } : {}
 		};
 		const target = Object.keys(TARGETS).find((flag) => values[flag]);
 		const operation = Object.keys(OPERATIONS).find((flag) => flags.has(flag));
@@ -197,7 +212,8 @@ function parse(argv) {
 			...operation ? { operation: OPERATIONS[operation][0] } : {},
 			...values["--lens"] ? { lens: values["--lens"] } : {},
 			...values["--audience"] ? { audience: values["--audience"] } : {},
-			...flags.has("--yes") ? { yes: true } : {}
+			...flags.has("--yes") ? { yes: true } : {},
+			...flags.has("--queue") ? { queue: true } : {}
 		};
 	}
 	if (head === "uninstall") return {
@@ -313,6 +329,7 @@ function refuseCombination(values, flags) {
 		}
 		if (values["--agent"]) return "`--agent` chooses who analyses a change, and `--delete` analyses nothing. Drop it, or drop `--delete` if you meant to review something.";
 		if (values["--model"]) return "`--model` chooses which model analyses a change, and `--delete` analyses nothing. Drop it, or drop `--delete` if you meant to review something.";
+		if (flags.has("--queue")) return "`--queue` puts a review on your review queue to work through, and `--delete` removes the review, so there would be nothing left to queue. Ask for one of them.";
 	}
 	if (flags.has("--yes") && !flags.has("--delete")) return "`--yes` answers the confirmation that `--delete` asks, and nothing here is asking one. Add `--delete` if you meant to remove a review.";
 	if (values["--review"]) {
@@ -980,6 +997,8 @@ your own checkout is never read or written while it works.
   prreviewbuddy review --pr <url> <url> ...
                                           review several pull requests, each on its own, two at a
                                           time; --concurrency <n> changes how many
+  prreviewbuddy review ... --queue        also put each review on your review queue, as soon as
+                                          it exists rather than when it is ready
   prreviewbuddy review --base <ref>       compare against a base of your choosing
   prreviewbuddy review --agent <agent>    review with ${AGENT_NAMES}
   prreviewbuddy review --model <model>    ask that agent for a particular model. Reviews keep
@@ -1408,11 +1427,52 @@ function batchFinished(rows, index) {
 		lines.push(`${lead}${row.detail ?? row.url ?? ""}`.trimEnd());
 		if (row.detail && row.url) lines.push(`${" ".repeat(lead.length)}${row.url}`);
 	}
-	if (rows.some((row) => row.outcome === "stopped" || row.outcome === "not-started" || row.outcome === "failed" && row.url)) lines.push("", "Run the same command again to carry on with the reviews that did not finish, from where each got to.");
+	const unfinished = rows.some((row) => row.outcome === "stopped" || row.outcome === "not-started" || row.outcome === "failed" && row.url);
+	lines.push(...batchQueueLines(rows));
+	if (unfinished) lines.push("", "Run the same command again to carry on with the reviews that did not finish, from where each got to.");
 	const all = indexLinks(index);
 	if (all) lines.push("", all);
 	return lines.join("\n");
 }
+/**
+* What `--queue` did across a batch, or nothing at all when it was not asked for.
+*
+* One line for what is in the queue, rather than a word on every row: the rows say how each review
+* ended, and the queue is where the reviewer goes next, so it is said once, together. What was left
+* out is named with its reason, because each reason has a different way round it.
+*/
+function batchQueueLines(rows) {
+	const asked = rows.filter((row) => row.queue !== void 0);
+	if (asked.length === 0) return [];
+	const lines = [""];
+	const queued = asked.filter((row) => row.queue === "added" || row.queue === "already");
+	if (queued.length > 0) lines.push(`In your review queue: ${queued.map((row) => row.label).join(", ")}`);
+	for (const row of asked) {
+		if (row.queue === "added" || row.queue === "already") continue;
+		lines.push(`Not added to your review queue: ${notQueuedBecause(row.label, row.queue)}`);
+	}
+	return lines;
+}
+function notQueuedBecause(subject, result) {
+	switch (result) {
+		case "complete": return `${subject} is marked complete. Move it back to In progress in the workspace to queue it.`;
+		case "full": return `${subject}, because the review queue is full. It holds 50 reviews at most.`;
+		default: return `${subject}, because the review queue could not be saved.`;
+	}
+}
+/**
+* What `--queue` did with the one review a single command acted on. To stderr, like every line that
+* is not the review's own link.
+*/
+function reviewQueued(result) {
+	switch (result) {
+		case "added": return "Added to review queue.";
+		case "already": return "Already in your review queue.";
+		case "complete": return "Not added to your review queue: this review is marked complete. Move it back to In progress in the workspace to queue it.";
+		case "full": return `Not added to your review queue: it is full, and holds 50 reviews at most.`;
+		default: return "Not added to your review queue: the queue could not be saved.";
+	}
+}
 function noReviews() {
 	return "No reviews stored yet. Run `prreviewbuddy review` in a repository to make one.";
 }
@@ -1908,16 +1968,16 @@ async function reviewBatch(command, repoPath, deps = realDeps()) {
 		}
 		claimed.set(identity, index);
 		const prepared = await deps.prepare(target, agent.id, command.operation === "fresh", command.requestedModel);
+		const workspaceId = prepared.kind === "new" ? prepared.workspaceId : prepared.existing.id;
+		row.workspaceId = workspaceId;
+		if (command.queue) row.reviewQueue = deps.enqueue(workspaceId);
 		if (prepared.kind === "existing") {
-			row.workspaceId = prepared.existing.id;
 			row.state = {
 				kind: "existing",
 				inProgress: prepared.existing.inProgress
 			};
 			return;
 		}
-		const workspaceId = prepared.kind === "resume" ? prepared.existing.id : prepared.workspaceId;
-		row.workspaceId = workspaceId;
 		row.state = {
 			kind: "running",
 			jobId: deps.jobIdOf(workspaceId) ?? ""
@@ -1949,7 +2009,11 @@ async function reviewBatch(command, repoPath, deps = realDeps()) {
 }
 function summaryRow(row, link) {
 	const url = row.workspaceId ? link(row.workspaceId) : void 0;
-	const withUrl = url ? { url } : {};
+	const queued = row.reviewQueue ? { queue: row.reviewQueue } : {};
+	const withUrl = {
+		...url ? { url } : {},
+		...queued
+	};
 	switch (row.state.kind) {
 		case "ready": return {
 			label: row.label,
@@ -1979,7 +2043,8 @@ function summaryRow(row, link) {
 		};
 		default: return {
 			label: row.label,
-			outcome: "not-started"
+			outcome: "not-started",
+			...queued
 		};
 	}
 }
@@ -1994,6 +2059,7 @@ function realDeps() {
 		prepare: prepareReview,
 		settle: (workspaceId, signal) => settleReview(workspaceId, "standard", signal),
 		jobIdOf: (workspaceId) => loadWorkspace(workspaceId)?.jobId,
+		enqueue: queueForReview,
 		links: async () => {
 			try {
 				const port = await ensureServer();
@@ -2257,6 +2323,7 @@ async function review(command, repoPath) {
 	const agent = await chooseFor(command);
 	if (!agent) return 1;
 	const prepared = await prepareReview(target, agent.id, command.operation === "fresh", command.requestedModel);
+	enqueue(command, prepared.kind === "new" ? prepared.workspaceId : prepared.existing.id);
 	if (prepared.kind === "existing") {
 		const url = linkTo(await ensureServer(), prepared.existing.id, prepared.existing.token);
 		out(existingReview(prepared.existing, url));
@@ -2311,6 +2378,7 @@ async function kiss(command, target) {
 		...workspace ? { review: { session: workspace.session } } : {}
 	}) ?? void 0;
 	if (workspace) {
+		enqueue(command, workspace.id);
 		const job = await recordKissRun({
 			workspaceId: workspace.id,
 			audience,
@@ -2330,6 +2398,7 @@ async function kiss(command, target) {
 		agentId: agent.id,
 		...requestedModel ? { requestedModel } : {}
 	});
+	enqueue(command, workspaceId);
 	const fresh = loadWorkspace(workspaceId);
 	const run = (fresh.kissRuns ?? [])[0];
 	if (!run) {
@@ -2390,6 +2459,7 @@ async function operate(command, workspace) {
 		err(commitReviewCannotUpdate(workspace.changeSet.data.pullRequest.head.sha));
 		return 1;
 	}
+	enqueue(command, workspace.id);
 	if (command.operation === "reanalyse") {
 		const agent = await chooseFor(command, workspace);
 		if (!agent) return 1;
@@ -2443,6 +2513,17 @@ async function operate(command, workspace) {
 	return 0;
 }
 /**
+* `--queue`: put the review on the reviewer's review queue, now, and say how that went.
+*
+* Called the moment a review exists and before its analysis is awaited, so the card is in the
+* workspace's Queue while the review is still being made. Never a reason to fail the command: the
+* review is what was asked for, and the queue is bookkeeping around it. To stderr, so a piped link
+* is still only a link.
+*/
+function enqueue(command, workspaceId) {
+	if (command.queue) err(reviewQueued(queueForReview(workspaceId)));
+}
+/**
 * Draw a job's progress block, from what the job itself records about its target.
 *
 * From the record rather than the caller, for the reason `drive` gives: the job knows what it is